| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
spdy_network_transaction_unittest.cc
to promote code reuse. Removes the kGetSyn and kGetSynReply binary
SPDY frame constants and replaces them with calls to factory methods,
for better clarity and to reduce maintenance costs going forward.
Also adds some helper methods for constructing mock reads and writes
from SpdyFrames.
TEST=net_unittests pass.
BUG=None
Review URL: http://codereview.chromium.org/2881001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51049 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Changes the default preference setting for Mac "me" card integration to be enabled.
BUG=46695
TEST=AutoFillDialogControllerTest.AuxiliaryProfilesTrue
Review URL: http://codereview.chromium.org/2800031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51047 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
correctly between runs.
Review URL: http://codereview.chromium.org/2834025
TBR=mlloyd@chromium.org
Review URL: http://codereview.chromium.org/2856018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51046 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2834025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=32410
TEST=unittests
Review URL: http://codereview.chromium.org/2858027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51041 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
in the view hierarchy
BUG=47576
TEST=none
Review URL: http://codereview.chromium.org/2844033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=16681
TEST=go to youtube.com, then go to a video, shift-esc, end flash process, see
the infobar. Notice the icon in the left side.
Review URL: http://codereview.chromium.org/2835020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51039 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=44699
TEST=Go to about:about, and see if About page loads. Check if links work.
Review URL: http://codereview.chromium.org/2845027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This URL sets off an error case that calls RDH::OnReadCompleted without
calling RDH::Read. ResourceDispatcherHost then tries to read from a failed
request. We can avoid this by ensuring has_started_reading is true when
OnReadCompleted is called (whether Read is called or not).
BUG=40250
TEST=ResourceDispatcherHostUITest.CrossSiteFailedRequest
Review URL: http://codereview.chromium.org/2860030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51037 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
malloced separately.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2810030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=mnaganov@chromium.org
BUG=None
TEST=None
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51033 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds a link to http://www.google.com/support/chrome/bin/answer.py?answer=142893 on the AutoFill settings dialog.
Nib changes: Adds button with link cell connected to |openHelp:| action.
BUG=42780
TEST=manual, open dialog and click help button.
Review URL: http://codereview.chromium.org/2825027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51032 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=43168
TEST=install an extension that has an infobar. see if one shows up.
Review URL: http://codereview.chromium.org/2858028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51031 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
this in r50897.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2863026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51024 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=47598
TEST=none
Review URL: http://codereview.chromium.org/2825025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51023 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=oshima@chromium.org
Review URL: http://codereview.chromium.org/2812028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51021 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=45015
TEST=none
TBR=jcivelli@chromium.org
Review URL: http://codereview.chromium.org/2880004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Note: This fix another TODO for hclam, missed in the other patch.
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/2863028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51018 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
API call.
BUG=41127
TEST=none
Review URL: http://codereview.chromium.org/2812023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51013 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
editorial fixes."
This reverts commit 699468c59a6563db5fb3fb4739c6710a279a4067.
TBR=erikchen@google.com
Review URL: http://codereview.chromium.org/2852029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51011 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None.
TEST=Test printing from Chrome PDF plugin on the Mac.
Review URL: http://codereview.chromium.org/2808029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51008 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
fixes.
TEST=net_unittests
BUG=46589
Review URL: http://codereview.chromium.org/2804008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51007 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A prefetch file is automatically generated by recording hard page faults
during process
startup. It's
used to speed up the process startup the next time by prefetching those
pages. By default, one prefetch file is maintained per exe.
Since chrome.exe is launched in different modes (browser, renderer, plugin etc.), we
want different prefetch profiles per process type. This is achieved by appending a
'/Prefetch:<integer type>' on the command line.
This has shown a 20% improvement in cold startup in ChromeFrameStartupTestActiveX.PerfCold
on XP, will watch perf dashboards improvements.
TEST=none
BUG=44129
Review URL: http://codereview.chromium.org/2810033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51006 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
revert CL after (if) mac valgrind bot breaks.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/2883002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=39400
TEST=Activate translate bar then try to shrink browser window.
Review URL: http://codereview.chromium.org/2858029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51003 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Change TopSites::GetMostVisitedURLs to take a callback. This allows TopSites to wait for the results list from the TopSitesDatabase.
BUG=none
TEST=TopSitesTest
Review URL: http://codereview.chromium.org/2811028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=33033.
TEST=None.
Review URL: http://codereview.chromium.org/2684001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51001 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Anyone who's changing a header here may break the chromeos build.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2838027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=47532 Every keystroke in a password beeps
TEST=Keystroke in a password box should not beep.
Review URL: http://codereview.chromium.org/2805038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50999 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=levin
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2833035
TBR=mnaganov@chromium.org
Review URL: http://codereview.chromium.org/2866028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50998 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
encrypted SSL socket.
BUG=46924
Review URL: http://codereview.chromium.org/2805039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50997 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
CROSBUG=4348
TEST=Backspace navigates back
Review URL: http://codereview.chromium.org/2863027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50996 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=garykac
Review URL: http://codereview.chromium.org/2876013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50992 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- chromium-os:4237 is a crash where button listener is released before
the button. And there could be such a case in PanelController where
close button and its listener is not coupled as other part of the code.
Potentially, a PanelController as the button listener could be released
before the button. The fix is to use the TitleCotnentView as button listener
and because it's the parent view of the button, it is always valid for
the life time of the button.
- Fix a crash in BrowserTabStripController::CreateNewTab when trying to dig
out cause for 4237. It could happen that user clicks quickly on close tab
and then on new tab button and model_->GetSelectedTabContents() returns
NULL;
BUG=chromium-os:4237
TEST=No more crashes coming in as in chromius-os:4237.
Review URL: http://codereview.chromium.org/2803024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50990 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
crashing.
BUG=45015
TEST=none
TBR=jcivelli@chromium.org
Review URL: http://codereview.chromium.org/2821021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50989 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=levin
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2833035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/2841027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50983 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST= first run bubble points at text, not half-heartedly betwixt icon and text start.
Review URL: http://codereview.chromium.org/2811035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
attempt caused some flakiness on the new tab warm startup test. The
only difference between this and the last is that I'm leaving some
suspcious code in TabStripModel::InsertTabContents and
Browser::AddTabWithURL. I'll try to isolate why those changes caused
flakiness after I land the rest.
Here's the description:
Moves Browser::AddTypes to TabStripModel. This patch is primarily
cleanup before I fix 29933, but has a couple of interesting bits
beyond the enum change:
. AddTabContents now supports adding pinned.
. Converted InsertTabContents call in extensionstabmodule to pass in
nothing (Rafael said old code was wrong).
BUG=29933
TEST=none
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/2866024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50981 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2805041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50980 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=See unit tests as part of this CL.
Review URL: http://codereview.chromium.org/2804010
TBR=rogerta@google.com
Review URL: http://codereview.chromium.org/2835022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=47575
TEST=none
TBR=jcivelli@chromium.org
Review URL: http://codereview.chromium.org/2853016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=See unit tests as part of this CL.
Review URL: http://codereview.chromium.org/2804010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50977 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
pepper::PluginModule.
Used Chromoting's plugin as the first attempt at using this interface.
BUG=none
TEST=compiles
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50667
Review URL: http://codereview.chromium.org/2843018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50976 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also, provide the underpinning for doing cryptohome-preserving password changes.
The caller must implement a callback called OnPasswordChangeDetected,
which will be called when we notice a password worked online, but did
not decrypt the user's cryptohome. The caller can then call
DoPasswordChange() once he has the old password, or
SkipPasswordChange() to blow away the data.
BUG=chromium-os:323
TEST=unit tests, put it on a device and try successful, failed logins, offline login and localaccount login
Review URL: http://codereview.chromium.org/2824022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Test crashes on Vista bot.
BUG=4354
TEST="Vista Tests (dbg)(1)" should cycle green.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50974 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=levin
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2817034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50973 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Less Git clutter.
TBR=mark@chromium.org
Review URL: http://codereview.chromium.org/2862030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix issue when accelerators were active when dialogs were opened.
Will remove accelerators in WM before submitting this CL.
(http://codereview.chromium.org/2874014)
BUG= http://crosbug.com/4215, http://crosbug.com/3939
TEST=Manual. Cycle through users using Left/Shift+Tab & Right/Tab
Review URL: http://codereview.chromium.org/2874014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50971 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2842026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50970 0039d316-1c4b-4281-b951-d872f2087c98
|