| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
I took this opportunity to rejigger how we hacked around using an uninstalled
libevent, to remove a TODO that mentioned danger in the README.
Files to review: README.chromium and chromium.patch.
The rest are probably rubber-stampable.
Review URL: http://codereview.chromium.org/412006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=ananta
BUG=28364
Review URL: http://codereview.chromium.org/418020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32655 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/414008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/419003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=none
TESt=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moving the HTML to the cache saved 8ms on New Tab Warm on Windows,
maybe we can shave a few more ms off by moving the CSS.
http://build.chromium.org/buildbot/perf/xp-release-dual-core/new-tab-ui-warm/report.html?history=150
After this change, I'm going to try to do some cleanup to merge
NewTabHTMLSource into DOMUIThemeSource since these classes are both
quite small now.
BUG=26228
Review URL: http://codereview.chromium.org/413004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/422003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32648 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Tree fix.
TBR=timsteele
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32647 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=type g in location bar, press ctrl+f, wait for did you mean infobar. it should be below the findbar.
Review URL: http://codereview.chromium.org/418005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32645 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=27921
TEST=None
Review URL: http://codereview.chromium.org/413005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32644 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
- Fix overflow error in colors.
BUG=21121
Review URL: http://codereview.chromium.org/414041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32643 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Rather than printing errno, this macro prints useful error messages.
Review URL: http://codereview.chromium.org/420006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32642 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/418016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=phajdan.jr
BUG=28372
Review URL: http://codereview.chromium.org/421008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=24173,28190
TEST=Plugins should no longer crash in WebPluginDelegateImpl::OnNullEvent()
Review URL: http://codereview.chromium.org/414044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Patched from 401007(see http://codereview.chromium.org/401007/) to commit. Reviewed by aa and darin.
R=aa,darin
Review URL: http://codereview.chromium.org/421005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32634 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds IO stats to memory_test, and renames most of the memory_test
traces to match the names used by page_cycler so that (after the historical
memory_ data is converted) we can do apples-to-apples comparisons
of stats across all the tests that use these methods.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/402104
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32632 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
rely on to trigger NPAPI keyboard focus notifications.
BUG=26585
TEST=On pages with multiple Flash text entry fields, only one should have
a blinking caret at any time. Flash elements that use the ActionScript2
"Key.IsDown()" function should only detect keydowns when they are in a
visible tab and focused.
Review URL: http://codereview.chromium.org/399090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
often if you send bad data into the framer and helps
debug early.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/418008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32630 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If we get a header which doesn't look like it contains a
parseable URL, log an error and drop it (instead of inserting
it into the pending_streams_ list).
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/420002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32629 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG= http://code.google.com/p/nativeclient/issues/detail?id=119
TEST=none
Review URL: http://codereview.chromium.org/410004
TBR=gregoryd@google.com
Review URL: http://codereview.chromium.org/418013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32628 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= http://code.google.com/p/nativeclient/issues/detail?id=119
TEST=none
Review URL: http://codereview.chromium.org/410004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=jorlow
TEST=ResourceDispatcherHostTest
BUG=28364
Review URL: http://codereview.chromium.org/414040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32623 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/418011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32622 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=28176
TEST=none
Review URL: http://codereview.chromium.org/416003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32620 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make bookmark sync link start up the sync process. Make the message more aesthetically pleasing.
Improve the overall layout of the message; ensure it doesn't overlap the NTP content. Also add a border to the notification line so that it matches the promo line in appearance, and stands out against themes of all colors.
BUG= 27853, 28047
TEST= start chrome, click on "bookmark sync" in promo message on NTP. chrome should start up the bookmark sync process.
Review URL: http://codereview.chromium.org/402021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Convert mappy to a page action popup.
Also fix a bug where disabling an extension with a page action didn't cause the icon to hide.
BUG=27519
TEST=none
Review URL: http://codereview.chromium.org/414019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32616 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
leak. As far as I can tell the first two are bugs in gtk.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/414012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32615 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=26594
TEST=None, just documentation
Review URL: http://codereview.chromium.org/412003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32614 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Windows API.
Review URL: http://codereview.chromium.org/402086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32613 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I'm responsible for misnaming it in the first place (cut-and-paste error). Oops.
BUG=23501
TEST=none
Review URL: http://codereview.chromium.org/414034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32612 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
There seems to still be an interactive ui test failure on Windows.
TBR=sgjesse@chromium.org
Review URL: http://codereview.chromium.org/420003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32609 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
with unit test fixes.
Make the WebKitThread object start the WebKit thread on construction (not lazily).
NOTE: It's very possible this will have a startup performance impact. I'm going to watch the bots after committing.
TODO: Clean up shutdown logic that exists simply because we don't know whether or not we'll ever start the WebKit thread.
TEST=The WebKit thread gets spun up early in the initialization process.
BUG=24144
Review URL: http://codereview.chromium.org/404025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32608 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
This should fix the issues that we had with version 2.0.0.
Review URL: http://codereview.chromium.org/418009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32605 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MockRead with zero length as a EOF; but it could be a MockRead which
is an error code (where the length is irrelevant).
Allow advancing of the next read over simulated errors.
BUG=none
TEST=a test of the test?
Review URL: http://codereview.chromium.org/421001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32604 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=2795
Review URL: http://codereview.chromium.org/410008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32603 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=17706
TEST=None
Review URL: http://codereview.chromium.org/414006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32602 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
TBR=ilewis
Review URL: http://codereview.chromium.org/419001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32601 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Functions that take a printf-style format get a new annotation, which
produces a bunch of compiler warnings when you use printf impoperly.
This change adds the annotations and fixes the warnings.
We now must use PRId64 for 64-bit numbers and the PRIsz for size_t.
Review URL: http://codereview.chromium.org/339059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32600 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
It hangs.
BUG=28332
TBR=dank
Review URL: http://codereview.chromium.org/412009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32599 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(The cursor was displayed with full keyboard accessibility enabled.)
Changes to About.xib: changed the class of the view containing the legal text to |AboutLegalTextView| (from |NSTextView|).
BUG=25570
TEST=Enable Full Keyboard Access, All controls in System Preferences; look in the About Chromium/Google Chrome; there should be no cursor displayed (at the end of the text).
Review URL: http://codereview.chromium.org/414028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32598 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- We have picked a winner, code can go back to being simple.
- result codes are now TFxx
TEST=launch setup with --inactive-user-toast
BUG=none
Review URL: http://codereview.chromium.org/416002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32597 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/395012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32596 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=28270
TEST=verify per bug report.
Review URL: http://codereview.chromium.org/414022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32595 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
bookmarks permission.
BUG=28136
TEST=see bug
Review URL: http://codereview.chromium.org/412007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32594 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32593 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
view_examples is just built fine without the line,
but good to explicit.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32592 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=28317
TEST=none
Review URL: http://codereview.chromium.org/402108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32591 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change views->SetBorder(...) to views->set_border(...).
The latter is the right function name in views/view.h:
// The border object is owned by this object and may be NULL.
void set_border(Border* b) { border_.reset(b); }
const Border* border() const { return border_.get(); }
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/405032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32590 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds functionality to choose between two different InfoBubbleView types: white background and gradient background.
Screenshot: http://andybons.com/chrome/news_popup.png
BUG=23881
TEST=Install a browser action extension that has a popup, click and observe the popup being shown. Initial unit test added, but disabled.
Review URL: http://codereview.chromium.org/402077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32589 0039d316-1c4b-4281-b951-d872f2087c98
|