summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Reverts the revert of 22517.rohitrao@chromium.org2009-08-0724-441/+512
| | | | | | | | | | | | | | | | | | | | Rewrites the Mac view resizing logic to have the BrowserWindowController directly resize and relayout its children views. Now when a view needs to be resized, it asks its resize delegate (typically its controller's parent) to perform the resize. BUG=http://crbug.com/17619 TEST=Make sure that views are laid out correctly, even when they change size. Open and close the bookmark bar. Trigger an infobar and then close it. Trigger the download shelf and then close it. Trigger a download shelf with the infobar open, or with the bookmark bar open. Switch to and from fullscreen with various bars open. Resize the browser window with various bars open. Start the browser with and without the bookmark bar open. Try all of the above in a popup window. Review URL: http://codereview.chromium.org/165014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22721 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build break with uninitialized variable 'ev_policy_tag'.ukai@chromium.org2009-08-071-10/+9
| | | | | | | | | | | | Fix some last nits in codereview.chromium.org/119026 TBR=wtc BUG=10911 TEST=none Review URL: http://codereview.chromium.org/165117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22720 0039d316-1c4b-4281-b951-d872f2087c98
* Add recent crash found by reliability bot to known_crashes.txt.tim@chromium.org2009-08-071-0/+4
| | | | | | | | | | TBR=pkasting BUG=18743 TEST=none Review URL: http://codereview.chromium.org/165116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22719 0039d316-1c4b-4281-b951-d872f2087c98
* Implement X509Certificate::IsEV for NSS.ukai@chromium.org2009-08-071-82/+202
| | | | | | | | | | | Factor out PKIXVerifyCert function from Verify and share it with IsEV. BUG=10911 TEST=EV info shown on omnibar for https://www.thawte.com/, but not on https://bugs.webkit.org/ Review URL: http://codereview.chromium.org/119026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22718 0039d316-1c4b-4281-b951-d872f2087c98
* This adds a stub for the mac installer so that the gyp generation won't fail ↵gspencer@google.com2009-08-072-0/+45
| | | | | | | | on Macs. Review URL: http://codereview.chromium.org/165109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22717 0039d316-1c4b-4281-b951-d872f2087c98
* tabindex-focus-blur-all timed out on Webkit; mark it so.tim@chromium.org2009-08-071-1/+2
| | | | | | | | | TBR=pkasting BUG=9798 TEST=none Review URL: http://codereview.chromium.org/165114 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22716 0039d316-1c4b-4281-b951-d872f2087c98
* Try to add filters again, this time with proper normalized purify output.tim@chromium.org2009-08-071-113/+113
| | | | | | | | | | | | | | | | | | | | | | Original attempt: http://codereview.chromium.org/165088 RevocableStore- issue 17385 CreateChannel - issue 17979 IPC::Channel::Channel() - issue 17888 SyncChannel::SyncChannel - issue 16128 CreatePipe - issue 18696 ReceivedSyncMsgQueue - issue 8469 OnAddFilter - 18698 IPC::Channel::ChannelImpl::Connect - issue 18699 TBR=pkasting BUG=17385, 17979, 17888, 16128, 18696, 8469, 18698, 18699 TEST=none Review URL: http://codereview.chromium.org/164127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22715 0039d316-1c4b-4281-b951-d872f2087c98
* Flaky timeoutpkasting@chromium.org2009-08-071-0/+1
| | | | | | | | | TBR=timsteele BUG=18740 TEST=none Review URL: http://codereview.chromium.org/164126 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22714 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk Cookie Manager polish.mattm@chromium.org2009-08-071-1/+7
| | | | | | | | | | Make dialog wider, set first column width to fixed (but resizable), set initial sort order. BUG=17919 Review URL: http://codereview.chromium.org/164125 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22713 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash on fullscreening of popup.jrg@chromium.org2009-08-073-0/+22
| | | | | | | | | | | | | BUG=http://crbug.com/18551 TEST=Create a pop-up window. Fullscreen it (Cmd-Shift-F). Go back (Cmd-Shift-F again). Repeat a few times across different launches of Chromium. Review URL: http://codereview.chromium.org/164024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22712 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a few bugs with the theme infobar:aa@chromium.org2009-08-076-16/+84
| | | | | | | | | | | | | | * Don't animate the infobar closing and opening when switching between themes. * Don't show multiple infobars when intalling themes in rapid succession. BUG=18213 Review URL: http://codereview.chromium.org/165029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22711 0039d316-1c4b-4281-b951-d872f2087c98
* Porting POINT to gfx::Point.thestig@chromium.org2009-08-072-8/+12
| | | | | | | | | | | Patch from thiago.farnia at gmail.com. Original review url: http://codereview.chromium.org/155888 BUG=none TEST=none Review URL: http://codereview.chromium.org/164121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22710 0039d316-1c4b-4281-b951-d872f2087c98
* Treat certificate signatures using weak signature algorithmswtc@chromium.org2009-08-071-0/+4
| | | | | | | | | | | as invalid. R=cevans,mal BUG=http://crbug.com/18725 TEST=none Review URL: http://codereview.chromium.org/164115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22709 0039d316-1c4b-4281-b951-d872f2087c98
* Restore right click on bookmark bar.estade@chromium.org2009-08-071-1/+1
| | | | | | | | it stopped working after r22660 Review URL: http://codereview.chromium.org/165108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22708 0039d316-1c4b-4281-b951-d872f2087c98
* Flaky timeoutpkasting@chromium.org2009-08-071-0/+1
| | | | | | | | | TBR=timsteele BUG=18733 TEST=none Review URL: http://codereview.chromium.org/164122 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22707 0039d316-1c4b-4281-b951-d872f2087c98
* Buff out Windows & Tabs API, fix a few doc bugs.rafaelw@chromium.org2009-08-079-35/+146
| | | | | | | | | | | | | | This adds callback types, event types, and descriptions for the tabs & windows api. All defined types are loaded first in preparing the template data, so that types can cross reference across apis. Also, additional commentary is added to content_scripts.html doc about communication with the embedding page of a content_script. A check is now made in build.py for the case of the doc page rendering timing out (which is typically a clue that page rendering went wrong and should be inspected with chrome). Review URL: http://codereview.chromium.org/165063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22706 0039d316-1c4b-4281-b951-d872f2087c98
* Make user data dir deletion optional for InProcessBrowserTests.tim@chromium.org2009-08-072-1/+12
| | | | | | | | | | | | | | Original patch by tejasshah@google.com Original review: http://codereview.chromium.org/159896 TEST=any browser test or live sync test TBR=nick Review URL: http://codereview.chromium.org/164118 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22705 0039d316-1c4b-4281-b951-d872f2087c98
* NNTP: Add a menu item that allows the user to restore all blacklistedarv@google.com2009-08-073-22/+51
| | | | | | | | | | | | | | thumbnails BUG=15247 TEST=Blacklist (remove) a few thumbnails (hit the x on the thumbnail toolbar). Then go to the options menu and "Restore all removed thumbnails". The removed thumbnails should be back. Review URL: http://codereview.chromium.org/165107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22704 0039d316-1c4b-4281-b951-d872f2087c98
* Set the dangerous download text to the bookmark bar texttc@google.com2009-08-071-0/+3
| | | | | | | | | | color since we already set the shelf to the toolbar background color. Review URL: http://codereview.chromium.org/164116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22703 0039d316-1c4b-4281-b951-d872f2087c98
* linux: fix windowless Flash when scrollingpiman@chromium.org2009-08-075-32/+54
| | | | | | | | | | | | | Apparently on linux windowless Flash needs a paint after a NPP_SetWindow, otherwise it cancels its timer to do InvalidateRect. Also in this change: WebKit calls WebPluginImpl::setFrameRect at each paint, even if the rects haven't changed. That used to always send a message to the plugin process, which is unnecessary (that case is always a no-op in the WebPluginDelegateImpl), so I fixed that too. BUG=18423 Review URL: http://codereview.chromium.org/159907 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22702 0039d316-1c4b-4281-b951-d872f2087c98
* Http Cache: Deactivate entries without having the key of thervargas@google.com2009-08-073-6/+77
| | | | | | | | | | | | | | | entry to delete. The disk cache may fail to provide the key for a given entry (if there is a disk error, for instance), so we fall back to enumerate the active entries to delete this one. BUG=9952 TEST=unittest Review URL: http://codereview.chromium.org/165089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22701 0039d316-1c4b-4281-b951-d872f2087c98
* Flaky crashpkasting@chromium.org2009-08-071-0/+1
| | | | | | | | | TBR=timsteele BUG=18724 TEST=none Review URL: http://codereview.chromium.org/164111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22700 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a typo in last suppression commit (forgot type)dank@chromium.org2009-08-071-7/+46
| | | | | | | | | | | | | | | and shorten a suppression that was so long valgrind barfed. Add suppressions for two new valgrind warnings that are extremely reproducible on the mac. Add variant of an old suppression. BUG=11333,18661,18705 TEST=none Review URL: http://codereview.chromium.org/165100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22699 0039d316-1c4b-4281-b951-d872f2087c98
* Valgrind Linux: add suppresssion for SVGNames.agl@chromium.org2009-08-071-0/+11
| | | | | | | | | | | This is very similar to the one just above it. SVGNames are part of the WebKit startup and are singleton strings. Since it's an O(1) 'leak', it's not really a leak at all. BUG=17966 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22698 0039d316-1c4b-4281-b951-d872f2087c98
* Changelist for mattm readability review.mattm@chromium.org2009-08-073-157/+187
| | | | | | Review URL: http://codereview.chromium.org/160037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22697 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Change the way to calculate the position of the tab title text.estade@chromium.org2009-08-061-4/+8
| | | | | | | | | | On my machine this doesn't actually change the position, but at least it gets rid of the magic -1. BUG=18555 Review URL: http://codereview.chromium.org/165024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22696 0039d316-1c4b-4281-b951-d872f2087c98
* Add a temporary extension error message box on linux.tc@google.com2009-08-061-2/+4
| | | | | | | | | The NOTREACHED() crashed my debug build. Review URL: http://codereview.chromium.org/164088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22695 0039d316-1c4b-4281-b951-d872f2087c98
* Add 'rpm' to dev tools for creating RPM packages.mmoss@chromium.org2009-08-061-1/+1
| | | | | | | Review URL: http://codereview.chromium.org/165103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22694 0039d316-1c4b-4281-b951-d872f2087c98
* Disable plugin tests on webkit purify due to timeout.tim@chromium.org2009-08-061-0/+2
| | | | | | | | | | BUG=18598 TBR=nsylvain TEST=none Review URL: http://codereview.chromium.org/164108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22693 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding r22644, "GTK: Rounded corner on status bubble."erg@google.com2009-08-062-28/+128
| | | | | | | | | | | | | | The previous patch made ui_tests red because we don't always have a GdkWindow when a widget's size-allocate signal is called. Move all responsibility into the expose-event handler. http://crbug.com/18309 Original Review URL: http://codereview.chromium.org/164010 Review URL: http://codereview.chromium.org/164104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22692 0039d316-1c4b-4281-b951-d872f2087c98
* NNTP: Remove tips and downloads and introduce a recently closed bar instead.arv@google.com2009-08-066-330/+168
| | | | | | | | | | | | | | Make the list mode only show one column and make the items look like links. BUG=None TEST= On the new tab page try opening and closing tabs and windows. The closed tabs and windows should appear in the recently closed bar at the bottom. Review URL: http://codereview.chromium.org/165095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22691 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: only-child-pseudo-class.html is working now.agl@chromium.org2009-08-061-1/+1
| | | | | | | BUG=17635 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22690 0039d316-1c4b-4281-b951-d872f2087c98
* Move ClosePage method to WebView.darin@chromium.org2009-08-067-16/+16
| | | | | | | | | | | | Since it is about closing a page, WebView is a better home for it. R=dglazkov BUG=10034 TEST=none Review URL: http://codereview.chromium.org/164105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22689 0039d316-1c4b-4281-b951-d872f2087c98
* When the plugin crashes, cleanup references to its window in the renderer.piman@chromium.org2009-08-067-2/+33
| | | | | | | | | This avoids spurious messages when the plugin crashes, and potential issues (plugin crashes, the HWND/XID gets destroyed, a new one gets created by a new instance and gets the same HWND/XID, the browser operates on the new one instead of the old one). Review URL: http://codereview.chromium.org/160614 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22688 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the error I introduced into the installer build.scons file.gspencer@google.com2009-08-061-1/+1
| | | | | | Review URL: http://codereview.chromium.org/165098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22687 0039d316-1c4b-4281-b951-d872f2087c98
* Enable new FTP for Windows TestShell so that the results of block-test.html aredarin@chromium.org2009-08-066-24/+8
| | | | | | | | | | | | | | | | | the same across platforms. WTC tells me that it should be ready to go, and it anyways is only exercised by these two security/block-test*.html tests. Also, add back the fix from r22651. Extend that fix a bit so that when we do not have a special mapping, we just spit out the existing error code value. This way, if we get an unexpected result, the output will tell us what the original error code was. This change doesn't impact any layout tests. R=dglazkov,wtc BUG=18665 TEST=none Review URL: http://codereview.chromium.org/165091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22686 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up copy pasta hotkeys in gtk bookmark manager.estade@chromium.org2009-08-062-4/+32
| | | | | | | | | | | Also change the display hotkey for tab reload from f5 (windowsy) to ctrl+r (linuxy). BUG=none TEST=use the new hotkeys Review URL: http://codereview.chromium.org/164097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22685 0039d316-1c4b-4281-b951-d872f2087c98
* Don't pack an empty label into bookmarks with empty titles.estade@chromium.org2009-08-061-9/+16
| | | | | | | | BUG=18348 Review URL: http://codereview.chromium.org/164101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22684 0039d316-1c4b-4281-b951-d872f2087c98
* Fix video sync error when framerate or playback rate is lowkylep@chromium.org2009-08-062-6/+15
| | | | | | | | BUG=18441 TEST=play a low framerate video or under low rate and verify it stays synced Review URL: http://codereview.chromium.org/160620 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22683 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding Coverity fixes from http://codereview.chromium.org/159862 ↵phajdan.jr@chromium.org2009-08-0610-14/+18
| | | | | | | | | | | | | excluding the broken ones. The change of GURL -> const GURL& caused some nasty crash and the change got reverted. TEST=none BUG=none Review URL: http://codereview.chromium.org/164095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22682 0039d316-1c4b-4281-b951-d872f2087c98
* CL 22502 dropped the app_strings as part of the switch, so we don't have ↵thomasvl@chromium.org2009-08-061-0/+3
| | | | | | | | | | some of the strings we actually need to run. BUG=none TEST=none (no really good way to confirm that app_strings are in there now, pending cl uses them). Review URL: http://codereview.chromium.org/164098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22681 0039d316-1c4b-4281-b951-d872f2087c98
* This completes the building of o3d.msi from the GYP build.gspencer@google.com2009-08-0615-35/+422
| | | | | | Review URL: http://codereview.chromium.org/164044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22680 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Pass font settings through to interstitial renderers.derat@chromium.org2009-08-065-46/+77
| | | | | | | | | BUG=18483 TESTED=restarted and visited a page with a broken SSL cert a few times while changing font settings via gnome-appearance-properties Review URL: http://codereview.chromium.org/164094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22679 0039d316-1c4b-4281-b951-d872f2087c98
* Add recent crash found by reliability bot to known_crashes.txt. Bug for ↵senorblanco@chromium.org2009-08-061-0/+2
| | | | | | | | | | | crash logged as 18700. BUG=http://crbug.com/18700 TEST=less redness == more goodness Review URL: http://codereview.chromium.org/165092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22678 0039d316-1c4b-4281-b951-d872f2087c98
* Flaky timeoutpkasting@chromium.org2009-08-061-1/+2
| | | | | | | | | TBR=ojan BUG=18702 TEST=none Review URL: http://codereview.chromium.org/165093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22677 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Don't choke when there's no selection in the bookmark editor tree view.estade@chromium.org2009-08-062-7/+24
| | | | | | | | | 1) disable "new folder" when no folder is selected 2) if a user clicks apply when no folder is selected, apply the title/url edits but leave it in its original location Review URL: http://codereview.chromium.org/164016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22676 0039d316-1c4b-4281-b951-d872f2087c98
* Properly size accepted dangerous downloads.estade@chromium.org2009-08-061-4/+6
| | | | | | | | BUG=18448 Review URL: http://codereview.chromium.org/165086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22675 0039d316-1c4b-4281-b951-d872f2087c98
* Add filters for IPC::SyncChannel leaks on purify.tim@chromium.org2009-08-061-0/+135
| | | | | | | | | | | | | | | | | | | | Most already are suppressed and have bugs for valgrind. RevocableStore- issue 17385 CreateChannel - issue 17979 IPC::Channel::Channel() - issue 17888 SyncChannel::SyncChannel - issue 16128 CreatePipe - issue 18696 ReceivedSyncMsgQueue - issue 8469 OnAddFilter - 18698 IPC::Channel::ChannelImpl::Connect - issue 18699 BUG=17385, 17979, 17888, 16128, 18696, 8469, 18698, 18699 Review URL: http://codereview.chromium.org/165088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22674 0039d316-1c4b-4281-b951-d872f2087c98
* Port of WebKit's appcache manifest parser code.michaeln@google.com2009-08-065-163/+516
| | | | | | | | | | | | | | | Added unittests for manifest parser to test_shell_tests. This is a clone of jennb's CL here. http://codereview.chromium.org/160608 TBR=jennb BUG=none TEST=manifest_parser_unittest.cc Review URL: http://codereview.chromium.org/165072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22673 0039d316-1c4b-4281-b951-d872f2087c98
* Correctly handle extensions width in the GTK extension shelf.phajdan.jr@chromium.org2009-08-066-6/+14
| | | | | | | | | | | Also make the method name used on Windows shorter and more obvious. TEST=none http://crbug.com/16759 Review URL: http://codereview.chromium.org/164092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22672 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-02 03:45:43 +0000