summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Bookmark STAR bubble.jrg@chromium.org2009-08-2023-12/+1543
| | | | | | | | | | | | | | | | | | | BUG=http://crbug.com/14929 Sample image attached to bug. TEST=Click the STAR to add a bookmark. Watch bubble come up. Title is "Bookmark added!" Confirm fields are OK. Switch tabs and see bubble go away. Click STAR again. Watch bubble come up. Title is "Bookmark" Make sure all the buttons work (Edit, Close, Remove). Make sure you can change the title and parent folder. Make sure "Choose another folder..." opens edit window. Review URL: http://codereview.chromium.org/171016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23886 0039d316-1c4b-4281-b951-d872f2087c98
* Provide a hint to build systems that DerivedSourcesAllInOne.cpp should bemark@chromium.org2009-08-201-3/+4
| | | | | | | | | | | | compiled earlier than other WebKit files. DerivedSourcesAllInOne.cpp is huge, and it is beneficial to begin its compilation first. Given how Xcode parallelizes, this allows other compilations to continue while the large file is being built. When DerivedSourcesAllInOne.cpp comes last, it is likely that nothing else will be available to be compiled at the same time. This is wasteful. Review URL: http://codereview.chromium.org/174157 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23885 0039d316-1c4b-4281-b951-d872f2087c98
* Remove include of IPC headers from headers they crept into. This slows down ↵jam@chromium.org2009-08-2012-5/+22
| | | | | | | | the build. Review URL: http://codereview.chromium.org/174148 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23884 0039d316-1c4b-4281-b951-d872f2087c98
* WONTFIX remaining WebArchive tests.dglazkov@chromium.org2009-08-201-14/+7
| | | | | | | | | | BUG=10395 TEST=none TBR=jparent Review URL: http://codereview.chromium.org/173150 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23883 0039d316-1c4b-4281-b951-d872f2087c98
* Build for Mac in the Release configuration at -O2mark@chromium.org2009-08-202-19/+12
| | | | | | | | | | | BUG=16713 TEST=Watch perf. Startup time should be flat or possibly lose a very small amount (~1%). Everything else should be a little bit faster. Watch sizes. The .app and .dmg will grow, but I've cut their sizes way down lately, and I'd like to cash in some of those gains for speed. Review URL: http://codereview.chromium.org/174160 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23882 0039d316-1c4b-4281-b951-d872f2087c98
* Http cache: Fix the code that handles 206s when revalidatingrvargas@google.com2009-08-203-22/+91
| | | | | | | | | | | a range from the cache. BUG=12258 TEST=unittests Review URL: http://codereview.chromium.org/174039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23881 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: more interactive tests porting.estade@chromium.org2009-08-207-71/+142
| | | | | | | | | | The most noteworthy change here is the implementation of SendMouseMove() and SendMouseClick() in ui_controls. I've combed the interwebs and I don't think it's possible to figure out the GdkWindow that is showing for a given (x,y) coordinate pair (except perhaps by delving into X), so we have to just send clicks to wherever the pointer lies. This is unfortunate in that it means we have to move the pointer, wait for it to get where it's going, and only then make the click. But on the bright side there's this super helpful function called gdk_display_warp_pointer() which makes moving the mouse a breeze. BUG=19076 Review URL: http://codereview.chromium.org/174113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23880 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Theme: Fix corner offsets on the find bar.erg@google.com2009-08-201-5/+5
| | | | | | | | http://crbug.com/19811 Review URL: http://codereview.chromium.org/173140 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23879 0039d316-1c4b-4281-b951-d872f2087c98
* Fix compile errorpkasting@chromium.org2009-08-201-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23878 0039d316-1c4b-4281-b951-d872f2087c98
* Disable the Bookmarks ExtensionAPITest becuase it is flaky.brettw@chromium.org2009-08-201-1/+2
| | | | | | Review URL: http://codereview.chromium.org/173149 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23877 0039d316-1c4b-4281-b951-d872f2087c98
* Initialize all new booleans in unittest constructor.pkasting@chromium.org2009-08-201-0/+2
| | | | | | | | | TBR=brettw BUG=none TEST=none Review URL: http://codereview.chromium.org/173148 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23876 0039d316-1c4b-4281-b951-d872f2087c98
* Fix typo in extension install dialog.aa@chromium.org2009-08-201-2/+2
| | | | | | TBR=erikkay@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23875 0039d316-1c4b-4281-b951-d872f2087c98
* Added GPU rendering plugin, an internal out-of-process plugin for rendering ↵apatrick@google.com2009-08-204-0/+230
| | | | | | | | | | | | | | | 3D graphics with the GPU. Does nothing at all yet. Only enabled if --enable-gpu-plugin is on the command line and only in Windows build. GPU plugin builds on Linux and Mac but is not functional or enabled yet. BUG=none TEST=none Review URL: http://codereview.chromium.org/174158 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23874 0039d316-1c4b-4281-b951-d872f2087c98
* Fix uninitialized memory read in autocomplete tests.brettw@chromium.org2009-08-201-0/+1
| | | | | | Review URL: http://codereview.chromium.org/173142 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23872 0039d316-1c4b-4281-b951-d872f2087c98
* Close the autocomplete popup when the user tries to move thetony@chromium.org2009-08-202-9/+8
| | | | | | | | | | | | | window with the custom frame, when the user tries to resize the window with the custom frame, and when the window switches between maximized/restored state. BUG=19636 Review URL: http://codereview.chromium.org/174109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23866 0039d316-1c4b-4281-b951-d872f2087c98
* Remove minidump_2_core target since it's not used and breaks 64-bit build.mmoss@chromium.org2009-08-201-13/+0
| | | | | | | Review URL: http://codereview.chromium.org/173138 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23865 0039d316-1c4b-4281-b951-d872f2087c98
* WONTFIX the test where we explicitly disallow file:// URLS from doing XHR to ↵dglazkov@chromium.org2009-08-201-3/+3
| | | | | | | | | | | | data:. TBR=abarth BUG=9275 TEST=none Review URL: http://codereview.chromium.org/174161 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23864 0039d316-1c4b-4281-b951-d872f2087c98
* Removed personalization_strings.h and moved all the strings into ↵idana@chromium.org2009-08-2010-123/+160
| | | | | | | | | | | | | generated_resources.grd. I'll take care of the Setup Wizard strings/resources in my next patch. BUG=none TEST=none Review URL: http://codereview.chromium.org/173069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23863 0039d316-1c4b-4281-b951-d872f2087c98
* Update test expectations with notes about accessibility tests.dglazkov@chromium.org2009-08-201-11/+6
| | | | | | | | | | R=jparent TEST=none BUG=10322 Review URL: http://codereview.chromium.org/173128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23862 0039d316-1c4b-4281-b951-d872f2087c98
* Fix gcc warning about possible unused variable experienced with Apple gcc 4.2mark@chromium.org2009-08-201-1/+1
| | | | | | | in an -O3 experiment. Review URL: http://codereview.chromium.org/173125 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23861 0039d316-1c4b-4281-b951-d872f2087c98
* Fix gcc warning about possible unused variable experienced with Apple gcc 4.2mark@chromium.org2009-08-201-2/+2
| | | | | | | in an -O3 experiment. Review URL: http://codereview.chromium.org/173124 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23860 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to minimize omnibox flicker, without increasing lag too much.pkasting@chromium.org2009-08-202-96/+151
| | | | | | | | | | This also updates a bunch of comments, mostly to keep terminology like "results" and "matches" consistent, occasionally to fix grammar or other issues. BUG=18369 TEST=none Review URL: http://codereview.chromium.org/173031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23859 0039d316-1c4b-4281-b951-d872f2087c98
* Remove WebPluginImpl::element_darin@chromium.org2009-08-205-76/+83
| | | | | | | | | | | | | This member was of type HTMLPlugInElement. This is a step toward removing all WebCore includes from webplugin_impl.cc. R=jam BUG=10036 TEST=none Review URL: http://codereview.chromium.org/173126 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23858 0039d316-1c4b-4281-b951-d872f2087c98
* Adds support for excluding WONTFIX from layout test formatting and sorting ↵gwilson@google.com2009-08-204-63/+101
| | | | | | | | | | | | | | of test failures by path. Also fixes other minor issues like not being able to pass absolute paths for output. R=ojan BUG=none TEST=run test_output_formatter.py, tests should not include WONFIX and sort properly Review URL: http://codereview.chromium.org/174097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23857 0039d316-1c4b-4281-b951-d872f2087c98
* Remove special event pumping now that r21355 is in and we can specify to use ↵avi@chromium.org2009-08-202-34/+6
| | | | | | | | | | | a UI loop for the renderer. BUG=http://crbug.com/13893 TEST=things should stay working, not crash, and not go "Not Responding" in the Activity Monitor Review URL: http://codereview.chromium.org/174156 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23856 0039d316-1c4b-4281-b951-d872f2087c98
* Add instrumentation to ClientSocketPool, that writes to LoadLog.eroman@chromium.org2009-08-209-59/+377
| | | | | | | | BUG=http://crbug.com/14478 Review URL: http://codereview.chromium.org/174101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23855 0039d316-1c4b-4281-b951-d872f2087c98
* Check for NULL Profile::GetDefaultRequestContext().ericroman@google.com2009-08-203-13/+29
| | | | | | | | | | | | | | | | | | | This papers over a chrome-bot crash. The problem is that the ChromeURLRequestContexts have a split life between the UI thread and IO thread. Although conceptually they live on the IO thread, they are lazy-initialized on the UI thread, and are contained by a Profile which also lives on the UI thread. What happens in this crash, is ResolveProxyMsgHelper (the class which handles IPCs from the plugin process for proxy resolving) calls Profile::GetDefaultRequestContext() to get at the main URLRequestContext from the IO thread. Well, during the shutdown sequence, ~ProfileImpl NULLs the default request context before the IO thread is torn down, so consumers on the IO thread may get NULL. Or even worse, might get a non-NULL pointer to a request context that has already been freed. With this patch I hack past the NULL case. Really we need a proper solution to managing URLRequestContexts split personality... I did a quick survey of the code and found other consumers that use GetDefaultRequestContext from the IO thread, so this bug may be happening elsewhere. BUG=http://crbug.com/18358 Review URL: http://codereview.chromium.org/172085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23854 0039d316-1c4b-4281-b951-d872f2087c98
* Disable playback controls if audio/video element has errored.scherkus@chromium.org2009-08-201-1/+4
| | | | | | | | | | TEST=load an audio/video with an unsupported input, then right click on it.. the playback control items should be disabled BUG=19740 Review URL: http://codereview.chromium.org/174119 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23853 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the folding define macro.ajwong@chromium.org2009-08-201-7/+0
| | | | | | | | | | | It will never be disabled anyways and just leaves a block of code open for bitrot. BUG=none TEST=none Review URL: http://codereview.chromium.org/171017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23852 0039d316-1c4b-4281-b951-d872f2087c98
* Change the enum style to use MACRO_STYLE rather than kConstant style to be ↵jennb@chromium.org2009-08-201-14/+14
| | | | | | | | | | | consistent with chrome code base. TEST=none BUG=none Review URL: http://codereview.chromium.org/174145 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23851 0039d316-1c4b-4281-b951-d872f2087c98
* Move MediaPlayerAction out of context_menu.h into webview.h since it's ↵ajwong@chromium.org2009-08-207-23/+36
| | | | | | | | really only used by webview. Review URL: http://codereview.chromium.org/174143 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23850 0039d316-1c4b-4281-b951-d872f2087c98
* Bump kNumBuffers to 3fbarchard@chromium.org2009-08-202-16/+22
| | | | | | | | BUG=17940 TEST=This vid should not stutter http://fbarchard-v64.ad.corp.google.com/testmatrix/color/color2.mp4 Review URL: http://codereview.chromium.org/174134 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23849 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of the extension's "Current Version" file.mpcomplete@chromium.org2009-08-2015-288/+254
| | | | | | | | | | | | The entire manifest.json value is now stored in the prefs file. This will allow for quick extension checks on startup. BUG=18293 TEST=Make sure installing/upgrading/uninstalling extensions works as expected. Review URL: http://codereview.chromium.org/174036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23848 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Also return bookmark index through bookmarks API."kuchhal@chromium.org2009-08-201-4/+1
| | | | | | | | Revert r23840 Review URL: http://codereview.chromium.org/173133 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23847 0039d316-1c4b-4281-b951-d872f2087c98
* Enabled mono playback support for Linux.scherkus@chromium.org2009-08-202-5/+20
| | | | | | | | | | BUG=19788 TEST=try playing any mono audio source, should just work! Review URL: http://codereview.chromium.org/173109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23846 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "During uninstall if Chrome is set as default,"kuchhal@chromium.org2009-08-2010-268/+106
| | | | | | | | | | allow user to choose another browser as default." reverting r23841 Review URL: http://codereview.chromium.org/173131 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23845 0039d316-1c4b-4281-b951-d872f2087c98
* Disable two tests while I investigate why Purify doesnt like them.kuchhal@chromium.org2009-08-201-2/+2
| | | | | | | | BUG=19820 Review URL: http://codereview.chromium.org/174153 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23844 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress a WebKit failure on Mac while we investigate.paul@chromium.org2009-08-201-0/+3
| | | | | | | | | BUG=19842 (http://crbug.com/19842) TEST=Covered by layout test Review URL: http://codereview.chromium.org/174150 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23843 0039d316-1c4b-4281-b951-d872f2087c98
* Delete the rebaseline result files for windows since these layout tests ↵jianli@chromium.org2009-08-204-2/+0
| | | | | | | | | | | should only be run under mac. BUG=none TEST=none Review URL: http://codereview.chromium.org/174151 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23842 0039d316-1c4b-4281-b951-d872f2087c98
* During uninstall if Chrome is set as default, allow user to choose another ↵kuchhal@chromium.org2009-08-2010-106/+268
| | | | | | | | | | | browser as default. BUG=14023 TEST=Make sure the option of choosing a different browser shows up during uninstall (and works as intended) iff chrome is set as default browser. Review URL: http://codereview.chromium.org/172080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23841 0039d316-1c4b-4281-b951-d872f2087c98
* Also return bookmark index through bookmarks API.kuchhal@chromium.org2009-08-201-1/+4
| | | | | | Review URL: http://codereview.chromium.org/173074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23840 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit DEPS roll 47547:47575.dimich@google.com2009-08-202-1/+9
| | | | | | | | | TBR=jianli BUGS=19835 TEST=none Review URL: http://codereview.chromium.org/174147 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23839 0039d316-1c4b-4281-b951-d872f2087c98
* Remove old filters that aren't necessary now that SpellCheck is disabled.erikkay@chromium.org2009-08-201-4/+1
| | | | | | | | TBR: huanr BUG=19833 BUG=19834 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23838 0039d316-1c4b-4281-b951-d872f2087c98
* Fix theme install on 64 bit chromium builds.tony@chromium.org2009-08-201-4/+4
| | | | | | | | | | Extension signature sizes are always 4 bytes, not variable depending on platform. Review URL: http://codereview.chromium.org/173104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23837 0039d316-1c4b-4281-b951-d872f2087c98
* Make new FTP the default on Windows. Use the --wininet-ftpwtc@chromium.org2009-08-203-12/+11
| | | | | | | | | | | | command-line switch to select the old WinInet-based FTP implementation. R=phajdan.jr BUG=http://crbug.com/4965 TEST=none Review URL: http://codereview.chromium.org/173099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23836 0039d316-1c4b-4281-b951-d872f2087c98
* Fix log message during install.kuchhal@chromium.org2009-08-201-2/+1
| | | | | | | | BUG=19745 Review URL: http://codereview.chromium.org/174084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23835 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Attempt #2 at updating PRIMARY selection on Ctrl-C in omnibox.derat@chromium.org2009-08-202-0/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | r23596 was the original attempt; r23714 reverted it. Using gtk_text_buffer_copy_clipboard() gives the GtkTextBuffer ownership of the GtkClipboard and appears to prevent it from unhighlighting its text. Tested as follows: 1. Select text in webkit and hit Ctrl-C; check that both the PRIMARY and CLIPBOARD selections contain it. 2. Click in the omnibox. All of the text gets highlighted. Check that the PRIMARY selection contains the omnibox text and the CLIPBOARD selection contains the webkit text. 3. Type Ctrl-C and confirm that the CLIPBOARD selection now contains the omnibox text. 4. Copy webkit text back to both selections. 5. Type Ctrl-L. The omnibox text gets highlighted but both selections still contain the webkit text. 6. Type Ctrl-C and confirm that both selections now contain the omnibox text. 7. Try hitting Ctrl-C again while the omnibox text is on the CLIPBOARD selection to make sure that a bizarre GTK crash doesn't occur (see comment in code). BUG=19648 TESTED=see above Review URL: http://codereview.chromium.org/173098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23834 0039d316-1c4b-4281-b951-d872f2087c98
* Remove personalization.h/cc by putting things in final resting placestim@chromium.org2009-08-2020-385/+140
| | | | | | Review URL: http://codereview.chromium.org/173085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23833 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline slider mouse events test (changed upstream ↵victorw@chromium.org2009-08-202-5/+11
| | | | | | | | | | | http://trac.webkit.org/changeset/45658) TBR=dglazkov TEST=LayoutTests\fast\forms\slider-mouse-event.html BUG=16289 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23832 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline editing test imagesvictorw@chromium.org2009-08-205-8/+2
| | | | | | | | | TBR=dglazkov TEST=layout test BUG=17883 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23831 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-01 01:45:41 +0000