| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15593 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=darin
BUG=0
TEST=0
Review URL: http://codereview.chromium.org/113127
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15592 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=darin
BUG=0
TEST=make build green.
Review URL: http://codereview.chromium.org/113125
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15590 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=darin
BUG=0
TEST=0
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15589 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changed ExtensionHost so that it returns NULL if it doesn't have
a browser, instead of getting the last active one. The problem
is that if ExtensionHost returns the last active browser at the
time it's constructed, it might be garbage by the time it is
used.
Changed tab functions to use more consistent logic to determine
the 'current' browser to operate on.
Review URL: http://codereview.chromium.org/115071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15587 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/112006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15586 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=darin
BUG=0
TEST=layout tests
Review URL: http://codereview.chromium.org/113117
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15585 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
(As a side effect, this patch also fixes disabled items in the rest
of the bookmarks bar.)
Review URL: http://codereview.chromium.org/113119
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15582 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
IPC messages.
Make OpenIncognito synchronuous.
Review URL: http://codereview.chromium.org/115092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15579 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
A reordering of stats gathering produced a vulnerability to
divide by zero.
bug=1835317
r=mbelshe
Review URL: http://codereview.chromium.org/113115
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15578 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15577 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TEST=none
Review URL: http://codereview.chromium.org/113108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15576 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
* Compile OS X dump_syms & symupload utilities from the public repository to simplify the branded builder.
* Correct comment in breakpad_mac_stubs.mm so it more accurately reflects reality.
Review URL: http://codereview.chromium.org/113114
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15574 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/2780
Review URL: http://codereview.chromium.org/115097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/99294
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15572 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
brings up a context menu containing "Search Google for''".
This change will fix the above by not adding the menu item if the selection
string is empty.
BUG=10798
patch by yuzo@google.com
original review: <http://codereview.chromium.org/100246>
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15571 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
handle the keypress.
Also, don't try to give the browser commands that are disabled.
----
(this description may need to be re-written)
BUG=11526
Review URL: http://codereview.chromium.org/113050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15570 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15569 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
real rect from WebCore.
Review URL: http://codereview.chromium.org/115096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15568 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
DOMWindow.idl
R=mbelshe
BUG=10898
TEST=no new layout failures after this change
Review URL: http://codereview.chromium.org/114011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15566 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
together.
This is also useful for chrome-extension URLs, where we want any URLs for a
given extension to be grouped in the same process.
BUG=11501,11002
Review URL: http://codereview.chromium.org/115003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15565 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
on Android:
0005fad6 _NPN_UnregisterObject
external/webkit/V8Binding/v8/npruntime.cpp:401
0005fb6a _NPN_DeallocateObject
external/webkit/V8Binding/v8/npruntime.cpp:296
0005fba2 NPN_ReleaseObject
external/webkit/V8Binding/v8/npruntime.cpp:312
0005e1e6 ForgetV8ObjectForNPObject(NPObject*)
external/webkit/V8Binding/v8/V8NPObject.cpp:367
0005fb1e _NPN_UnregisterObject
external/webkit/V8Binding/v8/npruntime.cpp:428
Review URL: http://codereview.chromium.org/113107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
I.e. http://build.chromium.org/buildbot/waterfall/builders/Modules%20Mac%20(valgrind)/builds/477/steps/valgrind%20test%3A%20ui/logs/stdio
Review URL: http://codereview.chromium.org/115093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15563 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Google" doesn't show correctly in a "New Tab" for RTL locales.
(http://crbug.com/2780)
The error happens in LocationBarView::TextDisplayWidth() which does not correctly calculate the location entry's text display width.
The fix itself contains comments so hope it is self-explained.
Test steps:
1. Start Chrome with a new user data directory (or clean up all browsing data) and make sure the UI language is Hebrew.
2 Type www.google.com in the omnibox and press Enter.
3 Close and re-open the browser.
4 Type character "h" in Ominibox
Without the fix, only "tab" button is showing as keyword hint.
With the fix, Hebrew translation of "press tab to search google" is displayed. Please be noted: you need to have enough space in omnibox in order for the whole keyword hint to be displayed, otherwise, only "tab" button will be displayed.
Review URL: http://codereview.chromium.org/100360
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15562 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115095
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15561 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113104
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=11472
Review URL: http://codereview.chromium.org/113109
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15559 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
RTL languages.
http://crbug.com/11223
Review URL: http://codereview.chromium.org/115091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15558 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Only interesting change is in v8_custom.cpp to account for recently upstreamed
V8 bindings.
R=dglazkov,japhet
Review URL: http://codereview.chromium.org/115090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15556 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115089
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15551 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Nib file changes:
- Changes the "Line Breaks" style to "Truncate Tail" for the TabCell.
Review URL: http://codereview.chromium.org/115043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15550 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15549 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15548 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=10965
Review URL: http://codereview.chromium.org/115084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15547 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Allow the message to go multiline, and it will just clip if it can't fit.
Review URL: http://codereview.chromium.org/113099
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15545 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15544 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15543 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/115079
BUG=9371
Review URL: http://codereview.chromium.org/115083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15542 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
detached document.
If there is no frame corresponding to the DOMWindow object from which
we are retrieving the constructor function, return undefined.
Attempts to construct the object will therefore throw an exception
because an attempt is made to call undefined as a function.
BUG=10861
Review URL: http://codereview.chromium.org/115079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I forgot that unittests.vcproj is not gypified...
TEST=There should be at least one test in unit_tests matching ImportantFileWriterTest.* on Windows
http://crbug.com/10618
Review URL: http://codereview.chromium.org/115077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15539 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is a preparation for removing even more dependencies on views/
on Linux, but further parts are more complicated.
http://crbug.com/11066
Review URL: http://codereview.chromium.org/115078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15538 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Because of the lack of my comments, omnibox2 does not use this MirroringContext class to re-order the text runs and fragments. (Sorry for the lack of comments.)
This change uses the MirroringContext class and adds comments that describe it.
Review URL: http://codereview.chromium.org/100248
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15537 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
42932:42994.
Do not allow cross-frame access to a frame whose document is
unavailable.
See http://trac.webkit.org/changeset/42983 for details. The rest of the changes from that change set will follow as a separate changelist.
BUG=11178
Review URL: http://codereview.chromium.org/113093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15536 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
returning an int is just a test optimization.
Expose a view_count() accessor on ViewStorage for unit tests to discern the number of views stored in it.
Review URL: http://codereview.chromium.org/113091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15534 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=ager
Review URL: http://codereview.chromium.org/113088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15532 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15531 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15530 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=eseidel
Review URL: http://codereview.chromium.org/115072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15528 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
priorities to decide what tests need fixing for the next release.
Leaving them in just leads to confusion.
This does mean that the bots will now report the total number
of tests we fail that we ever want to fix instead of the number
of tests we fail that we want to fix for the next release.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/116001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15527 0039d316-1c4b-4281-b951-d872f2087c98
|