summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Add Print Selection support to Chrome. This change is fairly involved since ↵sverrir@google.com2009-06-1920-128/+162
| | | | | | | | | | | | | | | | this means that the printing is done async instead of the fully synchronous mode the normal full page printing is. This means we create an in memory copy of the selected text for printing. This is the next step to move to fully async printing with print frame support. This change also removes the print on demand functionality that was no longer used. BUG=http://crbug.com/1682 TEST=The print dialog on Windows now contains an option to print selection only. Test that with various pages and various selections. Review URL: http://codereview.chromium.org/125082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18815 0039d316-1c4b-4281-b951-d872f2087c98
* Changing the mode we pull events in, so we don't fire off timers and ↵avi@google.com2009-06-191-3/+5
| | | | | | | | | | | notifications. BUG=http://crbug.com/14609 TEST=No immediate test; see that the specified crash in the bug report stops happening. Review URL: http://codereview.chromium.org/132070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18814 0039d316-1c4b-4281-b951-d872f2087c98
* Add 'theme_dll' as a dependency of 'chrome_dll'.sgk@google.com2009-06-192-4/+2
| | | | | | | | | gyp DEPS roll so loadable_module targets ignore import libraries. BUG=none TEST=none Review URL: http://codereview.chromium.org/131109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18813 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the redness on the new Google Chrome continuous builder by notnsylvain@chromium.org2009-06-191-1/+3
| | | | | | | | running the mini_installer_tests that need to access the previous installers, since they are not accessible from this buildbot. Review URL: http://codereview.chromium.org/131070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18812 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline some Linux specific layout test differences from r18803.deanm@chromium.org2009-06-1912-6/+6
| | | | | | | | | | | | Skia's gradient drawing has changed a slight bit. None of the differences are noticable visually. These changes were specific to Linux and didn't happen on Windows since we use Skia gradients for drawing our form buttons on Linux. Inspected each difference manually, and they look ok. Review URL: http://codereview.chromium.org/131111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18811 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: add fake callframe for live object expansion in console.pfeldman@chromium.org2009-06-191-1/+7
| | | | | | Review URL: http://codereview.chromium.org/132068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18810 0039d316-1c4b-4281-b951-d872f2087c98
* Display an infobar alert when extension process crashes.phajdan.jr@chromium.org2009-06-199-32/+190
| | | | | | | | | | | | Also correctly handle crashes in task manager. The infobar allows user to restart the extension process. TEST=Install buildbot extension, see its content in the shelf. Open task manager, kill extension process. Click "restart" in the infobar that should appear. The extension content in the shelf should re-appear after the crash. http://crbug.com/14111 Review URL: http://codereview.chromium.org/126289 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18809 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline Linux layout tests for the Skia roll in r18803.deanm@chromium.org2009-06-1952-26/+26
| | | | | | | Review URL: http://codereview.chromium.org/131110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18808 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: remove dock/undock buttonpfeldman@chromium.org2009-06-191-1/+5
| | | | | | | BUG=25 Review URL: http://codereview.chromium.org/131108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18807 0039d316-1c4b-4281-b951-d872f2087c98
* Implement restoring closed tab menu item. Reworked cross-platform code to ↵pinkerton@chromium.org2009-06-1910-80/+181
| | | | | | | | | | handle the case of restoring when there are no browsers open by making window restore re-use a given browser if it has no tabs. Removed unit test that assumes it can pass a NULL Browser. Wrote a new UI test to cover the same area, but it's disabled until another bug is fixed, and I didn't want to hold up landing this feature. Added key shortcut for "open window in incognito mode". BUG=13758 TEST=restoring closed tabs with visible windows and with no windows remaining open. Review URL: http://codereview.chromium.org/125257 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18806 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: fix crash when inspect element invoked on the root element.pfeldman@chromium.org2009-06-191-4/+4
| | | | | | Review URL: http://codereview.chromium.org/131106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18805 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unnecessary devtool_sanity_unittest.cc entries from 'unit_tests'.sgk@chromium.org2009-06-191-4/+0
| | | | | | | | BUG=14639 TEST=none Review URL: http://codereview.chromium.org/132067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18804 0039d316-1c4b-4281-b951-d872f2087c98
* Roll Skia up to r224, for a few bug fixes.deanm@chromium.org2009-06-1983-42/+42
| | | | | | | | | | | | | | | Most importantly this fixes a spline drawing error and a possible Linux crash when failing to load a font. The rebaselines are mostly due to minor gradient changes (Skia changes r212 and r213). There was one layout test that was hitting the spline drawing bug, and the results now look correct (svg-as-background-5.html). BUG=13007,14536 Review URL: http://codereview.chromium.org/131105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18803 0039d316-1c4b-4281-b951-d872f2087c98
* Don't grant unnecessary handle privileges in OpenProcessHandle.phajdan.jr@chromium.org2009-06-194-9/+8
| | | | | | | | | This patch makes it harder for process handles with more privileges to leak to untrusted places. Review URL: http://codereview.chromium.org/125260 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18802 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a valgrind error related to Zygote's CommandLine usage.craig.schlenter@chromium.org2009-06-193-5/+12
| | | | | | | | Also touch up some include guards and a comment. Review URL: http://codereview.chromium.org/131054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18801 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: add devtools.css to webkit.gyp. It should have been added as part ↵yurys@google.com2009-06-193-3/+4
| | | | | | | | of http://codereview.chromium.org/125116 Review URL: http://codereview.chromium.org/131103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18800 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools Profiler: Fix parsing of duplicate function names.mnaganov@chromium.org2009-06-191-1/+5
| | | | | | | | | | | If there are several functions with the same name, their names are suffixed with "{<counter>}". I forgot about this, and it resulted in emitting wrong URLs for them. BUG=none TEST=none Review URL: http://codereview.chromium.org/132065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18799 0039d316-1c4b-4281-b951-d872f2087c98
* Update V8 to version 1.2.8.2.sgjesse@chromium.org2009-06-191-1/+1
| | | | | | Review URL: http://codereview.chromium.org/131098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18798 0039d316-1c4b-4281-b951-d872f2087c98
* Test expectation update due to the WebKit merge 44805:44837.levin@chromium.org2009-06-191-2/+1
| | | | | | | | | | TBR=paul@chromium.org BUG=None TEST=None Review URL: http://codereview.chromium.org/132064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18797 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline tests due to the merge 44805:44837. levin@chromium.org2009-06-193-2/+6
| | | | | | | | | | | | The rebaseline is due to http://trac.webkit.org/changeset/44806 which did a vertical alignment change. TBR=paulg BUG=None TEST=None Review URL: http://codereview.chromium.org/132062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18796 0039d316-1c4b-4281-b951-d872f2087c98
* Fix: New window appears to the left/up if the taskbar is on left/top.yuzo@chromium.org2009-06-193-8/+25
| | | | | | | | | | | | | | | | | Currently, the Windows taskbar (put differently, work area) is not considered in getting the last window bounds (while it is for the saved window bounds). This causes new windows (CTRL-N) appear to the left/up of the existing window instead of right/down, if the taskbar is on left or top. TESTED=gcl try, manually TEST=Place the taskbar on left or top of the screen and create new Chrome windows by CTRL-N and observe. BUG=14131 Review URL: http://codereview.chromium.org/125179 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18795 0039d316-1c4b-4281-b951-d872f2087c98
* When we upgrade, discard all uploadable stats, including old logsjar@chromium.org2009-06-191-0/+8
| | | | | | | | | | | | | | We already discard all stability info when we do an upgrade to a new version, as there is less concern about stats from old versions. This change just adds the list of "old logs" (gathered in previous sessions, presumably with an old version) to the list of data that is discarded. BUG=14657 r=evanm Review URL: http://codereview.chromium.org/131089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18794 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: when script has URL all breakpoints are set using that URL and ↵yurys@google.com2009-06-191-26/+65
| | | | | | | | | line number, otherwise breakpoint is set using script id and line number. Breakpoints set using URL will survive page reload. BUG=13675 Review URL: http://codereview.chromium.org/131036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18793 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline tests due to the merge 44805:44837.levin@chromium.org2009-06-1923-58/+249
| | | | | | | | | | | | | | | | The majority of these have to do http://trac.webkit.org/changeset/44806 which did a vertical alignment change. become-overlay-composited-layer is a new result due to a new test added by http://trac.webkit.org/changeset/44817. BUG=None TEST=None TBR=paulg Review URL: http://codereview.chromium.org/132061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18792 0039d316-1c4b-4281-b951-d872f2087c98
* This is a fix for a memory leak.jcampan@chromium.org2009-06-192-2/+4
| | | | | | | | | | AutocompletePopupWin would be leaked when the browser view is closed. BUG=None TEST=Make sure Chrome can be opened/closed without crasher. Review URL: http://codereview.chromium.org/132050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18791 0039d316-1c4b-4281-b951-d872f2087c98
* Change URL back to the previous one if the typed URL causes file download.yuzo@chromium.org2009-06-191-0/+7
| | | | | | | | | | | | | | | | | | This is the successor to http://codereview.chromium.org/115704 TESTED=manually TEST=Type any URL that causes download, e.g., ftp://ftp.vim.org/pub/vim/pc/gvim72.zip into the omnibox. Without this change the URL remains there. With this change, the URL is changed back to the original one. BUG=1904 Review URL: http://codereview.chromium.org/126266 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18790 0039d316-1c4b-4281-b951-d872f2087c98
* Convert unit_tests.exe, with additional dependency on ffmpegsgk@google.com2009-06-191-2/+13
| | | | | | | | | | | | | | | (for dependencies on avcode-52.lib et al.). Adds additional system libraries (urlmon.lib and winmm.lib). Disables (excludes from the build) four modules with build or runtime errors: browser/debugger/devtools_sanity_unittest.cc browser/extensions/extensions_service_unittest.cc browser/password_manager/login_database_unittest.cc common/extensions/extension_unittest.cc BUG=none TEST=none Review URL: http://codereview.chromium.org/126180 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18789 0039d316-1c4b-4281-b951-d872f2087c98
* A crasher from the field seems to indicate that the page render widget host ↵jcampan@chromium.org2009-06-191-1/+2
| | | | | | | | | | view win can get the focus after the TabContents delegate has been NULLed. BUG=http://crbug.com/14599 TEST=Exercise closing tabs with on-unload handlers. Review URL: http://codereview.chromium.org/132052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18788 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit merge 44805:44837levin@chromium.org2009-06-1958-381/+11
| | | | | | | | | | | | The deletions of results are due to conversions of test to be dumpAsText tests. TBR=paulg BUG=none TEST=none Review URL: http://codereview.chromium.org/132057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18787 0039d316-1c4b-4281-b951-d872f2087c98
* Implement window open disposition for (some) navigation buttons.estade@chromium.org2009-06-196-5/+92
| | | | | | | | | | still need to do similar for link buttons and such. BUG=14518 Review URL: http://codereview.chromium.org/131071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18786 0039d316-1c4b-4281-b951-d872f2087c98
* Don't treat underscores as mnemonics in the bookmark bar.estade@chromium.org2009-06-191-2/+21
| | | | | | | | | BUG=14438 TEST=see bug Review URL: http://codereview.chromium.org/132049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18785 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 18765 to try to repair perf regressionjar@chromium.org2009-06-1922-229/+97
| | | | | | | TBR=mpcomplete Review URL: http://codereview.chromium.org/131093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18784 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 18730 in attempt to repair Linux UI build bustage.jar@chromium.org2009-06-192-47/+9
| | | | | | | tbr=tc Review URL: http://codereview.chromium.org/132055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18782 0039d316-1c4b-4281-b951-d872f2087c98
* Review URL: http://codereview.chromium.org/132023ericu@google.com2009-06-192-35/+67
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18781 0039d316-1c4b-4281-b951-d872f2087c98
* Render the dragged tab contents when detaching a tab from the tabstrip in gtk.jhawkins@chromium.org2009-06-195-19/+174
| | | | | | | | BUG=none TEST=Drag a tab out of the tabstrip. If the WM has compositing enabled, the dragged tab contents should be translucent; otherwise, the contents should be opaque. Review URL: http://codereview.chromium.org/131042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18780 0039d316-1c4b-4281-b951-d872f2087c98
* linux: Load icons with gdk instead of using PNGDecoder.estade@chromium.org2009-06-192-30/+30
| | | | | | | | BUG=14487 Review URL: http://codereview.chromium.org/131058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18779 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up BrowserWindowGtk constructor.estade@chromium.org2009-06-192-93/+104
| | | | | | Review URL: http://codereview.chromium.org/131062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18778 0039d316-1c4b-4281-b951-d872f2087c98
* Linux crash fix.kuchhal@chromium.org2009-06-192-9/+29
| | | | | | | | | | | | If no browser profile is found from which we can import, disable the import button. This was not problem on Windows since we always had IE. BUG=14489 TEST=Rename your Firefox profile dir (~/.mozilla/firefox) and make sure that the import button is disabled on the import dialog box. Review URL: http://codereview.chromium.org/131075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18777 0039d316-1c4b-4281-b951-d872f2087c98
* Handle middle click on gtk tab close button.mattm@chromium.org2009-06-192-0/+19
| | | | | | | | | BUG=14636 TEST=middle click on tab close button, left click on tab close button Review URL: http://codereview.chromium.org/131072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18776 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash in LocationBarView when accessing TabContents.finnur@chromium.org2009-06-192-21/+20
| | | | | | | | | | | | | The LocationBarView asks its delegate (the ToolbarView) for a pointer to TabContents. The problem is, the ToolbarView is keeping an internal pointer to TabContents, and that pointer is not getting cleared when the last tab goes away. This can lead to shutdown crashes, which is what I think is happening in the crash in bug 14601. This is a speculative fix because we can't reproduce, but according to the dis-assembly we access a corrupt STL struct through a non-null TabContents pointer, which makes sense if the TabContents pointer is not getting cleared (or if the STL struct is being modified through multiple threads, which I have verified it is not). BUG=14601 TEST=Cannot reproduce, we'll have to watch the crash reports as they come in to see if the crash is fixed. Review URL: http://codereview.chromium.org/132043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18775 0039d316-1c4b-4281-b951-d872f2087c98
* Fix problem with how HttpResponseHeaders::Update() copies headers -- it ↵ericroman@google.com2009-06-192-2/+15
| | | | | | | | | | | assumed the value range ended in a '\0'. BUG=14220 TEST=HttpResponseHeadersTest.Update Review URL: http://codereview.chromium.org/132042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18774 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug where the window would not be shaped properly whentc@google.com2009-06-181-0/+1
| | | | | | | | | | | | | | dragging a new tab out. It would sometimes not be shaped properly when opening a new window. The code to update the window frame looks to see if the window is maximized. state_ contains information as to whether or not we're maximized, but it wasn't set yet resulting in a UMR. Review URL: http://codereview.chromium.org/131079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18773 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache: First pass to add support for sparse entries.rvargas@google.com2009-06-1814-14/+1603
| | | | | | | | | | | | | Adding Read/Write support. BUG=12258 TEST=unittests. original review: http://codereview.chromium.org/126179 Review URL: http://codereview.chromium.org/132031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18772 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/131064 for tedoc2000.sky@chromium.org2009-06-181-0/+4
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/132041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18771 0039d316-1c4b-4281-b951-d872f2087c98
* Mark LayoutTests/media/unsupported-rtsp.html as CRASHhclam@chromium.org2009-06-181-0/+2
| | | | | | | | | | This test is really flaky, it is not passing as readily as you run it locally. Some investigation is needed. TBR=scherkus Review URL: http://codereview.chromium.org/131078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18770 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline some media layout testshclam@chromium.org2009-06-1820-331/+375
| | | | | | | | | | | | | | | | | | | | The following tests need to be rebaselined due to the change in media controls UI: LayoutTests/media/audio-controls-rendering.html LayoutTests/media/video-aspect-ratio.html LayoutTests/media/video-controls.html LayoutTests/media/video-controls-rendering.html LayoutTests/media/video-display-toggle.html LayoutTests/media/video-layer-crash.html LayoutTests/media/video-play-pause-events.html LayoutTests/media/video-src-change.html LayoutTests/media/video-transformed.html LayoutTests/media/video-zoom-controls.html LayoutTests/media/video-zoom.html Review URL: http://codereview.chromium.org/126300 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18769 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor so checking for number error is done by ParseChunkSize() rather ↵ericroman@google.com2009-06-182-6/+12
| | | | | | | | than the caller of ParseChunkSize(). Review URL: http://codereview.chromium.org/132037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18768 0039d316-1c4b-4281-b951-d872f2087c98
* Fix tab strip paint regression for tabs other than the first tab.tc@google.com2009-06-181-1/+1
| | | | | | | | | | X is already offset when we call SetBounds, so we only need to handle y offset. Review URL: http://codereview.chromium.org/131073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18767 0039d316-1c4b-4281-b951-d872f2087c98
* First draft of web resource service; fetches data from a JSON feed mirandac@chromium.org2009-06-1824-6/+770
| | | | | | | | | | and stores it in user prefs, where it can be used by the new tab page. BUG = http://crbug.com/13363 Review URL: http://codereview.chromium.org/125052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18766 0039d316-1c4b-4281-b951-d872f2087c98
* Send port-closed notification when a frame with ports unloads.mpcomplete@google.com2009-06-1822-97/+229
| | | | | | | | | | | | | Also add onLoad and onUnload chrome Event to our bindings, so we can add listeners to these events without needing a DOM. These don't hook into the window "unload" event, so we no longer prevent Chrome's sudden termination of tabs on shutdown. BUG=12686 TEST=no Review URL: http://codereview.chromium.org/125280 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18765 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-03 11:21:11 +0000