summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Convert ElideFilename from using wstring to string16.tony@chromium.org2010-09-299-33/+35
| | | | | | | | | | Some small cleanups of wstring::npos usage. BUG=23581 Review URL: http://codereview.chromium.org/3390035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61003 0039d316-1c4b-4281-b951-d872f2087c98
* Disable the 'Sign in to Cloud Print' button while the authorization dialog ↵scottbyer@chromium.org2010-09-292-2/+25
| | | | | | | | | | | is up. BUG=none TEST=Start enabling cloud print proxy from advanced UI, button should dim. Review URL: http://codereview.chromium.org/3550001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61002 0039d316-1c4b-4281-b951-d872f2087c98
* Add all foo_messages_internal.h files in chrome/common to ↵jamesr@chromium.org2010-09-291-2/+6
| | | | | | | | | | | | | | | | | ipc/ipc_message_impl_macros.h ipc/ipc_message_impl_macros.h has a list of #includes that are #if 0'd out so that xcode can see the dependency from foo_messages.cc on foo_messages_internal.h since it can't understand our MESSAGES_INTERNAL_FILE system. This list was out of date and didn't include newly added files like gpu_messages_internal.h which caused http://src.chromium.org/viewvc/chrome?view=rev&revision=60902 to break the mac build BUG=7828 TEST=compiles Review URL: http://codereview.chromium.org/3564003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61001 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 60997 - o Add user customizable launch type for apps by adding ↵andybons@chromium.org2010-09-2917-307/+60
| | | | | | | | | | | | | | | | | | | | options in each apps context menu. o Updated some comments that were using the outdated NOTIFY_PREF_CHANGED notification. o Make LAUNCH_PINNED the default type returned by ExtensionPrefs if it does not already exist. o Some minor refactoring within the code to reduce duplication. BUG=54731 TEST=NONE patch from issue 3419010 Review URL: http://codereview.chromium.org/3453029 TBR=andybons@chromium.org Review URL: http://codereview.chromium.org/3517004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61000 0039d316-1c4b-4281-b951-d872f2087c98
* Render crash in FormManager::FindCachedFormElement()dhollowa@chromium.org2010-09-292-92/+71
| | | | | | | | | | | | | | | To address the vulnerability of stale WebFrame pointers in the FormManager's cache this CL changes the cache from a map (with the WebFrame pointer as "key") to a flat vector of simplified "FormElement*" items. To avoid leaking memory, we need to still observe |frameDetached|, and use that as a signal to reap any associated WebFormElements or WebFormControlElements. BUG=48857 TEST=FormMananagerTest.*, and manual test of regular form filling, form filling a form with sub-iframes, and form filling a form with sub-frames. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60949 Review URL: http://codereview.chromium.org/3492015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60999 0039d316-1c4b-4281-b951-d872f2087c98
* Implemented TextInputController::firstRectForCharacterRange in the test shell.tony@chromium.org2010-09-291-1/+25
| | | | | | | | | | | BUG=3273 TEST=NONE Patch written by rniwa@chromium.org Review URL: http://codereview.chromium.org/3553001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60998 0039d316-1c4b-4281-b951-d872f2087c98
* o Add user customizable launch type for apps by adding options in each apps ↵andybons@chromium.org2010-09-2917-60/+307
| | | | | | | | | | | | | | | | | context menu. o Updated some comments that were using the outdated NOTIFY_PREF_CHANGED notification. o Make LAUNCH_PINNED the default type returned by ExtensionPrefs if it does not already exist. o Some minor refactoring within the code to reduce duplication. BUG=54731 TEST=NONE patch from issue 3419010 Review URL: http://codereview.chromium.org/3453029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60997 0039d316-1c4b-4281-b951-d872f2087c98
* DOMUI options: NSS Certificate manager part 1 (read only)mattm@chromium.org2010-09-2918-21/+847
| | | | | | | | | BUG=19991 TEST=run with --enable-tabbed-options, click certificate manager button in options Review URL: http://codereview.chromium.org/3389001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60996 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Comment tweaks requested in http://codereview.chromium.org/3549004thakis@chromium.org2010-09-291-2/+4
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3576004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60995 0039d316-1c4b-4281-b951-d872f2087c98
* Added methods to create and read from file-backed metafiles to the Windows ↵sanjeevr@chromium.org2010-09-293-2/+62
| | | | | | | | | | | Emf class. BUG=None TEST=Unittests Review URL: http://codereview.chromium.org/3538003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60994 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 60979 - Change management API uninstall event to just pass the ↵asargent@chromium.org2010-09-296-35/+21
| | | | | | | | | | | | | | | | | | | extension id. This is to enable some work we're doing to change the uninstall event to be delivered after the unload event. BUG=54415 TEST=An extension using the management API should just get the extension id instead of the full ExtensionInfo data for the onUninstalled event. Review URL: http://codereview.chromium.org/3575003 TBR=asargent@chromium.org Review URL: http://codereview.chromium.org/3550002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60993 0039d316-1c4b-4281-b951-d872f2087c98
* Roll WebKit 68638:68653.senorblanco@chromium.org2010-09-291-1/+1
| | | | | | | | | | BUG=none TEST=none TBR=morrita Review URL: http://codereview.chromium.org/3520008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60992 0039d316-1c4b-4281-b951-d872f2087c98
* [clang] Fixed clang compile failure introduced by 60976.akalin@chromium.org2010-09-291-3/+4
| | | | | | | | | | | | Put GetVlogLevelHelper definition before GetVlogLevel definition. gcc/msvc is fine with this, but not clang (correctly). BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3525006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60991 0039d316-1c4b-4281-b951-d872f2087c98
* disable test for linuxerikkay@chromium.org2010-09-291-1/+2
| | | | | | | | | BUG=54332 TEST=ExtensionTest.IsPrivilegeIncrease Review URL: http://codereview.chromium.org/3590004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60990 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache: Change the way we delete files.rvargas@google.com2010-09-295-16/+75
| | | | | | | | | | | | | | | | | | | | | | | | | Now we always share delete and request delete access when we open the files, and don't close the handle before deleting a file. The result is that the delete operation should not be prevented by someone opening the file right after we close our handle. The downside is that anybody attempting to open one of our files while the browser is running will have to also share delete or their request will fail. On the other hand, we don't really want other people modifying the files at the same time, so the change may be for good. The caveat is that I think most of the failures are result of improper AV behavior, so we have to see what happens. BUG=16723 TEST=net_unittests Review URL: http://codereview.chromium.org/3475025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60989 0039d316-1c4b-4281-b951-d872f2087c98
* Use ScopedRunnableMethodFactory for SpdySession to better control lifetime.willchan@chromium.org2010-09-292-4/+15
| | | | | | | | | | | I'm trying to make sure all IO objects clean up appropriately when HttpNetworkSession goes away. SpdySession can cause problems since it pointlessly keeps itself alive for another MessageLoop loop even though all references may have gone away. This fixes that. BUG=none TEST=none Review URL: http://codereview.chromium.org/3547003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60988 0039d316-1c4b-4281-b951-d872f2087c98
* fix permserikkay@chromium.org2010-09-292-0/+0
| | | | | | | | | | TBR=sky BUG= TEST= Review URL: http://codereview.chromium.org/3539005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60987 0039d316-1c4b-4281-b951-d872f2087c98
* shared_memory: improve error messages on failure.evan@chromium.org2010-09-291-4/+11
| | | | | | | | | | | | | | | | | Be careful to leave errno untouched if the file open fails, so that the latter logging statements that print errno will print the right message. Also format the logging text such that the perror-like output (appending text like ": Permission denied") makes more sense. Previously we'd end up printing text like Try [...] to fix.: Permission denied BUG=57305 TEST=shared_memory_unittest should still pass Review URL: http://codereview.chromium.org/3517003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60986 0039d316-1c4b-4281-b951-d872f2087c98
* shared_memory: remove wstrings, fix callers.evan@chromium.org2010-09-2930-64/+62
| | | | | | | | | BUG=23581 TEST=compiles Review URL: http://codereview.chromium.org/3555002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60985 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Fix deadlock in the accelerated drawing code.thakis@chromium.org2010-09-291-15/+23
| | | | | | | | | | | Also stop the display link thread for background tabs even if --disable-hole-punching is active. BUG=55754 TEST=Go to a page that uses the compositor (e.g. http://webkit.org/blog/386/3d-transforms/), then keep resizing the browser window for ~10 minutes. The browser should stay functional. Review URL: http://codereview.chromium.org/3549004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60984 0039d316-1c4b-4281-b951-d872f2087c98
* Stop refcounting ClientSocketPool.willchan@chromium.org2010-09-2934-1068/+1667
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Establishes that HttpNetworkSession owns all the socket pools. Move out all the socket pools into a ClientSocketPoolManager. This is because of the dependency tree amongst socket pools, which dictates the order in which they must be constructed and destructed. In order to better establish it, I moved them out to their own class. HttpNetworkSession owns the ClientSocketPoolManager which owns the pools. We pass the pools as raw pointers everywhere. Note that ClientSocketPoolManager owns more pools than are publicly accessible via its interface. That's because some of them are wrapped by publicly exposed pools. Also, ClientSocketPoolHistograms used to be reference counted. That's because it can be shared by multiple ClientSocketPools. But it's effectively a global as well, so I make their lifetimes persist for the length of ClientSocketPoolManager too. I also removed internal refcounting in ClientSocketPoolBase. I had refcounted it before I knew about ScopedRunnableMethodFactory back when I first started. I cleaned up the unit tests a lot. Back when I was a young padawan, I didn't really know what I was doing, so I copy/pasted a metric asston of code. Turns out most of it was stupid, so I fixed it. I also stopped the use of implementation inheritance with ClientSocketPoolTest because it's discouraged by the style guide and more importantly because it caused the ClientSocketHandles within the TestSocketRequest vector to be destroyed _after_ the pools themselves were destroyed, which is bad since the handles will call pool_->Release() which blows up. BUG=56215,56215 TEST=Existing unit tests Review URL: http://codereview.chromium.org/3389020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60983 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 60981 - Resubmitting http://codereview.chromium.org/3397030 with the ↵ericu@google.com2010-09-299-327/+0
| | | | | | | | | | | | | | needed one-line deletion. Tested, reproed the breakage, verified the fix. BUG=none TEST=none TBR=ericu@google.com Review URL: http://codereview.chromium.org/3567006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60982 0039d316-1c4b-4281-b951-d872f2087c98
* Resubmitting http://codereview.chromium.org/3397030 with the needed one-line ↵ericu@google.com2010-09-299-0/+327
| | | | | | | | | | | deletion. Tested, reproed the breakage, verified the fix. BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60981 0039d316-1c4b-4281-b951-d872f2087c98
* Added UI for clearing Chrome Sync dataraz@chromium.org2010-09-2918-20/+1318
| | | | | | | | | | | | | | | | | | | | | | - Created 2 tabs, one for for clearing local browsing data, one for clearing server data - Refactored the old local browsing code to use a grid layout rather than less-wieldy math - Controls on all tabs block while, closing dialog is disabled, new throbber is going while clear is in progress - Clear server tab will be behind a flag until I deploy the server endpoint - Retained old clearing behavior: dialog closes on successful lear - Clear server UI only visible if user is syncing Outstanding issues: - Clearing currently causes an account to become unusable. The cause of the issue is a known problem with auth; currently investigating a fix - Unlike local clearing, clearing server data is more likely to error out. For now I just show a label next to the clear button that says Error, allowing the user to try again BUG=54349 TEST=Clear from UI, or run sync backend tests checked in for issue 54280 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60845 Review URL: http://codereview.chromium.org/3412032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60980 0039d316-1c4b-4281-b951-d872f2087c98
* Change management API uninstall event to just pass the extension id.asargent@chromium.org2010-09-296-21/+35
| | | | | | | | | | | | | | This is to enable some work we're doing to change the uninstall event to be delivered after the unload event. BUG=54415 TEST=An extension using the management API should just get the extension id instead of the full ExtensionInfo data for the onUninstalled event. Review URL: http://codereview.chromium.org/3575003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60979 0039d316-1c4b-4281-b951-d872f2087c98
* Submit of http://codereview.chromium.org/3471021 for grt@. Original description:robertshield@chromium.org2010-09-292-1/+11
| | | | | | | | | | | Fix "Save As" test by sending a single WM_CHAR to the text box. BUG=56294 TEST=chrome_frame_tests --gtest_filter=*CFSaveAs Review URL: http://codereview.chromium.org/3531004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60978 0039d316-1c4b-4281-b951-d872f2087c98
* fix host permission handling when sites add support for https for the same ↵erikkay@chromium.org2010-09-298-99/+158
| | | | | | | | | | | | | set of hosts. this shouldn't be treated as a privilege increase, but is. Also, centralize the logic for permission messages in preparation for splitting this out of Extension altogether. BUG=56794 TEST=ExtensionTest.IsPrivilegeIncrease Review URL: http://codereview.chromium.org/3501013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60977 0039d316-1c4b-4281-b951-d872f2087c98
* Implemented VLOG() et al.akalin@chromium.org2010-09-2914-24/+341
| | | | | | | | | | | | | | Implemented VLOG(), VLOG_IF(), VLOG_IS_ON(). Added --v and --vmodule switches. Changed some spammy sync-related logs to use VLOG. BUG=56965 TEST=New unittests Review URL: http://codereview.chromium.org/3448028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60976 0039d316-1c4b-4281-b951-d872f2087c98
* Bump up the version of Native Client used in Chrome.msneck@google.com2010-09-291-1/+1
| | | | | | | | | BUG=none TEST=all tests pass, especially nacl_ui_tests Review URL: http://codereview.chromium.org/3461034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60975 0039d316-1c4b-4281-b951-d872f2087c98
* Mark common instantions of CancelableRequestConsumerTSimple as extern templates.erg@google.com2010-09-292-92/+198
| | | | | | | | | | | | | | | This means that these template instantiations will be built once in cancelable_request.cc instead of in each of the 20 files that use it. The definitions have been moved to make them not inline (as explicit template instantiation only works with non-inline members). This cuts more than 4 megabytes off libbrowser.a in Debug mode. This patch does nothing when compiled with MSVC, due to compiler problems. BUG=none TEST=compiles smaller Review URL: http://codereview.chromium.org/3520001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60974 0039d316-1c4b-4281-b951-d872f2087c98
* DOMUI: Reset the theme buttons when the installed theme changes.jhawkins@chromium.org2010-09-293-17/+71
| | | | | | | | | BUG=54095 TEST=none Review URL: http://codereview.chromium.org/3571002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60973 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor RadioButton Image code for linux/gtkoshima@chromium.org2010-09-294-76/+124
| | | | | | | | | | | so that DOMUI menu can use the same image. BUG=none TEST=none Review URL: http://codereview.chromium.org/3435033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60972 0039d316-1c4b-4281-b951-d872f2087c98
* Use CHROME_HEADLESS to enable crash reporter in pyauto on linux/macnirnimesh@chromium.org2010-09-292-7/+2
| | | | | | | | | | | Enable the disabled pyauto test. BUG=57189 TEST=crash_reporter.py on official build Review URL: http://codereview.chromium.org/3530003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60971 0039d316-1c4b-4281-b951-d872f2087c98
* Refactored GetIamgeDataUrlFromResource from system notification code so that ↵oshima@chromium.org2010-09-293-11/+49
| | | | | | | | | | | | | it can be reused. Added GeImageDataUrl(SkBitmap& bitmap) that convert SkBitmap to data url. This will be used in DOMUI based menu. BUG=none TEST=none Review URL: http://codereview.chromium.org/3561001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60970 0039d316-1c4b-4281-b951-d872f2087c98
* Couple of match preview changes.sky@chromium.org2010-09-2921-28/+225
| | | | | | | | | | | | | | | | | | | . Commit the match preview on mouse up for instant results. This is needed as instant results may shift up during the commit. If we didn't do this it could mean the mouse up event appears over a different item then the mouse went down on. . Makes match preview revert if focus goes to the page and wasn't initiated by a mouse event. . Makes transition from about:crash to valid page not commit the match preview. . Changes setOmniboxDimensions to setDropdownDimensions. BUG=54833 56179 TEST=none Review URL: http://codereview.chromium.org/3531001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60969 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 60964 - This adds WebFileWriterImpl, which implements WebFileWriter ↵sky@chromium.org2010-09-299-328/+0
| | | | | | | | | | | | | | and AsyncFileWriterClient. BUG=none TEST=none Review URL: http://codereview.chromium.org/3397030 TBR=ericu@google.com Review URL: http://codereview.chromium.org/3590002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60966 0039d316-1c4b-4281-b951-d872f2087c98
* This adds WebFileWriterImpl, which implements WebFileWriter and ↵ericu@google.com2010-09-299-0/+328
| | | | | | | | | | | AsyncFileWriterClient. BUG=none TEST=none Review URL: http://codereview.chromium.org/3397030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60964 0039d316-1c4b-4281-b951-d872f2087c98
* Remove flakiness from url_info testsjar@chromium.org2010-09-293-40/+47
| | | | | | | | | | | | | | | | | | | This test was testing to be sure that timing was correctly monitored during the lifetime of these UrlHostInfo instances. The new code defensively checks values, and when tehy appear to be out of spec, it verifies that the test bot is indeed running slowly, and exits. This will usually run the test as expected, but gracefully exit when the bot is just too slow (or has too much variance in execution speed) to run the test carefully. r=phajdan.jr BUG=55169 Review URL: http://codereview.chromium.org/3431028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60962 0039d316-1c4b-4281-b951-d872f2087c98
* Add SetMinimumWidth to Menu2 for chromeos.oshima@chromium.org2010-09-2910-13/+23
| | | | | | | | | | | | | This is to remove gtk dependency from menu2 code in chromeos and to make DOMUI transition smooth (crosbug.com/6497) Removed LanguageSwitchModel::GetFirstLevelMenuWidth as this does not seem to be used by anyone. BUG=none TEST=none Review URL: http://codereview.chromium.org/3533001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60961 0039d316-1c4b-4281-b951-d872f2087c98
* VP8 decoder for chromotinghclam@chromium.org2010-09-298-5/+272
| | | | | | | | | | | Added DecoderVp8 and unit test for chromoting. TEST=remoting_unittests BUG=50235 Review URL: http://codereview.chromium.org/3032047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60960 0039d316-1c4b-4281-b951-d872f2087c98
* Resubmit - Some cleanup work in GpuVideoDecoderHost and IpcVideoDecoderhclam@chromium.org2010-09-2911-445/+299
| | | | | | | | | | | TBR=sergeyu BUG=None. TEST=None. Review URL: http://codereview.chromium.org/3571007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60959 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache: Handle failures growing the user_buffer thatrvargas@google.com2010-09-295-18/+103
| | | | | | | | | | | | | | | | | | | should result in data going to an external file. After PrepareBuffer() we must always have either a buffer that will receive the user data, or an initialized address that points to the correct block or external file to receive the data. This CL makes sure that when we end up without a buffer, the second condition is met. BUG=56872 TEST=net_unittests Review URL: http://codereview.chromium.org/3471016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60958 0039d316-1c4b-4281-b951-d872f2087c98
* ui_tests: disable timing out media tests on Windows.evan@chromium.org2010-09-291-8/+8
| | | | | | | | | | Together, these sit for two minutes and fail every run. BUG=55477,56364 Review URL: http://codereview.chromium.org/3586003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60957 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 539.0 to 540.0chrome-release@google.com2010-09-291-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60955 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 60949 - Render crash in FormManager::FindCachedFormElement()dhollowa@chromium.org2010-09-292-71/+92
| | | | | | | | | | | | | | | | To address the vulnerability of stale WebFrame pointers in the FormManager's cache this CL changes the cache from a map (with the WebFrame pointer as "key") to a flat vector of simplified "FormElement*" items. To avoid leaking memory, we need to still observe |frameDetached|, and use that as a signal to reap any associated WebFormElements or WebFormControlElements. BUG=48857 TEST=FormMananagerTest.*, and manual test of regular form filling, form filling a form with sub-iframes, and form filling a form with sub-frames. Review URL: http://codereview.chromium.org/3492015 TBR=dhollowa@chromium.org Review URL: http://codereview.chromium.org/3543003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60953 0039d316-1c4b-4281-b951-d872f2087c98
* Use a BubbleWindow to host native dialogs on ChromeOS.xiyuan@chromium.org2010-09-296-3/+272
| | | | | | | | | | | | | - Add a BubbleFrameView that uses BubbleBorder as its border; - Add a BubbleWindow that uses BubbleFrameView as its window frame; - Change NativeDialogHost to use BubbleWindow as its container; BUG=chromium-os:6305 TEST=Verify javascript dialog is inside a bubble frame per mock in chromium-os:6305. Review URL: http://codereview.chromium.org/3402037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60952 0039d316-1c4b-4281-b951-d872f2087c98
* Hooked up functionality for getting info for attribs and uniforms.alokp@chromium.org2010-09-294-9/+248
| | | | | | Review URL: http://codereview.chromium.org/3436030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60951 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor login process: introduce LoginPerformer.nkostylev@chromium.org2010-09-295-132/+298
| | | | | | | | | | | This is first step towards "offline first login". BUG=http://code.google.com/p/chromium-os/issues/detail?id=6638 TEST=Manual: login, login failures, Guest mode should work well. Review URL: http://codereview.chromium.org/3461033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60950 0039d316-1c4b-4281-b951-d872f2087c98
* Render crash in FormManager::FindCachedFormElement()dhollowa@chromium.org2010-09-292-92/+71
| | | | | | | | | | | | | To address the vulnerability of stale WebFrame pointers in the FormManager's cache this CL changes the cache from a map (with the WebFrame pointer as "key") to a flat vector of simplified "FormElement*" items. To avoid leaking memory, we need to still observe |frameDetached|, and use that as a signal to reap any associated WebFormElements or WebFormControlElements. BUG=48857 TEST=FormMananagerTest.*, and manual test of regular form filling, form filling a form with sub-iframes, and form filling a form with sub-frames. Review URL: http://codereview.chromium.org/3492015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60949 0039d316-1c4b-4281-b951-d872f2087c98
* Add /third_party/safe_browsing/testing to .gitignore.maruel@chromium.org2010-09-291-0/+1
| | | | | | | | | | | | NO CODE CHANGE. TBR=lzheng BUG=none TEST=none Review URL: http://codereview.chromium.org/3580002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60948 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-11 13:37:41 +0000