summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Changes the image used for the new tab button.sky@chromium.org2009-06-263-0/+9
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/146056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19339 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in RootViewGtk where we we might not paint correctly ifsky@chromium.org2009-06-261-1/+12
| | | | | | | | | | | | SchedulePaint is invoked consecutively with different regions. Windows has similar code. BUG=none TEST=none Review URL: http://codereview.chromium.org/147170 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19338 0039d316-1c4b-4281-b951-d872f2087c98
* The following 3 ui tests have been flaky on Linux.jshin@chromium.org2009-06-262-4/+12
| | | | | | | | | | | | | | | | | DownloadTest.DownloadMimeType DownlaodTest.ContentDisposition SavePageTest.FilenameFromPageTitle BUG=15416,15244 http://crbug.com/15416 http://crbug.com/15244 TEST=Linux UI test bots do not fail due to these tests TBR=estade Original review: http://codereview.chromium.org/147179 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19334 0039d316-1c4b-4281-b951-d872f2087c98
* More BIDI support:estade@chromium.org2009-06-263-6/+18
| | | | | | | | | | | | | - mirror nine boxes - mirror menu positioning - mirror download item show/hide logic http://crbug.com/15406 is relevant, although I'm not sure this 100% fixes it. TEST=use download shelf in Hebrew chrome. Things should be mirrored. Use it in English and nothing should be borked. Review URL: http://codereview.chromium.org/147176 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19333 0039d316-1c4b-4281-b951-d872f2087c98
* Fix proper MACOSX exlussion.rvargas@google.com2009-06-261-3/+3
| | | | | | | | | | TBR=rafaelw BUG=none TEST=none Review URL: http://codereview.chromium.org/149051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19332 0039d316-1c4b-4281-b951-d872f2087c98
* Revert cl 19315 to see if it fixes the builds.rvargas@google.com2009-06-2617-213/+2625
| | | | | | | | | TBR=klink BUG=none Review URL: http://codereview.chromium.org/149049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19331 0039d316-1c4b-4281-b951-d872f2087c98
* So many reverts, I double-reverted. This is the triple-revert.evan@chromium.org2009-06-261-4/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19330 0039d316-1c4b-4281-b951-d872f2087c98
* Revert all of my patches from today.evan@chromium.org2009-06-2618-180/+91
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19328 0039d316-1c4b-4281-b951-d872f2087c98
* mac: retry build fix.evan@chromium.org2009-06-262-5/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19327 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r19318. Seems we're blocking some UI thread though I thought we ↵thestig@chromium.org2009-06-261-1/+1
| | | | | | | | | | didn't here. BUG=15342 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19326 0039d316-1c4b-4281-b951-d872f2087c98
* LayoutTests/dom/html/level2/html/HTMLElement142.html is crashing.rvargas@google.com2009-06-261-0/+3
| | | | | | | | | BUG=15425 TEST=none Review URL: http://codereview.chromium.org/147186 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19325 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: fix font fallback for charactors missing from the primary font.agl@chromium.org2009-06-265-5/+67
| | | | | | | | | | | | | | | We are using the sandbox host for font fallback now via the WebKit API. However, a patch landed in WebKit which added an assertion about being on the correct thread. Since the sandbox host was using WebString::fromUTF8, we hit the assertion and died. So, we have to implement a WebKitClient for the sandbox host. We cannot just pass in NULL because there's an assertion that it's non-NULL. Also, we cannot pass in a bogus pointer because it actually ends up getting called back. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19324 0039d316-1c4b-4281-b951-d872f2087c98
* Logic in MediaResourceLoaderBridgeFactory was wronghclam@chromium.org2009-06-261-2/+2
| | | | | | | | | | | | | | The logic outputs an extra "Not implemented" message for a correct case, and this extra message causes some layout tests to fail.. BUG=13907 TBR=scherkus TEST=MediaResourceLoaderBridgeFactoryTest.* Review URL: http://codereview.chromium.org/147184 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19323 0039d316-1c4b-4281-b951-d872f2087c98
* mac: build fix.evan@chromium.org2009-06-261-3/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19322 0039d316-1c4b-4281-b951-d872f2087c98
* Rebase LayoutTests/http/tests/workers/worker-importScripts.html.jianli@chromium.org2009-06-262-0/+88
| | | | | | | | | | | This is needed to address the different v8 error message being thrown. BUG=none TEST=none Review URL: http://codereview.chromium.org/147127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19321 0039d316-1c4b-4281-b951-d872f2087c98
* linux plugins: eliminate GtkWidget* from plugin processevan@chromium.org2009-06-2617-87/+177
| | | | | | | | | | | | | | | | | | | | | | | | | | | GtkWidget* (and its wrapper, gfx::NativeView) only work within a single process. Plugins already work with a lower-level type that works across processes -- an X Window id. The parent of a plugin is an HWND on windows, but it's an X Window id on X. So we introduce a new typedef wrapping that and push it through all the places in the code that needs it. Since we no longer have a GtkSocket in the WebPluginDelegateImpl, we need to do a bit more work in the WebViewDelegate (aka the browser process in the multiproc world). We also need the plugin host (the browser) to track the GtkSockets that are hosting the plugin, as well as destroy them when necessary. To do this we require the plugin owner to grab the plug-removed signal rather than putting its handler in GtkPluginContainer; this is the way it worked before I'd refactored into GtkPluginContainer so it shouldn't be so bad. This change still only works in test_shell, but the refactoring should translate to the multiprocess case pretty easily. Review URL: http://codereview.chromium.org/146009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19320 0039d316-1c4b-4281-b951-d872f2087c98
* Add stubs to WebFrameLoaderClient for context create/destroy, so webkit botmpcomplete@chromium.org2009-06-261-0/+4
| | | | | | | | | | | | compiles. BUG=no TEST=chrome compiles Review URL: http://codereview.chromium.org/149040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19319 0039d316-1c4b-4281-b951-d872f2087c98
* Reap dead xdg-open processes so they don't turn into zombies.thestig@chromium.org2009-06-261-1/+1
| | | | | | | | BUG=15342 TEST=Click show in folder for a download, close the file manager that opens up, run ps and make sure the xdg-open process didn't turn into a zombie. Review URL: http://codereview.chromium.org/147167 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19318 0039d316-1c4b-4281-b951-d872f2087c98
* Make omnibox2 dropdown not flash during result set transitions...ben@chromium.org2009-06-264-61/+172
| | | | | | | | | | | | | - Animate smoothly between decreasing popup heights. Increasing popup heights are instantaneous. - Don't start a size adjustment until a few ms after the result set is updated to avoid jumping the height of the omnibox popup during typing as results from async providers stream in. - The result row carries a copy of the match data so it always has something to paint even if the match that corresponded to those results is now gone. These rows aren't actually actionable by the user and only appear during the animation. The result views are retained even if they are not visible (clipped). BUG=none TEST=type slowly in the omnibox, note the height of the popup doesn't jump between characters. Review URL: http://codereview.chromium.org/149030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19317 0039d316-1c4b-4281-b951-d872f2087c98
* Disable ExtensionsService.ExternalInstallPref unittest on mac.rafaelw@chromium.org2009-06-261-0/+6
| | | | | | | | | | Broke with: http://codereview.chromium.org/140018. R=rvargas Review URL: http://codereview.chromium.org/147183 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19316 0039d316-1c4b-4281-b951-d872f2087c98
* Removes the outdated and flaky UI tests, and introduces a whole new set of ↵klink@chromium.org2009-06-2617-2625/+213
| | | | | | | | shiny unit tests instead.BUG=2242,2243 Review URL: http://codereview.chromium.org/146124 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19315 0039d316-1c4b-4281-b951-d872f2087c98
* make the color profile manage work with multiple test shellsthomasvl@chromium.org2009-06-256-99/+148
| | | | | | | | | | | | | | | make the helper exit on signals make the helper exit on any input on stdin make the helper change the profile on launch, and restore on exit. remove the color profile mgmt code from test shell remove the signal handlers from test shell update the script that runs the tests to start the helper before any test shells and stop it when done. make the helper a dep of test_shell so it's built. BUG=11173 TEST=run the layout tests with pixel diffs, the color profile should still be changed. Review URL: http://codereview.chromium.org/149036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19314 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused num_rows argument to OptionsLayoutBuilderGtkmattm@chromium.org2009-06-254-4/+4
| | | | | | | | BUG=none Review URL: http://codereview.chromium.org/149037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19312 0039d316-1c4b-4281-b951-d872f2087c98
* render view: Clear the text selection cache when we get an empty selection.estade@chromium.org2009-06-251-0/+2
| | | | | | | | | BUG=15126 TEST=see bug Review URL: http://codereview.chromium.org/147175 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19311 0039d316-1c4b-4281-b951-d872f2087c98
* Fix another bookmark manager crasher.estade@chromium.org2009-06-252-4/+35
| | | | | | | | | | | Also, don't allow drags to originate from parts of the table view that don't have rows. BUG=http://crbug.com/15388 TEST=try to drag from the white space below the lowest row of the bookmark manager right pane onto the bookmark bar (nothing should happen) Review URL: http://codereview.chromium.org/149024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19310 0039d316-1c4b-4281-b951-d872f2087c98
* Add a function to ResourceBundle to allow loading images that will mirror in ↵estade@chromium.org2009-06-256-72/+63
| | | | | | | | | | RTL. Use this function for custom buttons and for the Off the Record avatar. for reference, this will be a bit different than Views, which does it per class rather than per image: http://dev.chromium.org/developers/design-documents/ui-mirroring-infrastructure Review URL: http://codereview.chromium.org/147157 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19309 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Implementation for memory only sparse caching" r19270.scherkus@chromium.org2009-06-255-438/+73
| | | | | | | | | | | TBR=rvargas TEST=none BUG=none Review URL: http://codereview.chromium.org/149041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19308 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash in net::SSLClientSocketWin::OnIOComplete(int) whenwtc@chromium.org2009-06-256-14/+34
| | | | | | | | | | | | | | | | | | | | | an HttpNetworkTransaction is destroyed while its SSLClientSocket is verifying a certificate. Document that ClientSocket::Disconnect aborts any pending IO and prevents completion callback from running, like a cancel method. Change the verifier_ member of SSLClientSocket to a scoped_ptr so that we can destroy the CertVerifier object in the Disconnect method. (CertVerifier doesn't have a cancel method, so we cancel pending certificate verification by destroying the CertVerifier object.) R=willchan BUG=http://crbug.com/13981 TEST=none. I can only reproduce this crash by modifying the source code to create that condition. Review URL: http://codereview.chromium.org/147159 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19307 0039d316-1c4b-4281-b951-d872f2087c98
* Hooks backend tip service into new tab page. Also changes tip service to ↵mirandac@chromium.org2009-06-2513-175/+162
| | | | | | | | | | | load tips from popgadget, at http://www.google.com/labs/popgadget/world. BUG= http://crbug.com/14962 TEST= Enable new tab page. See welcome message. On reload afterwards (and always after that, as long as preferences file isn't removed), see browsing recommendations appear in bottom right corner. Review URL: http://codereview.chromium.org/147109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19306 0039d316-1c4b-4281-b951-d872f2087c98
* When falling out of a nested loop, if higher-priority work is done, be sure tomark@chromium.org2009-06-251-0/+10
| | | | | | | | | | still arrange to run lower-priority work on a subsequent pass. BUG=13468 TEST=http://crbug.com/13468#c5 Review URL: http://codereview.chromium.org/149029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19305 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: paste on middle-click up.agl@chromium.org2009-06-251-15/+28
| | | | | | | | | | | | | | | | | | | There is some debate about when pasting should actually happen xterm: pastes on up. GTK: pastes on down. Firefox: pastes on up. Midori: couldn't paste at all with 0.1.2 There is something of a webcompat angle to this well, as highlighted by crbug.com/14608. Pages can clear text boxes 'onclick' and, if we paste on down then the text is pasted just before the onclick handler runs and clears the text box. http://codereview.chromium.org/149020 BUG=14608 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19304 0039d316-1c4b-4281-b951-d872f2087c98
* Two tab dragging fixes for various window managers:jhawkins@chromium.org2009-06-253-16/+58
| | | | | | | | | | | * Reverse the order of enumeration when enumerating all top-level windows. XQueryTree returns the list of windows in bottom-to-top order, while DockInfo expects the windows in top-to-bottom order (ratpoison WM, Awesome WM). * Extend the enumeration one level deeper for window managers that parent top-level windows into an unnamed real top-level window (ion WM). BUG=14004 TEST=Extensive tab dragging in the following WMs: Metacity, Compiz, kwm, ion3, xmonad, ratpoison, awesome. Review URL: http://codereview.chromium.org/149028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19303 0039d316-1c4b-4281-b951-d872f2087c98
* Move extension delimiters to the right.cira@chromium.org2009-06-251-0/+1
| | | | | | | | | BUG=http://crbug.com/11880 TEST=Load Chrome with --lang=he, and add 1+ extension. Delimiters should be on the right. Review URL: http://codereview.chromium.org/147132 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19302 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: add Alt-n keys for switching tabs.agl@chromium.org2009-06-251-0/+12
| | | | | | | | | | | The UI decision was to have both Alt-n and Ctrl-n switch tabs. Ctrl-n to match Windows Chrome and Alt-n to match Firefox on Linux. Pages which try to grab either sets of keys will succeed. BUG=13395 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19301 0039d316-1c4b-4281-b951-d872f2087c98
* New user experience for the fullscreen message on Mac.maf@google.com2009-06-254-62/+153
| | | | | | | It's now a translucent window that slides down into the top right of the screen, hangs around for a while and then slides up up and away. Review URL: http://codereview.chromium.org/147135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19300 0039d316-1c4b-4281-b951-d872f2087c98
* Build fix: test_expectations.txt had a duplicate line (from r19297).agl@chromium.org2009-06-251-2/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19299 0039d316-1c4b-4281-b951-d872f2087c98
* Build fix: roll DEPS to pickup WebKit's r45203agl@chromium.org2009-06-251-1/+1
| | | | | | | | | | | | | | | | | 2009-06-25 Adam Langley <agl@google.com> TBRed: fix for Chromium tree. Add missing include for r45199. https://bugs.webkit.org/show_bug.cgi?id=26736 r45199 added a reference to throwError without including V8Proxy.h * bindings/v8/WorkerScriptController.cpp: git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19298 0039d316-1c4b-4281-b951-d872f2087c98
* Marks some <video> layout tests as flakyhclam@chromium.org2009-06-251-2/+7
| | | | | | | | BUG=13907 TBR=rvargas, scherkus Review URL: http://codereview.chromium.org/149031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19297 0039d316-1c4b-4281-b951-d872f2087c98
* Add bogus expected result to work around "Missing expected results" error ↵jianli@chromium.org2009-06-254-0/+2
| | | | | | | | for clipboard-file-access.html even we mark it as failed. Review URL: http://codereview.chromium.org/149025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19296 0039d316-1c4b-4281-b951-d872f2087c98
* Build fix: roll DEPS to pickup WebKit's 45201agl@chromium.org2009-06-251-1/+1
| | | | | | | | | | | | | | | | | | | 2009-06-25 Adam Langley <agl@google.com> TBRed: fix for Chromium tree. https://bugs.webkit.org/show_bug.cgi?id=26735 Fix V8IsolatedWorld to point to the correct include file. The deprecated v8_index.h was removed from the Chromium tree in r19291 and upstreamed into WebKit with r45193. However V8IsolatedWorld slipped in between the cracks and broke the build. * bindings/v8/V8IsolatedWorld.h: update with new header location. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19295 0039d316-1c4b-4281-b951-d872f2087c98
* two more unit_test fixes for: http://codereview.chromium.org/140018rafaelw@chromium.org2009-06-252-2/+5
| | | | | | | | R=rvargas Review URL: http://codereview.chromium.org/147171 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19294 0039d316-1c4b-4281-b951-d872f2087c98
* Use upstreamed V8Indexjaphet@chromium.org2009-06-257-925/+6
| | | | | | | | | | BUG=14466 TEST=none Review URL: http://codereview.chromium.org/126296 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19291 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: add baselines for clipboard-file-accessagl@chromium.org2009-06-253-0/+9
| | | | | | | BUG=15403 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19290 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 19271.ericroman@google.com2009-06-252-12/+9
| | | | | | | Revert 19271, since it caused crash in reliability test. (dns prefetcher may still cancel requests on the host resolver during shutdown). Review URL: http://codereview.chromium.org/149026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19289 0039d316-1c4b-4281-b951-d872f2087c98
* Fix unit_test breakage from http://codereview.chromium.org/140018rafaelw@chromium.org2009-06-251-0/+3
| | | | | | | | R=sky Review URL: http://codereview.chromium.org/147169 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19288 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: plumb fontconfig call out to the sandbox host.agl@chromium.org2009-06-2513-4/+382
| | | | | | | | | | | | | | | | | | | | | | | This is hopefully the last step before our renderers can run cleanly in a chroot. WebKit needs to be able to ask for the correct font to use in the case that the current font doesn't include glyphs for certain code points. Currently we make a fontconfig call in our WebKit port to handle this. This patch changes this so that the call is sent our via ChromiumBridge. Since we are at ChromiumBridge, we could make a sync IPC to the browser. However, fontconfig is a single threaded library and we are already using it on the UI thread in the browser, so the sync IPC would have to terminate on the UI thread. Even if this doesn't deadlock, it causes huge spikes in latency. So, instead, we send the IPC to the sandbox host process which is already setup to handle fontconfig requests from Skia. See: http://code.google.com/p/chromium/wiki/LinuxSandboxIPC git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19287 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit merge 45134:45176jianli@chromium.org2009-06-252-1/+5
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/148005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19286 0039d316-1c4b-4281-b951-d872f2087c98
* Refactored ExtensionsPrefs to store paths relative to the extensions install ↵rafaelw@chromium.org2009-06-2533-91/+333
| | | | | | | | | | | directory. Fix & reenabled two extensions_service unit_tests. R=erikkay BUG=14714 Review URL: http://codereview.chromium.org/140018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19285 0039d316-1c4b-4281-b951-d872f2087c98
* Add some checks to make sure header_buf_body_offset_ is never used when ↵ericroman@google.com2009-06-252-6/+10
| | | | | | | | | negative. BUG=b/1483703 Review URL: http://codereview.chromium.org/132051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19284 0039d316-1c4b-4281-b951-d872f2087c98
* Add a gyp "buildtype" variable to differentiate official release builds.mmoss@chromium.org2009-06-252-1/+14
| | | | | | | | | | | | | | | | This notion was previously overloaded on "branding", but as implied, that variable should really just control the "Google Chrome" vs. "Chromium" branding. We need a separate setting to distinguish between "release" builds (which get special handling, like breakpad symbol processing), and "everyday" builds, like the buildbot continuous builds or personal developer builds. This fixes a problem where the "Google Chrome" continuous builder was unnecessarily trying to upload breakpad symbols for every single build. Review URL: http://codereview.chromium.org/132038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19283 0039d316-1c4b-4281-b951-d872f2087c98