summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Add back 'WS_VSCROLL' flag when creating a combobox window. Without it, the ↵jshin@chromium.org2009-06-111-1/+5
| | | | | | | | | | | | | | | | dropdown list of a combobox longer than the 'default'(?) size gets truncated instead of getting a scrollbar. BUG=13438 (http://crbug.com/13438) TEST=In Options | Under the hood, click 'Fonts & languages' button. The default encoding menu should have a scrollbar. In languages tab, Chrome UI language list contains 49 languages instead of 20(?) or so languages. In a shorter dropdown list (e.g. spellcheck language dropdown), there should be no scrollbar. Review URL: http://codereview.chromium.org/120005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18121 0039d316-1c4b-4281-b951-d872f2087c98
* Add helper for creating table of labeled controls.mattm@chromium.org2009-06-114-44/+49
| | | | | | | | BUG=none Review URL: http://codereview.chromium.org/118489 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18120 0039d316-1c4b-4281-b951-d872f2087c98
* Save as dialog should show html filesmhm@chromium.org2009-06-111-0/+2
| | | | | | | | | | | | Currently "htm" files are hardcoded, that is the reason why its only seen. Adding "html" to the vector extension would fix this issue. BUG=13429 (http://crbug.com/13429) TEST=Can now see html in the save file dialog. Review URL: http://codereview.chromium.org/119409 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18119 0039d316-1c4b-4281-b951-d872f2087c98
* Fix HWND for Importer Dialogmhm@chromium.org2009-06-111-4/+2
| | | | | | | | | | | | Instead of grabbing the HWND from the browser, we can grab it from the current view since each view has a Widget who is associated with a HWND (NativeView). By doing that, we can assure the parent hwnd is that. Before, it was retrieving the hwnd from Browser* which caused this bug. BUG=13154 (http://crbug.com/13154) TEST=Launched Options>Importer>Import and it brought up the Options dialog. Review URL: http://codereview.chromium.org/119408 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18118 0039d316-1c4b-4281-b951-d872f2087c98
* Hide URL from extension pages.mhm@chromium.org2009-06-111-0/+5
| | | | | | | | | | | We can't do the same as we do for NTP because NTP is a DOMUI whereas chrome-extensions is just a normal webpage. Adding functionality within TabContents::ShouldDisplayURL() would be sufficient to tell the ombibox not to display the URL. BUG=12371 (http://crbug.com/12371) TEST=Tested chrome-extension://id/hello_world.html Review URL: http://codereview.chromium.org/119406 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18117 0039d316-1c4b-4281-b951-d872f2087c98
* Disable extensions in incognito mode.mpcomplete@google.com2009-06-1111-27/+91
| | | | | | | | | | | Add a browsertest to make sure we don't crash with an incognito window open. Had to finagle utility_process_host to make it work in a browsertest. BUG=12326 TEST=none Review URL: http://codereview.chromium.org/118476 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18116 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache: Avoid recursion when trimming entries.rvargas@google.com2009-06-103-3/+9
| | | | | | | | | | | | | | TrimCacheV2() calls EvictEntry() to move a given entry to the "deleted" list. EvictEntry() deletes the actual data, and that may end up calling ModifyStorageSize() and TrimCacheV2() again. BUG=b/1909376 TEST=none Review URL: http://codereview.chromium.org/121002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18115 0039d316-1c4b-4281-b951-d872f2087c98
* Replace a notimplemented with a link to the bug report.jhawkins@chromium.org2009-06-101-1/+1
| | | | | | | TBR=tony Review URL: http://codereview.chromium.org/122001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18114 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Implement BlockedPopupContainerView for linux.erg@google.com2009-06-1013-29/+390
| | | | | | | | | | | | | | | | This doesn't have: - rounded corners - gradient background - animating in or out. - graphical polish but it is fucntionally complete. http://crbug.com/12843 Review URL: http://codereview.chromium.org/118480 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18113 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 18109, 18111: Windows UI tests failed.agl@chromium.org2009-06-1038-740/+1219
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18112 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: build fix; false-positive GCC warning.agl@chromium.org2009-06-101-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18111 0039d316-1c4b-4281-b951-d872f2087c98
* Restricts the creation of RadioButton to specify an group-id.jcampan@chromium.org2009-06-102-8/+6
| | | | | | | | | | The API is dangerous without one, has it will probably collide with other non radio-button views. BUG=None TEST=None Review URL: http://codereview.chromium.org/120002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18110 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: refactor zygote supportagl@chromium.org2009-06-1038-1219/+740
| | | | | | | | | | | | | | | | | | http://code.google.com/p/chromium/wiki/LinuxZygote * Move Chrome specific bits out of base * Move away from the idea of reserved file descriptors (which don't really work with zygotes) * Load resources before forking renderers (means that we don't need communication between the zygote process and the renderers) * Make sure that gdb works against the browser again * Make sure that we have different ASLR between the renderers and the browser. http://codereview.chromium.org/119335 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18109 0039d316-1c4b-4281-b951-d872f2087c98
* Add chrome/browser to chrome/renderer deps temporarily. I will movetc@google.com2009-06-101-0/+1
| | | | | | | | | | | the header to chrome/common in a follow up change. TBR=beng Review URL: http://codereview.chromium.org/120007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18108 0039d316-1c4b-4281-b951-d872f2087c98
* First cut at tall titlebar and custom window frame.tc@google.com2009-06-104-28/+196
| | | | | | | | | | | | | | | | | | | This implements the tall titlebar with the XP frame buttons, which should work if your window manager supports them. The titlebar background is drawn by the containing hbox. It would be nice if the tab strip could be made transparent so it wouldn't need to paint a background itself, but I didn't know how to do that. I still need to implement the frame resizing, frame coloring and move the context menu from the tab strip to the titlebar. BUG=13430 Review URL: http://codereview.chromium.org/119371 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18107 0039d316-1c4b-4281-b951-d872f2087c98
* Fix memory leak in unit_testsbrettw@google.com2009-06-101-14/+9
| | | | | | | | BUG=13733 Original review: http://codereview.chromium.org/119444 Patch by Meelap Shah git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18106 0039d316-1c4b-4281-b951-d872f2087c98
* Roll to the new version of tcmalloc.mbelshe@google.com2009-06-102-2/+2
| | | | | | | | | | | This is so that we can pick up set_new_mode(). BUG=11475 TEST=none Review URL: http://codereview.chromium.org/118523 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18105 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the View cut/copy/paste tests for clipboard. The views delegate wasn't ↵ben@chromium.org2009-06-101-1/+42
| | | | | | | | | | attached so the textfield couldn't access the clipboard to write to it on copy. Create a mock views delegate for this test so that the textfield can get a clipboard. BUG=none TEST=duh. Review URL: http://codereview.chromium.org/118487 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18104 0039d316-1c4b-4281-b951-d872f2087c98
* Add an exact-match Keychain search, with unit tests; groundwork for a more ↵stuartmorgan@chromium.org2009-06-103-38/+315
| | | | | | | | | | complete Keychain implementation. BUG=none TEST=none Review URL: http://codereview.chromium.org/119377 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18103 0039d316-1c4b-4281-b951-d872f2087c98
* Show the remaining time in the downloads page.arv@google.com2009-06-101-2/+2
| | | | | | | | | | BUG=13386 TEST=Download a large file and make sure that you see the speed in the donwloads page. Review URL: http://codereview.chromium.org/119428 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18102 0039d316-1c4b-4281-b951-d872f2087c98
* Fix UMR in ExtensionCreator.aa@chromium.org2009-06-101-2/+3
| | | | | | Review URL: http://codereview.chromium.org/119443 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18101 0039d316-1c4b-4281-b951-d872f2087c98
* Do not allow URL drops on app windows to cause a navigation awaytc@google.com2009-06-1018-9/+132
| | | | | | | | | | | | | | | | | | | | | | | | | | from the currently loaded site. We are careful in this patch to continue to allow dropping URLs in text fields within the app window, and behavior for normal browser windows remains as before. There is a slight glitch when dragging a to an app window on the border of the window. Even though it is very brief, it is still disturbing. BUG=7171 TEST=Open Chrome (1), load google.com. Open Chrome (2), load yahoo.com. Drag a link from 1 to 2 and a link from 2 to 1 (both allowed). Create an app shortcut from 1, drag a link from 1 to 2 (allowed) and a link from 2 to 1 (denied). Verify that link scan be dragged to the omnibox and to text fields. Patch by Chase Phillips <chase@chromium.org> via http://codereview.chromium.org/119298 Review URL: http://codereview.chromium.org/121003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18100 0039d316-1c4b-4281-b951-d872f2087c98
* Stop auto-correcting abbreviations.BUG= www.crbug.com/12921TEST= For command ↵sidchat@google.com2009-06-104-11/+22
| | | | | | | | line --auto-spell-correct, "IMB" should not change to "IBM" Review URL: http://codereview.chromium.org/119210 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18099 0039d316-1c4b-4281-b951-d872f2087c98
* Use the convenience function gdk_screen_get_window_stack to enumerate ↵jhawkins@chromium.org2009-06-105-42/+49
| | | | | | | | | | top-level gdk windows instead of querying Xlib directly, which doesn't work across many window managers. BUG=none TEST=Exhaustive tab dragging in multiple window managers (Compiz, Metacity, KWM). Review URL: http://codereview.chromium.org/119345 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18098 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed some issues in the V8 bridge. It wasn't using HandleScopes correctly. ↵apatrick@google.com2009-06-104-37/+36
| | | | | | | | There seems to be an issue resizing V8 arrays. Whenever the bridge resized a V8 array, V8 would later crash. I changed the bridge to avoid resizing V8 arrays. Review URL: http://codereview.chromium.org/118531 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18097 0039d316-1c4b-4281-b951-d872f2087c98
* Fix tree bustagecpu@google.com2009-06-101-1/+0
| | | | | | | | | | | TEST=none BUG=none TBR=nsylvain Review URL: http://codereview.chromium.org/120003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18096 0039d316-1c4b-4281-b951-d872f2087c98
* Fix uninitialized ExtensionView::pending_preferred_width_.mpcomplete@google.com2009-06-101-1/+1
| | | | | | | BUG=13103 Review URL: http://codereview.chromium.org/119389 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18095 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Fix Firefox profile path for import.kuchhal@chromium.org2009-06-101-0/+2
| | | | | | | | BUG=13270 Review URL: http://codereview.chromium.org/118526 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18094 0039d316-1c4b-4281-b951-d872f2087c98
* UI part of the try chrome toastcpu@google.com2009-06-103-1/+281
| | | | | | | | | | | | | - experimental. 'en' only - modal dialog is farily custom BUG=none TEST=none Review URL: http://codereview.chromium.org/118510 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18093 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 18090jrg@chromium.org2009-06-1012-377/+122
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18092 0039d316-1c4b-4281-b951-d872f2087c98
* Ignore for now to get tree green jrg@chromium.org2009-06-101-0/+3
| | | | | | | | bug filed; crbug.com/13786 Review URL: http://codereview.chromium.org/119446 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18091 0039d316-1c4b-4281-b951-d872f2087c98
* To help resolve the performance issue introduced when enabling the resize ↵mad@google.com2009-06-1013-122/+389
| | | | | | | | corner, we now keep all non-intersecting rects separately and send an array of invalidation bitmaps via IPC as opposed to a single unionized rect :-) Review URL: http://codereview.chromium.org/108040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18090 0039d316-1c4b-4281-b951-d872f2087c98
* Refactors tab overview and gets the rest of the chunks working. I'vesky@chromium.org2009-06-1014-314/+926
| | | | | | | | | | | | | | | | refactored it so that there is a clear object responsible for dragging and the controller now controls it all. There is some common code between TabOverviewDragController and DraggedTabController. I will try and share some code between these two later. BUG=none TEST=none Review URL: http://codereview.chromium.org/118513 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18089 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the prepended manifest from the crx format. Now we just have the ↵aa@chromium.org2009-06-107-130/+111
| | | | | | | | header, the public key, the signature, and the zip. Review URL: http://codereview.chromium.org/118490 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18088 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash in linux if the renderer process dies too fast. On mac, wetc@google.com2009-06-108-35/+27
| | | | | | | | | | | | | | | | | | | | | | just don't get the sad tab page. If the renderer dies before it sends a ViewHostMsg_RenderViewReady message, we never get the TAB_CONTENTS_CONNECTED, which in turn means that TAB_CONTENTS_DISCONNECTED doesn't fire. If TAB_CONTENTS_DISCONNECTED doesn't fire, we never initialize sad_tab_ in tab_contents_view_gtk.cc and crash the browser process. I found this crash on the crash server: http://crash/reportdetail? reportid=fb3a7bc60c67eb1e&product=Chrome_Linux&version=3.0.183.1&date=&signa ture=TabContentsViewGtk::Invalidate()-534CC7 BUG=13715 Review URL: http://codereview.chromium.org/119395 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18087 0039d316-1c4b-4281-b951-d872f2087c98
* Null check render_view_host when processing unload events.ojan@chromium.org2009-06-101-2/+14
| | | | | | | | | | | | | I haven't been able to reproduce the crash, but I'm pretty sure this is the problem. I think this involves closing the browser while we're in the middle of a cross-process or interstitial page tab transition. TEST=none BUG=http://crbug.com/11493 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18086 0039d316-1c4b-4281-b951-d872f2087c98
* Bind ^Q to quit, as is standard with Linux GUI apps.tc@google.com2009-06-102-1/+2
| | | | | | | | | | | | | BUG=none TEST=Press ctrl+q and chrome should quit Patch by Jacob Mandelson <jacob@mandelson.org> via http://codereview.chromium.org/119393 Review URL: http://codereview.chromium.org/118522 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18085 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash in menu. It's possible for the WM_MENUSELECT to pass insky@chromium.org2009-06-101-0/+3
| | | | | | | | | | | | NULL as the menu on XP. I believe this only happens when closing the menu, so that it doesn't really matter what we do here. BUG=13759 TEST=see bug Review URL: http://codereview.chromium.org/119441 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18084 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate leaks (valgrind)jrg@chromium.org2009-06-101-1/+1
| | | | | | | TBR=nirnimesh git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18083 0039d316-1c4b-4281-b951-d872f2087c98
* Reconstructing thomaslewis' change 118477.bradnelson@google.com2009-06-102-2/+3
| | | | | | | | | | | I'm submitting this now to get more things working on the continuous build. BUG=None TEST=None TBR=thomaslewis git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18080 0039d316-1c4b-4281-b951-d872f2087c98
* Update webkit to r44571darin@chromium.org2009-06-103-11/+22
| | | | | | | | | | BUG=none TEST=none R=pkasting Review URL: http://codereview.chromium.org/119430 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18073 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION build from 188.0 to 189.0laforge@chromium.org2009-06-101-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18072 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bugs where O3D would output lots of spurious log messages in thetschmelcher@google.com2009-06-101-4/+32
| | | | | | | | case of blocking errors or EOFs on NACL handles. Review URL: http://codereview.chromium.org/118258 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18070 0039d316-1c4b-4281-b951-d872f2087c98
* Gets linux2 to compile again.sky@chromium.org2009-06-102-1/+3
| | | | | | | | | | BUG=none TEST=none TBR=ben@chromium.org Review URL: http://codereview.chromium.org/118515 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18069 0039d316-1c4b-4281-b951-d872f2087c98
* POSIX: read subprocess output before waiting for termination.agl@chromium.org2009-06-101-8/+7
| | | | | | | | | | | | | Previously, GetAppOutput was designed only for fuser. However, it appears that Mac is using it to read the output of ps: which outputs rather more. In this case, ps can fill up the pipe buffer while we are waiting for it to exit, leading to deadlock depending on how many other process are running on the system at the time. http://codereview.chromium.org/118514 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18068 0039d316-1c4b-4281-b951-d872f2087c98
* Dummy change to fix "svn: Inconsistent line ending style"maruel@chromium.org2009-06-101-13/+13
| | | | | | | | TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18067 0039d316-1c4b-4281-b951-d872f2087c98
* Converts a private variable to use scoped_nsobject.rohitrao@chromium.org2009-06-102-3/+4
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/118506 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18066 0039d316-1c4b-4281-b951-d872f2087c98
* Fix svn: Inconsistent line ending stylemaruel@chromium.org2009-06-101-0/+1
| | | | | | | | TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18065 0039d316-1c4b-4281-b951-d872f2087c98
* Try2 at disabling the thumbnail store unit tests. The previous try didn'tbrettw@chromium.org2009-06-101-2/+6
| | | | | | | | work because the friend declarations depended on the exact name of the tests, which I changed when I marked them disabled. Review URL: http://codereview.chromium.org/119426 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18064 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily disable the thumbnail store unittests due to leaks.brettw@chromium.org2009-06-101-2/+2
| | | | | | | BUG=13733 Review URL: http://codereview.chromium.org/118507 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18063 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-12 15:31:53 +0000