| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
TBR=erg@chromium.org
BUG=133171
TEST=linux valgrind TSAN bot cycles green (hopefully)
Review URL: https://chromiumcodereview.appspot.com/10532182
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142605 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=simonmorris@chromium.org
BUG=133167
TEST=linux/mac valgrind bots cycle green
Review URL: https://chromiumcodereview.appspot.com/10554020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142603 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
correct scale in css files
BUG=129203
TEST=Build
Review URL: https://chromiumcodereview.appspot.com/10544148
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142602 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
child. Wires it up for the situation of a child view with a layer
being stacked on top of a child control's window.
BUG=none
TEST=covered by unit test
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10554015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142601 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove "Learn more" link and add "Undo" button.
Also use correct bubble text resource on Linux.
TBR=akalin@chromium.org
BUG=125253
TEST=
Review URL: https://chromiumcodereview.appspot.com/10560025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142600 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, mnemonics are activated even with modifiers. For example, pressing "Alt + F" activates mnemonic 'f'. With this patch, pressing "Alt + F" doesn't activate mnemonic and is not handled by menu (and will be propagated).
With this patch, Chrome behave as following.
1) Press Alt + F and release all keys. And press Alt + F again
=> Wrench menu opens, and closes.
2) Press Alt + F and release only F key keeping Alt. And press F key keeping Alt.
=> Wrench menu opens, and closes.
3) Press Alt + F and release all keys. And press only F key.
=> Wrench menu opens, and closes the menu and Search box opens.
BUG=131264
TEST=Press Alt + F twice, and confirm that search box doesn't open.
Review URL: https://chromiumcodereview.appspot.com/10543133
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142599 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=131027
TEST=Open a menu, lock the screen. The menu is closed when the lock window triggers an activation change notification.
Review URL: https://chromiumcodereview.appspot.com/10532166
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142598 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142597 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=atwilson@chromium.org
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10565020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142596 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142592 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=132296
TEST=manual + aura_shell_unittests
Review URL: https://chromiumcodereview.appspot.com/10543158
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142590 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=132806
TEST=browser_tests
Review URL: https://chromiumcodereview.appspot.com/10556002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142589 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10562024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142588 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=132633
TBR=levin@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10554019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142587 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142586 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=morrita@chromium.org
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10566016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142585 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It isn't possible to give an exact date for withdrawing
support because it is being phased in several steps.
But I agree with the general sentiment of the bug report, so
my plan is to write a blog post explaining the steps and
link to that.
BUG=132633
TBR=levin@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10555015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142584 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/10555014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142583 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add hit test mask to aura Window;
- Use hit test mask to exclude shadow from hit test;
BUG=132872
TEST=Verify mouse events reaches app list launcher button when app list bubble is shown. Clicking on top 3 rect of the 3x3 grid icon should dismiss app list and mouse hover there should have a hover effect.
Review URL: https://chromiumcodereview.appspot.com/10566009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142582 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
crashes to Breakpad (Windows only).
BUG=130678
TEST=remoting_unittests.BreakpadWinDeathTest
Review URL: https://chromiumcodereview.appspot.com/10535082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=131659
TEST=
Review URL: https://chromiumcodereview.appspot.com/10559008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142580 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=127097
TEST=browser_test --gest_filter='*RemoteFileSystem*'
TEST=unit_tests --gtest_filter='*GData*'
Review URL: https://chromiumcodereview.appspot.com/10441015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142579 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=132984
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10556015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142578 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
After closing bug 127048, all public functions in GDataFileSystem are now asynchronous. Therefore
we can get rid of the "Async" suffix from these function names.
Cosmetic change only; does not affect functionality.
BUG=126992
TEST=unit_tests, browser_tests
Review URL: https://chromiumcodereview.appspot.com/10559020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142577 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
user data dir.
BUG=131033
TEST=install system-level chrome with require_eula in master prefs and eulaaccepted=0 in the ClientState key. nuke all user data dirs (including the metro one). now launch desktop chrome and accept the eula. make chrome the default browser and launch into metro. notice that it works.
Review URL: https://chromiumcodereview.appspot.com/10539153
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142576 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This changes our browser gyp to use the exact same build process as before
but just pull in about:tracing files from third_party/trace-viewer/src instead of
chrome/browser/resources/. This is a quick fix to restore about:tracing, which
as it turns out, people get upset about if it is broken. We can look for a more
"proper" fix with this landed.
BUG=132875
Review URL: https://chromiumcodereview.appspot.com/10566011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142572 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was causing issues with silverlight on 10.6 machines.
BUG=132235
TEST=
Review URL: https://chromiumcodereview.appspot.com/10539178
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142570 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=127688
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10537141
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142569 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Tabs can now be reordered inside a single chrome window on
linux_aura. Multiselection works too. Dragging out of a window doesn't
work yet.
Most of dock_info_aura.cc has been copied from dock_info_gtk.cc. A
helper function was moved from gtk_util to x11_util (which only used
pure X functions.)
BUG=133059
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10560014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142568 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142567 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chromium-side preparation for https://bugs.webkit.org/show_bug.cgi?id=89145, must land before the WebKit side.
I'll remove the #if after the WebKit side lands and rolls.
BUG=none
TEST=compiles
Review URL: https://chromiumcodereview.appspot.com/10539175
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142566 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=
BUG=none
TEST=build
Change-Id: I86953b47fc51ae9d371ff71bfbad449ca6a7c1cc
Review URL: https://chromiumcodereview.appspot.com/10543165
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142565 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
exceptions are not editable.
BUG=112190
TEST=None
Review URL: https://chromiumcodereview.appspot.com/10541177
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A recent change allowed us to handle a missing sync database by creating
a new directory and repopulating it by requesting an initial sync from
the server.
This commit builds on that work by intentionally deleting the sync
database if it is found to be corrupt or unusable. The client will then
recognize that the database is empty and repopulate it, just as it would
had the directory not existed in the first place.
BUG=109668
TEST=Manual. Three cases, see below:
- Delete 'Sync Data/SyncData.sqlite3' from the profile directory. Start
chromium and observe that all data is redownloaded from the server.
- Corrupt an existing sync directory. The SQL command
'DELETE FROM metas WHERE metahandle = 1' should be sufficient. Start
chromium and observe that the directory is deleted then recreated
and all data is redownloaded from the server.
- Ensure that no directory can be created. You could do this by marking
the 'Sync Data' folder as read-only. Start chrome, and observe that
sync is unusable, but the browser still works.
NOTE: This only works in release builds, debug builds will DCHECK.
It's debatable whether or not this scenario is worth testing.
Review URL: https://chromiumcodereview.appspot.com/10554016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142563 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change drop-image CSS style to 25 pixels wide to match actual width of images.
BUG=None
TEST=Manual
Depends on http://codereview.chromium.org/10535134/
Review URL: https://chromiumcodereview.appspot.com/10541142
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142562 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The real path names coming from file system are sometimes
human-unreadable, so FileChooser attaches them human-readable
display names. This CL wires the display names into FileRef.
BUG=129609
TEST=manual test on yahoo mail file attachment.
Review URL: https://chromiumcodereview.appspot.com/10560003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142561 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
UrlRequestContextGetter.
Also updated all code that depends on that methods.
TBR=mnissler@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10539148
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
this fixes webkitStorageInfo.requestQuota for platform apps in that the callback will actually be called (it acts as if the user always denies the request).
BUG=132219
TEST=see bug
Review URL: https://chromiumcodereview.appspot.com/10532175
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142559 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=compiles, unit_tests pass.
Review URL: https://chromiumcodereview.appspot.com/10559019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142558 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
JSONWriter's comment on OPTIONS_DO_NOT_ESCAPE option looks tempting to pass UTF-8 string with it, but just passing UTF-8 encoded strings without this option is correct.
If the option is used, e.g. a UTF-8 encoded character
(e.g. \xE8\xA8\xBC) will be *escaped* to "\u00e8\u00a8\u00bc".
BUG=132940
TEST=manually
Review URL: https://chromiumcodereview.appspot.com/10542174
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142557 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10566015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142556 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Old clients would sometimes end up with items that were deleted before
their existence was ever reported to the server. For a while, we let
these entries accumulate in the database, and just filtered them out of
the list of items to commit when we created that list in GetCommitIds.
Then we learned that a subset of these entries could be deleted in such
a manner that they would be detected as database corruption. The client
was udpated so it would delete these entries in a timely manner. The
filter in GetCommitIds was removed. See crbug.com/125381 for details.
It turns out that a lot of clients have some deleted local items in
their sync database created by older clients. When they update to the
new client which doesn't have the GetCommitIds filter, they will try
to commit the local tombstones. This is bad.
This commit addresses the problem in two ways:
1. Drop any server-unknown deleted items when we open the database.
2. As a fallback, put the filter back into GetCommitIds. The filter
should not be required, so it will trigger a NOTREACHED() if it is
executed.
BUG=132905,125381
TEST=SyncableDirectoryTest.OldClientLeftUnsyncedDeletedLocalItem
Review URL: https://chromiumcodereview.appspot.com/10559018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142555 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=109810
TEST=manual testing
Review URL: https://chromiumcodereview.appspot.com/10532168
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142554 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=123260
TEST=media_unittests, encrypted-media layout tests.
Review URL: https://chromiumcodereview.appspot.com/10534096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142553 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=132790
TEST=see bug for manual test
Review URL: https://chromiumcodereview.appspot.com/10557024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142552 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There is only one caller to this function (WebViewHost.cpp in the WebKit repo) and it
always specifies the literal "true". Removing this parameter will let us remove a
really nasty getter from WebView.
BUG=none
TEST=compiles
Review URL: https://chromiumcodereview.appspot.com/10532174
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142549 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=131693
TEST=Verify that app list bubble moves with launcher app list button when pinning/unpinning from app list grid.
Review URL: https://chromiumcodereview.appspot.com/10535170
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142548 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10556021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142547 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142546 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=129616
TEST=manual
Review URL: https://chromiumcodereview.appspot.com/10566013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142544 0039d316-1c4b-4281-b951-d872f2087c98
|