summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Make the fullscreen sample be the simplest possible one that shows good ↵ericu@google.com2009-06-101-403/+195
| | | | | | | | practices. Review URL: http://codereview.chromium.org/119340 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18007 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a linux bug in the find bar where we keep re-selecting texttc@google.com2009-06-102-2/+12
| | | | | | | | | | | | | on the page after closing the find bar. This happens because gtk_entry_set_text triggers a "changed" event in gtk. This doesn't happen in on the windows side. BUG=13344 Review URL: http://codereview.chromium.org/118457 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18006 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: rebaseline due to WebKit's r44503agl@chromium.org2009-06-1024-16/+576
| | | | | | | | | | | | | | | | r44503: Chromium Linux ignored the background color on <select>s. Rather than encode magic colours, we start with a base color (specified via CSS) and derive the other colors from it. Thus, setting the CSS background-color now correctly changes the colour of the control. https://bugs.webkit.org/show_bug.cgi?id=26030 TBR=tony git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18005 0039d316-1c4b-4281-b951-d872f2087c98
* Add bug for newly failing testsdarin@chromium.org2009-06-101-17/+17
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18004 0039d316-1c4b-4281-b951-d872f2087c98
* Removed platform specific test results for WebKit bug fix.ojan@google.com2009-06-106-26/+0
| | | | | | | | | | Committing for ryosuke.niwa@gmail.com. TEST=none BUG=13485 R=jparent git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18003 0039d316-1c4b-4281-b951-d872f2087c98
* part 2 of dragging change: reordering, but not persistingerikkay@google.com2009-06-1016-3045/+3429
| | | | | | | | | | | | | | * split up extension_shelf into a model and a view (easier to port) * ExtensionHost now owns ExtensionView rather than vice versa * dragging reorders extensions on the shelf * moved ExtensionView* into browser_tests (currently not working) BUG=12123 TEST=browser_tests.exe --gtest_filter=ExtensionShelfModel* (browser_tests.exe is currently broken) Review URL: http://codereview.chromium.org/119290 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18002 0039d316-1c4b-4281-b951-d872f2087c98
* Change the extension callback system to work more like events, where we trackmpcomplete@google.com2009-06-108-126/+119
| | | | | | | | | | | | | contexts rather than frames. Also change the way we call through to javascript, to avoid a v8::Compile. This is so we don't skew the histogram stats on our script cache. BUG=? TEST=none Review URL: http://codereview.chromium.org/119369 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18001 0039d316-1c4b-4281-b951-d872f2087c98
* Fix compile bustage by using macroben@chromium.org2009-06-101-1/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18000 0039d316-1c4b-4281-b951-d872f2087c98
* Ignore canvas-lineWidth.html test that is failing due to missing expecteddarin@chromium.org2009-06-101-1/+1
| | | | | | | | | | | | | results. We can stop skipping this once the expected results are checked in upstream. BUG=none TEST=none TBR=deanm Review URL: http://codereview.chromium.org/119403 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17999 0039d316-1c4b-4281-b951-d872f2087c98
* Review URL: http://codereview.chromium.org/118473petersont@chromium.org2009-06-091-1/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17998 0039d316-1c4b-4281-b951-d872f2087c98
* Update result formatting for the search provider for the Omnibox2 popup.ben@chromium.org2009-06-092-19/+73
| | | | | | | | | | | I've kept the old style in there now too since we have --disable-omnibox2 for a short while so QA can compare if necessary. http://crbug.com/13647 TEST=suggestion completions should be bolded in the omnibox2 dropdown. the first "Search Google For" item should now read "<query> - Search Google" (or whatever your default search engine is). Review URL: http://codereview.chromium.org/119341 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17997 0039d316-1c4b-4281-b951-d872f2087c98
* Remove Menu2Delegate interface and fold methods onto Menu2Model instead.ben@chromium.org2009-06-0915-192/+215
| | | | | | | | | | | | | Enhance SimpleMenuModel::Delegate interface to support additional options required by the above. Make MenuHostWindow process WM_MENUCOMMAND and WM_MENUSELECT - the first so we can determine which index was selected, the second so we can track highlight changes within a menu. Convert Tab's context menu back to the windows native menu. This will make my life easier when I upgrade chrome_menu.cc to the new API if only the bookmarks menus/context menus are using it. BUG=none TEST=page, app menus again, context menu for tabs. open a bunch of tabs, open this page: http://bengoodger.dreamhosters.com/software/chrome/cxmenutest.html, close that tab then right click on the menu quickly. should not crash! Review URL: http://codereview.chromium.org/118426 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17996 0039d316-1c4b-4281-b951-d872f2087c98
* Removing ffmpeg again.ajwong@chromium.org2009-06-098-167/+316
| | | | | | | | Reverting r17992 and r17987. Review URL: http://codereview.chromium.org/119399 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17995 0039d316-1c4b-4281-b951-d872f2087c98
* The features request broke backward compatibility for code currently in the ↵gman@google.com2009-06-093-9/+40
| | | | | | | | | | | | | | | | | | | | | | | | | wild. This CL fixes that as follows. If there is no 'o3d_features' argument passed to the plugin it assumes the code using the plugin is old and turns on the features that broke backward compatibility. Otherwise, the utility libraries always pass in a o3d_features argument from this point on so it will work the new way (ie, certain features must be requested). Also, the requested version is passed in as well. This way we can adjust the API by version number later. Unfortunately, as it is, neither the o3d_features argument is required nor is the version number which means if someone is not using the o3djs libraries it would be possible for them to make something that we would break later. We could maybe fix that by requiring a version number and failing if one is not passed in although old code will still not give us a version number so I'm really not sure how to handle that case. Review URL: http://codereview.chromium.org/118050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17994 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing include path for windows.ajwong@chromium.org2009-06-091-0/+3
| | | | | | Review URL: http://codereview.chromium.org/119396 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17992 0039d316-1c4b-4281-b951-d872f2087c98
* Update JSTemplate to the latest version.arv@google.com2009-06-0929-1696/+4175
| | | | | | | | | | | | | This version is from Google and has already stripped all non related code except for the MAPS_DEBUG flag. I manually removed all the debugging code related to MAPS_DEBUG. TEST=New tab page, history, downloads and all other pages using HTML content should still work. BUG=None Review URL: http://codereview.chromium.org/119384 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17990 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline property-getters-and-setters.html for WebKit r44445darin@chromium.org2009-06-093-1/+2
| | | | | | | | | | TEST=covered by layout test BUG=none TBR=ukai Review URL: http://codereview.chromium.org/118472 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17989 0039d316-1c4b-4281-b951-d872f2087c98
* Liberalize the size limits in the PNG decoder to match the changes landed ↵pkasting@chromium.org2009-06-091-5/+7
| | | | | | | | | | upstream to all the WebKit image decoders. I'm not sure where this is used, hence no test. BUG=3643 TEST=none Review URL: http://codereview.chromium.org/118462 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17988 0039d316-1c4b-4281-b951-d872f2087c98
* Reapply ffmpeg changes. The original review is at ↵ajwong@chromium.org2009-06-098-316/+164
| | | | | | | | http://codereview.chromium.org/118046. Review URL: http://codereview.chromium.org/118444 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17987 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a memory leak in a focus manager unit-test.jcampan@chromium.org2009-06-091-2/+2
| | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/118461 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17986 0039d316-1c4b-4281-b951-d872f2087c98
* Update test expectations to account for merge to r44544.darin@chromium.org2009-06-091-1/+23
| | | | | | | | | | BUG=none TEST=none TBR=eroman Review URL: http://codereview.chromium.org/118466 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17985 0039d316-1c4b-4281-b951-d872f2087c98
* Add themeChromiumLinux.css to the build.darin@chromium.org2009-06-091-0/+1
| | | | | | | | TBR=agl Review URL: http://codereview.chromium.org/118464 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17984 0039d316-1c4b-4281-b951-d872f2087c98
* Update WebKit to r44544.darin@chromium.org2009-06-098-32/+28
| | | | | | | | | | | | | | | | | | | | 1- WorkerThread::create() now takes a WorkerLoaderProxy parameter, which I implemented in a stub fashion on WebWorkerImpl. I'm sure the WebWorker guys will fix this up properly. 2- Removed expirationDate and setExpirationDate members of WebURLResponse consistent with their removal from WebCore::ResourceResponseBase. The corresponding logic for computing cache eviction time is now part of WebCore. 3- Added wtf/DateMath.{h,cpp} to the build. TEST=covered by existing tests, I hope! BUG=none R=eroman Review URL: http://codereview.chromium.org/119387 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17983 0039d316-1c4b-4281-b951-d872f2087c98
* Fix FTP binary file download issue.wtc@chromium.org2009-06-091-5/+6
| | | | | | | | | | | | | The patch is contributed by Ibrar Ahmed <ibrar.ahmad@gmail.com>. Original review: http://codereview.chromium.org/118455 R=wtc BUG=http://crbug.com/4965 TEST=Run with --new-ftp, and try to download a file. Review URL: http://codereview.chromium.org/118459 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17981 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 13570: Find box stops responding to browser window resize.finnur@chromium.org2009-06-092-1/+30
| | | | | | | | | | | | If you enter a search term and delete it, the Find box UI flag gets set as inactive and the box stops moving when the browser resizes. This fixes that. BUG=13570 TEST=Open Find, press 'e', press Backspace, resize the window. The Find box should move. Review URL: http://codereview.chromium.org/119383 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17980 0039d316-1c4b-4281-b951-d872f2087c98
* Convert additional tests to gyp generation:sgk@google.com2009-06-091-45/+89
| | | | | | | | | | | | | | | | | | | * Split chrome_dll_version.rc generation into its own target. * perf_tests.exe: add missing modules: browser/safe_browsing/database_perftest.cc, browser/safe_browsing/filter_false_positive_perftest.cc, common/json_value_serializer_perftest.cc. * interactive_ui_tests.exe: add dependency on installer_util_strings; add dependency on new chrome_dll_version target; add missing browser/debugger/devtools_sanity_unittest.cc module; add missing resources. * Cleanup: alphabetize sources in test_support_common. BUG=none TEST=successful build Review URL: http://codereview.chromium.org/119373 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17979 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Remove old ifdefs around a DCHECK.willchan@chromium.org2009-06-091-4/+0
| | | | | | Review URL: http://codereview.chromium.org/119376 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17978 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a unit test failure. One of the tests sends an empty bitmap through thisbrettw@chromium.org2009-06-091-3/+1
| | | | | | | | function, which has no config, and the assertion fails. I just removed the assretion, we assume ARGB8888 everywhere. Review URL: http://codereview.chromium.org/118456 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17976 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Mac compile bustagebrettw@chromium.org2009-06-091-1/+1
| | | | | | Review URL: http://codereview.chromium.org/119379 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17973 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Linux compile bustagebrettw@chromium.org2009-06-091-1/+1
| | | | | | Review URL: http://codereview.chromium.org/119378 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17972 0039d316-1c4b-4281-b951-d872f2087c98
* Modified ThumbnailStore to cache/store JPEGs insteadbrettw@chromium.org2009-06-0913-124/+185
| | | | | | | | | | | | | of SkBitmaps. Add command line flag "--thumbnail-store" to enable using the ThumbnailStore facility instead of the current ThumbnailDatabase. Original review: http://codereview.chromium.org/118409 Patch by Meelap Shah git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17971 0039d316-1c4b-4281-b951-d872f2087c98
* Add lib32asound2-dev into 32-bit build dependencies.ajwong@chromium.org2009-06-091-2/+2
| | | | | | Review URL: http://codereview.chromium.org/119336 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17970 0039d316-1c4b-4281-b951-d872f2087c98
* Add MOZ_Z_deflate to the known filter for UMR in purify.nsylvain@chromium.org2009-06-091-0/+0
| | | | | | | | BUG=13695 TEST=None Review URL: http://codereview.chromium.org/119374 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17969 0039d316-1c4b-4281-b951-d872f2087c98
* Commenting out V8-test until V8 bug is fixed.vangelis@google.com2009-06-091-1/+2
| | | | | | Review URL: http://codereview.chromium.org/119332 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17967 0039d316-1c4b-4281-b951-d872f2087c98
* Modifies the growbox behavior to be more Mac-like.rohitrao@chromium.org2009-06-094-9/+92
| | | | | | | | | | | | | | | | | | Nib file changes: - Set the min browser window size to 400x250. BUG=http://crbug.com/11844 BUG=http://crbug.com/13015 BUG=http://crbug.com/13017 TEST=Verify that windows have a minimum size. Verify that (with a single monitor) windows cannot be resized into the dock area, unless their lower right corner started in the dock area. Verify that windows can be resized across multiple monitors. Review URL: http://codereview.chromium.org/118439 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17965 0039d316-1c4b-4281-b951-d872f2087c98
* Mark webkit failures as flaky for later investigations.thestig@chromium.org2009-06-091-0/+7
| | | | | | Review URL: http://codereview.chromium.org/119372 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17964 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a minor bug in the print dialog on windows. The minimum page number was ↵sverrir@google.com2009-06-091-0/+1
| | | | | | | | | | | | | not set so you could ask for a printout of page 0-5 in a 5 page document. This caused an empty page to be printed before the others. BUG=none TEST=Try to enter illegal page number in the page number dialog. Review URL: http://codereview.chromium.org/118446 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17963 0039d316-1c4b-4281-b951-d872f2087c98
* Start using WebURLLoader, et. al. from the WebKit API.darin@chromium.org2009-06-0935-1334/+2786
| | | | | | | | | | | | | | | | | | | | | | | | | | | Moves our ResourceHandle to webkit/api/src/ResourceHandle.cpp from webkit/glue/resource_handle_impl.cc. A portion of resource_handle_impl.cc was moved into weburlloader_impl.{h,cc}, which now contains our implementation of WebURLLoader. The annoying parts of this CL involve WebPluginImpl. I had to convert it over to using WebURLLoader instead of ResourceHandle so that MultipartResourceDelegate can be shared. There is some complexity in WebURLRequest / WebURLResponse to make it cheap to wrap a ResourceRequest / ResourceResponse. I think this is worth it since there is a lot of conversion between the two types. Originally reviewed here: http://codereview.chromium.org/113928 BUG=10038 TEST=covered by existing tests R=dglazkov Review URL: http://codereview.chromium.org/118438 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17962 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash in Safari 4.0 final by making the O3D plug-in default to the ↵maf@google.com2009-06-091-12/+16
| | | | | | | | | | | Carbon event model, rather than the Cocoa event model. A recent change in the spec of the Cocoa event model for Mac OS X browser plug-ins means that essential window information is not supplied at NPP_SetWindow() time. Luckily we can use the Carbon event model while we work out what to do to operate in that environment (we really need to know what window to attach our AGL context to). Review URL: http://codereview.chromium.org/118434 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17961 0039d316-1c4b-4281-b951-d872f2087c98
* Should provide checks while loading bookmarksmhm@chromium.org2009-06-091-12/+6
| | | | | | | | | | | | | | Instead of providing a separate check to validate bookmarks while loading, we could assume invalid bookmarks are invalid, hence we don't break the loading sequence. We keep looping since another bookmark might be valid. If the JSON syntax is broken, it will exit gracefully because the parser can't parse the file. This patch is only good for people who are editing their bookmarks directly and missing a item in the bookmark node. BUG=10709 (http://crbug.com/10709) TEST=Deleted any line from the Bookmarks file within the bookmark children node. Loaded up Chromium and it loaded the error free bookmarks. Review URL: http://codereview.chromium.org/118351 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17960 0039d316-1c4b-4281-b951-d872f2087c98
* Clean-up following sgk's suggestions.jcampan@chromium.org2009-06-092-17/+30
| | | | | | | | | | | | | Also few fixes: - we need an AtExitManager instanciated for some calls to succeed (see browser_test_launcher_in_proc.cc) - the browser_tests.dll PDB file was getting overridden by the one for browser_tests.exe (making it hard to debug tests...) - the browser tests require the browser_resources.rc or some tests will fail. BUG=None TEST=Run the browser tests. Review URL: http://codereview.chromium.org/119270 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17959 0039d316-1c4b-4281-b951-d872f2087c98
* Fix QA code to work from svn.thomaslewis@google.com2009-06-091-2/+4
| | | | | | Review URL: http://codereview.chromium.org/118442 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17958 0039d316-1c4b-4281-b951-d872f2087c98
* Add a mipmap-like divide-by-two image scaling algorithm. I am going to use thisbrettw@chromium.org2009-06-093-7/+214
| | | | | | | for on-the-fly generated thumbnails. Review URL: http://codereview.chromium.org/118341 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17957 0039d316-1c4b-4281-b951-d872f2087c98
* Add a stack-based class for property disabling and re-enabling screen ↵pinkerton@chromium.org2009-06-093-4/+39
| | | | | | | | | | updating without epic fail. Fixes issues where we weren't re-enabling updates in many cases which caused both jank and resize issues. BUG=13476 TEST=closing windows shouldn't have jank regardless of the # of tabs. Resizing a window shouldn't explode visually in the chrome. Review URL: http://codereview.chromium.org/119363 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17956 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Import passwords from Firefox.kuchhal@chromium.org2009-06-092-48/+56
| | | | | | | | | | BUG=11191 TEST=Try importing password from Firefox on Linux and it should work (though they are not accessible in UI yet). Review URL: http://codereview.chromium.org/118443 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17955 0039d316-1c4b-4281-b951-d872f2087c98
* Make zygote mode not be the default; it screws with the valgrind bots,dkegel@google.com2009-06-091-1/+1
| | | | | | | | | | | | | | and there's a "double free or corruption" on atexit that we need valgrind for. To reenable, set ENABLE_ZYGOTE_MANAGER=1. It's going to be refactored anyway... BUG=none TEST=none Review URL: http://codereview.chromium.org/118440 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17954 0039d316-1c4b-4281-b951-d872f2087c98
* Fix SVN mime-type metadata for PNGs. Rietvelt has the ability to do ↵senorblanco@chromium.org2009-06-090-0/+0
| | | | | | | | | | | | | side-by-side image diffs, but only if the svn:mime-type is set correctly. This CL sets it for all PNGs in src/webkit/data/layout_tests/platform/*. BUG=none TEST=Upload a change to a layout test PNG. Check that you see image diffs in Rietveld. (One example uploaded for reference. I didn't bother uploading the other 4541, for obvious reasons). Review URL: http://codereview.chromium.org/119362 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17953 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: now that WebKit implementation of WebInspector.SourceView expects ↵yurys@google.com2009-06-098-39/+106
| | | | | | | | InspectorController.addResourceSourceToFrame to asynchronous we can get rid of our implementation of SourceView.setupSourceFrameIfNeeded. Review URL: http://codereview.chromium.org/118428 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17952 0039d316-1c4b-4281-b951-d872f2087c98
* This CL adds some more FocusManager unit-tests.jcampan@chromium.org2009-06-097-224/+508
| | | | | | | | BUG=None TEST=Run the unit-tests. Review URL: http://codereview.chromium.org/118413 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17951 0039d316-1c4b-4281-b951-d872f2087c98
* Fix suppression with PNGEncoder::EncodeBGRASkBitmap()nirnimesh@chromium.org2009-06-091-3/+1
| | | | | | | | BUG=12640 Review URL: http://codereview.chromium.org/119354 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17950 0039d316-1c4b-4281-b951-d872f2087c98