| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
The InfoBubble has been changed on Windows so it is parented to its border window. That caused a change in activation changes when losing focus. This resulted in Close() been called more than once, trigerring a DCHECK. This CL ensures multiple invocation of Close don't break.
BUG=46749
TEST=Bookmark a page. Click outside the bubble.
Click the Edit button.
Review URL: http://codereview.chromium.org/2850011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50125 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a Purify error (which we no longer use).
BUG=10553
TEST=ProfileManagerTest.CreateAndUseTwoProfiles
Patch by Xiaotian Chen <sargrass@google.com>
Review URL: http://codereview.chromium.org/2803009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50124 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50121 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=hclam
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/2861006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50120 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Created a notification for when a session is saved,
so that later we can observe this notification and
sync a session.
BUG=30519
TEST=session_service_unittest.cc
Review URL: http://codereview.chromium.org/2858005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50119 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=40101
Review URL: http://codereview.chromium.org/2870008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50118 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the initial implementation of System page in ChromeOS options.
BUG=chromium-os:
TEST=none yet, work in progress
Review URL: http://codereview.chromium.org/2781005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of HostConnection and ChromotingView. Also implement a bare-bones
PepperView.
No unittests yet. Still too in flux to be worth it.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2852003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
plumbing have been pushed.
Review URL: http://codereview.chromium.org/2806001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50114 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:2068
TEST=Verify that install a theme/extension from gallery will not trigger content browser per zel in chromium-os:2068.
Review URL: http://codereview.chromium.org/2823008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50113 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I made some corrections to my previously submitted function
TruncateUTF8ToByteSize, in order to clean up the code,
and use it to truncate sync node titles above 255 bytes.
BUG=43675
TEST=base/string_util_unittest.cc
Review URL: http://codereview.chromium.org/2632005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50112 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2867009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50111 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2814013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
chosen.
BUG=46716
TEST=new first run bubble after first run import mentions the search engine: "Search using Google from right here"
Review URL: http://codereview.chromium.org/2817009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50109 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. makes the menu show the same fonts regardless of whether the item
has children.
. adds text color to MenuConfig. I'm going to use this for the buttons
added to the menu.
. Changes TextButton to update text_size_ when the font changes.
. Changes TextButton to allow you to specify how accelerators are
shown.
. Nukes TextButton::OnMousePressed as it's not needed (super
implementation does the right thing and updates state the
TextButton::OnMousePressed wasn't).
. Changes accelerator to have constructor taking keycode and modifiers.
BUG=45734
TEST=none
Review URL: http://codereview.chromium.org/2833013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50108 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
reports
TBR=glider
Review URL: http://codereview.chromium.org/2869010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=44476
TEST=Linux CookieMonster.SetCookieableSchemes (as modified)
Review URL: http://codereview.chromium.org/2869002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50105 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= http://crosbug.com/4033
TEST=When WiFi was disabled through network status area button it's possible to enable it back.
Review URL: http://codereview.chromium.org/2850012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50104 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=46797
TEST=Mac Valgrind unit_tests goes green.
Review URL: http://codereview.chromium.org/2826007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2851009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50101 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2809016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These are mostly test files.
TBR=nsylvain
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/2818012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50098 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
add some basic suppressions
TBR=glider
Review URL: http://codereview.chromium.org/2869009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50097 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=46678
TBR=garykac
Review URL: http://codereview.chromium.org/2813017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- autofill: explicitly initialize in the copy constructor
- make some loops clearly use {} for empty bodies
- bump up app mode version number to 1.0 so we don't check for < 0 on the unsigned version number.
BUG=34160
TEST=none
Review URL: http://codereview.chromium.org/2856006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2806012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50094 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
UploadTest*, SessionHistoryTest.FrameBackForward, IPCSyncChannelTest.Multiple
TBR=glider
BUG=46783,46782,46781
Review URL: http://codereview.chromium.org/2851008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
It's failing and sometimes crashes Valgrind itself:
Test crash: http://build.chromium.org/buildbot/memory/builders/Chromium%20Mac%20(valgrind)/builds/5412/steps/memory%20test:%20ipc/logs/stdio
Valgrind crash: http://build.chromium.org/buildbot/memory/builders/Chromium%20Mac%20(valgrind)/builds/5400/steps/memory%20test:%20ipc/logs/stdio
TBR=glider
Review URL: http://codereview.chromium.org/2842011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50090 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
crbug is down right now so I can't file issues. Will file them once it is working again.
BUG=22927,29587,45562,46211
TBR=glider
Review URL: http://codereview.chromium.org/2809018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=21050,42222
TEST=net_unittests
Review URL: http://codereview.chromium.org/2722009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50088 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I suspect flaky failure in reload-crash.html was OnSentData is called when state_ has been changed to CLOSED while sending handshake message.
BUG=45720
TEST=none
Review URL: http://codereview.chromium.org/2845012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50087 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50085 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Tab key doesn't get here since it's handled by focus manager.
BUG=none
TEST=Enter a name without domain in username field on login screen. Remove
focus from the field (i.e. by hitting Tab). @gmail.com should be appended.
Review URL: http://codereview.chromium.org/2829005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50083 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
LanguageLibrary is a misnomer. This is actually an input method library.
Will change the file name in the next change list.
Methodology of refactoring:
1. perl -i -pe 's/LanguageLibrary/InputMethodLibrary/g' **/*.cc **/*.h
2. manually fix the lines that became longer than 80 chars.
3. grep 'language_lib' **/*.{cc,h} |grep -v '#include'
4. manually fix the variable names.
BUG=chromium-os:4063
TEST=manually
Review URL: http://codereview.chromium.org/2868009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50082 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=46666
TEST=none
Review URL: http://codereview.chromium.org/2852012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50081 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
<DIR_SOURCE_ROOT>/third_party/WebKit exists in a case of WebKit-only
checkout because we copy WebKit API headers to there. So check
<DIR_SOURCE_ROOT>/chrome instead.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2869008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50080 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2831012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50079 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
In case proxy_info_.is_empty(), we can't access proxy_info_.proxy_server()
or so.
BUG=46750
TEST=none
Review URL: http://codereview.chromium.org/2803010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2715003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50077 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Add font_descriptor and corresponding pluming to send an NSFont over IPC.
* Rejigger font_loader to accept an NSFont as input and output an ATSFontContainerRef. The reasoning behind this is that WebKit ultimately controls the font lifetime and we can only deactivate the font container once the font is no longer in use.
BUG=29729
Test=Unit tests should pass.
Review URL: http://codereview.chromium.org/2804001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change modifies RunStartupTest to call GetInitialLoadTimes, if applicable, to print out additional statistics for each tab computed on the browser.
Additionally, changes |test_cold| and |important| parameters to be enums instead of booleans to make tests more readable.
BUG=44129
TEST=none
Review URL: http://codereview.chromium.org/2714015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Now with the mac build fixed.
BUG=42894
TEST=out/Debug/chrome --diagnostics
Review URL: http://codereview.chromium.org/2821009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The debug options were forcefully causing apps to launch as tabs.
BUG=46502
TEST=try launching a panel or window based app, it shouldn't launch as a tab
Review URL: http://codereview.chromium.org/2844008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
No change in the logic. Just move the code around.
- Add language_config_model.cc, .h, _test.cc
- Sort function definitions and declarations so the order match in .cc and .h files.
Search for OCD in http://www.chromium.org/developers/coding-style
TEST=manually
BUG=chromium-os:4063
Review URL: http://codereview.chromium.org/2856005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50069 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
errors/crashes on adding new extensions with extensions sync turned on.
BUG=46742
TEST=manual, trybots
Review URL: http://codereview.chromium.org/2811011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50068 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2817012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50066 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=46751
TEST=n/a
TBR=jhawkins
Review URL: http://codereview.chromium.org/2802008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50065 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
suggested dimensions and would end up
opening a default top level browser window in IE.
ChromeFrame does receive the dimensions from the external tab container when it is notified about a popup being
opened.
Fix is to honor these dimensions by passing them off in the specially crafted url containing other arguments.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=42250
This fix is currently implemented for IE full tab mode only.
Bug=42250
Test=Covered by augmenting the existing window open test to also validate the window size. Added a new unit test
to test the ParseAttachExternalTabUrl helper function.
Review URL: http://codereview.chromium.org/2867007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50064 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
in Chrome (yet), but it is used by the gallery.
BUG=46379
Review URL: http://codereview.chromium.org/2845010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50062 0039d316-1c4b-4281-b951-d872f2087c98
|