summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Change <script id="o3d" to <script id="o3dscript"gman@google.com2009-07-2897-97/+97
| | | | | | | | | so that document.getElementById('o3d') will work for finding the o3d div. Review URL: http://codereview.chromium.org/159556 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21924 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for attribute spellcheck="true"/"false" in <input>.sidchat@google.com2009-07-281-0/+2
| | | | | | | | BUG=www.crbug.com/5574 TEST=Download the test file attached with the bug above. Open the html file in Chrome - the input box should show underlines for misspelled words. Now, edit the HTML file such that spellcheck attribute is false. Check again - misspelled words in the text box should not be underlined this time. Review URL: http://codereview.chromium.org/159547 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21923 0039d316-1c4b-4281-b951-d872f2087c98
* linux plugins: assume UTF-8 for plugin name/descriptionevan@chromium.org2009-07-281-2/+5
| | | | | | | | | Saw this on my Jaunty machine; plugin name included a copyright symbol. Review URL: http://codereview.chromium.org/159546 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21921 0039d316-1c4b-4281-b951-d872f2087c98
* Pull all the filesystem manipulation out ofaa@chromium.org2009-07-287-492/+651
| | | | | | | | | | | | | ExtensionsServiceBackend into a set of utility functions. The intent of this is: a) make extensions_service.cc smaller b) have smaller pieces hanging around that we can more easily reconfigure to implement new features. c) improve testability. Review URL: http://codereview.chromium.org/159400 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21920 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unreferenced .rules files.sgk@google.com2009-07-287-147/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/160285 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21918 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unreferenced .vcproj files.sgk@google.com2009-07-287-2617/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/159534 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21917 0039d316-1c4b-4281-b951-d872f2087c98
* Stop doing the saturation-gradient thing on the NNTP. It blinded people. ↵glen@chromium.org2009-07-282-2/+1
| | | | | | | | | | | Also update the section background so that it looks the same on white, but is actually transparent. BUG=none TEST=none Review URL: http://codereview.chromium.org/159549 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21914 0039d316-1c4b-4281-b951-d872f2087c98
* Update theme gallery URL. Not updating the translatable in order to keep the ↵glen@chromium.org2009-07-281-1/+1
| | | | | | | | | | | change as small as possible for beta merge. TBR=ben BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21913 0039d316-1c4b-4281-b951-d872f2087c98
* Mark LayoutTests/tables/mozilla/bugs/bug28341.html as PASS FAIL for windows ↵ajwong@chromium.org2009-07-281-1/+1
| | | | | | | | | | | | | debug. The test seems to be flaky on windows debug. BUG=14207 TEST=no new ones. Review URL: http://codereview.chromium.org/159552 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21912 0039d316-1c4b-4281-b951-d872f2087c98
* Re-org extension docs, template support for new static files.rafaelw@chromium.org2009-07-2826-881/+807
| | | | | | | | | | | | No chrome code changes (does not affect any files that are used in build or tests). This is the precursor to a build/check-in step to generate extension docs if underlying api or static content has changed. TBR Review URL: http://codereview.chromium.org/159551 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21911 0039d316-1c4b-4281-b951-d872f2087c98
* Only allow one theme installation infobar to be shown at a time.glen@chromium.org2009-07-283-0/+27
| | | | | | | | | BUG=None TEST=Install two themes without closing the infobar - make sure only one infobar is visible. Review URL: http://codereview.chromium.org/160296 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21910 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issues with right border of the lower section as well as some CSSarv@google.com2009-07-282-18/+48
| | | | | | | | | | | | | | | | | | tweaks for the list view mode. This also fixes an issue where the thumbnails were not positioned correctly at startup in RTL BUG=17810, 17811, 17751 TEST=Hide the recent activities and make sure that the right border of even more is shown. Switch to list mode. Make sure that the filler are hidden. Try dragging the items in the list view. The text should not dissappear. Review URL: http://codereview.chromium.org/160291 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21909 0039d316-1c4b-4281-b951-d872f2087c98
* Create render view for extensions on Linux.phajdan.jr@chromium.org2009-07-286-2/+75
| | | | | | | | | | | | | Now when an extension is loaded, you will see its entry in the task manager. However, on the shelf there is still only a placeholder label (I have to work on setting proper size for the render widget). TEST=none http://crbug.com/16759 Review URL: http://codereview.chromium.org/159527 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21908 0039d316-1c4b-4281-b951-d872f2087c98
* Cancel a task if stopped/errored so we don't hit an over-protective DCHECK.scherkus@chromium.org2009-07-281-0/+5
| | | | | | | | | TEST=media bear tests should start passing again BUG=none Review URL: http://codereview.chromium.org/160295 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21907 0039d316-1c4b-4281-b951-d872f2087c98
* left a file outestade@chromium.org2009-07-281-0/+4
| | | | | | | | TBR=awong Review URL: http://codereview.chromium.org/159550 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21906 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: More hotkeys.estade@chromium.org2009-07-284-0/+38
| | | | | | | | | | | | - ctrl+e = ctrl+k - alt + e and alt + f to open the page and wrench menus respectively (emulating menu bar _File and _Edit) BUG=none TEST=use the new hotkeys Review URL: http://codereview.chromium.org/160292 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21905 0039d316-1c4b-4281-b951-d872f2087c98
* - Roll DEPS to pickup fix for failure of canvas-ImageData-behaviour.htmliposva@chromium.org2009-07-281-1/+1
| | | | | | Review URL: http://codereview.chromium.org/159545 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21904 0039d316-1c4b-4281-b951-d872f2087c98
* Old NTP: Make sure we do not try to load "undefined" for the p13narv@google.com2009-07-282-15/+28
| | | | | | | | | | | | | | | iframe. Also, override some styles that gets set in the theme css which is written for the new new tab page. BUG=None TEST=Start chrome with --old-new-tab-page Review URL: http://codereview.chromium.org/160290 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21903 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: it's not actually a bug to have the selection become empty in the URL ↵mdm@chromium.org2009-07-281-1/+1
| | | | | | | | | | | picker. BUG=none TEST=in a debug build, go to wrench->options->basics, select "open the following pages", click "add", select something from the list, and then deselect it by holding ctrl and clicking it again; chromium should not crash Review URL: http://codereview.chromium.org/159540 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21902 0039d316-1c4b-4281-b951-d872f2087c98
* Change for building dtoa on 64-bit.deanm@chromium.org2009-07-283-1/+31
| | | | | | | Review URL: http://codereview.chromium.org/159541 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21901 0039d316-1c4b-4281-b951-d872f2087c98
* The messages attached to the task created by an IPC ChannelProxy are leaked ↵jcampan@chromium.org2009-07-282-3/+30
| | | | | | | | | | when the message loop is destroyed (the MessageLoop deletes its pending tasks on destruction, but not the messages). BUG=17091 TEST=Run the ui_tests with Purify. We should not be leaking messages. Review URL: http://codereview.chromium.org/159366 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21900 0039d316-1c4b-4281-b951-d872f2087c98
* An example extension that uses YouTube Gdata API.lzheng@chromium.org2009-07-286-0/+342
| | | | | | | | | | (This is a patch of http://codereview.chromium.org/160109 Reviewer: aa.) BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21899 0039d316-1c4b-4281-b951-d872f2087c98
* There are instances where the URLRequestAutomationJob::Kill() function can ↵ananta@chromium.org2009-07-281-2/+4
| | | | | | | | | | | | get called after Cleanup, which results in the AutomationResourceMessageFilter member getting destroyed and a subsequent crash. Added a NULL check for the same. Review URL: http://codereview.chromium.org/160293 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21898 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes the Linux build break.klink@chromium.org2009-07-281-4/+0
| | | | | | | | TBR=jcampan Review URL: http://codereview.chromium.org/159543 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21897 0039d316-1c4b-4281-b951-d872f2087c98
* Adds additional MSAA information to fill in a few gaps in the hierarchy.klink@chromium.org2009-07-287-4/+63
| | | | | | | | | TEST=None BUG=None Review URL: http://codereview.chromium.org/160239 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21896 0039d316-1c4b-4281-b951-d872f2087c98
* Small test_shell fixes for 64-bit.deanm@chromium.org2009-07-282-2/+3
| | | | | | | | | | - xlib crashes because GDK_LAST_CURSOR is an invalid param. - int64 on 64-bit is long, not long long, so we have to cast. Review URL: http://codereview.chromium.org/160289 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21894 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for spell check underlines disappearing when user clicks out of the Text ↵sidchat@google.com2009-07-281-2/+8
| | | | | | | | | | Box. WebKit removes all spell check markers in Frame::respondToChangedSelection() if, for a text box, the ShouldSpellcheckByDefault() method we have defined in the glue returns false. The problem is, ShouldSpellcheckByDefault() is also called just after the user clicks outside the textbox. As a result, it either detects that the text box is not a focussed node, or determines that the editor is not editable, and returns false, which makes the Frame remove all the markers from the corresponding document object. BUG=www.crbug.com/6058 TEST=Write random stuff in a text box - after the underlines appear, click outside the text box - the underlines should not disappear. Other functionalities of spellcheck, such as changing spell check language, toggling spell check language on/off, should not be affected at all. Review URL: http://codereview.chromium.org/159516 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21892 0039d316-1c4b-4281-b951-d872f2087c98
* Assorted fixes for 64-bit.deanm@chromium.org2009-07-288-14/+16
| | | | | | | Review URL: http://codereview.chromium.org/160288 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21891 0039d316-1c4b-4281-b951-d872f2087c98
* Widen a suppression to match different operator new to takedkegel@google.com2009-07-281-1/+1
| | | | | | | | | | | care of warning seen today at http://build.chromium.org/buildbot/waterfall/builders/Chromium%20Mac%20(valgrind)/builds/379/steps/valgrind%20test:%20unit/logs/stdio BUG=17540 TEST=throw rotten tomatoes at chromium mac valgrind bot if it goes red Review URL: http://codereview.chromium.org/159531 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21890 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a BAD_OVERRIDE defect reported by Coverity. Removewtc@chromium.org2009-07-281-1/+0
| | | | | | | | | | | an unused version of the OnMessageReceived method. R=brettw BUG=17104 TEST=none Review URL: http://codereview.chromium.org/160242 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21889 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a FORWARD_NULL defect reported by Coverity. We shouldwtc@chromium.org2009-07-284-31/+36
| | | | | | | | | | | | | | | | | | allow the src_url argument of Clipboard::ReadHTML and the html and base_url arguments of ClipboardUtil::CFHtmlToHtml to be NULL. Fix nits reported by cpplint.py. In Clipboard::SetGtkClipboard, use strdup to duplicate strings. R=tony BUG=http://crbug.com/17101 TEST=none Review URL: http://codereview.chromium.org/160247 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21888 0039d316-1c4b-4281-b951-d872f2087c98
* Add a NULL check for the pending render view host when we get a close message.brettw@chromium.org2009-07-281-1/+2
| | | | | | | | | I don't think we're guaranteed to have a pending one. BUG=17916 Review URL: http://codereview.chromium.org/160286 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21887 0039d316-1c4b-4281-b951-d872f2087c98
* WriteData and BeginWriteData should fail if length iswtc@chromium.org2009-07-282-4/+17
| | | | | | | | | | | | | negative. Add a unit test for WriteData(NULL, 0). R=darin BUG=none TEST=new unit test should pass Review URL: http://codereview.chromium.org/159310 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21886 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Pipeline will execute a callback whenever an run-time error has ↵scherkus@chromium.org2009-07-285-77/+1
| | | | | | | | | | happened." TBR=kylep Review URL: http://codereview.chromium.org/160287 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21885 0039d316-1c4b-4281-b951-d872f2087c98
* linux: extra shadow in prefs dialogevan@chromium.org2009-07-281-2/+3
| | | | | | | | | | | When we use gtk_scrolled_window_add_with_viewport, it sets its own shadow. BUG=16913 Review URL: http://codereview.chromium.org/159535 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21884 0039d316-1c4b-4281-b951-d872f2087c98
* Reset static data in Watchdog to better isolate the tests.phajdan.jr@chromium.org2009-07-283-6/+21
| | | | | | | | | TEST=none http://crbug.com/17839 Review URL: http://codereview.chromium.org/160217 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21883 0039d316-1c4b-4281-b951-d872f2087c98
* Implemented a proper clock for audio/video synchronization.scherkus@chromium.org2009-07-288-26/+437
| | | | | | | | | | | More or less a change to pull out time management from PipelineImpl into a new class ClockImpl. Biggest difference is ClockImpl will use the system clock + linear interpolation to provide a more "precise" representation of the current playback position. BUG=16508 TEST=a/v sync should remain the same, currentTime should report more precise values Review URL: http://codereview.chromium.org/159517 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21882 0039d316-1c4b-4281-b951-d872f2087c98
* Rework FTP control response parsing code and fix socket Write misuse.phajdan.jr@chromium.org2009-07-287-217/+524
| | | | | | | | | | | It also fixes other minor issues in the code, and makes ftp.vim.org work! TEST=Visit ftp.vim.org on Linux with Chromium compiled in Debug mode. You should see directory listing after a short while. BUG=http://crbug.com/15792 Review URL: http://codereview.chromium.org/149368 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21881 0039d316-1c4b-4281-b951-d872f2087c98
* "Add Page" window title capitalization was wrong.evan@chromium.org2009-07-281-1/+1
| | | | | | | | | | | (I went through the rest of the .grd to check all the window titles, and filed a bug on the one other bad one.) Spotted by Michael Monreal. Review URL: http://codereview.chromium.org/159533 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21880 0039d316-1c4b-4281-b951-d872f2087c98
* Reenable use of ExecuteScriptInNewWorld.mpcomplete@chromium.org2009-07-284-19/+40
| | | | | | | | | | | I didn't even realize I checked in the code that disabled it. BUG=no TEST=no Review URL: http://codereview.chromium.org/159454 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21878 0039d316-1c4b-4281-b951-d872f2087c98
* Pipeline will execute a callback whenever an run-time error has happened.kylep@chromium.org2009-07-285-1/+77
| | | | | | | | BUG=16738 TEST=pipeline_impl_unittest.cc Review URL: http://codereview.chromium.org/159373 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21877 0039d316-1c4b-4281-b951-d872f2087c98
* Consider "127.0.0.1" and "[::1]" local addresses for the purposes of proxy ↵ericroman@google.com2009-07-283-203/+255
| | | | | | | | | | | bypass. BUG=http://crbug.com/17903 TEST=ProxyServiceTest.IsLocalName Review URL: http://codereview.chromium.org/159526 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21876 0039d316-1c4b-4281-b951-d872f2087c98
* Disable ShowModalDialogTest.BasicTest. Currently #2 flaky test.phajdan.jr@chromium.org2009-07-281-1/+2
| | | | | | | | | TEST=none http://crbug.com/17806 Review URL: http://codereview.chromium.org/160210 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21875 0039d316-1c4b-4281-b951-d872f2087c98
* Moved the logical dependency on Blacklist from URLRequestContextidanan@chromium.org2009-07-285-14/+17
| | | | | | | | | | | to ChromeURLRequestContext. BUG=16932 TEST=none Review URL: http://codereview.chromium.org/159519 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21874 0039d316-1c4b-4281-b951-d872f2087c98
* Remove *.vsprops files that are no longer referenced (or only havesgk@google.com2009-07-2856-711/+0
| | | | | | | | | references to each other) anywhere in the Chromium code base. BUG=none TEST=rebuild Review URL: http://codereview.chromium.org/159523 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21873 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the massive type confusion for ParamTraits in the IPC code.deanm@chromium.org2009-07-281-49/+22
| | | | | | | | | | | | | By using non-primitive types (like size_t), we are constantly having problems with duplicate definitions for the same type. Just implement all of the IPC using the primitive types (int, long, etc), and there is no confusion. Also fix a bunch of incorrect format specifiers. Review URL: http://codereview.chromium.org/159520 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21872 0039d316-1c4b-4281-b951-d872f2087c98
* Turn on metrics reporting on POSIX if user has consented.jeremy@chromium.org2009-07-283-8/+10
| | | | | | Review URL: http://codereview.chromium.org/159512 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21871 0039d316-1c4b-4281-b951-d872f2087c98
* Fix proxy settings for Gnome >=2.26mattm@chromium.org2009-07-281-3/+33
| | | | | | | | | | | | | | | | | Proxy settings are set using Gnome's network properties dialog, by running the binary directly. The binary was renamed from gnome-system-preferences to gnome-system-properties in Janurary 2009, so to ensure the dialog works on both newer and older systems, this patch searches the users PATH for the binary to use. Upstream rename: http://git.gnome.org/cgit/gnome-control-center/commit/?id=4f1b6aafba338a267b6c1b911ceb33358b2eca09 BUG=17756 TEST='Under the Hood' -> 'Change proxy settings' still works on Ubuntu Hardy as well as Ubuntu Jaunty. Review URL: http://codereview.chromium.org/160146 Patch from Joel Stanley. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21870 0039d316-1c4b-4281-b951-d872f2087c98
* When there are no images to replace a blacklisted page, putting fillerarv@google.com2009-07-282-3/+6
| | | | | | | | | | | | | | | causes a blank spot which no other thumbnail can be dragged to. This will go away on page refresh, but we can easily redraw all items keeping the filler in the rightmost indices. Original patch by pierre.lafayette@gmail.com, http://codereview.chromium.org/160152 BUG=17738 r=me git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21869 0039d316-1c4b-4281-b951-d872f2087c98
* Cherrypick valgrind patch to fix thinko that keptdkegel@google.com2009-07-282-0/+22
| | | | | | | | | | leak suppressions from being tallied. BUG=17890 TEST=run sh tools/valgrind/chrome_tests.sh -t base --tool_flags="--nocleanup_on_exit" & look at <suppcounts> in valgrind.tmp/* before and after sh tools/valgrind/build-valgrind-for-chromium.sh, verify leak suppressions show up after. Review URL: http://codereview.chromium.org/160275 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21868 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-19 06:31:14 +0000