summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* views: [accessibility] Add accessible name for the Close button in generic ↵ctguil@chromium.org2010-03-222-1/+8
| | | | | | | | | | | | Window. BUG=9614 TEST=open AccExplorer, open a dialog window, point it to the Close button in the top-right corner, see if it shows Close as the accessible name. Patch from Thiago Farina <thiago.farina@gmail.com> Review URL: http://codereview.chromium.org/1155005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42270 0039d316-1c4b-4281-b951-d872f2087c98
* Add the option of importing bookmarks from file to first run.huanr@chromium.org2010-03-225-7/+63
| | | | | | | | | BUG=32728 TEST=run with --import-from-file Review URL: http://codereview.chromium.org/1077007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42266 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor Directory/Directory::Kernel to eliminate some duplicate variable ↵nick@chromium.org2010-03-222-51/+49
| | | | | | | | | | | | | declarations. Add a PersistedKernelInfo member to the directory kernel, rather than having parallel members. BUG=37331 TEST=unit tests. Review URL: http://codereview.chromium.org/1078004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42265 0039d316-1c4b-4281-b951-d872f2087c98
* Enable DOM paste for extensions with clipboard access.dcheng@chromium.org2010-03-222-0/+8
| | | | | | | | | BUG=none TEST=browser_tests.exe --gtest_filter=ExtensionApiTest.Clipboard Review URL: http://codereview.chromium.org/1121004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42264 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Draw the icons within the browser actions overflow menu. Also...andybons@chromium.org2010-03-223-40/+137
| | | | | | | | | | | | | | | o Fix an issue where the grippy was too far to the right when no browser actions were shown. o Maintain the correct order of extensions within the overflow menu. Still to be done: o Animating once resize is complete. o Syncing the size of the container accross windows. TEST=none BUG=32101 Review URL: http://codereview.chromium.org/1165002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42263 0039d316-1c4b-4281-b951-d872f2087c98
* Make gfx::Font use callbacks to perform locale-dependent font adjustments. ↵ben@chromium.org2010-03-226-12/+44
| | | | | | | | | | | Also cleans up some of the last remaining l10n_util usages within app/gfx in preparation for moving these files to toplevel gfx. BUG=none TEST=none Review URL: http://codereview.chromium.org/1110008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42262 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Linux shared library build.mmoss@google.com2010-03-221-0/+8
| | | | | | | | r42182 moved some gtk code into a library that didn't link gtk libs. Review URL: http://codereview.chromium.org/1074007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42261 0039d316-1c4b-4281-b951-d872f2087c98
* Integration with Toolbar autofill servers.georgey@chromium.org2010-03-227-25/+330
| | | | | | | | | | | | | Still to do: 1. Update upload rates based on response 2. Differentiate autofilled/not uploads 3. Do not query if there is no items in autofill 4. Fix forms to correspond to the data queried by toolbar BUG=none TEST=Should request data from toolbar servers Review URL: http://codereview.chromium.org/1119004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42260 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed a build break of an offical build using VS2008.mad@chromium.org2010-03-221-0/+1
| | | | | | | | | | | | | | | Even though our 'real' official builds are still done with VS2005, we started experimenting with VS 2008, and got a link error in reliability tests. For some reason linking indirectly with WebKit takes more space than having an explicit dependency. Without this change, we get this error: fatal error C1083: Cannot open compiler intermediate file: '.\release\lib\webcore.lib': Not enough space LINK : fatal error LNK1257: code generation failed BUG=none TEST=none Review URL: http://codereview.chromium.org/1075013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42258 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate a race between the syncerthread delivering PAUSEDnick@chromium.org2010-03-221-11/+11
| | | | | | | | notifications and the syncmanager subscribing to them. Review URL: http://codereview.chromium.org/1096006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42257 0039d316-1c4b-4281-b951-d872f2087c98
* Rewrite/clean up a bunch of label.cc to fix the following problems:pkasting@chromium.org2010-03-224-325/+220
| | | | | | | | | | | | | | | | | | * Focus rects on single-line labels could be the wrong height. Turns out SizeStringInt() doesn't adjust the height of a single-line string because it assumes you know your font's height. Passing in a default height of the font height fixed this. * Remove a bunch of confusing code/functions that did totally different things in single- and multi-line mode, and make things handle both modes and do what you'd expect. * Make functions be in the same order in the header and .cc files. * Make several things const. * Simplify. BUG=38679 TEST=Radio buttons in content blocked bubbles do not produce weird-looking focus rects when clicked. The third page of the Options dialog lays out correctly, and checkboxes don't produce too-wide focus rects when clicked. In RTL languages, the Options dialog still looks right, with no string clipping. Review URL: http://codereview.chromium.org/1072007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42256 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash with "ATTACH 12345 as db". Believed to not have security impact.cevans@chromium.org2010-03-223-0/+25
| | | | | | | | | BUG=38745 TEST="ATTACH 12345 as db" Review URL: http://codereview.chromium.org/1108003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42255 0039d316-1c4b-4281-b951-d872f2087c98
* Don't run DirectoryListerTest.* as welltimurrrr@chromium.org2010-03-221-1/+1
| | | | | | | | BUG=38926 TBR=glider Review URL: http://codereview.chromium.org/1123006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42254 0039d316-1c4b-4281-b951-d872f2087c98
* views: [accessibility] Fix the first three issues pointed in the bug for the ↵ctguil@chromium.org2010-03-221-2/+4
| | | | | | | | | | | | | Report Bug dialog. BUG=9614 TEST=see bug Patch from Thiago Farina <thiago.farina@gmail.com> Review URL: http://codereview.chromium.org/1154002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42253 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit merge 56312:56350 (disables a work test due to ↵japhet@chromium.org2010-03-222-2/+3
| | | | | | | | | | | | http://trac.webkit.org/changeset/56329) BUG=38918 TEST=none TBR=ajwong Review URL: http://codereview.chromium.org/1098008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42251 0039d316-1c4b-4281-b951-d872f2087c98
* Use the new number-of-browser-actions pref instead of width-in-pixels tompcomplete@chromium.org2010-03-222-37/+49
| | | | | | | | | | | save and restore the browser action toolbar's size. Linux already does this. Also fixes a regression where Windows would ignore the pref and always show all browser actions on startup. Review URL: http://codereview.chromium.org/1081009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42250 0039d316-1c4b-4281-b951-d872f2087c98
* Don't touch the pasteboard when the browser may be shutting downjrg@chromium.org2010-03-221-1/+3
| | | | | | | | | | | (bookmark model being deleted). BUG=38665 Review URL: http://codereview.chromium.org/1165001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42249 0039d316-1c4b-4281-b951-d872f2087c98
* Allowing MSI mode detection to work from the master preferences file. robertshield@chromium.org2010-03-2218-233/+373
| | | | | | | | | | | | | | | | Refactor the piece of master preferences code that was in setup_util.h|cc (setup) into master_preferences.h|cc (install_util). This adds an install_util -> googleurl dependency, which should to be fine. Add in master_preferences_dummy.cc to keep the nacl64 stuff compiling happily. Add values.h|cc to the portion of base built in 64 bit mode and add a minor fix to values.cc to make it build. Also refactor accompanying master_preferences test code from setup tests to install_util tests. BUG=19370 Review URL: http://codereview.chromium.org/979003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42248 0039d316-1c4b-4281-b951-d872f2087c98
* PBKDF2 implemetation using NSS.albertb@chromium.org2010-03-2214-30/+358
| | | | | | | | | BUG=none TEST=unit test Review URL: http://codereview.chromium.org/1024001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42247 0039d316-1c4b-4281-b951-d872f2087c98
* Make various types of input work better with ctrl-enter. If we detected ↵pkasting@chromium.org2010-03-227-94/+139
| | | | | | | | | | that the hostname without adding the TLD was illegal, we'd sometimes fail to allow the TLD to be added. BUG=38605 TEST=Should be able to hit ctrl-enter on "401k" and "999999999999" to open them with www. and .com attached. Review URL: http://codereview.chromium.org/1088004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42246 0039d316-1c4b-4281-b951-d872f2087c98
* Check in new icons for omnibox security changes alone, so that my patch to ↵pkasting@chromium.org2010-03-224-0/+0
| | | | | | | | | | | actually use them can be tested on the tryservers. BUG=27570 TEST=none TBR=sky Review URL: http://codereview.chromium.org/1167002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42245 0039d316-1c4b-4281-b951-d872f2087c98
* Remove files from the project that haven't existed since r40783.avi@chromium.org2010-03-221-2/+0
| | | | | | Review URL: http://codereview.chromium.org/1134006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42243 0039d316-1c4b-4281-b951-d872f2087c98
* Disable DirectoryLister.* on TSan/Mactimurrrr@chromium.org2010-03-221-0/+4
| | | | | | | | BUG=38926 TBR=glider Review URL: http://codereview.chromium.org/1142009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42242 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup testing objects.vandebo@chromium.org2010-03-221-13/+13
| | | | | | | | | BUG=NONE TEST=Heapchecker errors eliminated Review URL: http://codereview.chromium.org/1108004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42241 0039d316-1c4b-4281-b951-d872f2087c98
* ChromeFrame net tests would crash on startup while initializing the ↵ananta@chromium.org2010-03-221-1/+4
| | | | | | | | | | | | | extensions service. The crash occured while dereferencing a NULL manifest. Fix is to check for the same and avoid initializing the extension if we don't have a manifest. TBR=aa Review URL: http://codereview.chromium.org/1107013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42240 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Keyboard accessibility for the page and app menus.", rev 42234 and ↵maruel@chromium.org2010-03-2240-807/+52
| | | | | | | | | | 42236. TBR=dmazzoni Review URL: http://codereview.chromium.org/1158004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42239 0039d316-1c4b-4281-b951-d872f2087c98
* Add unit test to check for zero length dir in FTP PWD response. inferno@chromium.org2010-03-221-0/+11
| | | | | | | | BUG=38845 TEST=FtpNetworkTransactionTest.ZeroLengthDirInPWD Review URL: http://codereview.chromium.org/1166001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42238 0039d316-1c4b-4281-b951-d872f2087c98
* Fix typo in Mac mergedmazzoni@chromium.org2010-03-221-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42236 0039d316-1c4b-4281-b951-d872f2087c98
* Extended the suppression for 30547 (leak destroying BookmarkModel)glider@chromium.org2010-03-221-1/+19
| | | | | | | | | | | | Suppressed bug 38895 (leaks in KeywordEditorView::SetColumnValues) Suppressed bug 18698 (leak in IPC::ChannelProxy::Context::OnAddFilter) BUG=30547,38895,18698 TBR=timurrrr Review URL: http://codereview.chromium.org/1157004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42235 0039d316-1c4b-4281-b951-d872f2087c98
* Keyboard accessibility for the page and app menus.dmazzoni@chromium.org2010-03-2240-52/+807
| | | | | | | | | | | | | | | | | | | | | | | | | | Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility ui test. Review URL: http://codereview.chromium.org/660323 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42234 0039d316-1c4b-4281-b951-d872f2087c98
* Update expectations for xpdual/moz/vm_peak_*.chase@chromium.org2010-03-221-2/+2
| | | | | | | | | | | | | | | There was a vm_peak_* improvement recently, possibly caused by WebKit roll in r42192, 56306:56312, but more likely due to an infrastructure change made by maruel around r42200. BUG=none TEST=moz perf step is green TBR=nsylvain@chromium.org Review URL: http://codereview.chromium.org/1142008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42233 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the dependency on layout_package.path utils from the heapcheck runnerglider@chromium.org2010-03-222-14/+4
| | | | | | | | | | (see http://codereview.chromium.org/669031) TBR=timurrrr,dpranke Review URL: http://codereview.chromium.org/1167001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42232 0039d316-1c4b-4281-b951-d872f2087c98
* Implement SOCKSClientSocketPoolvandebo@chromium.org2010-03-2225-262/+1183
| | | | | | | | | | | | | | This is the first layered pool, so there are several infrastructure changes in this change as well. Add a ConnectionTimeout method to pools so that layered pools can timeout each phase. Add a name method to pools to support per pool UMA histograms. Change SOCKS sockets to take a ClientSocketHandle instead of a ClientSocket BUG=30357 (blocks an SSL Pool) TEST=existing unit tests Review URL: http://codereview.chromium.org/668097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42231 0039d316-1c4b-4281-b951-d872f2087c98
* Pass the raw history backend pointer to the gmock action rather than the refptr.skrul@chromium.org2010-03-221-1/+1
| | | | | | Review URL: http://codereview.chromium.org/1072009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42230 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug with native text field where if there's a visibility change, the ↵chocobo@chromium.org2010-03-223-26/+18
| | | | | | | | | | native control gets recreated without updating the properties. For chromeos login, the password field becomes a normal textfield. BUG=chromeos:2023 TEST=during login, we should not show the password in the clear. Review URL: http://codereview.chromium.org/1076008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42229 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the order of the context menu in the tabbed bookmark manager.arv@chromium.org2010-03-221-3/+5
| | | | | | | | | | | | | | | The "Delete" menu item should be right after the "Paste" menu item. As it's in the bookmarks bar and in the old bookmarks manager. BUG=None TEST=open the tabbed bookmarks manager and see if the "Delete" menu item is right after the "Paste". Patch from Thiago Farina <thiago.farina@gmail.com> Review URL: http://codereview.chromium.org/1159001 Patch from Thiago Farina <thiago.farina@gmail.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42228 0039d316-1c4b-4281-b951-d872f2087c98
* Merging the translate manager UMA stats from the 249 branch to the trunk.jcampan@chromium.org2010-03-222-0/+11
| | | | | | | | | | | | Original review: http://codereview.chromium.org/853010 BUG=None TEST=None TBR=kuan Review URL: http://codereview.chromium.org/1111006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42227 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r41641 "Make DevTools open docked by default..."xiyuan@chromium.org2010-03-2211-415/+144
| | | | | | | | | | | | | | - Fix DevToolsSanityTest time out. The timeout is because the tests wait for Browser closed notification. However, docked DevTools does not have its own Browser object and hence the wait times out. BUG=none TEST=none Review URL: http://codereview.chromium.org/1025005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42226 0039d316-1c4b-4281-b951-d872f2087c98
* Command-click on a bookmark folder button will now open all injrg@chromium.org2010-03-222-11/+73
| | | | | | | | | | | | | | | | background tabs. BUG=34288 TEST=\ 1) Make sure normal clicking will open bookmarks, bookmark folders. 2) Make sure right-click opens context menus on folders 3) command-click a folder --> opens all the marks in that folder in background tabs Review URL: http://codereview.chromium.org/1115004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42225 0039d316-1c4b-4281-b951-d872f2087c98
* Move importer data types into a separate file to prepare for moving importermirandac@chromium.org2010-03-2240-241/+359
| | | | | | | | | | into its own process. BUG= 18774 TEST= none Review URL: http://codereview.chromium.org/1110005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42224 0039d316-1c4b-4281-b951-d872f2087c98
* Annotated the memory leaks in RSAPrivateKeyUnitTest.* and glider@chromium.org2010-03-222-0/+17
| | | | | | | | | | SignatureCreatorTest.BasicTest. BUG=34742 TBR=wtc Review URL: http://codereview.chromium.org/1117007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42223 0039d316-1c4b-4281-b951-d872f2087c98
* Make SDCH experiment significant on the dev channel populationjar@chromium.org2010-03-221-2/+2
| | | | | | | | | | | | | The experiment was reduced to a low level to avoid impacing much of the standard release population. Now that we've adjusted the definition of the page-load-time metrics, I'd like to see the results of the experiment, and I need a larger participation rate to be visible on the dev channel. r=willchan Review URL: http://codereview.chromium.org/1162001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42222 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up the extensions service after fixing the bug.phajdan.jr@chromium.org2010-03-221-17/+1
| | | | | | | | | | | | | This removes excessive debugging code I added to gather more info about the crashes. They have now disappeared, and the checks obscure the code now. TEST=extension browser tests, unit_tests, etc BUG=30405 Review URL: http://codereview.chromium.org/1078006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42221 0039d316-1c4b-4281-b951-d872f2087c98
* Update V8 to version 2.1.7.whesse@chromium.org2010-03-221-1/+1
| | | | | | Review URL: http://codereview.chromium.org/1155007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42220 0039d316-1c4b-4281-b951-d872f2087c98
* Filtered out ExtensionTest.InitFromValueInvalid from being executed underglider@chromium.org2010-03-221-0/+3
| | | | | | | | | | | ThreadSanitizer on Mac BUG=38889 TBR=timurrrr Review URL: http://codereview.chromium.org/1111009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42219 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Keyboard accessibility for the page and app menus."maruel@chromium.org2010-03-2240-811/+52
| | | | | | | | | | This reverts commit 42217. TBR=dmzazzoni Review URL: http://codereview.chromium.org/1154003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42218 0039d316-1c4b-4281-b951-d872f2087c98
* Keyboard accessibility for the page and app menus.dmazzoni@chromium.org2010-03-2240-52/+811
| | | | | | | | | | | | | | | | | | | | | | | | | | Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility ui test. Review URL: http://codereview.chromium.org/660323 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42217 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed the IPCChannelTest.ChannelProxyTest suppression to match broken stacks.glider@chromium.org2010-03-221-1/+1
| | | | | | | | TBR=timurrrr Review URL: http://codereview.chromium.org/1163002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42216 0039d316-1c4b-4281-b951-d872f2087c98
* Disables temporarily IFramesWithFreshPosition.bulach@chromium.org2010-03-221-1/+3
| | | | | | Review URL: http://codereview.chromium.org/1082009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42215 0039d316-1c4b-4281-b951-d872f2087c98
* Disables Geolocation tests for macbulach@chromium.org2010-03-221-2/+11
| | | | | | | | | | (follow on up http://codereview.chromium.org/1134001) TEST=geolocation_browsertest.cc Review URL: http://codereview.chromium.org/1149007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42214 0039d316-1c4b-4281-b951-d872f2087c98