| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=40284
TEST=Click on a folder in the bookmark bar which itself has subfolders. Move the mouse to hover over a subfolder. Verify that the folder in the bookmark bar remains highlighted. Move the mouse into the subfolder being hovered. Verify that the subfolder button remains highlighted. Move the mouse onto a different bookmark within the main parent folder. Verify that the originally highlighted subfolder is no longer highlighted.
Review URL: http://codereview.chromium.org/1784012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46311 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=42817
TEST=Build the installer and make sure that icons are included.
Review URL: http://codereview.chromium.org/1913001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46309 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=42953
TEST=manual
Review URL: http://codereview.chromium.org/1910001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46308 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TBR=yaar@chromium.org
TEST=none
Review URL: http://codereview.chromium.org/1915001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46307 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1908003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46306 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=26102
Review URL: http://codereview.chromium.org/1893001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46305 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Run chrome, see that autofill is not an option.
Review URL: http://codereview.chromium.org/1833002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46304 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=42904
TEST=run the tests
Review URL: http://codereview.chromium.org/1796010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46303 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
a) fix gripper resize
b) fix browser action drag movement
BUG=42697
TEST=LANG=he_IL chrome
Review URL: http://codereview.chromium.org/1789005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46302 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=build on Linux and ran trybots
BUG=none
Review URL: http://codereview.chromium.org/1833003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46301 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
A font moved directories on Lucid, so support loading the font
from either of those directories.
Review URL: http://codereview.chromium.org/1830003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46300 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
access, already added in webkit as part of fix - https://bugs.webkit.org/show_bug.cgi?id=27751. Enable the setting in Test framework. Also, provide a command-line switch for this setting.
BUG=41654
TEST=None
Review URL: http://codereview.chromium.org/1815005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46299 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
FullTabModeIE_TestMultipleGet and FullTabModeIE_TestPostReissue
tests. These tests expect the last request received to be /quit?OK. However at times it appears that we receive an additional
accept request which ends up failing this test.
Fix is to add a custom function which returns the request associated with a path. Changed the expectations accordingly.
Review URL: http://codereview.chromium.org/1903001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46298 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
will check in tests when machine is working again
TBR=kbr@chromium.org
TEST=none
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46297 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=43129
TEST=Duplicate a nano-tab and observe that a nano-tab is created.
Review URL: http://codereview.chromium.org/1898001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46296 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This changes the implementation such that the extensions_ui now iterates over all the RVHs in the process, rather than maintain an explicit list of ExtensionFunctionDispatchers (live app pages don't have EFDs).
TEST=none
BUG=42605
Review URL: http://codereview.chromium.org/1827002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46295 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
case where it is being run from the current working directory and "."
is not on the PATH.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1896001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46294 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=43115
TEST=CrOS UI Valgrind goes greener.
Review URL: http://codereview.chromium.org/1876002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46293 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
testURLTypes (from Srikanth): test for different URL types - http: https: ftp: javascript:, etc
testDuplicateBookmarks (from Ismail): Verify bookmark duplicates
testBookmarksPersistence (from Deepak): Verify that bookmarks and groups persist browser restart
testSessionRestoreShowBookmarkBar (from Srikanth): Verify restore for bookmark bar visibility
Review URL: http://codereview.chromium.org/1719002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46292 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The tab contents changes are purely cosmetic (readability).
BUG=43114
TEST=Drag a tab in an Extension App Window. It should have a regular sized icon.
Review URL: http://codereview.chromium.org/1889001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46291 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=43099
TEST=visual inspection
Review URL: http://codereview.chromium.org/1839004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46290 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of our image scaling code. In this version it times performance of image scaling using Skia, and using Chromium's own scaler with and without filtering.
BUG=none
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=44950
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45067
Review URL: http://codereview.chromium.org/1518034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46289 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original review:
http://codereview.chromium.org/1826004/show
BUG=40961
TEST=Open a page with a select. Click the select to bring up
the popup. Try moving/resizing the window. The popup
should close when you do.
Review URL: http://codereview.chromium.org/1856003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/26897
TEST=the hung renderer dialog should have the title "Page(s) Unresponsive"
Review URL: http://codereview.chromium.org/1885001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46286 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Enabling this now on the Dev channel will give us better coverage to find any issues we don't know about yet
BUG=38932
TEST='gpu' and 'direct' wmode Flash instances should use CA on 10.6 (renderer CPU should be very low during video playback)
Review URL: http://codereview.chromium.org/1877004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46285 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Patch by seh@chromium.org
http://codereview.chromium.org/1719023/show
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1875001
TBR=scherkus@chromium.org
Review URL: http://codereview.chromium.org/1892001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46283 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ChromeThread. This will allow us to make UrlFetcher independent of ChromeThread and we can then move it to chrome/common.
BUG=None
TEST=UrlFetcher unit-tests
Review URL: http://codereview.chromium.org/1702016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46282 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CommandLine::GetProgram(). Simplify a couple DCHECKs with DCHECK_EQ.
Committing for Shriram Kunchanapalli (kshriram18@gmail.com)
Original code review: http://codereview.chromium.org/413003/show
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1733010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46281 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes I18N issues.
BUG=42537
TEST=manual (English and German)
Review URL: http://codereview.chromium.org/1886001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46280 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=32623,43113
TEST=CrOS Valgrind gets greener.
TBR=wtc
Review URL: http://codereview.chromium.org/1833004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46278 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
problems in particular on Windows XP where the temporary directory
path contains spaces.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1872003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46277 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to notifier.
BUG=None
TEST=None, no functional change.
Review URL: http://codereview.chromium.org/1869002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46276 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=43048
TEST=manual, although couldn't repro original problem
Review URL: http://codereview.chromium.org/1845002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46275 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=43109
TEST=Webkit Mac goes green.
Review URL: http://codereview.chromium.org/1831002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46274 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=33327
TEST=covered by spellcheck_unittest
Review URL: http://codereview.chromium.org/1523017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46273 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/43101
TEST=Close a tab within an Extension Window and reopen it. It should work just like restoring a tab works today.
Review URL: http://codereview.chromium.org/1884001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46272 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
code more readable than using an "overridable" bool argument.
R=jcivelli
BUG=41360
TEST=None. Covered by existing tests.
Review URL: http://codereview.chromium.org/1862002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46271 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Improve GtkChromeShrinkableHBox to show invisible children properly when some children are removed or shrunk.
BUG=42379 gtk_chrome_shrinkable_hbox does not always show children that should be visisble
TEST=See bug report.
Review URL: http://codereview.chromium.org/1703024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46270 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=42153,42965
Review URL: http://codereview.chromium.org/1866002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46269 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1830004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46268 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
xib change: removal of dialog title
BUG=http://crbug.com/26897
TEST=as in bug
Review URL: http://codereview.chromium.org/1861003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46267 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is done by using chrome://newtab/#app-launcher and then map the hash to an attribute which is later used in the CSS. I investigated several alternative methods but they all lead to either a higher memory footprint (due to two copies of the NTP source in memory) or slowdown of NTP. No caching of the resource.
During my refactoring I *accidentally* fixed 35783 so I'm keeping that in there.
BUG=35783
TEST=Launch chrome with a new profile with the app launcher turned on.
Review URL: http://codereview.chromium.org/1846003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46266 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The widget is called "GtkToolbar", not "GtkToolBar". Capitalization
matters. This could have been a simple one character fix, but after looking at
it, I've set the internal-padding to 1 pixel and wrapped the "Other Bookmarks"
button so that it has one pixel of padding above and below it to
match. Otherwise, it can draw into BrowserAction area.
BUG=20495
TEST=Bookmark bar doesn't look ridiculously constrained on Radiance or Ambiance GTK+ theme.
Review URL: http://codereview.chromium.org/1843002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46265 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's not clear how to test this easily
it seems like we an integration test
is needed at some point. I did run the
conformance tests with share_resources
set to true and it rand without crashing.
TEST=unit tests
BUG=none
Review URL: http://codereview.chromium.org/1817002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46264 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
GetOrCreateTabbedBrowser returned this.
BUG=42914
TEST=see bug
Review URL: http://codereview.chromium.org/1812009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46263 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This requires mapping SEC_E_INVALID_TOKEN to ERR_SSL_PROTOCOL_ERROR.
We were mapping SEC_E_INVALID_TOKEN to ERR_UNEXPECTED because
previously I got SEC_E_INVALID_TOKEN when I called
InitializeSecurityContext at the wrong time. If we call
InitializeSecurityContext correctly, SEC_E_INVALID_TOKEN indicates
an invalid SSL record.
R=agl
BUG=42538
TEST=the unit test SSLClientSocketTest.PrematureApplicationData
should pass on Windows.
Review URL: http://codereview.chromium.org/1718022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46260 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=42909
TEST=none
Review URL: http://codereview.chromium.org/1692020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
':' in the drive letter on windows.
2. Fix testCrazyFilenames test for win. Expand crazy_filenames.txt to contain i18n filenames as ascii strings.
3. Disable bookmark_bar.testBookmarkBarVisible on win
4. Get rid of using hashlib module in dowload tests. Since we have the files, it doesn't make sense to compute checksum to verify if 2 files are the same -- direct comparison will do.
Review URL: http://codereview.chromium.org/1780013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46258 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
|browser| would be NULL because we don't check if browser
supports tabstrip. So it would crash on line 2070 of browser.cc.
Also fixed some lint issues with include orders and duplication.
BUG=http://crbug.com/43095
TEST=Open Extension window, duplicate the tab in it (it should not crash).
Review URL: http://codereview.chromium.org/1878001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46256 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=tommi
Review URL: http://codereview.chromium.org/1850002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46255 0039d316-1c4b-4281-b951-d872f2087c98
|