| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is needed to expose crosh process to hterm (if pseudo terminal used for
communication between terminalPrivateApi and crosh process is not controlling, job
control in the crosh process won't work, and it won't be able to e.g. process signals).
TEST=None
BUG=chromium-os:23273
Review URL: https://chromiumcodereview.appspot.com/9176013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118585 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=estade@chromium.org
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/9131023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118584 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also update leveldb's README.chromium file.
BUG=110826
TEST=
Review URL: http://codereview.chromium.org/9176014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118583 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The score for an URL or title was being artificially multiplied in cases where the search term(s) occurred multiple times in the URL and/or page title.
BUG=110893
TEST=Enhanced the unit tests.
Review URL: https://chromiumcodereview.appspot.com/9270024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118582 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move ProfileImplIOData to be destroyed after all extension-related services.
Initialize extension preferences after creating profile services.
BUG=104095
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9131022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Combine method pairs for left/right cursor motion in RenderText{,Linux,Win}, eliminating a lot of duplicate logic. The merged functions use new enums VisualTextDirection {VISUAL_LEFT, VISUAL_RIGHT} and LogicalTextDirection {LOGICAL_PREVIOUS, LOGICAL_NEXT}.
* Make CalculateSubstringBounds and GetSelectionBounds return the result instead of taking it as an out pointer argument.
* Remove Utf16IndexOfAdjacentGrapheme for clarity (it took a UTF-8 index as its argument)
* Delete some unused obsolete methods in RenderText, remove some logging code, and fix some comments.
The logic should be unchanged except that in the Backspace handler in NativeTextfieldViews, cursor_changed is now set to true only if the text changed (like Delete). Formerly it was always set to true, which appears to be a bug.
BUG=none
TEST=existing unit tests
Review URL: http://codereview.chromium.org/8958024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118580 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
issues.
BUG=None
TEST=
Review URL: http://codereview.chromium.org/9226013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118579 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=102563
TEST=manually tested ppapi mouse lock example.
Review URL: http://codereview.chromium.org/9213017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118578 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=darin@chromium.org,jhawkins@chromium.org
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/9186021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118577 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
linker on linux reviewed that glue has a dependency on linux on tcmalloc that wasn't declared. Adding it :).
TBR=tony@chromium.org
R=evan@chromium.org
BUG=none
TEST=webkit_unit_tests links properly with the BFD linker
Review URL: https://chromiumcodereview.appspot.com/9138031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118576 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
for process creation
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9270032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118575 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Re-lands r118489 but with static initializers removed.
BUG=25472, 107880
TEST=net_unittests
R=mmenke
Review URL: http://codereview.chromium.org/9226035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118574 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
rather than looking up chrome.windows.
BUG=110694
TEST=as in bug
Review URL: https://chromiumcodereview.appspot.com/9138009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is part 3 of 3 in a series of patches to remove the unnecessary
SYNC_CYCLE_CONTINUATION sync cycle that follows every commit.
Previously, we would schedule a SYNC_CYCLE_CONTINUATION sync cycle to
retry in case of failure if we detected that the number of unsynced handles
was greater than zero by the time the current sync cycle was complete.
That value was stale; it was updated only at the beginning of the sync
cycle and did not take into account the fact that many handles may have
been committed during the cycle. Every cycle that started with at least
one uncommitted item would result in an extra SYNC_CYCLE_CONTINUATION
(and GetUpdates request to the server) being performed.
The new logic attempts to perform SYNC_CYCLE_CONTINUATION sync cycles only
when necessary. The logic is based on the idea that we should only retry
if we detect a failure. Parts 1 and 2 in this patch series provide a
mechanism for detecting failures. This patch makes it so we schedule
another sync cycle only if that code detects a failure.
Note that the logic being used here does not distinguish between
transient an non-transient errors. We could optimize this code by not
retrying unless we have reason to believe a retry would be a sensible
response to this kind of error. However, the old code did not attempt
to handle different errors differently, so we won't either. The
exponential backoff in SyncScheduler should ensure this doesn't cause
any serious problems.
BUG=94670
TEST=Manual. Trigger sync for a Zipit data type with about:sync open.
Note 'Empty GetUpdates' counter is not incremented with each change.
Review URL: http://codereview.chromium.org/9185031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118572 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
bug=110914, 88574
Review URL: http://codereview.chromium.org/9233019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118571 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
unfortunately the dependency only worked when building chromium in a
chromium checkout and not a webkit-only checkout. This fixes that.
R=piman@chromium.org, ananta@chromium.org
BUG=110910
TEST=build.webkit.org chromium bots can run gyp happily.
Review URL: https://chromiumcodereview.appspot.com/9131026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118570 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=109360
TEST=Pack an extension, and make various errors: missing or bad directory,
existing PEM file, bad PEM file. Each should produce an error message of
the same style as the main Pack Extension dialog. When errors appear, the
main dialog should return once the error is dismissed, and should finally
disappear only upon successful pack or when directly cancelled.
Review URL: http://codereview.chromium.org/9250004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118569 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=110955
TEST=heapcheck is green
Review URL: https://chromiumcodereview.appspot.com/9233022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118568 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Dependent on clipboard.h change in https://chromiumcodereview.appspot.com/9264014
BUG=None
TEST=
Review URL: http://codereview.chromium.org/9226012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118567 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The logic is meaty enough to be factored out.
Add unit tests along the way.
The original patch (crrev.com/118265) was reverted as it introduced
a new static initializer. This version fixed that problem by defining
the constant in the .h file. To be extra careful, replaced
kChunkBufferSize with a member variable chunk_buffer_size_.
BUG=72001
TEST=add unit tests. run tools/linux/dump-static-initializers.py locally to confirm that new static initializers are not introduced.
Review URL: http://codereview.chromium.org/9176009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118566 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
After invoking an interface method this will allow creation from other than
RenderThread.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9265027
TBR=sehr@google.com
Review URL: https://chromiumcodereview.appspot.com/9131027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118565 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
while he was getting content to build as a component.
TBR=jam@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9271016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=cr.ui.List still works as expected
Review URL: http://codereview.chromium.org/9131018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118563 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=106208
TEST=none
Review URL: http://codereview.chromium.org/9192025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118562 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also provided a way to override the default resource name.
BUG=None
TEST=Manual
Review URL: http://codereview.chromium.org/9159022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118561 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9269019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118559 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118558 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=110191
TEST=none
Review URL: http://codereview.chromium.org/9195027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118557 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
registrations for readability.
BUG=none
Review URL: https://chromiumcodereview.appspot.com/9138038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118554 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
After invoking an interface method this will allow creation from other than
RenderThread.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9265027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118553 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Reduces the poll interval for success to 12 hours, and for failures to a maximum of 4 hours.
BUG=110551
Review URL: https://chromiumcodereview.appspot.com/9255033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118551 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We now only consider a tab syncable if it has at least one valid entry, where
valid is true iff the url is valid and the scheme is neither chrome or file.
This avoids syncing tabs with nothing but chrome:// or file:// navigations.
BUG=109301
TEST=unit_tests
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=118198
Review URL: http://codereview.chromium.org/9114015
TBR=zea@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9233021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118549 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: https://chromiumcodereview.appspot.com/9167034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118548 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SSL_ForceHandshake returns wrong positive results after sending
pending data. See https://bugzilla.mozilla.org/show_bug.cgi?id=718554.
Fortunately this bug doesn't affect Chromium because Chromium
compares the return value of SSL_ForceHandshake with SECSuccess (0).
R=agl@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9265015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118547 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reenables delayed firing of canplaythrough for media elements, and fixes
the bug that had been introduced where a video with autoplay=true sometimes
never starts. With this change, a video with autoplay=true should always
(though not necessarily immediately) start playback on its own.
BUG=106480,73609
TEST=media_unitests, manually checking video files in various conditions
Review URL: https://chromiumcodereview.appspot.com/9113023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118546 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Tested manually using poster circle. Used --enable-partial-swap in command line
Review URL: http://codereview.chromium.org/9123020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118545 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=108506
TEST=
Review URL: http://codereview.chromium.org/9192033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118544 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is chrome side of https://bugs.webkit.org/show_bug.cgi?id=76593
This also reverts r118249
BUG=99516
TEST=manually ran Chrome w/accelerated content, DRT, test_shell_tests.
Review URL: http://codereview.chromium.org/9254035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118543 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=jennb@chromium.org
BUG=108171
TEST=
Review URL: http://codereview.chromium.org/9190023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118542 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
from interfering in existing window layout heuristics/animations.
BUG=none
TEST=existing
Review URL: https://chromiumcodereview.appspot.com/9138026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9124021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118540 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118539 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=WebGL conformance tests
R=kbr
Review URL: https://chromiumcodereview.appspot.com/9195032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118538 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The sync_socket creation failure has been fixed so the test should now pass. See bug for details
BUG=103975
TEST=this is a test dammit!
Review URL: http://codereview.chromium.org/9254042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118537 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This causes ~/.profile to be sourced in a Virtual Me2Me session, which the
other Xsession script didn't seem to be doing.
BUG=110825
TEST=Manual
Review URL: https://chromiumcodereview.appspot.com/9192034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118536 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Extends 'aura_builder' target to work on Mac. This excludes bits
that are not currently working.
To build:
ash_shell
aura_demo
aura_unittests
compositor_unittests
To run:
compositor_unittests
webkit_unit_tests
Gyp flags:
'use_aura': 1
BUG=110632, 110627
TEST=Compile 'aura_builder' target on Mac with 'use_aura' bit set.
R=cmp@chromium.org, oshima@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9226024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118535 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
not embedded in the test, but rather are in a separate test data
directory.
They moved to src/chrome/test/data/chromeos/cros
BUG=none
TEST=successfully ran refactored test after a build.
Review URL: http://codereview.chromium.org/9249033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118534 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=99527
TEST=none
Review URL: http://codereview.chromium.org/9141023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118533 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://build.chromium.org/f/chromium/perf/linux-release/dromaeo_jslib/report.html?history=150&rev=118506
TBR=ulan@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9141025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118532 0039d316-1c4b-4281-b951-d872f2087c98
|