summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Connect the 'changed' signal on the label entry and change the expander ↵jhawkins@chromium.org2010-01-201-2/+29
| | | | | | | | | | title as the user types. BUG=none TEST=none Review URL: http://codereview.chromium.org/554012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36602 0039d316-1c4b-4281-b951-d872f2087c98
* Re-revert 36595 (restoring 36548); that didn't fix anything.dpranke@chromium.org2010-01-202-4/+0
| | | | | | | | | | BUG=none TEST=none TBR=thomasvl@chromium.org Review URL: http://codereview.chromium.org/548082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36599 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk: don't crash when a dragged tab gets deleted.estade@chromium.org2010-01-201-0/+8
| | | | | | | | | | | Unfortunately, the more correct seeming gtk_grab_remove(gtk_grab_get_current()); doesn't seem to work. BUG=30592 TEST=see bug Review URL: http://codereview.chromium.org/542139 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36598 0039d316-1c4b-4281-b951-d872f2087c98
* Try reverting r36548 to see if this causes the webkit linux failures todpranke@chromium.org2010-01-202-0/+4
| | | | | | | | | | | | improve. BUG=none TBR=thomasvl@chromium.org TEST=none Review URL: http://codereview.chromium.org/551076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36595 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for back/forward issue with httpequiv patch.tommi@chromium.org2010-01-203-20/+124
| | | | | | | | | | | | After reissuing a cf navigation we now remove the previous entry from the travellog to preserve the correct navigation history. Also updating the BackForward unit tests to expect two pairs of BeforeNavigate/NavigateComplete notification when we transition from IE to CF. TEST=Run *BackForward* unit tests BUG=32550 Review URL: http://codereview.chromium.org/549092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36594 0039d316-1c4b-4281-b951-d872f2087c98
* Missed one mac valgrind suppression last time.dpranke@chromium.org2010-01-201-0/+26
| | | | | | | | | | R=rahulk@chromium.org BUG=36244 TEST=none Review URL: http://codereview.chromium.org/542137 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36593 0039d316-1c4b-4281-b951-d872f2087c98
* Allow link drags from the bookmark manager out to the Gnome desktoptony@chromium.org2010-01-201-5/+6
| | | | | | | | | | | | | (nautilus). This should create a shortcut to the site rather than downloading the file to the desktop. I didn't do this before because of the menu crasher. BUG=24210 Review URL: http://codereview.chromium.org/553024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36592 0039d316-1c4b-4281-b951-d872f2087c98
* Fix (hopefully) the linux64 build issue exposed by Neb's CL.sehr@google.com2010-01-201-0/+4
| | | | | | | | TBR=laforge Review URL: http://codereview.chromium.org/542136 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36590 0039d316-1c4b-4281-b951-d872f2087c98
* Another try at landing this.jcampan@chromium.org2010-01-2016-84/+160
| | | | | | | | | | | | | | | | | | | | | | It caused several tests to fails previously. There was a crasher in some Windows code in the CLD that has been removed by the port of the CLD code to Linux and Mac. That should hopefully make everything work now. Enabling language detection on page load. A memory error has been fixed in the CLD library in the meantime. This should hopefully fixes the crashers in the reliability tests. Note that this version is actually simpler than the original review since the detection is now performed in the renderer. (So the CLD code runs sandboxed.) Original review: http://codereview.chromium.org/492024/show BUG=30662 TEST=Run the unit-tests. TBR=brettw Review URL: http://codereview.chromium.org/552049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36589 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 36586 - Implemented AddressWatchTask for OS X.akalin@chromium.org2010-01-204-169/+1
| | | | | | | | | | | | | | Added some utility methods to ServerConnectionManager. BUG=32430 TEST=Manual testing with a laptop Review URL: http://codereview.chromium.org/543098 TBR=akalin@chromium.org Review URL: http://codereview.chromium.org/546083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36588 0039d316-1c4b-4281-b951-d872f2087c98
* Implemented AddressWatchTask for OS X.akalin@chromium.org2010-01-204-1/+169
| | | | | | | | | | | Added some utility methods to ServerConnectionManager. BUG=32430 TEST=Manual testing with a laptop Review URL: http://codereview.chromium.org/543098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36586 0039d316-1c4b-4281-b951-d872f2087c98
* Allow link drags from the star, bookmarks bar, and bookmark bar menustony@chromium.org2010-01-207-27/+43
| | | | | | | | | | | to the Gnome desktop (nautilus). These should create shortcuts. Other drag operations should be the same as before. BUG=24210 Review URL: http://codereview.chromium.org/548067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36585 0039d316-1c4b-4281-b951-d872f2087c98
* Suppressing pkix memcheck erros.oshima@chromium.org2010-01-201-1/+48
| | | | | | | | | | | | | They are most likely a problem in the library we depend, but I'd like somewone who knows better to look at this before moving this to category 1. BUG=32641 TEST=none Review URL: http://codereview.chromium.org/552053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36584 0039d316-1c4b-4281-b951-d872f2087c98
* Style cleanup of member variable in FindBarGtk.tony@chromium.org2010-01-202-4/+4
| | | | | | | | I missed this during review. Review URL: http://codereview.chromium.org/543112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36583 0039d316-1c4b-4281-b951-d872f2087c98
* Bookmark manager: Implemented new button bar.snej@chromium.org2010-01-205-506/+484
| | | | | | | | | | (Nib changes: Removed toolbar, added segmented control and pop-up button, removed focus highlighting for outline views.) BUG=32442 TEST=Verify activation and behavior of + and - buttons and 'gear' menu items. Review URL: http://codereview.chromium.org/543116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36582 0039d316-1c4b-4281-b951-d872f2087c98
* Fix typo in file.dpranke@chromium.org2010-01-201-1/+0
| | | | | | | | | | BUG=none TBR=rahulk@chromium.org TEST=none Review URL: http://codereview.chromium.org/552054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36581 0039d316-1c4b-4281-b951-d872f2087c98
* Indent menu items in add-bookmark pop-up, to show folder hierarchy.snej@chromium.org2010-01-202-4/+12
| | | | | | | | | BUG=32427 TEST=Click 'star' button; click 'Folder:' pop-up. Verify that menu item indentation matches folder nesting. Review URL: http://codereview.chromium.org/545094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36580 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: respect menu model's radio button groupings.estade@chromium.org2010-01-201-8/+11
| | | | | | | | | | | (don't just group by proximity) BUG=32222 TEST=see bug Review URL: http://codereview.chromium.org/548074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36579 0039d316-1c4b-4281-b951-d872f2087c98
* Posix: try to make signal handler async signal safe again.willchan@chromium.org2010-01-191-31/+104
| | | | | | | | | There used to be freezes in browser_tests and ui_tests on the trybots and buildbots, but I've tried the trybots many times and haven't seen this repro, so I'm going to try committing again. This change is mostly a revert of r35192. Review URL: http://codereview.chromium.org/546035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36577 0039d316-1c4b-4281-b951-d872f2087c98
* relaxing constraintsoshima@chromium.org2010-01-191-3/+2
| | | | | | | | | * tooltip_554686_2 to match the call stack under 32bit environment on 64bit os * 32089 was happening in other tests as well. Review URL: http://codereview.chromium.org/553021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36576 0039d316-1c4b-4281-b951-d872f2087c98
* Add some valgrind suppressions for the mac.dpranke@chromium.org2010-01-191-0/+28
| | | | | | | | | | R=rahulk@chromium.org TEST=none BUG=32644 Review URL: http://codereview.chromium.org/543123 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36575 0039d316-1c4b-4281-b951-d872f2087c98
* Fleshing out the i18n doc. Added a page for the messages.jsonkathyw@chromium.org2010-01-195-30/+1148
| | | | | | | | | | | format (i18n-messages.html). Miscellaneous small improvements to i18n.html and to the generated API doc. TEST=none BUG=none Review URL: http://codereview.chromium.org/546060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36573 0039d316-1c4b-4281-b951-d872f2087c98
* Reverts CHECKs as broke build. I likely need to include base/logging.sky@chromium.org2010-01-191-3/+0
| | | | | | | | | | BUG=25324 TEST=none TBR=brettw@chromium.org Review URL: http://codereview.chromium.org/542129 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36572 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 36565 - Modifying three main samples of docs (gmail checker, news ↵cira@chromium.org2010-01-1913-286/+20
| | | | | | | | | | | | | | feed, subscribe to feed) to i18n versions. Only "news feed" is saved as a separate version to keep the noni18n one. Landing it on behalf of ernestd(at)google.com TBR=finnur TBR=cira@chromium.org Review URL: http://codereview.chromium.org/552052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36571 0039d316-1c4b-4281-b951-d872f2087c98
* Added public copy constructor to AutoFillProfile to allow it to be used in ↵georgey@chromium.org2010-01-192-5/+32
| | | | | | | | | | std containers. TEST=no BUG=none Review URL: http://codereview.chromium.org/553019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36570 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Don't propagate $GNOME_DISABLE_CRASH_DIALOG to external apps.thestig@chromium.org2010-01-191-0/+9
| | | | | | | | BUG=24120 TEST=none Review URL: http://codereview.chromium.org/548071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36569 0039d316-1c4b-4281-b951-d872f2087c98
* adding underscore notation to manifest.json. Also adding spanish dictionary.cira@chromium.org2010-01-193-3/+33
| | | | | | | | | | | See http://codereview.chromium.org/551005 for review. Landing for ernestd(at)google.com TBR=finnur git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36568 0039d316-1c4b-4281-b951-d872f2087c98
* Adds some CHECKs in hopes of figuring out why we're getting crashessky@chromium.org2010-01-191-0/+3
| | | | | | | | | | | during painting. BUG=25324 TEST=none Review URL: http://codereview.chromium.org/543118 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36567 0039d316-1c4b-4281-b951-d872f2087c98
* Modifying three main samples of docs (gmail checker, news feed, subscribe to ↵cira@chromium.org2010-01-1913-20/+286
| | | | | | | | | | | feed) to i18n versions. Only "news feed" is saved as a separate version to keep the non-i18n one. Landing it on behalf of ernestd(at)google.com TBR=finnur git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36565 0039d316-1c4b-4281-b951-d872f2087c98
* Make print styles work again.kathyw@chromium.org2010-01-191-3/+3
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/543073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36563 0039d316-1c4b-4281-b951-d872f2087c98
* Mac bookmark manager: Make URLs editable.snej@chromium.org2010-01-196-12/+80
| | | | | | | | | BUG=32028 TEST=BookmarkItemTest.URL*. Manually: click the URL of a selected item and it will become editable. Type new value and hit Return/Enter. Review URL: http://codereview.chromium.org/551055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36562 0039d316-1c4b-4281-b951-d872f2087c98
* suppressing two new memroy error in chromeos buildoshima@chromium.org2010-01-191-0/+40
| | | | | | | | | BUG=32623,32624 TEST=none Review URL: http://codereview.chromium.org/543108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36561 0039d316-1c4b-4281-b951-d872f2087c98
* Added pglGetCurrentContext. Make gles2 implementation pointer global ↵apatrick@chromium.org2010-01-194-21/+36
| | | | | | | | | | | variable thread local. TEST=none BUG=none Review URL: http://codereview.chromium.org/549090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36560 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk: fix reference counting/destruction of GtkMenu* in MenuGtk. estade@chromium.org2010-01-191-0/+6
| | | | | | | | | | | | | regression caused by r35404 credit to Bryan Yeung for finding the bug BUG=31977, 31765, 32514, 31988 TEST=see bugs Review URL: http://codereview.chromium.org/552044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36559 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed gles2 demo by switching it from a console application to a windowed ↵apatrick@chromium.org2010-01-192-11/+26
| | | | | | | | | | | one. The HINSTANCE it was getting from the console was invalid for some reason. TEST=none BUG=none Review URL: http://codereview.chromium.org/542119 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36558 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Save/restore task manager window pos and size.thakis@chromium.org2010-01-1918-775/+397
| | | | | | | | | | | | | Make window size remembering mechanism easier to use and more compatible with windows's chrome profiles. Nib changes: Unset "show at startup" so that the initial repositioning isn't visible. BUG=32147 TEST=Move & size taskman window, quit chrome, reopen chrome. Size & pos should've stayed. Same for keyword editor. Page info dialog should behave as it did before. Review URL: http://codereview.chromium.org/536086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36557 0039d316-1c4b-4281-b951-d872f2087c98
* Fix json_results_generator to not fail if you have an empty results.jsondpranke@chromium.org2010-01-191-1/+1
| | | | | | | | | | BUG=none TEST=none R=ojan@chromium.org Review URL: http://codereview.chromium.org/542122 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36556 0039d316-1c4b-4281-b951-d872f2087c98
* valgrind: Remove a couple 0 byte patches. Gcl got confused.thestig@chromium.org2010-01-192-0/+0
| | | | | | | BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36555 0039d316-1c4b-4281-b951-d872f2087c98
* (Mac) Intercept (Cocoa) cursor setting by plugins and forward it on properly.avi@chromium.org2010-01-195-5/+82
| | | | | | | | | BUG=http://crbug.com/20717 TEST=as in bug; this covers new Flash Review URL: http://codereview.chromium.org/554003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36554 0039d316-1c4b-4281-b951-d872f2087c98
* Currently the code will recursively call betweenmbelshe@chromium.org2010-01-191-5/+6
| | | | | | | | | | | | | | | | | | | ReadSocket() OnReadComplete() ReadSocket() ... as long as the reads are completing synchronously. This is not a huge problem, but avoiding recursion offsers some robustness and avoids stack blowouts. BUG=none TEST=none Review URL: http://codereview.chromium.org/546071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36553 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r36541 (which went in without any commit log by some magic). Was ↵jshin@chromium.org2010-01-1915-243/+190
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | reverted in r36550. Now I'm relanding with the full description. Port back CLD to Linux and Mac by replacing Windows API calls with ICU's equivalent APIs for normalization. I also fixed bug 23553 (Traditional Chinese is not detected) by calling LanguageCode instead of LanguageCode_ISO_639_1. The latter covers only ISO 639-1, but there are languages detected by CLD not covered by ISO 639-1. In that case, ISO 639-2 is used. In case even ISO 639-2 does not cover (e.g. Traditional Chinese), another fallback is taken by LanguageCode. The html file for CLD testing (french_sentence.html) is explicitly labelled with charset=ISO-8859-1. Original Review: http://codereview.chromium.org/523108 BUG=25206,23553 TEST=1. CLD is built on Linux/Mac 2. The following test pass: - unit_tests: Extension*.DetectTabLang* and CompactLangDet*.* - browser_tests: ExtensionBrowserTest.Toolstrip 3. Install the 'cld extension' in chrome/common/extensions/docs/examples/api/i18n/cld and go to http://news.google.com.tw and 'zh-TW' shows up in the language badge at the upper right (upper-left in he/ar Chrome) corner. TBR=jcampan Review URL: http://codereview.chromium.org/545123 TBR=jshin@chromium.org Review URL: http://codereview.chromium.org/551070 TBR=jshin@chromium.org Review URL: http://codereview.chromium.org/549091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36552 0039d316-1c4b-4281-b951-d872f2087c98
* Converted all demos to use gpu::demos::Example base class.alokp@chromium.org2010-01-196-302/+90
| | | | | | Review URL: http://codereview.chromium.org/542120 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36551 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 36541 (which went in without any commit log by some black magic). jshin@chromium.org2010-01-1915-190/+243
| | | | | | | | | | | | Reland it with the commit log for the record. Review URL: http://codereview.chromium.org/545123 TBR=jshin@chromium.org Review URL: http://codereview.chromium.org/551070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36550 0039d316-1c4b-4281-b951-d872f2087c98
* Use buildtime to ensure stability statsjar@chromium.org2010-01-195-12/+32
| | | | | | | r=huanr Review URL: http://codereview.chromium.org/548058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36549 0039d316-1c4b-4281-b951-d872f2087c98
* Enabled the GetPeerName on all platforms, not just Linux.thomasvl@chromium.org2010-01-192-4/+0
| | | | | | | | BUG=32595 TEST=using a SOCKS5 proxy and a debug build, you don't blow out in a NOTREACHED() any more Review URL: http://codereview.chromium.org/551069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36548 0039d316-1c4b-4281-b951-d872f2087c98
* Implement the remaining UI of the gtk AutoFill dialog.jhawkins@chromium.org2010-01-194-19/+321
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/551065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36547 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a secondary mini_installer target for Chrome Frame. This will remove ↵robertshield@chromium.org2010-01-1918-284/+315
| | | | | | | | | | | | | | the need to have different build scripts to build either Chrome or Chrome Frame. Also remove the now-unneeded gyp variables 'chrome_frame_define' and 'google_update_appid'. BUG=Both Chrome and Chrome Frame products should be buildable from a single solution file - we shouldn't need to run GYP with different settings to get a CF solution. TEST=none Review URL: http://codereview.chromium.org/542078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36546 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Refactors BrowserActionButton to be within its own file, also breaking ↵andybons@chromium.org2010-01-196-228/+257
| | | | | | | | | | a circular dependency on BrowserActionsController. BUG=none TEST=none Review URL: http://codereview.chromium.org/543117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36545 0039d316-1c4b-4281-b951-d872f2087c98
* Port BrowserActionApiTest.BrowserActionPopup to linux.estade@chromium.org2010-01-198-28/+83
| | | | | | | | | | | Also make the test proprely wait for the EXTENSION_HOST_DID_STOP_LOADING signal. BUG=29710 TEST=compiles Review URL: http://codereview.chromium.org/515065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36544 0039d316-1c4b-4281-b951-d872f2087c98
* Created a base class for examples taken from gles2 book. It encapsulates the ↵alokp@chromium.org2010-01-192-50/+90
| | | | | | | | well-defined pattern followed by the examples to eliminate duplicated code. Once we finalize this CL, I will go ahead and change all demos to use this base class. Review URL: http://codereview.chromium.org/543110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36542 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 19:15:15 +0000