| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
See review at:
http://codereview.chromium.org/609010/show
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/657019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39827 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/657032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39826 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/35554
TEST=no visible change in normal mode; incognito mode still being worked on
Review URL: http://codereview.chromium.org/652179
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39825 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add new error code "END_OF_STREAM" and use it in HttpStreamParser.
Update a test to expect failure instead of success on an incomplete stream.
BUG=25032
TEST=updated unittests
Review URL: http://codereview.chromium.org/650190
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39822 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=darin@chromium.org
BUG=none
TEST=valgrind bots don't choke on this.
Review URL: http://codereview.chromium.org/652191
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39821 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
window appropriately. Also register for main status notifications, allowing us to move some code out of BWC and into FSC.
BUG=None
TEST=Fullscreen a window on a 1024x768 monitor. Go into display preferences and change the monitor resolution to something higher. The fullscreen window should continue to fill the whole screen.
Review URL: http://codereview.chromium.org/656020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=valgrind test(2) will cycle green.
Review URL: http://codereview.chromium.org/657009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39819 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Changed it to be a proper class with hidden implementation variables, setters etc.
Also seized this opportunity to move the bypass list from being a member of ProxyConfig, to being a member of ProxyRules. This is a more correct hiearchy, since the bypass rules only apply to the manual settings. Lastly, this makes it possible to have the manual rules evaluation be a method on ProxyRules, and shift some more code out of proxy_service.
Review URL: http://codereview.chromium.org/651070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39818 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
threads in IE.
This causes the histogram snapshots to get corrupted.
Fix is to synchronize access to the function which gathers these histograms.
Fixes bugs http://code.google.com/p/chromium/issues/detail?id=36500
http://code.google.com/p/chromium/issues/detail?id=36510
Bug=36500,36510
Review URL: http://codereview.chromium.org/657023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39817 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=36512
TEST=drag a file out of the downloads page
Review URL: http://codereview.chromium.org/657026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39815 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=darin@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/652184
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39814 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=36616
TBR=dglazkov@chromium.org
TEST=none
Review URL: http://codereview.chromium.org/652183
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39812 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=32402
TEST=See bug.
Review URL: http://codereview.chromium.org/657024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39806 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
page as...' dialog
Adds extension base don MIME type of the page.
Adds capability of the complete save of the "application/xhtml+xml" pages
BUG=34722
TEST=In the bug + try pages with other MIME types, such as "text/xml", "text/plain" or "text/css"
Review URL: http://codereview.chromium.org/650176
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39804 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=34181
TEST=open the exceptions editor, type some text in the host textfield, see the indication.
Review URL: http://codereview.chromium.org/650122
Patch from thiago.farina@gmail.com.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39802 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/657015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39799 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/652165
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39798 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=36605
R=darin@chromium.org
TEST=mac valgrind unit tests
Review URL: http://codereview.chromium.org/652171
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=dpranke
BUG=36602
TEST=none
Review URL: http://codereview.chromium.org/652169
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39795 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
unless the UI language is English.
This is a temporary measure until we're sure that removing English from
the default value of A-L for most non-English locale is safe in terms of
web compatibility.
BUG=36182
TEST=1. Run Chrome in English and go to any English page. Translation info-bar does not show up.
2. Run a non-English version of Chrome and go to any English page. Translation info-bar does show up.
Review URL: http://codereview.chromium.org/652138
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39794 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
sandbox/linux/suid/sandbox.c, in order to make the source more
greppable.
With inconsistent constant names it was harder to find who sends the
message that sandbox.c receives.
http://codereview.chromium.org/652108
(Patch from mseaborn@chromium.org)
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39793 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(Added in WebKit's r55159, rolled in our r39758)
BUG=36585
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39792 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=fschneider
BUG=36602,36604
TEST=none
Review URL: http://codereview.chromium.org/657021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39791 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/657004
TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/657022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=darin@chromium.org
BUG=http://crbug.com/36602
TEST=none
Review URL: http://codereview.chromium.org/652163
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39789 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=24182, 36603
R=darin@chromium.org
TEST=svg/text/text-text-05-t.svg, editing/selection/extend-selection.html
Review URL: http://codereview.chromium.org/657018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39788 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
store. Changes to a user's address and credit card information are now persisted. Other changes are:
- Selectively disables the preferences "Setup autofill..." button when the PersonalDataManager is not available.
- Allows the user to add or remove address or credit card entries in the AutoFill dialog.
- The billing and shipping popup menus in the credit card entries now properly reflect the list of addresses.
Notes on nib changes:
- AutoFillAddressFormView.xib : added Delete button, wired to trigger |deleteAddress:| action.
- AutoFillDialog.xib changed window size to encompass new controls. Added "Add Address" and "Add Credit Card" buttons. Wired them up to |addNewAddress:| and |addNewCreditCard:| actions, respectively.
- Preferences.xib : |autoFillSettingsButton_| outlet wired up to facilitate disabling when no |PersonalDataManager| is available.
- AutoFillCreditCardFormView.xib : added "Delete" button and wired up to |deleteCreditCard:| action. Removed outlets to menus that were only there for temporary disablement reasons. Set up bindings for billing and shipping address menu items and for their selected item.
BUG=33029
TEST=unit_tests --gtest_filter=AutoFillDialogControllerTest.*
Note new: Google Test filter = AutoFillDialogControllerTest.*:AutoFillAddressModelTest.*:AutoFillAddressViewControllerTest.*:AutoFillCreditCardModelTest.*:AutoFillCreditCardViewControllerTest.*:DisclosureViewControllerTest.*:SectionSeparatorViewTest.*:VerticalLayoutViewTest.*
Review URL: http://codereview.chromium.org/650163
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39787 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We're focusing on StartToFinish rather than StartToFinishDoc
for PLT tests. I pulled out teh StartToFinishDoc histograms,
and added one more modulated histogram to look at ratios of
forward to back in various test scenarios.
I also removed the A/B tests for delayed binding.
r=willchan
Review URL: http://codereview.chromium.org/657006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39786 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Added icons to network options page.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/657001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39784 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=36498
TEST=Should see _pyautolib.so & pyautolib.py in http://build.chromium.org/buildbot/continuous/linux/LATEST/chrome-linux.test/
Review URL: http://codereview.chromium.org/652155
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39782 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/652130
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39781 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Sometimes there is not a current context.
TBR=jochen
BUG=36600
TEST=none
Review URL: http://codereview.chromium.org/652158
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39780 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/657004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39779 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
field_count() instead of directly accessing the size of |fields_| because we NULL-terminate the field vector.
BUG=none
TEST=fox.com/24 doesn't crash the browser.
Review URL: http://codereview.chromium.org/657010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39778 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Started failing with WebKit r54823 and passing somewhere in r54962:54989.
BUG=35923
TEST=none
Review URL: http://codereview.chromium.org/650197
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39777 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
OS X 10.6. 10.6 adds two new keyboard layouts where the "m" key has a
different key code than expected. These layouts are "Dvorak - Left" and
"Dvorak - Right".
TEST=unit_tests '--gtest_filter=NSMenuItemAdditionsTest.*' on 10.6
BUG=34784
Review URL: http://codereview.chromium.org/652151
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=36591
Review URL: http://codereview.chromium.org/652146
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39775 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=wtc@chromium.org
BUG=32641
TEST=chromeos valgrind test will no longer see the failure with the following memcheck errors:
-----
Memcheck:Jump
obj:*
...
obj:*
fun:find_objects
fun:find_objects_by_template
fun:nssToken_FindTrustForCertificate
-----
Memcheck:Addr4
...
fun:PR_Unlock
fun:nssSession_ExitMonitor
fun:find_objects
fun:find_objects_by_template
fun:nssToken_FindCertificatesBySubject
fun:nssTrustDomain_FindCertificatesBySubject
fun:nssCertificate_BuildChain
fun:NSSCertificate_BuildChain
fun:CERT_FindCertIssuer
fun:ocsp_CreateCertID
fun:CERT_CreateOCSPCertID
Review URL: http://codereview.chromium.org/650155
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39773 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/656018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39772 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:1625
TEST=Login and go to gmail and confirm you don't need to login again.
Review URL: http://codereview.chromium.org/657005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39771 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
an extension popup was causing the popup to lose focus and
be dismissed, causing other problems.
This CL fixes it on Windows with the following:
- the message box is now parented to the popup, not the tab
- the popup is not disimissed when losing focus to a window for
which it is the owner.
BUG=29147
TEST=Create an extension with a popup that contains a combo-box
and a button to show an alert and confirm box. Click on the
combobox and select an item. Click the button to show the
alert and confirm message box. The popup should not be closed
when you do that.
Review URL: http://codereview.chromium.org/650045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39770 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/652135
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39769 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is not the final UI (the "more info" disclosure triangle is missing), but it's pretty close and, more importantly, functional.
BUG=34894
TEST=Go to Preferences>under the hood>content settings>cookies and select "ask me every time". Then browser around and note that a message box pops up all the time. All the buttons on the message box should do what they claim.
Review URL: http://codereview.chromium.org/650206
TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/652150
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/630009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39765 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the code is fixed.
BUG=34784
TEST=test still runs on mac 10.5 bots
Review URL: http://codereview.chromium.org/652134
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39761 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=34785
TEST=tests still run on the 10.5 bots and passes.
Review URL: http://codereview.chromium.org/652131
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39760 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39759 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39758 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
processing an automation message
to focus through an external tab. Based on the crash dump, it appears that the tab_contents_ member is destroyed
and set to NULL in the context of a call to TabContents::Focus which calls the Windows API SetFocus on the native
HWND, which could dispatch messages like WM_DESTROY for the external tab.
Fix is to add a second NULL check for tab_contents_ after the call to TabContents::Focus. Added a comment
describing this scenario in the code.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=29246
Bug=29246
Review URL: http://codereview.chromium.org/653005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is not the final UI (the "more info" disclosure triangle is missing), but it's pretty close and, more importantly, functional.
BUG=34894
TEST=Go to Preferences->under the hood->content settings->cookies and select "ask me every time". Then browser around and note that a message box pops up all the time. All the buttons on the message box should do what they claim.
Review URL: http://codereview.chromium.org/650206
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39756 0039d316-1c4b-4281-b951-d872f2087c98
|