summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Add UMA calls to record search engine choice during first run.mirandac@chromium.org2010-04-163-0/+73
| | | | | | | | BUG= 37565 TEST= UMA calls should be recorded correctly. Review URL: http://codereview.chromium.org/1528037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44816 0039d316-1c4b-4281-b951-d872f2087c98
* Don't run RSAPrivateKeyUnitTest under ThreadSanitizer on Windowstimurrrr@chromium.org2010-04-161-0/+3
| | | | | | | TBR=glider Review URL: http://codereview.chromium.org/1653008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44815 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: navigate to URL on PRIMARY when middle-clicking the location icon.estade@chromium.org2010-04-165-38/+75
| | | | | | | | | BUG=40610 TEST=manual Review URL: http://codereview.chromium.org/1549043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44814 0039d316-1c4b-4281-b951-d872f2087c98
* Addressed review feedback on previous CL introducing --in-process-webglkbr@google.com2010-04-162-7/+7
| | | | | | | | | | | flag. BUG=39721 TEST=none Review URL: http://codereview.chromium.org/1658007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44813 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 44805 - Make sure GoogleUpdateSettings::GetChromeChannel does not readsiggi@chromium.org2010-04-165-102/+16
| | | | | | | | | | | | | | | | from the wrong section of registry when a peruser install has left some registrations behind. Fix the odd race and other bugs I encountered along the way. BUG=40994 TEST=Unittests in this change. Open about box and look at the channel string. Review URL: http://codereview.chromium.org/1582035 TBR=siggi@chromium.org Review URL: http://codereview.chromium.org/1610034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44812 0039d316-1c4b-4281-b951-d872f2087c98
* Refactored to pass the URLSecurityManager via the HttpAuthFactory class to ↵ahendrickson@chromium.org2010-04-1619-156/+156
| | | | | | | | | | | | | the HttpNetworkSession. Fixed a bug where the command-line whitelist was not being propagated down to the URLSecurityManager. BUG=29596 TEST=None Review URL: http://codereview.chromium.org/1634005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44811 0039d316-1c4b-4281-b951-d872f2087c98
* Add expectations for newly flaky SVG tests resulting from latest webkit roll.ajwong@chromium.org2010-04-161-2/+6
| | | | | | | | TBR=nsylvain Review URL: http://codereview.chromium.org/1629023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44810 0039d316-1c4b-4281-b951-d872f2087c98
* fixing issues with filebrowser namely, namely allowing it to grow on mount, ↵dhg@chromium.org2010-04-167-25/+64
| | | | | | | | | | and fixing download cases so the flow is better. BUG=none TEST=none Review URL: http://codereview.chromium.org/1527036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44808 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes possible crash if the window hosting a menu was closed while thesky@chromium.org2010-04-1621-206/+445
| | | | | | | | | | | | menu was showing. When this happens the window the menu creates is implicitly destroyed (because the parent is going away). BUG=25563 TEST=see bug Review URL: http://codereview.chromium.org/1664001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44807 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure GoogleUpdateSettings::GetChromeChannel does not readsiggi@chromium.org2010-04-165-16/+102
| | | | | | | | | | | | | from the wrong section of registry when a per-user install has left some registrations behind. Fix the odd race and other bugs I encountered along the way. BUG=40994 TEST=Unittests in this change. Open about box and look at the channel string. Review URL: http://codereview.chromium.org/1582035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44805 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Refactor sandbox profiles to use a common base configuration file.jeremy@chromium.org2010-04-168-103/+77
| | | | | | | | | | | Eliminate rule duplication in our sandbox profiles by creating a new common.sb file which we include implicitly at the start of all other sandbox configuration files. BUG=39987 TEST=Chrome on Mac should continue to render pages, all unit tests should pass. Review URL: http://codereview.chromium.org/1656006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44804 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily add expectation fix before rebaselining.ajwong@chromium.org2010-04-161-2/+2
| | | | | | Review URL: http://codereview.chromium.org/1652013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44803 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily add expectation fix before rebaselining.ajwong@chromium.org2010-04-161-0/+2
| | | | | | Review URL: http://codereview.chromium.org/1652013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44802 0039d316-1c4b-4281-b951-d872f2087c98
* Add a test to verify that creating notifications fromaa@chromium.org2010-04-162-6/+2
| | | | | | | | | | extensions using relative URLs works. BUG=39216 Review URL: http://codereview.chromium.org/1528040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44800 0039d316-1c4b-4281-b951-d872f2087c98
* Check if the icon handle has become invalid when the load callback is invoked.zork@chromium.org2010-04-161-1/+5
| | | | | | | | | BUG=40875 TEST=See bug. Review URL: http://codereview.chromium.org/1660004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44799 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug where GetSubtreeBookmarkManagerFunction would crash ifsky@chromium.org2010-04-161-0/+4
| | | | | | | | | | | the node no longer exists. BUG=41630 TEST=see bug Review URL: http://codereview.chromium.org/1521036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44798 0039d316-1c4b-4281-b951-d872f2087c98
* Webkit Roll 57659 -> 57677ajwong@chromium.org2010-04-162-1/+4
| | | | | | Review URL: http://codereview.chromium.org/1572044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44797 0039d316-1c4b-4281-b951-d872f2087c98
* Size TabContents being restored during a session restore.japhet@chromium.org2010-04-161-3/+11
| | | | | | | | | | BUG=40232 TEST=none Review URL: http://codereview.chromium.org/1658004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44792 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Bookmark star missing on NTP and BMM.shess@chromium.org2010-04-162-71/+114
| | | | | | | | | | | | | | | Fix to let bookmark star, page actions, and content settings show up even when there is a search hint. Tries to mimic Windows LocationBarView::Layout() code. Keyword-search mode superceeds the location icon. Keyword-search bubble, search hint, and ssl label can all be omitted if there is not room for them. BUG=40463 TEST=See bug. Review URL: http://codereview.chromium.org/1530038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44789 0039d316-1c4b-4281-b951-d872f2087c98
* Add style to clip children which reduces flashing when the tab control is ↵jcivelli@google.com2010-04-161-1/+2
| | | | | | | | | | | | | | | | resized. The tab control still flashes a little bit but it is only the outer area and not the large content area/child controls. Fixing that probably requires drawing the tab control on our own which is perhaps overkill. BUG=28383 TEST=follow steps given in the bug and resize password manager window, tab should not flicker as much as it did earlier. Original patch by Satish: http://codereview.chromium.org/1646009/show Review URL: http://codereview.chromium.org/1622029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44785 0039d316-1c4b-4281-b951-d872f2087c98
* Mac Bookmarks bar crash hovering from one folder to another.dhollowa@chromium.org2010-04-163-60/+268
| | | | | | | | | | | | | Fix for race condition where the BookmarkBarFolderController was trying to simultaneously open and close its hover view. This code serializes the opening and closing. BUG=40006 TEST=BookmarkBarFolderControllerTest.HoverState Review URL: http://codereview.chromium.org/1593031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44783 0039d316-1c4b-4281-b951-d872f2087c98
* Narrow TSan ignores on Windows a little bittimurrrr@chromium.org2010-04-161-1/+1
| | | | | | | TBR=glider Review URL: http://codereview.chromium.org/1662002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44782 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug where opening an extension options tab from a sole incognito windowmpcomplete@chromium.org2010-04-162-0/+3
| | | | | | | | | | would fail to show the new window. BUG=41526 Review URL: http://codereview.chromium.org/1545041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44781 0039d316-1c4b-4281-b951-d872f2087c98
* A bit wider SpdyNetwork gtest filter for TSan/Wintimurrrr@chromium.org2010-04-161-1/+2
| | | | | | | TBR=glider Review URL: http://codereview.chromium.org/1610033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44780 0039d316-1c4b-4281-b951-d872f2087c98
* Don't run some tests from base_ under ThreadSanitizer on Windowstimurrrr@chromium.org2010-04-161-0/+15
| | | | | | | TBR=glider Review URL: http://codereview.chromium.org/1582034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44779 0039d316-1c4b-4281-b951-d872f2087c98
* Add ability to manipulate DOM elements from the automation proxy. Rework the ↵kkania@chromium.org2010-04-1615-447/+901
| | | | | | | | | | way that javascript is packaged and parsed in the JavascriptExecutionController, and add some waiting methods. BUG=none TEST=none Review URL: http://codereview.chromium.org/1632001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44778 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Centralize hack to make tests work with AutocompleteClassifier.shess@chromium.org2010-04-162-4/+9
| | | | | | | | | | | | | | | | A recent change added AutocompleteClassifier, which had to be hacked into the testing profile to make tests with real location bars work. Unfortunately, more code is tripping over this, so I'm moving the hack to a central location rather than adding it case-by-case. Issue 39725 is about removing the need for this. BUG=39725 TEST=trybots. Review URL: http://codereview.chromium.org/1618028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44775 0039d316-1c4b-4281-b951-d872f2087c98
* code fix for video framejiesun@google.com2010-04-162-72/+63
| | | | | | Review URL: http://codereview.chromium.org/1623011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44774 0039d316-1c4b-4281-b951-d872f2087c98
* Reorganize the Mac plugin host codestuartmorgan@chromium.org2010-04-162-336/+372
| | | | | | | | | | | | | Reorders the Mac WebPluginDelegateImpl code for better findability. The only changes that aren't just moving existing code unchanged are: - The external drag tracking has been consolidated into a helper class. - The Windows-specific comment in Print has been replaced with a NOTIMPLEMENTED(). BUG=none TEST=none; no behavioral change Review URL: http://codereview.chromium.org/1633014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44773 0039d316-1c4b-4281-b951-d872f2087c98
* Adding extra argument DCHECKs to AddressList methods.cbentzel@chromium.org2010-04-162-2/+11
| | | | | | | | | BUG=40796 TEST=net_unittests.exe --gtest_filter="*AddressList*" Review URL: http://codereview.chromium.org/1560028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44772 0039d316-1c4b-4281-b951-d872f2087c98
* views: Implement a TODO to convert all the callers of the deprecatedsatorux@chromium.org2010-04-163-26/+2
| | | | | | | | | | | | | constructor of TableView2 to the new one. BUG=None TEST=out/Debug/unit_tests --gtest_filter=TableView2Test.* Patch from Thiago Farina <thiago.farina@gmail.com> Review URL: http://codereview.chromium.org/1530026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44771 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing dependencies for app_unittests for Linuxglider@chromium.org2010-04-161-0/+1
| | | | | | | | | | (this CL is almost similar to http://codereview.chromium.org/669158, but for other testing binary. We also don't need to fix the Mac dependencies) Review URL: http://codereview.chromium.org/1556010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44769 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 379.0 to 380.0chrome-release@google.com2010-04-161-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44765 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 44762 - Reenable ruby tests.antonm@chromium.org2010-04-161-0/+35
| | | | | | | | | Review URL: http://codereview.chromium.org/1662001 TBR=antonm@chromium.org Review URL: http://codereview.chromium.org/1553037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44763 0039d316-1c4b-4281-b951-d872f2087c98
* Reenable ruby tests.antonm@chromium.org2010-04-161-35/+0
| | | | | | Review URL: http://codereview.chromium.org/1662001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44762 0039d316-1c4b-4281-b951-d872f2087c98
* Remove pattern for fixed bug BUG=40736 from list of known crashes on ↵whesse@chromium.org2010-04-161-4/+0
| | | | | | | | reliability tests. Review URL: http://codereview.chromium.org/1604038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44761 0039d316-1c4b-4281-b951-d872f2087c98
* Filter YUV scaling at half size and below with center of pixelfbarchard@chromium.org2010-04-164-98/+156
| | | | | | | | | BUG=19113 TEST=use playerwtl and reduce size to half and turn filtering on/off. Should look better. Review URL: http://codereview.chromium.org/1625017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44760 0039d316-1c4b-4281-b951-d872f2087c98
* Add the linux_use_debugallocation flag.glider@chromium.org2010-04-162-14/+33
| | | | | | | | | | | Setting this flag to 1 shall force the use of debugallocation.cc instead of tcmalloc.cc The flag is off by default because it still needs testing. BUG=30715 Review URL: http://codereview.chromium.org/1513043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44759 0039d316-1c4b-4281-b951-d872f2087c98
* Widen freetype suppression to match new leaks.jochen@chromium.org2010-04-161-2/+0
| | | | | | | | | | BUG=none TEST=valgrind bots more green R=jochen@chromium.org Review URL: http://codereview.chromium.org/1508038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44758 0039d316-1c4b-4281-b951-d872f2087c98
* Update V8 to version 2.2.3.2. BUG=40736.whesse@chromium.org2010-04-161-1/+1
| | | | | | Review URL: http://codereview.chromium.org/1618025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44757 0039d316-1c4b-4281-b951-d872f2087c98
* This CL makes the translate context menu disabled when thejcivelli@chromium.org2010-04-162-4/+18
| | | | | | | | | | | | | | | page language is the same as the UI language. BUG=39506 TEST=With Chrome configure to be in English, Visit www.google.com. Right click on the page, the context menu "Translate to English" should be disabled. Do the same on www.google.fr, the menu should be enabled. Review URL: http://codereview.chromium.org/1619014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44756 0039d316-1c4b-4281-b951-d872f2087c98
* Improve bookmark bar folder scroll.jrg@chromium.org2010-04-1610-137/+1113
| | | | | | | | | | | | | | | | | | | | | | | | | BUG=39791 TEST=\ Create bookmark folders with various quantites of bookmarks. Make sure normal folders work. Open some that don't fit on the screen. See rounded corners on bottom. Try and move mouse to bottom of screen --> window grows and scrolls. Move mouse to top of screen --> window does NOT change size but does scroll. Move mouse off folder while scrolling --> scrolling stops. Make sure no buttons get "stuck" with a mouse-enter (highlit). Make sure no "getting stuck" or "window scrolls off the screen". Briefly test subfolders. xib changes: - Window content view is now BookmarkBarFolderWindowContentView - BookmaerkBarFolderView now wrapped in an NSScrollView - Some view autosizing changed Review URL: http://codereview.chromium.org/1593025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44755 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill: Skip past non-matching fields when filling out a form where the numberjhawkins@chromium.org2010-04-162-6/+241
| | | | | | | | | | | of FormData fields does not match the number of cached control elements. BUG=41573 TEST=FormManager.FillForm* Review URL: http://codereview.chromium.org/1629020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44748 0039d316-1c4b-4281-b951-d872f2087c98
* Fix expectations for MonikerPatchTest unit testsamit@chromium.org2010-04-161-2/+2
| | | | | | | | | | | | | | | | The contract of the cache stream is changed to return S_FALSE if the data is completely read and this was the last data notification. Adjusted unit test expectations accordingly BUG=none TEST=Tests from MonikerPatchTest TBR=ananta Review URL: http://codereview.chromium.org/1523027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44747 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 44712 - Merge the enableapplauncher flag with the enablenick@chromium.org2010-04-164-2/+6
| | | | | | | | | | | extensionapps flag since we will be using them together. Review URL: http://codereview.chromium.org/1659004 TBR=aa@chromium.org Review URL: http://codereview.chromium.org/1654015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44745 0039d316-1c4b-4281-b951-d872f2087c98
* Fix DCHECK in web_drop_target_win.cc.dcheng@chromium.org2010-04-164-36/+52
| | | | | | | | | | | Relax the DCHECK for asserting that only one drag op is set. WebKit occasionally only sets DragOperationMove to indicate a drag move, even though the usual convention is to set both DragOperationMove and DragOperationGeneric. BUG=41670 TEST=none Review URL: http://codereview.chromium.org/1513044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44742 0039d316-1c4b-4281-b951-d872f2087c98
* Add test for more special tabsnirnimesh@chromium.org2010-04-161-0/+4
| | | | | | Review URL: http://codereview.chromium.org/1594034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44741 0039d316-1c4b-4281-b951-d872f2087c98
* Enable SSE2 compilation for ChromeOS.fbarchard@chromium.org2010-04-161-0/+9
| | | | | | | | | | In practice the <video> tag needs this for faster YUV conversion/filtering. BUG=19113 TEST=Test youtube html5 with chromeos (not chromiumos). It should not crash, and it should be faster. Review URL: http://codereview.chromium.org/1553035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44740 0039d316-1c4b-4281-b951-d872f2087c98
* Made ThemeChangeProcessor handle multiple updates to work aroundakalin@chromium.org2010-04-161-16/+29
| | | | | | | | | | | a problem with the syncapi. BUG=41439 TEST=manual Review URL: http://codereview.chromium.org/1622030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44736 0039d316-1c4b-4281-b951-d872f2087c98
* With the ChromeFrame moniker patch on, the data cache maintained to indicate ↵ananta@chromium.org2010-04-164-13/+16
| | | | | | | | | | | | | | | whether we should switch to Chrome, was not being drained correctly to the delegate, resulting in the delegate continuing to wait for more data when there was none. This caused sites like go/wave to not redirect correctly to CF. Fixes bug http://code.google.com/p/chromium/issues/detail?id=41365 Bug=41365 Review URL: http://codereview.chromium.org/1637017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44735 0039d316-1c4b-4281-b951-d872f2087c98