summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Rename all occurrences of "app extension" with "extension app" since we were ↵aa@chromium.org2010-05-0621-185/+185
| | | | | | | | using both and consistency is nice. Review URL: http://codereview.chromium.org/1924002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46576 0039d316-1c4b-4281-b951-d872f2087c98
* Allows browser tests to run with recent changedavemoore@chromium.org2010-05-062-2/+12
| | | | | | | | | http://codereview.chromium.org/2003001 broke browser tests for login / wizard screens. This fixes them. Review URL: http://codereview.chromium.org/1995005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46575 0039d316-1c4b-4281-b951-d872f2087c98
* Add debugging statement and mark recently-added test as flakydmazzoni@chromium.org2010-05-061-2/+7
| | | | | | | | | | | until we figure out the reason for the failure. BUG=none TEST=none TBR=ctguil@chromium.org Review URL: http://codereview.chromium.org/2004002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46574 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit roll 58855:58879.vitalyr@chromium.org2010-05-061-1/+1
| | | | | | | | | | BUG=none TEST=none TBR=dpranke@chromium.org Review URL: http://codereview.chromium.org/2042001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46573 0039d316-1c4b-4281-b951-d872f2087c98
* Various fixes for the OpenGL ES 2.0 conformance tests.gman@chromium.org2010-05-0619-95/+318
| | | | | | | | | | | | | | Was failing 268 of 1198 Now failing 266 of 1198 ugh! all those changes only fixed 2 tests :-( TEST=some unit test and conformance tests. BUG=none Review URL: http://codereview.chromium.org/1942004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46572 0039d316-1c4b-4281-b951-d872f2087c98
* Removed drek left over from an earlier expirement.mrossetti@chromium.org2010-05-061-3/+0
| | | | | | | | BUG=None TEST=None git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46571 0039d316-1c4b-4281-b951-d872f2087c98
* The button was being told to highlight but then it was not being told it ↵mrossetti@chromium.org2010-05-061-0/+4
| | | | | | | | | | | needed to be redrawn. BUG=43225 TEST=Drag a bookmark into a bar folder and then a subfolder and verify that the buttons in the path to the open subfolder are all highlighted. Review URL: http://codereview.chromium.org/2006001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46570 0039d316-1c4b-4281-b951-d872f2087c98
* Rename some other occurrences of deperecated methods.antonm@chromium.org2010-05-062-2/+2
| | | | | | Review URL: http://codereview.chromium.org/1954002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46569 0039d316-1c4b-4281-b951-d872f2087c98
* Reimplement accessibility of web content by caching the entire dmazzoni@chromium.org2010-05-0626-1173/+5505
| | | | | | | | | | | | | | | | | | | | | | | | | | accessibility tree in the browser process. Adds new RPCs for a browser tab to request accessibility info from a renderer; the renderer responds with a complete tree of accessibility metadata for the entire DOM, which is then cached in the RenderWidgetHostView. This part is cross-platform and will help with accessibility on both Windows and Mac OS X. For Windows, MSAA support for web content has been rewritten to use this new cache. Tested in JAWS and NVDA screen readers. Using Chrome with a screen reader is now fast and stable, unlike the previous implementation. However, note that most advanced functionality is still not supported, and much work remains to make Chrome work well with a screen reader. This is a necessary step to improve stability first. BUG=25564 BUG=13291 TEST=See http://codereview.chromium.org/1806001 Review URL: http://codereview.chromium.org/1637018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46567 0039d316-1c4b-4281-b951-d872f2087c98
* Rollback http://codereview.chromium.org/1820002dpolukhin@chromium.org2010-05-0617-501/+318
| | | | | | | | | BUG=crosbug.com/2800 TEST=none Review URL: http://codereview.chromium.org/2003004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46565 0039d316-1c4b-4281-b951-d872f2087c98
* Add ability to place bubble arrow on left and right side of the bubble or ↵dpolukhin@chromium.org2010-05-0619-318/+501
| | | | | | | | | | | make it float with top edge. BUG=crosbug.com/2800 TEST=Should be no visible changes with info bubble, everything should work as before. Bubble is used for example in bookmarking. Review URL: http://codereview.chromium.org/1820002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46564 0039d316-1c4b-4281-b951-d872f2087c98
* Automatically run valgrind tryjobs for CLs modifying suppression filestimurrrr@chromium.org2010-05-062-3/+13
| | | | | | Review URL: http://codereview.chromium.org/2030001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46563 0039d316-1c4b-4281-b951-d872f2087c98
* Add some defensive checks.yusukes@chromium.org2010-05-061-5/+20
| | | | | | | | | | | Added code that detects array out-of-bounds errors. This should help to debug regressions like http://code.google.com/p/chromium-os/issues/detail?id=2878#c11 . BUG=chromium-os:2878 TEST=see the bug 2878. confirmed that with this change, chrome does not crash. Review URL: http://codereview.chromium.org/2018002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46560 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: keep manual docked state update until corresponding webkit change ↵pfeldman@chromium.org2010-05-061-0/+2
| | | | | | | | lands. Review URL: http://codereview.chromium.org/2036001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46559 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 397.0 to 398.0chrome-release@google.com2010-05-061-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46557 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: inspector tabs are initially drawn in the undocked style even for ↵pfeldman@chromium.org2010-05-062-4/+20
| | | | | | | | | | docked inspectors BUG=40804 Review URL: http://codereview.chromium.org/2009002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46555 0039d316-1c4b-4281-b951-d872f2087c98
* Implement SetCacheMode and CloseCurrentConnections in webkit_support.jochen@chromium.org2010-05-061-0/+6
| | | | | | | | | | | This change makes webkit_glue an independent dynamic library again. BUG=none TEST=compile DumpRenderTree with shared libraries. Review URL: http://codereview.chromium.org/2031001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46554 0039d316-1c4b-4281-b951-d872f2087c98
* Add hooks to fetch about:plugins info for PyAuto.nirnimesh@chromium.org2010-05-066-1/+320
| | | | | | | | | Also, hooks for to enable/disable a plugin. Add a test which excercises them. Review URL: http://codereview.chromium.org/1935003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46553 0039d316-1c4b-4281-b951-d872f2087c98
* A var was not initialized.jcivelli@chromium.org2010-05-061-1/+2
| | | | | | | | | | | | Original review: http://codereview.chromium.org/2016001/show BUG=None TEST=Valgrind bots should be green. Review URL: http://codereview.chromium.org/2025001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46552 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crasher withe the AppLauncher on Linux.jcivelli@chromium.org2010-05-061-0/+4
| | | | | | | | | | | | | | | | | | | | | On Linux, the WidgetGTK destruction is asynchronous. The AppLauncher is deleted when the bubble is closing, but the bubble is deleted when the WidgetGtk is destroyed. So the bubble (and its DOMUI) is going away after the app launcher. Since the app launcher is the TabContentsDelegate of the bubble tab, the deleted app launcher could still be notified. This CL ensures we NULL the TabContents' delegate when the AppLauncher is deleted so it is not accessed. Original review: http://codereview.chromium.org/1985003/show BUG=3068 TEST=On ChromeOS, open the app launcher and close it while it is loading. Try several times, it should not crash. Review URL: http://codereview.chromium.org/1996005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46551 0039d316-1c4b-4281-b951-d872f2087c98
* Escape special characters in installer strings (rc file).tony@chromium.org2010-05-061-1/+5
| | | | | | Review URL: http://codereview.chromium.org/1980006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46549 0039d316-1c4b-4281-b951-d872f2087c98
* Call set_unblock(true) on async resize message to guarantee itskbr@google.com2010-05-061-1/+15
| | | | | | | | | | | | | | | | | processing order relative to sync messages, in particular flush on behalf of SwapBuffers, in the GPU process. This fixes a race condition in WebGL initialization where the back buffer would sometimes not be resized properly. Thanks to jam for the suggestion for this fix. Tested manually by reloading the WebGL image-texture-test demo over 100 times and ensuring it displayed properly each time. BUG=42733 TEST=none Review URL: http://codereview.chromium.org/1914005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46545 0039d316-1c4b-4281-b951-d872f2087c98
* Initial support for web-extent background pages.rafaelw@chromium.org2010-05-0623-73/+494
| | | | | | | | | | | | | | | | | | | | This patch adds a new RVH container: BackgroundContents. The idea is that apps can open a live web-page as a "background" page using window.open('<url>', '<name>', 'background'); If 'background' is specified and the opener is within the app's extent, a BackgroundContents will be used. Otherwise, the 'background' feature is ignored and it is treated as a regular popup call. Note that as of this patch the following are explicitly not-yet addressed: 1) Session storage for BackgroundContents 2) SSL (or other failures) requiring UI 3) Javascript messages (alert, etc...) 4) Session restore TEST=All tests should pass BUG=41275 Review URL: http://codereview.chromium.org/1734014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46544 0039d316-1c4b-4281-b951-d872f2087c98
* Removed some dependencies on sync from GaiaAuthenticator so that it can be ↵sanjeevr@chromium.org2010-05-064-12/+30
| | | | | | | | | | | moved to common. BUG=None TEST=Test Bookmarks Sync Review URL: http://codereview.chromium.org/1964005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46543 0039d316-1c4b-4281-b951-d872f2087c98
* Branded stable channel builds should not display any text after the versionmark@chromium.org2010-05-061-1/+6
| | | | | | | | | | | | | | | | | | | | | number in the About window or about:version. The existing code assumed that KSChannelID would be set to "stable" on the stable channel, but this is incorrect. On the stable channel, KSChannelID is not set at all. Originally, the code was correct, but it broke in r36375. BUG=43357 TEST=1. Check the About window in a stable-channel build. It should show the version number without being adorned by the word "unknown" or any other text. 2. In the same stable-channel builds, visit about:version. The Google Chrome line should show something like 5.0.375.29 (Official Build 46008) without the word "unknown" or any other text. Review URL: http://codereview.chromium.org/1990002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46541 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit roll to r58855.dpranke@chromium.org2010-05-061-1/+1
| | | | | | | | | | BUG=none TEST=none R=none Review URL: http://codereview.chromium.org/2021001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46540 0039d316-1c4b-4281-b951-d872f2087c98
* Tweak the chat manager ifdef condition.scherkus@chromium.org2010-05-061-1/+1
| | | | | | | BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46539 0039d316-1c4b-4281-b951-d872f2087c98
* Kill subprocesses (e.g. unit tests) which appear to be hanging. Use ajrg@chromium.org2010-05-062-7/+210
| | | | | | | | | | | | | | | | | | | mechanism similar to buildbot (e.g. give up if no output from a subprocess within a few minutes). When SIGTERMed (e.g. by buildbot), make an effort to SIGTERM any running subprocess. Should make the coverage bots more resiliant against getting "stuck" (e.g. the "clean" stage won't fail because a running process prevents a directory from being empty). Added some unit tests for the coverage script. BUG=None TEST=Run the coverage script. Review URL: http://codereview.chromium.org/1957004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46538 0039d316-1c4b-4281-b951-d872f2087c98
* NTP: Bounce the app icon after it is installed.arv@chromium.org2010-05-062-24/+57
| | | | | | | | | | | This also has a small fix to the shrink wrap CSS for the launcher. BUG=None TEST=Install an app, the launcher should show up and the icon should bounce. Review URL: http://codereview.chromium.org/2014001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46536 0039d316-1c4b-4281-b951-d872f2087c98
* Add an UMA histogram that counts the types of network error codes that main ↵eroman@chromium.org2010-05-061-0/+20
| | | | | | | | | | | | frame page loads fail with: Net.ErrorCodesForMainFrame BUG=41811 Review URL: http://codereview.chromium.org/1568024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46535 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Use the new ShowAutoFillDialog interface to load imported profiles/CCs injhawkins@chromium.org2010-05-061-7/+18
| | | | | | | | | | | the AutoFill dialog. BUG=none TEST=none Review URL: http://codereview.chromium.org/1988003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46534 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Remove npapi hack from basictypes.h now that npapi.h is fixed."evan@chromium.org2010-05-061-0/+10
| | | | | | | | This reverts commit r46528 because it broke the Chrome Frame build. Chrome Frame: why we can't have nice things. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46533 0039d316-1c4b-4281-b951-d872f2087c98
* Supress valgrind fro SpdyNetworkTransactionTest.PostWithEarlySynReply.mbelshe@chromium.org2010-05-061-0/+1
| | | | | | | | | | BUG=none TEST=none TBR=eroman@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46532 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill: Clean up the server response handling code.jhawkins@chromium.org2010-05-067-68/+88
| | | | | | | | | | | | | * Move the server response handler to FormStructure. * Update the |autofill_count_| when we receive server data. TBR=georgey (vacation) BUG=none TEST=none Review URL: http://codereview.chromium.org/1965002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46530 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill: Fix a renderer crash by resetting the form cache when each WebFramejhawkins@chromium.org2010-05-063-11/+13
| | | | | | | | | | | closes. BUG=43353 TEST=none Review URL: http://codereview.chromium.org/1980004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46529 0039d316-1c4b-4281-b951-d872f2087c98
* Remove npapi hack from basictypes.h now that npapi.h is fixed.evan@chromium.org2010-05-061-10/+0
| | | | | | | | TEST=compiles on trybots Review URL: http://codereview.chromium.org/1954005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46528 0039d316-1c4b-4281-b951-d872f2087c98
* NTP: Fix issue where we have a visual glitch when hovering the thumbnailsarv@chromium.org2010-05-061-2/+3
| | | | | | | | | | | | | We need to set the transition for border-top-left-radius as well border-top-right-radius. Setting the transition to border-radius is not sufficient. BUG=43092 TEST=Hover the thumbnails on the most visited section. There should be no gaps in the upper corners. Review URL: http://codereview.chromium.org/1994001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46527 0039d316-1c4b-4281-b951-d872f2087c98
* Add time for when chrome's main() is called.davemoore@chromium.org2010-05-054-9/+45
| | | | | | | | Also output chrome's time to launch on the login screen. Review URL: http://codereview.chromium.org/2003001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46526 0039d316-1c4b-4281-b951-d872f2087c98
* Do not wrap the original callback if we can;t initialize sniffing cacheamit@chromium.org2010-05-053-16/+20
| | | | | | | | | | | | | | | | CreateStreamOnHGlobal may fail if the underlying GlobalAlloc fails. It has a strange behavaior where if we pass in an HGlobal, it can create more streams per process. So the fix is to: 1. not register us as a bind status callback if we cannot create a stream for sniffing data and 2. When initializing the data sniffing stream pre-create a HGlobal BUG=To be filed TEST=none Review URL: http://codereview.chromium.org/1983002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46525 0039d316-1c4b-4281-b951-d872f2087c98
* Added NetworkChangeNotifierThread interface.akalin@chromium.org2010-05-0512-152/+381
| | | | | | | | | | | | Also made NetworkChange{Observer,Notifier}Proxy use it instead of managing the source message loop and NetworkChangeNotifier themselves. BUG=42606 TEST=unit tests Review URL: http://codereview.chromium.org/1973001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46524 0039d316-1c4b-4281-b951-d872f2087c98
* Cookies would not get set correctly in ChromeFrame in full tab mode. The ↵ananta@chromium.org2010-05-054-26/+85
| | | | | | | | | | | | | | | code to set cookies in IE incorrectly parses the cookies into name value pairs. In this scenario we end up with an empty name string which causes cookies to not get set correctly. It appears that an empty name string is not treated on the same lines as NULL. In any case we should not be doing any parsing and should just set the cookie as is. This fixes bug http://code.google.com/p/chromium/issues/detail?id=42818. Added a unit test to validate this case. Bug=42818 Review URL: http://codereview.chromium.org/1917005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46523 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate non-functional differences between our NPAPI headers and the ↵stuartmorgan@chromium.org2010-05-052-427/+408
| | | | | | | | | | | | | npapi-headers copies This changes only whitespace/comment and file order differences; substantive changes will be done separately. BUG=42645 TEST=None; no behavioral changes. Review URL: http://codereview.chromium.org/2001001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46522 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a unit-test that was crashing on valgrind bot.eroman@chromium.org2010-05-052-6/+15
| | | | | | | | | | | | | The problem is that ClientSocketPoolBaseHelper holds a pointer to a task, and tries to call a method on that pointer during destruction. However, if destruction of ClientSocketPoolBaseHelper occurs during message loop destruction, then pending tasks are deleted, so this "backup_task" pointer that it accesses may be invalid. I worked around the problem here by avoiding this destruction code-path in the unit-test. It would be good to make ClientSocketPoolBaseHelper able to handle this case though. BUG=43291 Review URL: http://codereview.chromium.org/1920003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46521 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug in PRESUBMIT.py because of default argument ordering.maruel@chromium.org2010-05-051-5/+5
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1941004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46520 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill: Use PrefService::FindPreference instead of PrefService::HasPrefPath.jhawkins@chromium.org2010-05-051-1/+1
| | | | | | | | | | | HasPrefPath will crash if the preference is not registered. BUG=42358 TEST=none Review URL: http://codereview.chromium.org/2007002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46519 0039d316-1c4b-4281-b951-d872f2087c98
* Fix leak in SpdyNetworkTransactionTest.CloseWithActiveStream.mbelshe@chromium.org2010-05-052-2/+1
| | | | | | | | | | | | | | The test case identified a case where previously we hung (we didn't close out the stream on the now-dead session). With the fix, we closed the streams, but we didn't remove the session reference, leaving it leaked. The test case did properly catch this. BUG=43179 TEST=SpdyNetworkTransactionTest.CloseWithActiveStream. Review URL: http://codereview.chromium.org/1916004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46518 0039d316-1c4b-4281-b951-d872f2087c98
* Changes DraggedTabController to operate on a View instead of a Tab.sky@chromium.org2010-05-053-27/+25
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1905005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46517 0039d316-1c4b-4281-b951-d872f2087c98
* Update Mac plugins for SetFocus changes, and remove old workaround messagesstuartmorgan@chromium.org2010-05-0518-173/+115
| | | | | | | | | | | | | Now that WebKit is sending unfocus events, rework Mac plugins to correctly track plugin focus as a function of WebKit element focus and window-level view focus. Remove message plumbing for the old workarounds that were used to partially simulate focus switching for Mac plugins. Windows and Linux will currently ignore the new focus loss notifications so their behavior is unchanged. BUG=32721 TEST=Mac plugins should stop reacting to keyboard events once another control on the page, or the omnibox, is focused. They should also regain keyboard focus when switching back to their tab if they had it when the tab was hidden. Review URL: http://codereview.chromium.org/1736007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46516 0039d316-1c4b-4281-b951-d872f2087c98
* When an app window gets a new tab, show the window.skerner@chromium.org2010-05-051-0/+1
| | | | | | | | | BUG=43126 TEST=none Review URL: http://codereview.chromium.org/1999001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46515 0039d316-1c4b-4281-b951-d872f2087c98
* Make the other GetProfile() method public.tommi@chromium.org2010-05-051-2/+9
| | | | | | | | | | | | The way the default profiles, extensions and services are initialized has changed in a way that makes it hard or even impossible to tweak profile preferences before extensions are initialized. For example SafeWeb is initialized as part of referencing the default profile. Upon being initialized, it refers back to the default profile and its preferences (that are currently being constructed), so there's no 'public' way of fetching the default profile, tweak preferences and and _then_ initialize services. However, by allowing calls to GetProfile(path, init_extensions), we can again do two phased profile/extension initialization as we used to. Note that GetProfile(path) is already public. TEST=none BUG=none Review URL: http://codereview.chromium.org/1986001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46512 0039d316-1c4b-4281-b951-d872f2087c98