| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
make: remove redundant LINK definition
ninja+make: complain about 'settings' targets
BUG=96629
Review URL: http://codereview.chromium.org/8008025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102533 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
For context, see http://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/f8d4f43b6e66ab83#
Review URL: http://codereview.chromium.org/8002009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102532 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102529 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
TBR=mihaip@chromium.org
Review URL: http://codereview.chromium.org/8002024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102528 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/96904
BUG=96904
TEST=
Review URL: http://codereview.chromium.org/7967014
TBR=akalin@chromium.org
Review URL: http://codereview.chromium.org/8023001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102527 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
manually duplicating their functionality.
Thanks to Darin Fisher for the suggestion.
I hate to think how it is all implemented internally, but it is not
on the critical path, and code looks much better...
Review URL: http://codereview.chromium.org/7978035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=96629
Review URL: http://codereview.chromium.org/7970010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102523 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
registering.
Fixed up potential slicing in extension_history_api.cc.
Removed unnecessary forward declaration in typed_url_model_associator.h.
BUG=94039
TEST=All unit tests pass.
Review URL: http://codereview.chromium.org/7745055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102521 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=thakis@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8015013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102520 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7917014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102519 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Saving a buffer kicks off an async syntax check and highlights error lines.
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/8008008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102518 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
exclude extension_input_ui_api that is chromeos specific
BUG=97131
TEST=none
Review URL: http://codereview.chromium.org/7966024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102516 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Plus some cleanups:
* Use a lock in PolicyProvider::GetContentSettingValue
* Sanity checks when converting a Value to a ContentSetting.
BUG=88533
TEST=unit tests
Review URL: http://codereview.chromium.org/7992004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102515 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows develoeprs to build from any sln file and not have to rebuild the
world. This is more like how XCode projects are generated.
We choose src/build/{Debug,Release} because this is where all.sln generates
files and this is what the bots use. This shouldn't require any changes to
the bots.
BUG=95278
Review URL: http://codereview.chromium.org/7835006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102514 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=sky@chromium.org
Review URL: http://codereview.chromium.org/7969011
TBR=tfarina@chromium.org
Review URL: http://codereview.chromium.org/8018007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102513 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=sky@chromium.org
Review URL: http://codereview.chromium.org/7969011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
REVIEW=http://codereview.chromium.org/7970019/
TEST=NONE
BUG=NONE
Review URL: http://codereview.chromium.org/7970019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102510 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=85408
TEST=
Review URL: http://codereview.chromium.org/7970017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102509 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The saveAsMHTML allows saving a tab as MHTML.
BUG=97306
TEST=Run the browser tests.
Review URL: http://codereview.chromium.org/7946008
TBR=jcivelli@chromium.org
Review URL: http://codereview.chromium.org/8008020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102508 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Guest session is also considered a "user session".
BUG=chromium-os:18259
TEST=Manual.
Review URL: http://codereview.chromium.org/7966036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102506 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The saveAsMHTML allows saving a tab as MHTML.
BUG=97306
TEST=Run the browser tests.
Review URL: http://codereview.chromium.org/7946008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102505 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
invoked as the result of unloading history. I've convinced myself
ignoring these are ok. If unloading happens before migration TopSites
is going to trigger history to be loaded again to complete migration,
but that's rare and not worth trying to deal with. That said, TopSites
really needs some unload code, but that's a separate issue.
BUG=93721
TEST=covered by tests, but make sure you don't see anything weird with
most visited on new tab page.
R=brettw@chromium.org
Review URL: http://codereview.chromium.org/8005002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102504 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Dr. Memory light mode
BUG=96433
TBR=bruening
Review URL: http://codereview.chromium.org/8022001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102503 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=97131
TEST=none
Review URL: http://codereview.chromium.org/7972025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102501 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the GPU to the browser.
Implements AcceleratedSurfaceContainerTouchOSMesa in the browser's renderer for receiving a GLSurface contents and building a GLTexture in the browser for compositing.
BUG=
TEST=./out/Debug/chrome --use-gl=osmesa --show-fps-counter
Review URL: http://codereview.chromium.org/7980006
Patch from Dana Jansens <danakj@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102500 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=sky@chromium.org
Review URL: http://codereview.chromium.org/7980056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102498 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/87790
R=vangelis@chromium.org
Review URL: http://codereview.chromium.org/7980047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102497 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=83592
TEST=compiles
Review URL: http://codereview.chromium.org/7979015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102493 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=97420
TEST=n/a
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102485 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102484 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
now-separate open source project via DEPS.
BUG=97420
TEST=existing
Review URL: http://codereview.chromium.org/7994005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=mark@chromium.org
Review URL: http://codereview.chromium.org/7966034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
a bit choppy.
Also not to return -1 when the session_id is not set, since MediaStreamManager has not enabled AudioInputDeviceManager yet.
Review URL: http://codereview.chromium.org/7993002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DoubleSplitViewExample.
SplittedView::GetPreferredSize() was returning it's own size,instead of preferred size. Hence new_size was always = divder_offset_ in SingleSplitView::OnMosueDrag(), leading to no Layout() call.
Avoid overriding SplittedView ::GetPreferredSize() to use default implementation.
BUG=none
TEST=Drag second splitter from left to right and then drag same splitter to right
Review URL: http://codereview.chromium.org/7998001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102479 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Pristine condition, original packaging !
Added just README.chromium and LICENSE files
Review URL: http://codereview.chromium.org/7926007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102477 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It looks like http://codereview.chromium.org/7865026 introduced two slight style problems that Clang's chromium-style plugin doesn't appreciate: the destructor isn't virtual, and it's inlined. This CL changes both.
BUG=
TEST=Does Chrome compile with clang/chromium-style?
Review URL: http://codereview.chromium.org/8018001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102476 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7885043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102475 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Conditionalize the ffmpeg dependency and exclude files which rely on it
for the media and media_unittest targets. Disable the ffmpeg_unittests,
ffmpeg_tests and media_bench for Android targets as they require it.
This change also conditionalizes the inclusion of yasm_compile.gyp, as
yasm is only used for the ia32 and x86 target architectures.
BUG=
TEST=
Review URL: http://codereview.chromium.org/7977023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102474 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
new Settings page.
BUG=87377
TEST=None, the page is already inaccessible.
Review URL: http://codereview.chromium.org/7976023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Specific changes:
Add a method to create a new profile to TestingAutomationProvider.
Add a method to open a browser window with a given Profile.
Fix methods in TestingAutomationProvider to use the profile from a browser, instead of the instance variable profile_.
Add a test in ntp.py to make sure ntp pages don't leak between profiles, to test the new methods.
The general idea here is that one can still use profile_ for most tests, but one has the option of creating multiple profiles and opening windows with a specific profile to test multiprofile features.
BUG=87470
TEST=new ntp.py test in CL.
Review URL: http://codereview.chromium.org/7865026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102470 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=97505
TEST=See bug, it has repro steps that work.
Review URL: http://codereview.chromium.org/7989010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102469 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We first post the file enumeration to the FILE thread then get back to the UI
thread to use the profile. InstallCrx makes it's own calls to the FILE thread
to actually install the extensions.
This should also make booting up more responsive as FILE io is done in parallel
to the rest of the boot process.
BUG=97581
TEST=Fire up branded chrome in debug build and observe that the crash described in the bug does not appear.
Review URL: http://codereview.chromium.org/7990002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102466 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:20680
TEST=Manual. Signed in with user who was not whitelisted.
Review URL: http://codereview.chromium.org/7989005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102465 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The leak is a definitive one, even if I do not think this will solve the bug
related.
BUG=97459
TEST=none
Review URL: http://codereview.chromium.org/7979037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102464 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102463 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Mac bookmark editor uses the passed in parent node when editing nodes. This wasn't being passed in correctly after the refactoring.
BUG=97626
TEST=Test editing a bookmark from the bookmark bar on Mac.
Review URL: http://codereview.chromium.org/8012001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102461 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=94936
TEST=profile name column can be selected in Windows task manager.
Review URL: http://codereview.chromium.org/7987001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102458 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added three optional arguments to be used with the new custom control file for the browser tests. The control.custom file has detailed usage of the arguments.
Sample commands to use the parameters,
gtest_filter:
./run_remote_tests.sh --remote host --use_emerged desktopui_BrowserTest.control.custom$ --args 'gtest_filter=PanelBrowserTest.AutoResize gtest_filter=PrintPreviewWebUITest.TestColorSettings:PrintPreviewWebUITest.TestPrinterChangeUpdatesPreview'
This will run only the three specified tests and none else.
gtest_filter works like the --gtest_filter parameter in the regular Chrome browser_tests, plus it can be specified multiple times to specify additional tests
skip_deps:
./run_remote_tests.sh --remote host --use_emerged desktopui_BrowserTest.control.custom$ --args 'skip_deps gtest_filter=PrintPreviewWebUITest.TestColorSettings'
This will run only the one specified test and will not copy over the chrome_test or pyauto dependencies. This is a total of over 550mb of data.
Keep in mind that you need to run run_remote_tests.sh once WITHOUT skip_deps to make sure the deps do initially get on the target device, otherwise your tests will all just fail.
gdbserver:
./run_remote_tests.sh --remote host --use_emerged desktopui_BrowserTest.control.custom$ --args 'skip_deps gtest_filter=PrintPreviewWebUITest.TestColorSettings gdbserver'
This will essentially not copy over the deps, run only the one test, but it will run the test under gdbserver, so your test will pause. Use this option *only* if you are debugging, otherwise you'll have to manually log on and kill the gdbserver instance.
The gdbserver instance will always be created on port 1234. Incoming connections will automatically be opened on the device for that port before gdbserver is started.
Use target remote host:1234 in a gdb instance to connect to the paused test.
The order of any of the arguments is irrelevant.
R=zelidrag@chromium.org,nirnimesh@chromium.org,sosa@chromium.org
BUG=chromium-os:20705
TEST=Tested locally with http://gerrit.chromium.org/gerrit/8130
Review URL: http://codereview.chromium.org/7994011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102457 0039d316-1c4b-4281-b951-d872f2087c98
|