| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
classes.
BUG=chromiumos:3176
TEST=Run out/Debug/unit_tests. Run out/Debug/chrome loginmanager startupmanifest=./chrome/browser/chromeos/testdata/startup_manifest.json. There should be no asserts.
Review URL: http://codereview.chromium.org/2101021
TBR=denisromanov@chromium.org
Build error below. I don't immediately see how this CL caused the
problem, but the only other things on the blamelist are valgrind
suppressions which don't change code.
Linking...
LINK : warning LNK4224: /OPT:NOWIN98 is no longer supported; ignored
Creating library C:\b\slave\chromium-rel-builder\build\src\build\Release\lib\npchrome_frame.lib and object C:\b\slave\chromium-rel-builder\build\src\build\Release\lib\npchrome_frame.exp
chrome_tab.obj : error LNK2001: unresolved external symbol "unsigned int (__stdcall* ATL::g_pfnGetThreadACP)(void)" (?g_pfnGetThreadACP@ATL@@3P6GIXZA)
chrome_frame_ie.lib(chrome_active_document.obj) : error LNK2001: unresolved external symbol "unsigned int (__stdcall* ATL::g_pfnGetThreadACP)(void)" (?g_pfnGetThreadACP@ATL@@3P6GIXZA)
chrome_frame_npapi.lib(utils.obj) : error LNK2001: unresolved external symbol "unsigned int (__stdcall* ATL::g_pfnGetThreadACP)(void)" (?g_pfnGetThreadACP@ATL@@3P6GIXZA)
C:\b\slave\chromium-rel-builder\build\src\build\Release\servers\npchrome_frame.dll : fatal error LNK1120: 1 unresolved externals
Error executing link.exe (tool returned code: 1120)
2 build system warning(s):
- VS settings folder not found
- Interoperability reenabled
Review URL: http://codereview.chromium.org/2224008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Passes locally, fails sometimes on linux 64 bit buildbot, and apparently winxp as well.
BUG=21321
TEST=tree is greener
Review URL: http://codereview.chromium.org/2276008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
<insert_a_suppression_name_here>
Heapcheck:Leak
fun:LinearHistogram::FactoryGet
fun:ClientSocketPoolHistograms
fun:HttpNetworkSession
and
<insert_a_suppression_name_here>
Heapcheck:Leak
fun:Histogram::FactoryGet
fun:Histogram::FactoryGet
fun:ClientSocketPoolHistograms
fun:HttpNetworkSession
BUG=45263
TBR=erikkay@chromium.org
Review URL: http://codereview.chromium.org/2222006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromiumos:3176
TEST=Run out/Debug/unit_tests. Run out/Debug/chrome --login-manager --startup-manifest=./chrome/browser/chromeos/testdata/startup_manifest.json. There should be no asserts.
Review URL: http://codereview.chromium.org/2101021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48424 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=45263
TBR=erikkay@chromium.org
Review URL: http://codereview.chromium.org/2299004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48423 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This should help reduce confusion when reading logs that have a mixture of passive and actively captured events (since there may have been some loss of information along the boundaries).
Review URL: http://codereview.chromium.org/2094020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48420 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=erikkay@chromium.org
Review URL: http://codereview.chromium.org/2317001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48419 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
In particular, explain how it can be used to specify SOCKS v4 / SOCKS v5 proxies, and give some examples.
Review URL: http://codereview.chromium.org/2221006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48418 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- RedirectTest.ClientServerServer passes locally so I'm trying re-enabling it.
- file a bug for RedirectTest.ClientCancelledByNewNavigationAfterProvisionalLoad .
- file a bug for SessionHistoryTest.CrossFrameFormBackForward
- mark SessionHistoryTest.LocationReplace as failing rather than disabled
- fix UnloadTest.BrowserCloseTabWhenOtherTabHasListener (the popup was being caught by the popup blocker)
TEST=buildbots
BUG=12913
Review URL: http://codereview.chromium.org/2264001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48417 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Can't be sure these aren't flaky, but surely they should not be DISABLED.
BUG=21321,14731,19394
Review URL: http://codereview.chromium.org/2230002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48416 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also make one execute significantly faster.
BUG=45021
TEST=they pass consistently
Review URL: http://codereview.chromium.org/2296001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48415 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=erikkay@chromium.org
Review URL: http://codereview.chromium.org/2275006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
questions can contain non-ASCII characters.
They lead the error message to be garbled and an non-ASCII path to turn
empty.
BUG=44145,45009
TEST=See bugs
Review URL: http://codereview.chromium.org/2148004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48413 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On xpdual, adjust morejs times and moz vm_peak_r. The vm_peak_r
change was in WebKit roll 58541:58626.
On mac10.5, adjust intl1 times.
On mac10.6, adjust moz and intl1 times.
On linux-release-hardy, adjust intl2 times.
All were improvements from their last expectations.
BUG=none
TEST=tests are green
TBR=nsylvain@chromium.org
Review URL: http://codereview.chromium.org/2308002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48412 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Redesign IL client state machine to better reflect OpenMAX workflow
2. Remove racing condition
3. Better error handling
4. Add EGLImage support
5. Ready for buffer recycling with video renderer
6. Ready for more feature support such as flushing, pausing
Submitted for: wjia@chromium.org
Reviewed: http://codereview.chromium.org/2143003/show
Review URL: http://codereview.chromium.org/2282002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48411 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GYP files that's needed by r583, but not defined in Chrome. Since Chrome uses its own GYP files for breakpad, we have to duplicate the definition.
Submitting on behalf of hansl@google.com, original change at http://codereview.chromium.org/2290001/show.
BUG=None
TEST=None
TBR=siggi@chromium.org
Review URL: http://codereview.chromium.org/2257006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48407 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
information. Options get uploaded to the cloud print server.
Also added some logging for cups proxy.
BUG=none
TEST=Run linux CP proxy and verify that CUPS options gets uploaded to the cloud print server.
Review URL: http://codereview.chromium.org/2232002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48406 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
LoginScreen.
NewUserView will be reused for other user login on images login screen.
TEST=No visible changes.
BUG=crosbug.com/2320
Review URL: http://codereview.chromium.org/2253004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48405 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
will be enabled at 50% of chance.
BUG=45022
TEST=Use command-line flag --chrome-sxs to force the browser as SxS, go to gmail.com,
login/logout, check about:histograms, you should see xx_spdytrial_xxx histograms.
Review URL: http://codereview.chromium.org/2188001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48404 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ChromeOS needs to be able to show notification before a user logged in (such as battery, update notification).
Currently, all attempt to show notification results in crash because BalloonHost assume all profile has
extension service, which is not the case for login profile that ChromeOS uses.
John, I didn't ifdef'ed because BalloonHost is not assuming extension_function_dispacher is allways present.
Please let me now if I should limit this change to OS_CHROMEOS.
BUG=http://crosbug.com/3491
TEST=none
Review URL: http://codereview.chromium.org/2221003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48403 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Has not failed for 14 days, last failure was May 12.
TBR=jam
TEST=ui_tests
BUG=28372
Review URL: http://codereview.chromium.org/2240007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48402 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Use separate tints for icons in the omnibox and the other icons like page/app menu. We don't pick the tinting color to be the skyline accent color, but instead create one based off the accent color and the contrast between the window background and the label color.
BUG=43853
TEST=1) Darklooks should have white icons (both the page icons and in the omnibox) 2) DarkRoom should have page/app menu icons that match the label color on the "Other Bookmarks" button while the icons in the omnibox which are on a white background should visually be more orange and contrast with the white. 3) Ambiance/Radiance should have icons that contrast with their background instead of fading into it. 4) New Wave should have dark rust orange instead of light neon orange (again, contrasting with the background).
Review URL: http://codereview.chromium.org/2266004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We use to not need them since we would simply overinstall them all the time.
But now that overinstall is allowed and reset the extension state (e.g., close and reopen the background page), we can't simply install exploded extensions at will anymore, we must first check if it was already installed or not (which means GetEnabledExtensions must return them) and only install them when they are not already there.
BUG=0
TEST=none
Review URL: http://codereview.chromium.org/2303004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2299001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
hopefully fix the link step.
BUG=43791
TEST=Mac Valgrind can link sync_unit_tests
Review URL: http://codereview.chromium.org/2276006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48398 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
that's needed by r583, but not defined in Chrome. Since Chrome uses its own GYP files for breakpad, we have to duplicate the definition.
Submitting on behalf of hansl@google.com, original change at http://codereview.chromium.org/2290001/show.
BUG=None
TEST=None
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
windows builds more similar to linux/mac, which already treat signed/
unsigned equality comparisons as warnings (and hence errors).
BUG=44471
TEST=none
Review URL: http://codereview.chromium.org/2222002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48395 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to FAILS
BUG=38572,45168
TEST=N/A
Review URL: http://codereview.chromium.org/2280005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Uses libgps / gpsd to get gps fixes. Modified the location arbitrator to use GPS instead of network location provider.
Current version requires manual code edit to enable (ENABLE_LIBGPS_LOCATION_PROVIDER) See http://docs.google.com/View?id=dfbnm49n_1g8ktswhr for demo instructions (work in progress)
BUG=43868
TEST=Built with ENABLE_LIBGPS_LOCATION_PROVIDER and used gpsd's gpsfake script (see linked doc above)
Review URL: http://codereview.chromium.org/2032010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48393 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=45203
TEST=as described in the bug
Review URL: http://codereview.chromium.org/2265003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Although this doesn't have a behavioral impact in this CL, it is needed for additional logging which I'd like to add.
BUG=34737
TEST=net_unittests
Review URL: http://codereview.chromium.org/2288001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=45050
TEST=see bug
Review URL: http://codereview.chromium.org/2285001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2224003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:3601
TEST=Log in as new user, confirm mouse is faster
(can check with "synclient -l" on the command line...MaxSpeed
should be "1")
TBR:chocobo
Review URL: http://codereview.chromium.org/2296003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Remove modify_database flag.
Make sure we delete data structures on the WebKit thread.
Handle single process mode.
Review URL: http://codereview.chromium.org/2125017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=Compiles
BUG=40286
Review URL: http://codereview.chromium.org/2069016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48385 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=44738
TBR=mbelshe
Review URL: http://codereview.chromium.org/2257004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=45210
TBR=timurrrr
Review URL: http://codereview.chromium.org/2303005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48383 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
make sure that devtools client is detached from devtools agent if inspected render view is closing. It is necessary because render thread may be blocked by a script staying on a breakpoint in which case close message will never be dispatched(close message is posted as a non nestable task so it cannot be processed in the message loop in ScriptDebugServer).
Review URL: http://codereview.chromium.org/2238002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48382 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=glider
Review URL: http://codereview.chromium.org/2266006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48381 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the TSan bot
BUG=45207
TBR=akalin
Review URL: http://codereview.chromium.org/2309002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48378 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
gps.h is required by the geolocation implementation in Chrome to use GPS devices (where available).
(blocking http://codereview.chromium.org/2032010)
BUG=43868
TEST=none
Review URL: http://codereview.chromium.org/2061002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48377 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
and use their FilePath equivalents.
BUG=24874
TEST=included
Review URL: http://codereview.chromium.org/2125021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48376 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48374 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=tony, pkasting
Review URL: http://codereview.chromium.org/2308001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The change in Preferences.xib binds the homepage options container's enabled state to the new property PreferencesWindowController.IsHomepageManaged
BUG=43423
TEST=Manual, especially homepage options on general page of options dialog
Review URL: http://codereview.chromium.org/2059001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48371 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2232003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48370 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=ananta
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/2225006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
on Chromium.
TBR=ben
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/2282005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48368 0039d316-1c4b-4281-b951-d872f2087c98
|