summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Rename Container->Widgetben@chromium.org2008-11-21107-701/+663
| | | | | | | | | R=erg review url = http://codereview.chromium.org/11348/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5849 0039d316-1c4b-4281-b951-d872f2087c98
* Port some files in chrome/common to Linux.evanm@google.com2008-11-217-36/+31
| | | | | | | | | | BUG=3649 Review URL: http://codereview.chromium.org/10255 Patch from Paweł Hajdan jr <phajdan.jr@gmail.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5848 0039d316-1c4b-4281-b951-d872f2087c98
* Remove use of wide characters in stats table identifiers.evanm@google.com2008-11-2124-327/+332
| | | | | | | Review URL: http://codereview.chromium.org/11544 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5847 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issue where NTP metrics for restored tabs weren't getting recorded ↵glen@chromium.org2008-11-212-4/+1
| | | | | | | | | | correctly. BUG=4668 Review URL: http://codereview.chromium.org/11356 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5846 0039d316-1c4b-4281-b951-d872f2087c98
* Move the platform files form port to skia for Mac only. Hopefully this won't ↵brettw@google.com2008-11-2116-48/+57
| | | | | | | | affect other platforms. Review URL: http://codereview.chromium.org/11357 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5845 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes possible crash in creating Browser. The crash could happensky@google.com2008-11-211-0/+5
| | | | | | | | | | | | | | | because its possible for the browserwindow to be null when SaveWindowPlacement is invoked (when the browserwindow is initially created). If the SessionService ends up asking the browser for the browserwindow it would get null and crash. BUG=4666 TEST=no direct way to test this as its rather random. But make sure you don't encounter any problems with session restore. Review URL: http://codereview.chromium.org/11567 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5844 0039d316-1c4b-4281-b951-d872f2087c98
* Build bsdiff.exe, not bsdiff.lib (old, old cut-and-paste error).sgk@google.com2008-11-211-9/+3
| | | | | | Review URL: http://codereview.chromium.org/11572 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5838 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the getintidentifier-special-values.html plugin layout test, which broke ↵ananta@chromium.org2008-11-211-2/+11
| | | | | | | | | | | | | | as a result of change r5829 to fix silverlight windowless plugin issues. One of the changes was to return int32 as the variant type wherever applicable. Firefox does the same and Silverlight does rely on this behavior. This is broken in webkit. I will be filing a bug against webkit. The fix is to support int32 as an incoming NPVariant type in the layout test plugin. TBR=jam Review URL: http://codereview.chromium.org/11574 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5837 0039d316-1c4b-4281-b951-d872f2087c98
* Delete ifdefs which were causing a crash by hiding a NULL check.erg@google.com2008-11-211-2/+0
| | | | | | | Review URL: http://codereview.chromium.org/11355 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5835 0039d316-1c4b-4281-b951-d872f2087c98
* Capture a wow_helper.scons config (close to building, but notsgk@google.com2008-11-212-0/+95
| | | | | | | | worth finishing) with comments about why we don't actually build it (if only to help others avoid confusion in the future). Review URL: http://codereview.chromium.org/11571 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5834 0039d316-1c4b-4281-b951-d872f2087c98
* pull in some upstream code in this forked filepinkerton@google.com2008-11-211-0/+8
| | | | | | Review URL: http://codereview.chromium.org/11570 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5833 0039d316-1c4b-4281-b951-d872f2087c98
* Discard CHAR events if their corresponding KEY_DOWN events triggered ↵pkasting@chromium.org2008-11-212-2/+17
| | | | | | | | | | accelerators. Original patch by Alex Mendes de Costa (alexmdac@gmail.com) on http://codereview.chromium.org/11268, r=me. BUG=91 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5832 0039d316-1c4b-4281-b951-d872f2087c98
* Plumb WebCore's windowResizerRect() through glue and renderer. Enables Mac ↵pinkerton@google.com2008-11-2111-3/+74
| | | | | | | | scrollbars to not overlap the in-window resizer widget. Review URL: http://codereview.chromium.org/11353 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5831 0039d316-1c4b-4281-b951-d872f2087c98
* Wrap MSVC-specific pragmas. As -Wunknown-pragmas has been disabled for wtf,deanm@chromium.org2008-11-2112-19/+57
| | | | | | | | | | some of these sneaked in. BUG=2053 Review URL: http://codereview.chromium.org/11801 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5830 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding this fix. The earlier attempt broke test_shell_tests. The fixananta@chromium.org2008-11-216-10/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | has been added to this CB. Fix Silverlight windowless plugin painting issues. This fixes the following issues:- 1. http://code.google.com/p/chromium/issues/detail?id=4272 2. http://code.google.com/p/chromium/issues/detail?id=301 (Partially) The fixes are as below:- 1. Silverlight in the NPP_HandleEvent call for WM_PAINT, calls NPN_GetProperty for a bunch of properties like pageXOffset, pageYOffset, etc. It expects these properties to have integer types on return. We always return double. Firefox returns integer for these properties. Added a check in the conversion to NPVariant function in v8 to check for whether the value is an integer and return the intger type. 2. When the windowless plugin calls NPN_InvalidateRect we ask the plugin to paint in the same call, which the Silverlight plugin does not like. It relies on the fact that browsers would initiate invalidation asynchronously and eventually paint. This is a perfectly legal assumption. The Flash plugin does work if we synchronously ask it to paint. However other plugins could have similar issues. I verified with worldofwarcraft.com to see if the async paint has any sideeffects and there were none. 3.If the Silverlight plugin is not visible initially as on msdn.microsoft.com, it does not paint. This occurs because the plugin expects proper paints to come from the browser. It does not invalidate itself in UpdateGeometry as Flash. The plugin widget on msdn is not dynamic. It does call NPN_InvalidateRect initially when it is not visible. We don't send the call to the renderer as the plugin is not visible. To workaround this we now track the damaged rect even if the rect does not intersect the clipping rect of the plugin. In a geometry update if the plugin is visible, we send over the accumulated damaged rect to the renderer. The Silverlight plugin instance on msdn.microsoft.com does not work correctly even with these fixes. However it paints correctly. R=jam Bug=4272,301 Review URL: http://codereview.chromium.org/11569 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5829 0039d316-1c4b-4281-b951-d872f2087c98
* only resize the window when running layout tests. Makes it easier to use for ↵pinkerton@google.com2008-11-213-4/+11
| | | | | | | | normal browsing. Review URL: http://codereview.chromium.org/11566 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5826 0039d316-1c4b-4281-b951-d872f2087c98
* Roll deps to pick up r5824 (mac font metrics fix)amanda@chromium.org2008-11-211-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5825 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed all the remaining hardcoded strings in AccessibilityTestsniranjan@google.com2008-11-214-107/+103
| | | | | | | | | | | | Changed the GetRole() and GetState() methods to return DWORD constants instead of strings. We didn't really need the string values of Roles and States and this led us to compare strings in the test cases when we should have been just comparing constants. This change fixes all that. All the accessibility tests should now run on locales other than en-us and as a nice side effect, the tests should run very very marginally faster. TEST=ui_tests.exe --gtest_filter=AccessibilityTest* Review URL: http://codereview.chromium.org/11558 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5821 0039d316-1c4b-4281-b951-d872f2087c98
* Fix use of LOAD= with WantSystemLib() (we could blow up if a variablesgk@google.com2008-11-2116-228/+262
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | hadn't been added to the config) and extend use of LOAD= into submodules: * Add a ChromeLoadSConscriptModules() method that encapsulates the conditional logic, and makes things more readable by specifying component names as keyword arguments, not hard-coding the logic as a series of if-tests. * Put the ChromeLoadSConscriptModules() logic in a Tool module in site_scons/site_tools, so it doesn't clutter up build/SConscript.main directly. * Move env.WantSystemLib() calls into the individual *.scons files, so we call them each time (or not, based one LOAD=) and the config itself just returns if the system library is requested and we don't need to build anything locally. * Move the settings where a library name changes based on whether or not the system lib is being used into the using_*.scons files, so they're available to clients independently of whether or not the component's *.scons configuration is loaded. * While here: rename the affected third_party SConscript files: third_party/libjpeg/SConscript => third_party/libjpeg/libjpeg.scons third_party/libxml/SConscript => third_party/libxml/libxml.scons third_party/libxslt/SConscript => third_party/libxslt/libxslt.scons * While here: move the Chrome{Program,SharedLibrary}() etc. builder definitions from build/SConscript.main to a new too Ad the ChromeLoadSConscriptModules() logic in a Tool module, to remove more clutter from build/SConscript.main. Review URL: http://codereview.chromium.org/11430 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5820 0039d316-1c4b-4281-b951-d872f2087c98
* Only remove -Wall from $CXXFLAGS on Linux, not on Mac. Mac's toolsgk@google.com2008-11-211-1/+1
| | | | | | | chain doesn't add -Wall, leading to an exception and stack trace. Review URL: http://codereview.chromium.org/11343 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5819 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r5816 due to InvokeMethods failures in test_shell_tests.sgk@google.com2008-11-215-34/+9
| | | | | | Review URL: http://codereview.chromium.org/11342 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5818 0039d316-1c4b-4281-b951-d872f2087c98
* Expanding and fleshing out the skelton for RenderThemeGtk::systemFont.mmoss@google.com2008-11-211-2/+68
| | | | | | | | | Far from complete, but so far it makes the controls on www.google.com look better. Review URL: http://codereview.chromium.org/11295 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5817 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Silverlight windowless plugin painting issues. This fixes theananta@chromium.org2008-11-215-9/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | following issues:- 1. http://code.google.com/p/chromium/issues/detail?id=4272 2. http://code.google.com/p/chromium/issues/detail?id=301 (Partially) The fixes are as below:- 1. Silverlight in the NPP_HandleEvent call for WM_PAINT, calls NPN_GetProperty for a bunch of properties like pageXOffset, pageYOffset, etc. It expects these properties to have integer types on return. We always return double. Firefox returns integer for these properties. Added a check in the conversion to NPVariant function in v8 to check for whether the value is an integer and return the intger type. 2. When the windowless plugin calls NPN_InvalidateRect we ask the plugin to paint in the same call, which the Silverlight plugin does not like. It relies on the fact that browsers would initiate invalidation asynchronously and eventually paint. This is a perfectly legal assumption. The Flash plugin does work if we synchronously ask it to paint. However other plugins could have similar issues. I verified with worldofwarcraft.com to see if the async paint has any sideeffects and there were none. 3.If the Silverlight plugin is not visible initially as on msdn.microsoft.com, it does not paint. This occurs because the plugin expects proper paints to come from the browser. It does not invalidate itself in UpdateGeometry as Flash. The plugin widget on msdn is not dynamic. It does call NPN_InvalidateRect initially when it is not visible. We don't send the call to the renderer as the plugin is not visible. To workaround this we now track the damaged rect even if the rect does not intersect the clipping rect of the plugin. In a geometry update if the plugin is visible, we send over the accumulated damaged rect to the renderer. The Silverlight plugin instance on msdn.microsoft.com does not work correctly even with these fixes. However it paints correctly. R=jam Bug=4272,301 Review URL: http://codereview.chromium.org/11492 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5816 0039d316-1c4b-4281-b951-d872f2087c98
* Disable inspector UI test.ojan@google.com2008-11-211-1/+2
| | | | | | Review URL: http://codereview.chromium.org/11340 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5815 0039d316-1c4b-4281-b951-d872f2087c98
* Mark a memory leak from the global plugin list as a knowntc@google.com2008-11-211-0/+255
| | | | | | | | | | | leak. It's always been this way, but when we refactored into chromium bridge as a wtf::vector of pointers, purify started to identify this as a leak. The change that this started happening was r5610. Review URL: http://codereview.chromium.org/11807 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5814 0039d316-1c4b-4281-b951-d872f2087c98
* Allow test_shell to open relative paths, like "test_shell ."dsh@google.com2008-11-211-2/+3
| | | | | | Review URL: http://codereview.chromium.org/11555 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5813 0039d316-1c4b-4281-b951-d872f2087c98
* Add builds of miscellaneous .exes:sgk@google.com2008-11-217-2/+214
| | | | | | | | | | base\debug_message.exe chrome\test\perf\perf_tests.exe chrome\tools\convert_dict\convert_dict.exe chrome\tools\profiles\generate_profile.exe Review URL: http://codereview.chromium.org/11541 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5812 0039d316-1c4b-4281-b951-d872f2087c98
* Update tests lists after 38500:38550 merge. TBR to greenify tree.ojan@google.com2008-11-211-2/+4
| | | | | | Review URL: http://codereview.chromium.org/11557 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5811 0039d316-1c4b-4281-b951-d872f2087c98
* Missed a usage of TestShellRequestContext. This one is allowed to behave asdarin@chromium.org2008-11-211-1/+1
| | | | | | | | | | before. TBR=tony Review URL: http://codereview.chromium.org/11338 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5810 0039d316-1c4b-4281-b951-d872f2087c98
* Link ui_tests against port.lib (where PlatformDeviceWin::InitializeDC moved).sgk@google.com2008-11-211-0/+1
| | | | | | Review URL: http://codereview.chromium.org/11328 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5809 0039d316-1c4b-4281-b951-d872f2087c98
* Landing change by yury.semikhatsky@gmail.com to unfork inspector JS files.ojan@google.com2008-11-2132-12310/+287
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5808 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that we always use a direct connection to the internet when running indarin@chromium.org2008-11-213-9/+17
| | | | | | | | | | | layout test mode. This should help avoid some spurious errors caused by proxy servers. R=tony Review URL: http://codereview.chromium.org/11334 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5807 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to fix linux build. We'll need to upstream this ifojan@google.com2008-11-211-1/+0
| | | | | | | this actually is the problem. Review URL: http://codereview.chromium.org/11556 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5805 0039d316-1c4b-4281-b951-d872f2087c98
* src/webkit side of merge 38500:38550.ojan@google.com2008-11-218-10/+14
| | | | | | Review URL: http://codereview.chromium.org/11551 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5803 0039d316-1c4b-4281-b951-d872f2087c98
* Shim in test_shell string resources needed for http:// tests.deanm@chromium.org2008-11-202-5/+138
| | | | | | | | We eventually need to figure out our localization / resources on Linux, but this will unblock some parallel work for now. Review URL: http://codereview.chromium.org/11553 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5801 0039d316-1c4b-4281-b951-d872f2087c98
* Force the default GTK theme for layout tests.evanm@google.com2008-11-201-1/+9
| | | | | | | Review URL: http://codereview.chromium.org/11456 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5800 0039d316-1c4b-4281-b951-d872f2087c98
* Review URL: http://codereview.chromium.org/11606jcampan@chromium.org2008-11-201-1/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5799 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug where tooltips would get stuck. This was happening becausesky@google.com2008-11-204-1/+10
| | | | | | | | | | | | | | | | | | on Vista we manage showing/hiding tooltips ourself. It would appear when managing our own tooltips like this we need to explicitly hide the tooltip. If you rapidly moved the mouse we wouldn't get a mouse move and the tooltip would stick. The fix is to have ContainerWin forward mouse leave and have the tooltip manager close the tooltip on mouse leave. BUG=2717 TEST=on vista do the following. Add a bookmark to the bookmark bar and hover the mouse over it. Then hit control-b so the bookmark bar disappears. Make sure the tooltip disappears too. Review URL: http://codereview.chromium.org/11540 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5798 0039d316-1c4b-4281-b951-d872f2087c98
* Adds various docking positions when dragging around a tab. I've addedsky@google.com2008-11-2014-112/+1085
| | | | | | | | | | | | | | | | | | | | | | | the ability to dock to the following locations: Maximize the window on drop. Resize the window to fill up the left, bottom, or right half of the monitor. Tile the newly created window with an existing chrome window such that the two are on top of each other and fill the height of the monitor, or tiled such that they fill the width of the monitor. The graphics suxor. Glen says he'll come up with something better once its landed. BUG=none TEST=4628 Review URL: http://codereview.chromium.org/11325 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5797 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding the new autofill.jcampan@chromium.org2008-11-2019-708/+210
| | | | | | | | | I rolled it back yesterday, it broke the Linux and Mac builds. TBR=tim Review URL: http://codereview.chromium.org/11543 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5796 0039d316-1c4b-4281-b951-d872f2087c98
* Fix layout tests that regressed by changing the resize corner. These tests ↵tc@google.com2008-11-2010-24/+60
| | | | | | | | | | needed a new image baseline. The last webkit merge also pulled in a new resize corner test. It's passing except for font differences to I rebaselined that as well. Review URL: http://codereview.chromium.org/11549 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5795 0039d316-1c4b-4281-b951-d872f2087c98
* * fix build errorkuchhal@chromium.org2008-11-201-1/+1
| | | | | | Review URL: http://codereview.chromium.org/11550 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5794 0039d316-1c4b-4281-b951-d872f2087c98
* * fix build errorkuchhal@chromium.org2008-11-201-1/+2
| | | | | | Review URL: http://codereview.chromium.org/11548 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5793 0039d316-1c4b-4281-b951-d872f2087c98
* Port directory lister to allow the linux and mac test shells to display file ↵estade@chromium.org2008-11-2016-161/+217
| | | | | | | | | | directories. This is a revision of r5725. It doesn't break mac build. Review URL: http://codereview.chromium.org/11507 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5792 0039d316-1c4b-4281-b951-d872f2087c98
* - If the exe rename command fails try calling Google Update to do the same ↵kuchhal@chromium.org2008-11-207-72/+105
| | | | | | | | | | | | | | job. This works when we are logged into XP/Vista as limited rights user. - Update Google Update idl file that has the recently added COM object. - Add --system-level to the rename command that gets added to the registry. - Remove all the code to uninstall Gears MSI. Now most of the user have been upgraded to Chrome installer that includes gears.dll. BUG=1463346 Review URL: http://codereview.chromium.org/11255 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5791 0039d316-1c4b-4281-b951-d872f2087c98
* Make the editor deletion UI work in layout test mode andtc@google.com2008-11-2011-25/+94
| | | | | | | | | | rebase 2 tests that use it. The only difference is font size. BUG=http://b/1124435 Review URL: http://codereview.chromium.org/11536 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5790 0039d316-1c4b-4281-b951-d872f2087c98
* Use the editor delegate in the GTK test shell.erg@google.com2008-11-201-0/+4
| | | | | | | | | This adds "EDITTING DELEGATE: " lines in the LayoutTest output. Review URL: http://codereview.chromium.org/11532 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5788 0039d316-1c4b-4281-b951-d872f2087c98
* Disable some tests while I fix.tc@google.com2008-11-201-2/+3
| | | | | | | | TBR=ojan Review URL: http://codereview.chromium.org/11545 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5787 0039d316-1c4b-4281-b951-d872f2087c98
* Mach msg class can use an externally allocated buffer rather than an internaljeremy@chromium.org2008-11-203-95/+184
| | | | | | | | | fixed size buffer. Replace deprecated bootstrap functions with Cocoa equivalents. Review URL: http://codereview.chromium.org/11486 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5786 0039d316-1c4b-4281-b951-d872f2087c98
* Change window_handle() to view_handle(). When disambiguating HWNDs, this was ↵avi@google.com2008-11-209-20/+20
| | | | | | | | turned into a ViewHandle but the name was never changed. This has been distracting me forever. Review URL: http://codereview.chromium.org/11528 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5783 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-20 21:02:08 +0000