| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
|
|
| |
TEST=heapcheck bot goes green
TBR=raz@chromium.org
Review URL: http://codereview.chromium.org/3361011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58883 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
| |
Use an observer instead, to wait more reliably.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3344006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58880 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
| |
BUG=54690
TEST=none
Review URL: http://codereview.chromium.org/3290015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58879 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This may have caused the following ui_tests failures in debug mode on Windows:
MediaTest.VideoBearTheora
MediaTest.VideoBearSilentWebm
MediaTest.VideoBearSilentTheora
UILayoutTest.MediaUILayoutTest
MediaTest.VideoBearWebm
BUG=0
TEST=tests
TBR=apatrick@chromium.org
Review URL: http://codereview.chromium.org/3295021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58878 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
| |
chrome-extensions:
URLs into TabContents::GetWebkitPrefs() so that it gets called both when the RenderView is
created and on subsequent preference updates. Also removed checking for kChromeInternalScheme as it is not used (per Darin).
BUG=54869
Review URL: http://codereview.chromium.org/3364015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58874 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Figure while I'm sheriffing, should do some valgrind gardening. I
tested these on my 10.6 box, and all seem to work fine:
DownloadUtilTest.AddFileToPasteboardTest
FindPasteboardTest.ReadingFromPboardUpdatesFindText
FindPasteboardTest.SendsNotificationWhenTextChanges
RenderViewTest.MacTestCmdUp
ClearBrowsingDataControllerTest.*
RenderViewTest.OnPrintPages
RenderViewTest.Print*
TabStripControllerTest.AddRemoveTabs
BUG=21479,30378,30379,30386,30396,30397
TEST=Mac valgrind green
Review URL: http://codereview.chromium.org/3322016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58873 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
| |
BUG=51981
TEST=no
Review URL: http://codereview.chromium.org/3266015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58872 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
| |
(This patch depends on unsubmitted change in file_util_proxy:
http://codereview.chromium.org/3293009/show)
BUG=32277
TEST=none; layout tests will be added later.
Review URL: http://codereview.chromium.org/3328011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58870 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Changes the AutoFill dialog on Mac to be modeless. Changes to preferences and AutoFill profile and credit card information is now saved immediately.
Nib changes: Removes Save and Cancel buttons, activates Close and Minimize controls, and compacts dialog to account for new vertical space.
BUG=49935
TEST=AutoFillDialogControllerTest.*
Review URL: http://codereview.chromium.org/3302015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58869 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
| |
BUG=54009
TEST=none
Review URL: http://codereview.chromium.org/3311016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58868 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
| |
BUG=54734
TEST=change a content setting to a non-default value, reset defaults, make sure the content setting radio has changed appropriately.
Review URL: http://codereview.chromium.org/3311017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58867 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
| |
It's pointing to U_IS_SURROGATE instead of CBU_IS_SURROGATE.
BUG=NONE
TEST=CBU16_IS_SURROGATE works fine in base.
TBR=brettw
Review URL: http://codereview.chromium.org/3294018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58866 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
| |
WideToUTF8(std::basic_string<wchar_t,std::char_traits<wchar_t>,std::allocator<wchar_t> > const &)
Upload data was called after the InfoBar changed the current page thus resulting in the NULL pointer dereference.
BUG=54439
TEST=Should not crash
Review URL: http://codereview.chromium.org/3291019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58864 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
See previous patch at http://codereview.chromium.org/2830010/show
This patch puts the responsibility of waiting on the test rather than making ui_test.cc robust.
The reason for moving the test to interactive tests (instead of straight up ui tests) is that waving the mouse around can break the test.
BUG=46614
TEST=test passes many times locally; try bots
Review URL: http://codereview.chromium.org/3338013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58863 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
| |
BUG=53988
TEST=none
Review URL: http://codereview.chromium.org/3338014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58862 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
| |
This will pull in support for the GL_NV_fence extension and a fix for eglSwapInterval.
TEST=try
BUG=none
Review URL: http://codereview.chromium.org/3347017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58861 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tests.
The sync integration tests currently access the network to communicate
with the notification server. We need to move to a model where all
server accesses are stubbed out by local servers. This is the first step
towards implementing a local notification server.
BUG=53933,53931
TEST=sync_integration_tests
First time committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58768
Review URL: http://codereview.chromium.org/3326007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58860 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
| |
BUG=54280
TEST=accessible only via unit test checked in this CL
Original patch by raz@chromium.org
Original review: http://codereview.chromium.org/3293007
Review URL: http://codereview.chromium.org/3310018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58859 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3343012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58858 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
The main change was to make scoped_ptr and the basic types the same for both NaCl and trusted plugins and to implement new logging code for GPU common and client code. Service code and unit tests can still use the logging code in base.
I am really not happy with the new logging code but I thought I'd let you take a look at it to see what you think. The biggest thing I don't like is it uses assert(false) to throw an exception in a platform independent way, which brings up a modal dialog. Not ideal in the middle of a unit test run. I don't know if that will make the bots hang. Hopefully they'll time out or something.
TEST=try
BUG=none
Review URL: http://codereview.chromium.org/2936009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58857 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
| |
chrome frame helper processes on launch (after setting its own hook).
BUG=53127
TEST=You can't start more than one medium/low integrity chrome_frame_helper.exe per desktop.
Review URL: http://codereview.chromium.org/3371002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58855 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
| |
This makes it possible for us to flip this flag and rebaseline the
linux tests in a single commit.
BUG=21386
Review URL: http://codereview.chromium.org/3348013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58854 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
| |
TBR=oshima
BUG=54308
TEST=ChromeOS Valgrind
Review URL: http://codereview.chromium.org/3371007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58853 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
| |
BUG=53347
TEST=Go incognito
Download a large file
Go to the Downloads page (chrome://downloads)
The item being downloaded should have the incognito guy
Review URL: http://codereview.chromium.org/3305016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58849 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
| |
BUG=54822
TEST=Flakes don't make the buildbots red.
Review URL: http://codereview.chromium.org/3352012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58843 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:4727,chromium-os:2863
TEST=Confirm that the UI only shows 2 settings (tap-to-click and sensitivity)
Confirm that the settings work on both x86-generic and x86-dogfood builds.
Review URL: http://codereview.chromium.org/3315016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58842 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
| |
<deque> header from mft_h264_decoder.h.
BUG=none
TEST=compile
Review URL: http://codereview.chromium.org/3331019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58840 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Failures:
http://build.chromium.org/buildbot/waterfall/builders/XP%20Tests/builds/22649/steps/browser_tests/logs/stdio
http://build.chromium.org/buildbot/waterfall/builders/Vista%20Tests/builds/22157/steps/browser_tests/logs/stdio
( RUN ) sendFinancialPing
( FAILED ) sendFinancialPing
Got EXTENSION_TEST_FAILED notification.
.\browser\extensions\extension_rlz_apitest.cc(67): error: Value of: RunExtensionTest("rlz")
Actual: false
Expected: true
FAIL (no message)
at Object.callback (chrome-extension://acmddjjmpkiijbjcdpchhmniojioobgh/test.js:147:63)
at Object.<anonymous> (chrome/ExtensionProcessBindings:124:19)
[ FAILED ] ExtensionApiTest.Rlz (1531 ms)
BUG=54294
TEST=green tests
TBR=rogerta@google.com
Review URL: http://codereview.chromium.org/3371006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58839 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When using False Start, this patch causes NSS to perform a single
write which contains the ClientKeyExchange, ChangeCipherSpec, Finished
and first application data record.
This removes a source of non-determinism when dealing with False Start
intolerant servers. Previously, Chrome may, or may not work depending
on network timing.
BUG=none
TEST=none
http://codereview.chromium.org/3331005/show
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58838 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
| |
storage-panel-show.html
BUG=
TEST=
Review URL: http://codereview.chromium.org/3369003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58837 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
of the chrome extension API, since a false does not represent an error. Added
an optional callback to the API so that caller can determine if the ping was
sent or not.
BUG=54294
TEST=n/a
Review URL: http://codereview.chromium.org/3358012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58827 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
| |
should be displayed once and only once. Also, if more than one proxy is in use, socket pools with the same proxy will appear adjacent to each other.
BUG=39756
TEST=manual
Review URL: http://codereview.chromium.org/3328009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58826 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
| |
superseded by layout test
BUG=
TEST=
Review URL: http://codereview.chromium.org/3356011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58825 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since the blacklist has gotten rather larger, it's now precompiled
into a hash table in the binary.
See also: http://www.imperialviolet.org/2010/09/05/blacklisting.html
(Originally landed in r58712. Reverted in r58726 because it broke the
ARM builders. The processing binary was being built for the target,
not the host.)
TEST=net_unittests
BUG=none
http://codereview.chromium.org/3303008/show
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58824 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
| |
This change is part of a series of changes to bring TouchEvent
processing to views.
BUG=na
TESTED=compiled with and without touchui
Review URL: http://codereview.chromium.org/3192002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58823 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
| |
This shows up in the field a number of times due to the Kerberos HTTP authentication protocol not being supported by Chrome, and leads people to believe it's a bigger problem than it actually is.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3369004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58822 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3292011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58821 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
| |
to the source file.
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/3341018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58818 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
| |
BUG=50943
TEST=ExtensionApiTest.WebNavigationEvents
Review URL: http://codereview.chromium.org/3369007
TBR=jochen@chromium.org
Review URL: http://codereview.chromium.org/3359013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58816 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=50943
TEST=WebNavigationEvents doesn't fail
TBR=jochen@chromium.org
Review URL: http://codereview.chromium.org/3352011
TBR=jochen@chromium.org
Review URL: http://codereview.chromium.org/3291017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58815 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
| |
BUG=50943
TEST=WebNavigationEvents doesn't fail
TBR=jochen@chromium.org
Review URL: http://codereview.chromium.org/3352011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58814 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
| |
TBR=jrg
BUG=53276
TEST=None
Review URL: http://codereview.chromium.org/3372003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58811 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
| |
symbols.
BUG=53127
TEST=the .exe and .dll as well as their respective .pdbs get archived by the builder.
Review URL: http://codereview.chromium.org/3297017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58810 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
| |
BUG=50943
TEST=ExtensionApiTest.WebNavigationEvents
Review URL: http://codereview.chromium.org/3369007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58809 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
| |
This new method is needed in the cases when stale values from caches
are not acceptable, for example, when estimating an effect of GC
on working set of the app.
Review URL: http://codereview.chromium.org/3294010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58808 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
| |
BUG=50943
TEST=ExtensionApiTest.WebNavigationEvents
Review URL: http://codereview.chromium.org/3307013
TBR=jochen@chromium.org
Review URL: http://codereview.chromium.org/3317013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58807 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
cases.
Create HelpAppLauncher and LoginHtmlDialog instances only once.
BUG= http://crosbug.com/6379
TEST=Tried on 3 cases: network not connected/connected but no internet (offline), connected to internet (online help topic)
Review URL: http://codereview.chromium.org/3294012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58806 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58804 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
| |
BUG=50943
TEST=ExtensionApiTest.WebNavigationEvents
Review URL: http://codereview.chromium.org/3307013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58802 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
| |
I'm not sure that it's right solution but EXTERNAL_PREF_DOWNLOAD is valid enum value so there is no reason to prohibit its deserialization.
TEST=none
BUG=54241
Review URL: http://codereview.chromium.org/3365013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58801 0039d316-1c4b-4281-b951-d872f2087c98
|