| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
47630:47646.
TBR=brettw
BUG=20016
TEST=none
Review URL: http://codereview.chromium.org/174292
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/174269
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24062 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
browser_tests, and fixes some simple errors in the focus unit test.
Review URL: http://codereview.chromium.org/173243
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24061 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Patch contributed by thiago.farina@gmail.com
BUG=None
TEST=None
Review: http://codereview.chromium.org/171027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24058 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://trac.webkit.org/changeset/47397 added calls to getStorageUpdates().
TEST=ran tests locally
BUG=none
Review URL: http://codereview.chromium.org/174196
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24057 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
enables modal_html_dialog_delegate.cc for Mac and Linux, since it's already ported. Porting defines in tab_contents.cc were removed to reflect the current state of the ports.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/174278
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24055 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Landing CL for rsesek@chromium.org
Original CL: http://codereview.chromium.org/172084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24054 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
regression issue.
This CL implements two unimplemented methods of AutocompleteEditViewGtk: OnRevertTemporaryText() and IsSelectAll().
The implementation are mostly copied from autocomplete_edit_view_mac.mm.
Some grammer errors and a valgrind warning introduced by CL 165457 are also fixed.
This CL was just updated to fix a regression caused by CL 165457 (issue 19631).
BUG=19631: Tabbing on Omnibox enters in to search UI mode
TEST=Input something in omnibox and make sure some text is selected and popup view is opened, change current selection in popup view by pressing up/down then press escape to see if omnibox is reverted to its original content and selection.
TEST=Make sure www.google.com is one of the search engine, open www.google.com then move the focus back to omnibox and press tab to see if the focus is moved into web page.
Review URL: http://codereview.chromium.org/172041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also, the max time for the merge/sync UI should be increased to minutes.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/174170
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24051 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
of the LocationBar, and correctly exposing MSAA/ARIA roles for Documents, Graphics, Menubars and Toolbars.
BUG=13291,19982
TEST=Assign @role menubar or toolbar to any dom element, and use Inspect32 (or similar tool) to see it exposed correctly. In the same way, <html> tag is exposed as role document.
Review URL: http://codereview.chromium.org/174252
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24049 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
error.
R=abarth
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/171056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24048 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
http://trac.webkit.org/changeset/47640 for rebaselining.
R=jianli
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/174281
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24047 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
with linux64 and mingw. Thanks to ambro on IIRC.
BUG=19999
TEST=use qt-faststart on mingw or linux64 and notice some of the printfs have invalid values.
Review URL: http://codereview.chromium.org/174272
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24046 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
R=jparent@chromium.org
TEST=none
Review URL: http://codereview.chromium.org/174282
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24045 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Build failures.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24044 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
According to glib docs, we need to do this if it's at all possible
for us to hit glib on multiple threads. This may be happening
when we grab plugin metadata from the file thread.
(Note that this is *not* initializing the GDK locking system.)
BUG=18957
Review URL: http://codereview.chromium.org/174264
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24043 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=scherkus
TEST=none
BUG=20004
Review URL: http://codereview.chromium.org/174275
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix leaks of (encoded) certificate extensions returned by
CERT_FindCertExtension. They can be freed as soon as they
are decoded.
R=ukai
BUG=http://crbug.com/10911
TEST=none
Review URL: http://codereview.chromium.org/173154
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24041 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
request failed and there is no response. This fixes the crashes in
OCSPTrySendAndReceive.
R=willchan
BUG=http://crbug.com/19915
TEST=See issue 19915 for steps to reproduce the crash.
Review URL: http://codereview.chromium.org/174248
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
After running several iterations of unittests and ui_tests under
valgrind, I was unable to reproduce the error.
BUG=18705 (http://crbug.com/18705)
TEST=Run unit tests and see that we don't get WindowSizer errors on Mac.
Review URL: http://codereview.chromium.org/174266
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24039 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Bubble arrow now gives STAR a wedgie (Glen)
- Bubble slightly higher up (Ben)
- 'Remove' button moved to bottom-left; made full size (Cole, Glen, Ben)
- Title alignment tweaks (Cole)
- Window height += 8 for better alignment (Cole)
- Window has shadow and no explicit border (Cole)
Review URL: http://codereview.chromium.org/173215
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
objc objects that own c++ objects have funny behavior. The C++ object's destructor can be called at an unspecified future time, long past the time that the objc object is destructed.
One possible symptom is an objc exception thrown when a browser window closes which could surface as a failure of Chrome to quit.
Review URL: http://codereview.chromium.org/173232
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24037 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For network state, make it return "loading" for everything that's not a file source since our cache does not yet reliably support caching the full media w/o need for a network.
For ready state, correctly handle seeks to drop from HaveEnoughData down to HaveMetaData until the seek completes. Also implement the seeking() function.
BUG=18975
TEST=none
Review URL: http://codereview.chromium.org/165432
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24036 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=18973
Volume silder thumb image for media controls.
Review URL: http://codereview.chromium.org/173139
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=19971
Review URL: http://codereview.chromium.org/173216
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24034 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/17569
TEST=None
Review URL: http://codereview.chromium.org/173230
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24033 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Mac have their own sandboxes. Remove the corresponding stubs from temp_scaffolding_stubs.h.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/173228
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24032 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=jparent
BUG=none
TEST=enabling layout tests
Review URL: http://codereview.chromium.org/173226
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24031 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Fix 10.6 bug where garbled text was displayed due to insuccesful font loading.
* Tightened down the Sandbox a bit, instead of allowing access to /System/Library limit it to certain subdirectories.
* Remove unused warmup code now that we allow sysctl-read.
BUG=11269
BUG=b/1853366
TEST=On 10.6, copy Arial.ttf from /System/Library/Fonts to ~/Library/Fonts , Launch Chrome. Text on NTP should be displayed normally and not garbled.
Review URL: http://codereview.chromium.org/174254
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/174261
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24029 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
uses same code path.
R=phajdan.jr
BUG=19361
TEST=none
Review URL: http://codereview.chromium.org/173227
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24028 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also fix a bug in the Windows implementation of SendMouseMoveNotifyWhenDone where the task would never be run if the cursor was already in the destination position before the call.
BUG=19076
BUG=19881
Review URL: http://codereview.chromium.org/174201
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24027 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/174260
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24026 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This recommits r23971
Review URL: http://codereview.chromium.org/174259
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24024 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/174253
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24023 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
APIs and concrete classes defined in our new appcache library, and get rid of the old files.
There are many files in the CL, mostly to pickup constant values now defined in our new appcache library, and to reflect a terminilogy change (from 'context' to 'host').
TEST=some existing unit tests apply
BUG=none
Review URL: http://codereview.chromium.org/170003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24022 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
they match the paths in expectations.json.
Review URL: http://codereview.chromium.org/174241
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24021 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=19866
TEST=ExtensionApiTest.Bookmarks
Review URL: http://codereview.chromium.org/173220
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/173171
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24019 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24018 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=18466
TEST=reduce DLL sizes with -O2 and other options, and test performance with this code.
Review URL: http://codereview.chromium.org/165039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24017 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original CL171023 by Song YeWen.
BUG=16020
TEST=test with all media types and ensure there are no memory leaks are
functional differences from previous version.
Review URL: http://codereview.chromium.org/174027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24016 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Requires --enable-byte-range-support
BUG=12258
TEST=covered by unit tests.
Review URL: http://codereview.chromium.org/173173
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24015 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24014 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/174251
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24013 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
It seems like short of writing a new diff program
the original idea of multiplying the alpha in
as RGB * (0.5 + alpha * 0.5) would give a better
test.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24012 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
you can't just convert the relative coords from the event
to the screen because you don't know if your View's position
relative to the screen may or may not have changed. You need
the screen coordinates from the event itself. This change
uses gdk_get_current_event() to get the event so we can get the screen coords from it
Review URL: http://codereview.chromium.org/173213
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24011 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=13524
TEST=spellchecking options behave like in windows.
Review URL: http://codereview.chromium.org/173112
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24010 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=17549
TEST=see bug
Review URL: http://codereview.chromium.org/173222
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24008 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
layout_package.platform_utils.
Deltas from that change:
* Don't enable 'win-xp' as the default platform
* Don't assume 'webkit/Release' exists (it doesn't by default on mac and
linux), and fix the output results directory path in run_webkit_tests
* Update tools/valgrind/chrome_tests.py (which I didn't realize
depended on the layout_package code).
BUG=none
R=tony@chromium.org
TEST=none
Review URL: http://codereview.chromium.org/174209
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24007 0039d316-1c4b-4281-b951-d872f2087c98
|