| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
This reverts commit 27381 (build break).
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
versions of Chrome.
|owner_drawn| is currently set if the UI font family or the UI font size is overriden. However, this leads menu items to be invisible in the system menu. This was not the case in Chrome 2.0, but somehow the way 'owner_drawn' menu is drawn has changed and we have this regression.
As a work around for the branch (3.0 train left, but we can merge this to 3.0.1), this CL sets |owner_drawn| to false for the system menu even if the UI font or the UI font size is overriden.
BUG=18042 (http://crbug.com/18042 )
TEST=Run Chrome with '--lang=hi' command line flag on Windows. Make sure that the translated menu items in the system menu are visible (e.g. 'New Tab', 'Task Manager') although a bit too small to read while the font size in the page/wrench menu is reasonably large.
Review URL: http://codereview.chromium.org/200123
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27382 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
enabled ScrollView on linux.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/222030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27381 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
cross-thread NewRunnableMethod.
This assertion caught such an error in VisitedLinkMaster!
My approach, modify RunnableMethodTraits<T> to assert that
when ReleaseCallee happens on a different thread from
RetainCallee that the type supports thread-safe reference
counting. I do this by adding a static method to both
RefCounted<T> and RefCountedThreadSafe<T>.
This results in a little ugliness in cases where people
implement AddRef and Release by hand (to make the no-ops).
There may be a nicer way to deal with those few cases.
R=brettw
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/251012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27379 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=17615
Review URL: http://codereview.chromium.org/219032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27378 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
does not exist.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/244018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27377 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://trac.webkit.org/changeset/48759.
TBR=abarth
TEST=none
BUG=17523
Review URL: http://codereview.chromium.org/249019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27376 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
It's time to kill this. It's been marginally useful, but only marginally.
http://codereview.chromium.org/222021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27375 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
point in the code.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/243004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27374 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) Fix division by zero if running only 1 WONTFIX test.
2) Do not add to the missing list if a test missing the result is marked as WONTFIX.
Also update the test_expectation list:
1) Remove SKIP for one test so that we can rebaseline it later.
2) Remove a qt test that was skipped previously because its missing result.
BUG=none
TEST=non
Review URL: http://codereview.chromium.org/246013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
browser crash that triggers ~100 times a day:
`anonymous namespace'::PureCall()
_invalid_parameter_noinfo
std::vector<unsigned char,std::allocator<unsigned char> >::operator[](unsigned int)
WebCursor::GetCursor(HINSTANCE__ *)
RenderWidgetHostViewWin::UpdateCursorIfOverSelf()
RenderWidgetHostViewWin::UpdateCursor(WebCursor const &)
I was unable to reproduce myself, so I don't know if the bad cursor came from
the web or from the Windows "external cursor" concept. Accordingly:
- Do not accept 0-sized cursors from the renderer.
- Do not access array[0] on an empty array as per other call sites in the
cursor code.
Thanks to The Mighty Hoppy for triggering this via means unknown!
BUG=NONE
TEST=NONE (unable to reproduce)
Review URL: http://codereview.chromium.org/251008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
closes the dialog.
BUG=19786
TEST=Open Sync Bookmaeks Login dialog. Enter credentials, TAB between fields, etc. to ensure nothing is broken. Hit the ESC key to dismiss the dialog.
Patch by Randy Posynick (http://codereview.chromium.org/199069)
Review URL: http://codereview.chromium.org/246020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27371 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
GTK: Listen for BROWSER_THEME_CHANGED and upload proper colors.
BUG=23031
Review URL: http://codereview.chromium.org/248006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27368 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/242025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Currently, RSAPrivateKeyUnitTest.InitRandomTest takes too long to pass.
We ignore istrumentation of NSS to speed up the tests that use it.
Review URL: http://codereview.chromium.org/242032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Darwin-specific ignore files to ThreadSanitizer.
This is necessary because ThreadSanitizer cannot handle the dSYM files
properly and the "src:*" ignore rules don't work on Mac.
The ignores_mac file contains the rules that make ThreadSanitizer
ignore the false positives reported on
base::subtle::{NoBarrier_Load, Release_Store}
This patch was prepared by Alexander Potapenko (cc'ed)
Review URL: http://codereview.chromium.org/251017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27365 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
off the appropriate archive directory. This allows us to not lose the
layout tests results history one one of the bots is clobbered.
A small change is needed to the buildbots to pass in the --build-name flag
before we'll be able to actually grab the results of archive location.
Review URL: http://codereview.chromium.org/246014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27364 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=darin
TEST=LayoutTests/fast/loader/*
BUG=8407
Review URL: http://codereview.chromium.org/243011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27363 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
to the list.
BUG:9798
Review URL: http://codereview.chromium.org/248018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27360 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fix one "fullscreen" to be "full screen" to match all other uses (not yet used, so no translation issue for windows)
Fix two new strings that were in Title Case instead of Sentence case.
BUG=22257
TEST=the context menus on different types of web content should be title case on mac/linux but sentence case on windows. These are new strings, so they won't exist in other languages yet.
Review URL: http://codereview.chromium.org/244004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27359 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
==25902== </valgrindoutput>
==25902== FATAL: in suppressions file "/b/slave/chromium-rel-linux-valgrind-tests-1/build/src/tools/valgrind/memcheck/suppressions.txt" near line 1081:
==25902== too many callers in stack trace
==25902== exiting now.
So, i'm making the stack trace smaller.
Review URL: http://codereview.chromium.org/244020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27358 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
for windows.
Please don't commit code that does not compile.
Review URL: http://codereview.chromium.org/244019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/242030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/242029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/248016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This is still not perfect, but all least it should work
for all the use cases we currently have.
Review URL: http://codereview.chromium.org/254001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27353 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
tbr:oshima@chromium.org
Review URL: http://codereview.chromium.org/242028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27352 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/235037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27351 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Tim's fix works.
Review URL: http://codereview.chromium.org/246018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27346 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/245023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27345 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CommandLine::Terminate.
This should relieve the purify redness.
TBR=nick
TEST=ProfileSyncServiceTest, sync_unit_tests
Review URL: http://codereview.chromium.org/243023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
it fails too often on linux.
Also disable LayoutTests/transitions/transition-end-event-left.htmt
It looks like all the transition-end-event-* are flaky.
BUG:9798
Review URL: http://codereview.chromium.org/248015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27343 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
disabled because of flakyness, but it's not disabled, and it's
really flaky, so i'm disabling it for real.
BUG:22668
Review URL: http://codereview.chromium.org/242027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27342 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
AutocompleteEditViewTest.BrowserAccelerators
because they started failing all the time.
TBR:pkasting
BUG:23213
Review URL: http://codereview.chromium.org/246017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27341 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27340 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=senorblanco@chromium.org
BUG=23197
TEST=None
Review URL: http://codereview.chromium.org/243020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add failure for newly added test for me to investigate.
TBR=senorblanco@chromium.org
TEST=None
BUG=None
Review URL: http://codereview.chromium.org/242023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rolling right up to the next breakage.
Adding new breakages that I need to investigate.
TBR=senorblanco@chromium.org
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/251006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27336 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=22926
Review URL: http://codereview.chromium.org/235033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=22926
Review URL: http://codereview.chromium.org/242015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27334 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It only adds a svn:ignore.
NO CODE CHANGE.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/235035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27333 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Linux shared build.
TBR=maruel
Review URL: http://codereview.chromium.org/245020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
wstring to avoid conversions "To and From wstring".
BUG=None
TEST=run unit_tests.exe
Review URL: http://codereview.chromium.org/217008
Patch from tfarina.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27331 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/249011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27330 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=23138,23139,23140
TEST=none
Review URL: http://codereview.chromium.org/249012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27329 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
http://src.chromium.org/viewvc/chrome?view=rev&revision=27303.
TBR: arv
Review URL: http://codereview.chromium.org/242021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27328 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
becomes a builtin plugin in Chrome and runs in the renderer process.2. Most of the changes are related to launching the NaCl process (that loads and runs the NaCl module) and establishing the initial communication between that process and the NaCl plugin.3. Command line flag "internalnacl" is required to enable the builtin NaCl plugin. NaCl still cannot run in Chrome sandbox, the flag automatically disables the sandboxCommitted: http://src.chromium.org/viewvc/chrome?view=rev&revision=27315
Review URL: http://codereview.chromium.org/153002
TBR=bradnelson@google.com
Review URL: http://codereview.chromium.org/244017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=bradnelson
Review URL: http://codereview.chromium.org/249014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27325 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
plugin in Chrome and runs in the renderer process.2. Most of the changes are related to launching the NaCl process (that loads and runs the NaCl module) and establishing the initial communication between that process and the NaCl plugin.3. Command line flag "--internal-nacl" is required to enable the built-in NaCl plugin. NaCl still cannot run in Chrome sandbox, the flag automatically disables the sandboxCommitted: http://src.chromium.org/viewvc/chrome?view=rev&revision=27315
Review URL: http://codereview.chromium.org/153002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27324 0039d316-1c4b-4281-b951-d872f2087c98
|