| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
Some apt commands were being run as the normal user,
resulting in the script dying.
BUG=none
TEST=gave the diff to someone; it fixed the failures for them
Review URL: http://codereview.chromium.org/2137002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47458 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=44371
Review URL: http://codereview.chromium.org/2066008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47457 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/2023003 and
http://codereview.chromium.org/2020002
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2094001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47455 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=Ensure that the About Chrome dialog has proper accessibility role.
BUG=none
Review URL: http://codereview.chromium.org/1838002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
background proxy channel thread and is accessed
from the UI thread, the proxy channel thread and the IPC thread. This leads to a race condition when ChromeFrame is being
torn down which occurs because the ChromeFrameAutomationProxy pointer is being set to NULL in the UI thread/deleted in
the proxy background thread while it could be accessed while processing a callback in the IPC thread thus causing a crash.
Fix is to ensure that the IPC thread does not access the ChromeFrameAutomationProxy pointer. To achieve this the callbacks
are now individual context objects which when invoked forward the actions to the ChromeFrameAutomationClient object.
The CreateExternalTab and ConnectExternalTab callbacks now complete their actions on the UI thread.
While at this based on a discussion and lot of help from Stoyan we decided to clean up the sync message dispatching code
used by ChromeFrame by having callbacks now derive from a SyncMessageCallContext class to ensure that these get cleaned
up correctly in all cases. For e.g. if we don't receive a response for a message, etc and thus enable them to present
a consistent interface to be invoked when we receive a response for a IPc message.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=44245
Bug=44245
Review URL: http://codereview.chromium.org/2073007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We already don't compile the code to load the library for 64-bit, this makes it so we also don't try to build anything into it.
BUG=None
TEST=Eventually we should be able to compile for 64-bit on the Mac.
Review URL: http://codereview.chromium.org/2090007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47452 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When Window Manager sends us a NOTIFY_SYSKEY_CLICKED message,
we adjust the volume accordingly. Currently just calling
amixer as WM was doing before. There will be a different
change submitted for WM to send this message instead of
calling amixer itself.
Patch by davej@chromium.org:
http://codereview.chromium.org/2102001/show
BUG=cros/525
TEST=none
Related to issue 2107001.
Review URL: http://codereview.chromium.org/2107010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47451 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
timeticks.
Also use a prettier display for the DNS cache and "bad proxy" cache.
BUG=37421
Review URL: http://codereview.chromium.org/2120002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47450 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=brettw
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2074010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47448 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This started occuring with revisions 47419 and 47420.
BUG=44393
TBR=glotov
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47446 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This time around i've tested it on the mac with a full build. Fixed string16 issues.
Review URL: http://codereview.chromium.org/2133002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47445 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This provides for basic access to the window and element containing the
instance. Enumeration of properties is not implemented.
R=brettw
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2075005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
software, for consistency with Chrome, and as a switch in media_bench
BUG=31093
TEST=media_bench --error-correction --stream=video --video-threads=1 d:\mediatests\tulip\tulip2.mp4
Review URL: http://codereview.chromium.org/2107009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=HistoryTest::MostVisitedURLs
Original review: http://codereview.chromium.org/2099004
Checked in for Nik Sckrob
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47442 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For WebGL the shader translation is off. For Pepper
and other processes it is on. This will
be removed and the tranlator will always be on
at some point in the future
TEST=More conformance tests pass, manually ran WebGL demos in Chrome.
BUG=none
Review URL: http://codereview.chromium.org/2127001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47441 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=victorw
Review URL: http://codereview.chromium.org/2102006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47440 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=44379 gtk_chrome_shrinkable_hbox may redraw children with incorrect size allocation.
TEST=see bug report.
Review URL: http://codereview.chromium.org/2120005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47439 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also tested for OGG.
BUG=43094
TEST=play a movie with 5.1 sound. ie startrek-sbspot_h720p.mov. The voices should be centered.
Review URL: http://codereview.chromium.org/2095007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
WriteHyperlink to take string16 anchor text.
BUG=42624
TEST=none
Review URL: http://codereview.chromium.org/2036013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47432 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2083007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47431 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
delegate to avoid stale weak references.
BUG=44225
TEST=see bug
Review URL: http://codereview.chromium.org/2122008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47430 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This regressed in r43790 (my fault, as I reviewed it). There used to be a test that covered this functionality, but the test was removed in r37819.
BUG=44107
TEST=none.
Review URL: http://codereview.chromium.org/2109004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DISABLED test that times out on Mac. (Original patch reviewed at http://codereview.chromium.org/2067003 )
Track "display" and "run" separately for mixed content, and make the latter downgrade the SSL state to "authentication broken".
Make the "display" state only affect the current tab (not the entire host).
Fix an SSL browser test by supplying the appropriate SiteInstance*.
Move a test from "disabled" to "flaky" since it at least passes for me.
Make the SSLManager header and .cc files put functions in the same order, and make that order somewhat saner.
BUG=15072, 18626, 40932, 42758
TEST=Covered by browser tests
Review URL: http://codereview.chromium.org/2063008
Review URL: http://codereview.chromium.org/2126005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also, made the info-bubble HWND on Windows owned by its border widget so that it shows on top. That way we don't have to create a hole in the border widget to make it visible.
BUG=None
TEST=Make sure other info-bubble (bookmark bubble, extension bubbles...) work as expected. Test that when tarting Chrome with --app-panel, creating a new tab shows the apps launcher with an animation.
Review URL: http://codereview.chromium.org/2096004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
AutoFill keyboard shortcut to "Edit -> AutoFill Form" removed for security reasons. Nib changes: Removed menu separator and "AutoFill Form" menu item from MainMenu.xib.
BUG=42264
TEST=Manual test: Launch Chrome, look under Edit menu, expect no AutoFill Form item.
Review URL: http://codereview.chromium.org/2125006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I've seen this fail on my local machine as well as on the try server. Looks like there's a race condition.
BUG=none
TEST=none
TBR=dmazonni@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47424 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:3061
TEST=Verify options dialog is closed when "Get Theme" link is clicked per chromium-os:3061.
Review URL: http://codereview.chromium.org/2090003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47423 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
point. This is a to avoid the deadlock that occurs when shutting it down in DllMain in chrome_launcher.exe.
BUG=44212
TEST=chrome_launcher.exe stops hanging
Review URL: http://codereview.chromium.org/2094006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47422 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=atwilson
BUG=44371,44371
Review URL: http://codereview.chromium.org/2132004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47420 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=None
BUG=32407
Review URL: http://codereview.chromium.org/1742004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47419 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change fixes the issue where PathIsWritable returns the wrong
answer when called by the superuser. It also slightly simplifies the
code.
This fix is helpful for Chrome OS because Chrome OS uses
PathIsWritable in backlight-tool
TEST=Verified that this change fixes backlight-tool (part of the Chrome OS power manager).
BUG=none
Patch by davidjames
http://codereview.chromium.org/2073005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47418 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a temporary implementation. The real implementation
will require
*) glGetString to return "GL_EXT_texture_compression_dxt1"
*) CommandBufferEnable("GL_EXT_texture_compression_dxt1")
to dynamically modify the validation after it has made
sure the "GL_EXT_texture_compression_dxt1" is returned
from the system level GL
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/2136003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47417 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Looks like I wasn't running test_shell for a while when I decided that the race is gone
BUG=24715
TBR=glider
Review URL: http://codereview.chromium.org/2103004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47416 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since WebKit r59457, this test is rebaselined and can be enabled again.
Landing http://codereview.chromium.org/2078009/show
BUG=42740
TEST=ui_tests --gtest_filter=DOMStorageTest.RootLayoutTests
TEST=run_webkit_tests.sh --debug storage/domstorage/quota.html
Review URL: http://codereview.chromium.org/2066006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47415 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
For now this extra text is not localized.
Added max width for info bubble, text will be wrapped.
BUG=crosbug.com/3274
TEST=On Chrome OS login type wrong password.
Review URL: http://codereview.chromium.org/2084006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47413 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
See http://build.chromium.org/buildbot/waterfall/builders/Linux%20Perf%20(1)/builds/9017
TBR=atwilson
Review URL: http://codereview.chromium.org/2126004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47412 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2104005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It needs to be after calling navigator.geolocation.getCurrentPosition()/watchPosition() rather than just accessing navigator.geolocation.
Depends on https://bugs.webkit.org/show_bug.cgi?id=38323.
BUG=42789
TEST=GeolocationBrowserTest.NoInfoBarBeforeStart
Review URL: http://codereview.chromium.org/1950001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47406 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change the layout so the input method configure button will be shown right
next to the input method name (the layout was bad as the row was sharing the
same columnset with the huge the "Display Google Chrome in this language"
button).
Also widen the width of the dialog from 96 to 106, so the "Display Google
Chrome in this language" button does not get truncated. To do this, define
separate dialog size settings for this dialog.
BUG=chromium-os:3235
TEST=manually
Review URL: http://codereview.chromium.org/2106008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47404 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Looks like we print different stacks for dtors on Valgrind and PIN
TBR=glider
Review URL: http://codereview.chromium.org/2086006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47403 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=glider
Review URL: http://codereview.chromium.org/2067012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47402 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=atwilson
BUG=none
Review URL: http://codereview.chromium.org/2117008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=44354
TBR=brettw
Review URL: http://codereview.chromium.org/2091008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=44341
TEST=none
TBR=asargent,cevans,glotov
Review URL: http://codereview.chromium.org/2098010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
synchronization primitives.
TBR=timurrrr
Review URL: http://codereview.chromium.org/2107007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47398 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
value checks.
Relands. It's irrelative.
http://buildbot.jail.google.com/buildbot/waterfall/builders/Mac10.5%20Tests%20(dbg)(2)/builds/16790
TBR=sky
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/2098007
TBR=phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/2076004
TBR=tyoshino@chromium.org
Review URL: http://codereview.chromium.org/2073009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It looks that this change caused lots of test failures. Reverts for now and wait and see.
http://buildbot.jail.google.com/buildbot/waterfall/builders/Mac10.5%20Tests%20(dbg)(2)/builds/16790
TBR=sky
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/2098007
TBR=phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/2076004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47396 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
since code's changed a lot. I've changed it so as not to flush the host resolver too. I suspect there might have been a bug there. I was unable to reproduce the crash here on network change, so I think either that fixed it or something else changed under the hood. In any case, I want to reland this and see if anyone encounters any problems with it.
BUG=40455,40457
Review URL: http://codereview.chromium.org/2114004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47395 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=44341
TEST=none
TBR=rvargas
Review URL: http://codereview.chromium.org/2079006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47394 0039d316-1c4b-4281-b951-d872f2087c98
|