| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
| |
BUG=none
R=none
TEST=bots green up
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59208 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
| |
R=none
BUG=none
TEST=bots green up
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59207 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
slowed due to WebKit bug 45524.
Hopefully I am adjusting the expectations correctly.
BUG=https://bugs.webkit.org/show_bug.cgi?id=45524
TEST=page cycle bots green up
TBR=chase@chromium.org
Review URL: http://codereview.chromium.org/3306017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59206 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
| |
TEST=bots stay green
BUG=none
R=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59205 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
| |
I expect the page_cycler_morejs to fail; will update the baselines
afterwards when I have data telling me what to update them to.
BUG=none
TEST=bots stay green (except for page_cycler_morejs)
R=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59204 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
So that it does not introduce static initializers into including files.
TEST=try
BUG=54904
Review URL: http://codereview.chromium.org/3354018
Reverting due to serious perf regression in some cases.
TBR=apatrick@chromium.org
Review URL: http://codereview.chromium.org/3358030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59203 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
| |
password store.
TEST=save a password containing a non-ASCII character, it should autofill correctly
BUG=54065
Review URL: http://codereview.chromium.org/3316014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59202 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59195 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
A recent migration to using streams for handling preconnection included
a tiny typo, which prevented us from annotating sockets as having been
created as part of speculation. As a result, we did not get any stats,
despite the fact that preconnection was active.
BUG=55161
r=mbelshe
Review URL: http://codereview.chromium.org/3326020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59193 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
| |
still a couple of rough edges, but this is a good start.
BUG=54833
TEST=none
Review URL: http://codereview.chromium.org/3333027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59192 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
| |
BUG=36740
TEST=
Review URL: http://codereview.chromium.org/3341029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59191 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
| |
IOThread and the sync thread race to initialize OCSP (lazily done by SSLClientSocketNSS), but OCSP is only allowed to be initialized on the IOThread. So we eagerly initialize it to prevent the race. Hopefully this doesn't regress startup time!
BUG=36740
TEST=none
Review URL: http://codereview.chromium.org/3327019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59190 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
| |
through to the TabContentsDelegate, but at the time I need another
delegate will have been installed.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3306015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59189 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the case of Negotiate, authentication can look like
C: GET
S: 401, WWW-Authenticate: Negotiate
C: GET, WWW-Authorization: Negotiate <client_token_1>
S: 401, WWW-Authenticate: Negotiate <server_token_1>
C: GET, WWW-Authorization: Negotiate <client_token_2>
S: 401, WWW-Authenticate: Negotiate <server_token_2>
on that third challenge, the handler was reported as being in "the final round" and this was treated as a rejection of the authentication attempt. After that, the new challenge token was used by a new auth handler that hadn't established a security context, and an ERR_INVALID_HANDLE would be returned.
This CL also does some prep work to correctly handle the "stale=true" value for Digest authentication, but I decided to defer the HttpAuthCache changes needed for that to a separate CL since this was large enough.
BUG=53282
TEST=net_unittests. Unfortunately, I haven't been able to set up a proxy/server to do more than two auth challenges, but this does happen in the wild.
Review URL: http://codereview.chromium.org/3360017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59188 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
| |
expected.
TBR=vandebo
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59187 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
try-again and cancel buttons.
For recognition status, the bubble shows:
- "Speak now" at the top
- Image/icon with status below that
- "Cancel" button at the bottom
In message mode, the bubble shows:
- The given message (could span multiple lines) at the top
- A row of 2 buttons at the bottom, "Try again" and "Cancel"
BUG=53598
TEST=manual, unplug mic and start recognition to check error message, and similarly give no speech to check.
Review URL: http://codereview.chromium.org/3300029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59184 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
| |
BUG=29593
TEST=browser_tests --gtest_filter=AutocompleteBrowserTest.FocusSearch
Review URL: http://codereview.chromium.org/3280012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59183 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
TBR=vangelis@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59182 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
| |
TEST=try
BUG=none
Review URL: http://codereview.chromium.org/3343021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59181 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
editable.
BUG=52339
TEST=Right click on a folder in the folder tree
Add folder
The folder name should be editable.
Review URL: http://codereview.chromium.org/3326019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59180 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
This temporary instrumentation has already yielded the intended data, so it is no longer necessary.
BUG=54307
Review URL: http://codereview.chromium.org/3337012
TBR=huanr@chromium.org
Review URL: http://codereview.chromium.org/3322020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59178 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert 59171 - Correct typo so that statistics appear for speculative activities
A recent migration to using streams for handling preconnection included
a tiny typo, which prevented us from annotating sockets as having been
created as part of speculation. As a result, we did not get any stats,
despite the fact that preconnection was active.
BUG=55161
r=mbelshe
Review URL: http://codereview.chromium.org/3331023
TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/3375007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59177 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
| |
make try jobs run.
TBR=rafaelw@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59176 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=50006 (and various other reports)
TEST=Run chrome under nested window manager using Xephyr (see
http://code.google.com/p/chromium/wiki/LayoutTestsLinux)
use --enable-logging=stderr --log-level=0
kill xephyr
examine log. You should see
X IO Error detected
followed (not necessarily immediately) by
successfully saved /tmp/tx/Default/Preferences
successfully saved /tmp/tx/Local State
successfully saved /tmp/tx/Local State
successfully saved /tmp/tx/Default/Preferences
along with no crash.
There is a high ranking crash report on both linux and chromeos that happens whenever X sends an error to chrome. This change causes us to log and continue when we get a regular error from X. When we get an IO error, indicating X is gone, we attempt to shut down gracefully.
Review URL: http://codereview.chromium.org/3175038
TBR=davemoore@chromium.org
Review URL: http://codereview.chromium.org/3332019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59175 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
| |
delete the old one.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3336020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59174 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ALso fix broken unit test.
BUG=http://crbug.com/51640
TEST=place a million bookmarks in a folder. Open the folder. Make
sure the scroll up only happens when the mouse is over the arrow
(horiz positioning doesn't matter). Now that the scroll down arrow
(at top of screen) has appeared, make sure the scroll down only
happens when the mouse is over the arrow (again, horiz positioning
doesn't matter).
Review URL: http://codereview.chromium.org/3327017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59173 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
A recent migration to using streams for handling preconnection included
a tiny typo, which prevented us from annotating sockets as having been
created as part of speculation. As a result, we did not get any stats,
despite the fact that preconnection was active.
BUG=55161
r=mbelshe
Review URL: http://codereview.chromium.org/3331023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59171 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert 59168 - Disable SpdyNetworkTransactionTest.WriteError on Mac as it's crashing.
BUG=55174
TEST=SpdyNetworkTransactionTest.WriteError
Review URL: http://codereview.chromium.org/3315022
TBR=jhawkins@chromium.org
Review URL: http://codereview.chromium.org/3350019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59170 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/48681
TEST=open bookmark folder. Mouse-over a button to highlight it. zoom
in (e.g. ctrl-scroll-up). Make sure padding on right and left sides
are equal. (Previously we had too much padding on right side).
Review URL: http://codereview.chromium.org/3361014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59169 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
| |
BUG=55174
TEST=SpdyNetworkTransactionTest.WriteError
Review URL: http://codereview.chromium.org/3315022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59168 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
| |
BUG=52799
TEST=none
Review URL: http://codereview.chromium.org/3369011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59167 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
we now show the messages within the speech input UI bubble. We also let the user retry recognition without returning the error to the web page unless the user clicked the cancel button or closed the bubble.
For this to work, we now keep the request alive in the SpeechInputManager map until it completes successfully or user explicitly cancelled it. We also keep the SpeechInputBubble object alive, even when the actual bubble window is not visible on screen, and construct the window if required whenever we want to show the recording status or error message on screen.
BUG=53598
TEST=unit_tests --gtest_filter=SpeechInputBubbleControllerTest.*
Review URL: http://codereview.chromium.org/3352018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59166 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
| |
a flag.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3312017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59165 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
| |
We could conceivably hit these lines if the firefox profile is in a weird state.
BUG=54718
TEST=none
Review URL: http://codereview.chromium.org/3305019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59164 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
| |
TBR=jar
BUG=55169
TEST=unit_tests
Review URL: http://codereview.chromium.org/3324016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59163 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3324015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59161 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
| |
BUG=none
TEST=see attached image
Review URL: http://codereview.chromium.org/3351023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59160 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3360023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59159 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
| |
BUG=55143
TEST=drag something in the render view
Review URL: http://codereview.chromium.org/3351024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59158 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The uninstall dialog used to say:
[===============================x]
|Confirm Uninstallation |
|--------------------------------|
|<b>Uninstall Foo Extension?</b> |
| |
|Are you sure you want to |
|uninstall this extension? |
| |
|================================|
We don't have the bottom string with the word 'app', and I
realized it is somewhat extraneous anyway. So just removed it
in all cases and de-bolded the text above. Looks much better.
Also, fixed a bug where the icon we display in the GTK
dialogs is too big by doing image resizing in
ExtensionInstallUI.
BUG=54874
TEST=Uninstall app and extension. Both should have a prompt,
and UI layout should be the same.
Review URL: http://codereview.chromium.org/3332016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59157 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
| |
Also, moved some code closer to the object it's operating on.
BUG=48913
TEST=unit_tests, ui_tests, browser_tests
Review URL: http://codereview.chromium.org/3341013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59156 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As seen at http://build.chromium.org/buildbot/try-server/builders/mac/builds/45974/steps/compile/logs/stdio :
warning: 'PluginExceptionsTableModelTest' has a field 'PluginExceptionsTableModelTest::table_model_' whose type uses the anonymous namespace
The fix for that is to move the test into the anonymous namespace too, which breaks the friend declaration. So I need to work around that, too.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3345019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59155 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
| |
TEST=none
BUG=28291
Review URL: http://codereview.chromium.org/3362015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59154 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
| |
bug 30k and up)
BUG=Too many to list
TEST=Valgrind stays green-ish.
Review URL: http://codereview.chromium.org/3301018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59153 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
not work for resources.
GCC has troubles with arraysize() for structures in the different namespace and with annonymous structures.
The only difference from 3305029 is in pepper_private.cc.
Added PDF resources to Chrome.
Added private interface to access resources from pepper plugin.
Added example to PDF srting resource.
BUG=54322
TEST=none
Review URL: http://codereview.chromium.org/3335016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59150 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
| |
up to bug 30k)
BUG=Too many to list
TEST=Valgrind stays green-ish.
Review URL: http://codereview.chromium.org/3373005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59149 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=50006 (and various other reports)
TEST=Run chrome under nested window manager using Xephyr (see
http://code.google.com/p/chromium/wiki/LayoutTestsLinux)
use --enable-logging=stderr --log-level=0
kill xephyr
examine log. You should see
X IO Error detected
followed (not necessarily immediately) by
successfully saved /tmp/tx/Default/Preferences
successfully saved /tmp/tx/Local State
successfully saved /tmp/tx/Local State
successfully saved /tmp/tx/Default/Preferences
along with no crash.
There is a high ranking crash report on both linux and chromeos that happens whenever X sends an error to chrome. This change causes us to log and continue when we get a regular error from X. When we get an IO error, indicating X is gone, we attempt to shut down gracefully.
Review URL: http://codereview.chromium.org/3175038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59147 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Next patches will also centralize timeouts for our other test binaries
based on that file.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3308020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59145 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
| |
Fix GView interceptor unit tests to match what is supposed to happen in the presence of the PDF internal plug-in on ChromeOS.
BUG=51242
TEST=GViewRequestInterceptorTest.DoNotInterceptPdfWhenEnabled, GViewRequestInterceptorTest.InterceptPdfWhenDisabled
Review URL: http://codereview.chromium.org/3308016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59144 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
| |
BUG=54898
TEST=first run in Hebrew
Review URL: http://codereview.chromium.org/3369012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59143 0039d316-1c4b-4281-b951-d872f2087c98
|