| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
This will be used in a layout test for per-strike renderer preferences.
BUG=none
TEST=Future layout test
http://codereview.chromium.org/660383
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40410 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
expectation before the
testing::InSequence specification and getting rid of the duplicate FileDownload expectations.
TBR=amit
Review URL: http://codereview.chromium.org/661385
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
reflect its relation to the Autocomplete feature.
BUG=33032
TEST=none
Review URL: http://codereview.chromium.org/661323
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The only functional change should be that the app panel close button width is now its preferred width, not its preferred width + 4.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/660128
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40407 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
views: refactor out the "Alt" TableView feature.
BUG=34181
TEST=open bookmarks manager, type something in the search text-field, see if a
message is showed when there is no match and see if everything still works as
before.
Review URL: http://codereview.chromium.org/660380
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40406 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=levin
Review URL: http://codereview.chromium.org/660391
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40405 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/37109
TEST=None
TBR=nsylvain
Review URL: http://codereview.chromium.org/661383
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40404 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add a warning to the incognito new tab page that your extensions are
disabled in that mode.
- Toggling an extension in incognito will reload the extension, fixing a bug
where browser actions in existing incognito windows would not get updated.
BUG=36292
BUG=32365
TEST=run chrome with --enable-experimental-extension-apis and some extensions loaded, and open an incognito window. Enable some extensions in incognito and make sure things work.
Review URL: http://codereview.chromium.org/660220
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40403 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
we always read the cookies from
the host browser when the renderer requests them. This also cleans up the mess with the host network stack
code parsing cookies from the host looking for persistent cookies.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=34151
Bug=34151
Test=Covered by existing host network stack tests and chrome frame cookie tests.
Review URL: http://codereview.chromium.org/661290
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40402 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=32406
TEST=unittests
Review URL: http://codereview.chromium.org/660041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=levin
Review URL: http://codereview.chromium.org/660385
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
error right now is dsputil_mmx.c:605: error: can't find a register in class 'GENERAL_REGS' while reloading 'asm'
BUG=35850
TEST=none. valgrind builds should work.
Review URL: http://codereview.chromium.org/661379
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40398 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none - not used and blocks refactoring for bug 30357
TEST=unit tests
Review URL: http://codereview.chromium.org/661318
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=37138
TEST=Valgrind reports no errors
Review URL: http://codereview.chromium.org/660322
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40396 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=36871
Review URL: http://codereview.chromium.org/660353
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40395 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/660357
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of the WidgetWin object for
the ExternalTabContainer. Basically the crash happens while dereferencing the chrome ui message loop which
has been destroyed. This could happen in a ChromeFrame instance as the message loop is destroyed when the
module ref count drops to 0. The ref count is decremented in the destructor of the AutomationProvider which
runs before the Widgetwin destructor.
Fix is to move the code in the WidgetWin destructor to the code which processes WM_NCDESTROY
Fixes bug http://code.google.com/p/chromium/issues/detail?id=37163
Bug=37163
Review URL: http://codereview.chromium.org/663001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40393 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Bug=37204
TBR=amit
Review URL: http://codereview.chromium.org/660386
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=14774
TEST=AutoamtedUITestBase.FLAKY_CloseTab stops being flaky?
Review URL: http://codereview.chromium.org/660324
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=None
BUG=None
TBR=mmoss
Review URL: http://codereview.chromium.org/661374
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Keychain.
BUG=34607
TEST=KeygenHandlerTest.SmokeTest
Review URL: http://codereview.chromium.org/652137
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
window.
BUG=27365
TEST=none
Review URL: http://codereview.chromium.org/661187
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40386 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/660345
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/37117
TEST=as in comment 2 of bug.
Review URL: http://codereview.chromium.org/661310
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40383 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/37077
TEST=as in bug; drag off a tab and it should stay themed
Review URL: http://codereview.chromium.org/660302
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40382 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/37078
TEST=as in bug
Review URL: http://codereview.chromium.org/660307
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40381 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/36794
TEST=as in bug
Review URL: http://codereview.chromium.org/660305
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is making the nacl 64 app to fail to build, because our code
to make sure we use the lib64 folder fails because it does not except
to have the sdk Lib dir twice (once for 2008, once for win7).
Review URL: http://codereview.chromium.org/660314
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40379 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BookmarkBubbleControllerTest needs _three_ passes. I believe it's
because the bubble is a child window.
BUG=none
TEST=allows test to run on tsan bots.
Review URL: http://codereview.chromium.org/661347
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40378 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
message without calling DefWindowProc we don't get OnSize notification.
BUG=36280
TEST=See steps to reproduce in the bug.
Review URL: http://codereview.chromium.org/660087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40376 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40371 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change introduces one more dependency on chrome/browser,
but it seems simpler to move gtk_util first and then fix it.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/661271
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change suppresses leaks started since Build 3151 (on a Linux valgrind bot) and Build 3513 (on a Mac valgrind bot).
TBR=zork
BUG=37168
TEST=make valgrind bots green.
Review URL: http://codereview.chromium.org/661351
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=nsylvain@chromium.org
BUG=36799
TEST=moz and morejs tests stay green
Review URL: http://codereview.chromium.org/660366
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40365 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
replacement preceeds ? sign.
BUG=19718
Patch by glotov@chromium.org
Original review http://codereview.chromium.org/601004
TEST=Verify that slash is escaped as stated in description; example: create
search engine en.wikipedia.org/%s and search it with parameters wiki/hi
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40364 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=35850
TEST=none. should behave same as before but with better security.
Review URL: http://codereview.chromium.org/660363
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40363 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also fix an unrelated TODO in this area.
xib change: Make ContentSettingsWindowController the NSTabView's delegate and hook the controller's IBOutlet up to the NSTabView.
BUG=36949
TEST=Open content settings via a blocked popups bubble. Popup tab should be selected. Select javascript tab, close window. Reopen window, javascript tab should still be selected.
Review URL: http://codereview.chromium.org/661354
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Including some changes to make things testable, including adding WebDatabase* to the ctor of the MA and PC, plus making some methods virtual on WebDatabase.
Review URL: http://codereview.chromium.org/661316
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40359 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This forces implementations to consider each case, and avoids subtle bugs that can happen by using the default no-op implementation (like bug 36964).
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/661236
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40358 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
TBR=darin
Review URL: http://codereview.chromium.org/661350
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Re-enabling the tests that were disabled in the first pass.
Also changing how we substitute localization values (using direct method that avoids flashing __MSG__const while the page is loading).
Also made some minor fixes after testing various locales.
BUG=37109
TEST=This CL is about enabling automated tests.
Review URL: http://codereview.chromium.org/660328
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=nsylvain
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=nsylvain
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40349 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/660347
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/661343
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40346 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
of the obsolete kFormAutofillEnabled.
BUG=36640
TEST=none
Review URL: http://codereview.chromium.org/661327
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40345 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=37137
TEST=See bug. Also, hit "add" and "remove" in succession, shouldn't crash either.
Review URL: http://codereview.chromium.org/661326
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
rather than universal, and put mac notifications in the upper right as requested.
BUG=34826
TEST=create notifications on all platforms
Review URL: http://codereview.chromium.org/661333
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40343 0039d316-1c4b-4281-b951-d872f2087c98
|