summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Increase timeout in url_fetchet to make it morensylvain@chromium.org2009-06-191-2/+2
| | | | | | | | friendly when running in purify. Review URL: http://codereview.chromium.org/139004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18852 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "posix: two related changes to make plugin IPC work on POSIX."evan@chromium.org2009-06-1917-280/+60
| | | | | | This reverts commit r18850, as it had a compile failure. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18851 0039d316-1c4b-4281-b951-d872f2087c98
* posix: two related changes to make plugin IPC work on POSIX.evan@chromium.org2009-06-1917-60/+280
| | | | | | | | | | | | | | | | | | | | | | * use a new ChannelHandle type when passing IPC channels over IPC The current POSIX code assumes that one end of a channel is always a new child process (a renderer). For plugins we need to be able to construct channels between each of the browser, plugin, and renderer. This change augments the messages related to creating channels to allow passing in a base::FileDescriptor containing the socket. The intent is that the browser process, as the initial interchange between plugin and renderer, creates the socketpair() on their behalf and hands each their respective end of the connection. * register channel endpoint names in the global pipe map The plugin code assumes it can map from a string to a channel endpoint at basically any time. So whenever we get a channel endpoint over IPC, we install it in a global map of channel endpoints. Review URL: http://codereview.chromium.org/113157 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18850 0039d316-1c4b-4281-b951-d872f2087c98
* Add a switch to allow longer shutdown timeouts, since quitting under ↵stuartmorgan@chromium.org2009-06-193-3/+17
| | | | | | | | | | valgrind is very slow on the Mac. BUG=none TEST=Most/all of the UI tests should pass on the Mac when run under valgrind. Review URL: http://codereview.chromium.org/140008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18849 0039d316-1c4b-4281-b951-d872f2087c98
* Instead of try:-except:-finally:, use nested try:-except: withinsgk@google.com2009-06-191-28/+29
| | | | | | | | | try:-finally: so builds will work without forced upgrades to Python 2.5. BUG=12818 TEST=successful build Review URL: http://codereview.chromium.org/140005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18848 0039d316-1c4b-4281-b951-d872f2087c98
* Add Mac support for setting plugin fullscreen area. maf@google.com2009-06-195-27/+59
| | | | | | Review URL: http://codereview.chromium.org/126252 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18847 0039d316-1c4b-4281-b951-d872f2087c98
* Support running worker's fast layout tests in UI test framework.jianli@chromium.org2009-06-193-11/+229
| | | | | | | | | BUG=none TEST=This is a UI test. Review URL: http://codereview.chromium.org/131012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18846 0039d316-1c4b-4281-b951-d872f2087c98
* part 3 of toolstrip dragging - persist the drag ordererikkay@google.com2009-06-199-38/+182
| | | | | | | | | | | | Also notify other browser windows of changes to the order. BUG=http://code.google.com/p/chromium/issues/detail?id=12123 TEST=browser_tests.exe --gtest_filter=ExtensionShelfModelTest.* Review URL: http://codereview.chromium.org/131114 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18845 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up the layout. Remove un-mac'y divider lines. Rework the Under The ↵pinkerton@chromium.org2009-06-191-814/+160
| | | | | | | | | | Hood panel to be more like on windows and remove stuff that's not needed. Disable all prefs that aren't currently hooked up. BUG=none TEST=Prefs on first two panels haven't stopped working. Review URL: http://codereview.chromium.org/140004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18844 0039d316-1c4b-4281-b951-d872f2087c98
* Remove ourselves as a message loop observer in the tabstrip destructor to ↵jhawkins@chromium.org2009-06-191-0/+4
| | | | | | | | | | catch the case when the user closes the last tab in a tabstrip. In this case, we add ourselves as a message loop observer and never get a chance to remove ourselves before the tabstrip is destroyed. BUG=14648 TEST=Open a new window and press the close button on the tab. The browser should not crash. Review URL: http://codereview.chromium.org/140006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18843 0039d316-1c4b-4281-b951-d872f2087c98
* First draft of web resource service; fetches data from a JSON feed mirandac@chromium.org2009-06-193-4/+2
| | | | | | | | | | | | and stores it in user prefs, where it can be used by the new tab page. BUG = http://crbug.com/13363 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18766 Review URL: http://codereview.chromium.org/125052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18842 0039d316-1c4b-4281-b951-d872f2087c98
* Implement the backend of SSL client authentication forwtc@chromium.org2009-06-194-34/+220
| | | | | | | | | | | | | | | | | Windows. Create Schannel SSPI CredHandles with certificates for SSL client authentication. Remember the client certificates that the user selected so that we don't ask the user again and again. R=rvargas,eroman BUG=http://crbug.com/318 TEST=none Review URL: http://codereview.chromium.org/131086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18841 0039d316-1c4b-4281-b951-d872f2087c98
* Enable DownloadRequestManager for Mac.paul@chromium.org2009-06-194-10/+3
| | | | | | | | | | | | | | | | DownloadRequestManager is the object that manages the number of downloads that can occur in a given tab. It throttles non-user initiated downloads to prevent carpet-bombing download attacks. Enabling this object for Mac fixes the issue where we can only download one file in a given tab. BUG=None (mac work). TEST=Can now download more than one item in a tab. Review URL: http://codereview.chromium.org/132039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18840 0039d316-1c4b-4281-b951-d872f2087c98
* We recently learned that loadable_modules should have the IgnoreImportLibrarybradnelson@chromium.org2009-06-192-4/+2
| | | | | | | | | | | | | setting turned on to prevent their dependencies from assuming they emit an import libary. This implies that these two targets should be loadable_module, rather than manually setting IgnoreImportLibrary. BUG=None TEST=None Review URL: http://codereview.chromium.org/132080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18839 0039d316-1c4b-4281-b951-d872f2087c98
* Follow up to my previous CL for adding IDS_UI_FONT resources to ↵cira@chromium.org2009-06-1950-225/+0
| | | | | | | | | | | | | app_locale_settings. Removing duplicate IDS_UI_FONT_ from locale_settings (already present in app_locale_settings). There are no code changes. BUG=http://crbug.com/7319 TEST=No test case, since we are removing dupes. The only check is to make sure code compiles (and it does). Review URL: http://codereview.chromium.org/131060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18838 0039d316-1c4b-4281-b951-d872f2087c98
* TBR: Fix Toolstrips sometimes show scrollbars as renderingaa@chromium.org2009-06-1910-11/+45
| | | | | | | See: http://codereview.chromium.org/126098 Patch from Jerry Tang <tangjie@google.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18837 0039d316-1c4b-4281-b951-d872f2087c98
* Disable flaky UI test.jparent@chromium.org2009-06-191-1/+2
| | | | | | | BUG=14731 Review URL: http://codereview.chromium.org/138001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18836 0039d316-1c4b-4281-b951-d872f2087c98
* Comments added to SSL unit tests.jrg@chromium.org2009-06-192-0/+35
| | | | | | Review URL: http://codereview.chromium.org/132081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18835 0039d316-1c4b-4281-b951-d872f2087c98
* linux: make extensions service test pass in Debug.evan@chromium.org2009-06-192-5/+3
| | | | | | | | | | | It only passes on the build bots because they still have old directories, I think? AbsolutePath() on POSIX will fail if the path doesn't exist. We let the program march on in that case and the normal error handling (that would handle the non-existent path) make the tests continue to pass. Review URL: http://codereview.chromium.org/132054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18834 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor FFmpegDemuxerTest to use gmock and eliminate flakiness.scherkus@chromium.org2009-06-195-438/+569
| | | | | | | | | | | | | | | This eliminates all final traces of the old global-functions-and-variables style of mocking, which was a massive headache to maintain and verify correctness. No new tests have been added, however gmock creates much stronger assertions for the tests themselves. I also made FFmpegDemuxerTest a friend of FFmpegDemuxer to let tests verify that all tasks on the internal demuxing thread have completed. BUG=13933 TEST=FFmpegDemuxerTest should more awesome and less flaky Review URL: http://codereview.chromium.org/126306 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18833 0039d316-1c4b-4281-b951-d872f2087c98
* Only select scalable fonts. Fixed-size fonts don't work with ↵thestig@chromium.org2009-06-191-0/+10
| | | | | | | | | | FT_Set_Char_Size in SkFontHost_FreeType.cpp. BUG=13007 TEST=On Linux, visit url with { font-family: fixed; } on a computer with pcf fonts. Review URL: http://codereview.chromium.org/131096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18832 0039d316-1c4b-4281-b951-d872f2087c98
* Add "Show all downloads" link to download shelf.thakis@chromium.org2009-06-193-6/+341
| | | | | | | | | | | BUG=14665 TEST=Download something, check that "show all downloads" text is on shelf, click it, check that the downloads tab opens. Review URL: http://codereview.chromium.org/132073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18831 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Fallback to SSL if server closes early during TLS handshake.willchan@chromium.org2009-06-191-1/+8
| | | | | | | | | BUG=http://crbug.com/14092 TEST=See bug for example TLS-intolerant server. Review URL: http://codereview.chromium.org/131085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18830 0039d316-1c4b-4281-b951-d872f2087c98
* Use correct calling convention for intercepted callcpu@google.com2009-06-191-2/+4
| | | | | | | | | | | - Thanks to zhu.she.pi@gmail.com for finding the bug BUG=14631 TEST=no test Review URL: http://codereview.chromium.org/131066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18827 0039d316-1c4b-4281-b951-d872f2087c98
* Add to watchlist.kuchhal@chromium.org2009-06-191-0/+8
| | | | | | Review URL: http://codereview.chromium.org/132076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18826 0039d316-1c4b-4281-b951-d872f2087c98
* Add merging algorithm for keychain and metadata db PasswordForms, and unit ↵stuartmorgan@chromium.org2009-06-193-0/+440
| | | | | | | | | | | | tests for it. Not used quite yet, since the metadata database still needs to be integrated into PasswordStoreMac. BUG=none TEST=none Review URL: http://codereview.chromium.org/131076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18825 0039d316-1c4b-4281-b951-d872f2087c98
* Add a suppression for couple of valgrind warnings in OpenGL.framework ↵stuartmorgan@chromium.org2009-06-191-0/+7
| | | | | | | | | | initialization. BUG=none TEST=Run ui_tests under valgrind; see fewer warning that we can't fix. Review URL: http://codereview.chromium.org/131081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18824 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a leak when we bail out early because of the wrong bpp.jhawkins@chromium.org2009-06-191-1/+3
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/131118 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18823 0039d316-1c4b-4281-b951-d872f2087c98
* Fix compile error.pinkerton@chromium.org2009-06-191-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18822 0039d316-1c4b-4281-b951-d872f2087c98
* Make escape close the prefs window.pinkerton@chromium.org2009-06-191-0/+7
| | | | | | | | BUG=none TEST=fields in the middle of being editing should not save the value. Review URL: http://codereview.chromium.org/131113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18821 0039d316-1c4b-4281-b951-d872f2087c98
* Add a temporary command-line switch --auto-ssl-client-auth forwtc@chromium.org2009-06-194-4/+34
| | | | | | | | | | | | | | | | | automatically selecting a client certificate when an SSL server requests client authentication. This switch will be removed when we implement client certificate selection UI. Also fix some cpplint.py nits. R=jcampan BUG=http://crbug.com/318 TEST=none Review URL: http://codereview.chromium.org/131090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18819 0039d316-1c4b-4281-b951-d872f2087c98
* DEPS roll to revert gyp change that broke Chromium Linux builder.sgk@google.com2009-06-191-1/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/131117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18818 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Enable 'Inspect element' on chromeui content while in debug mode.pfeldman@chromium.org2009-06-191-1/+6
| | | | | | Review URL: http://codereview.chromium.org/132071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18817 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: make import warning dialog modal.kuchhal@chromium.org2009-06-194-3/+14
| | | | | | | | | | | | Make ImporterHost aware of the current parent window and use that as parent for the warning dialog. BUG=13481 TEST=Start Firefox, try to import profile in Chrome and make sure the warning dialog is modal. Review URL: http://codereview.chromium.org/131080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18816 0039d316-1c4b-4281-b951-d872f2087c98
* Add Print Selection support to Chrome. This change is fairly involved since ↵sverrir@google.com2009-06-1920-128/+162
| | | | | | | | | | | | | | | | this means that the printing is done async instead of the fully synchronous mode the normal full page printing is. This means we create an in memory copy of the selected text for printing. This is the next step to move to fully async printing with print frame support. This change also removes the print on demand functionality that was no longer used. BUG=http://crbug.com/1682 TEST=The print dialog on Windows now contains an option to print selection only. Test that with various pages and various selections. Review URL: http://codereview.chromium.org/125082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18815 0039d316-1c4b-4281-b951-d872f2087c98
* Changing the mode we pull events in, so we don't fire off timers and ↵avi@google.com2009-06-191-3/+5
| | | | | | | | | | | notifications. BUG=http://crbug.com/14609 TEST=No immediate test; see that the specified crash in the bug report stops happening. Review URL: http://codereview.chromium.org/132070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18814 0039d316-1c4b-4281-b951-d872f2087c98
* Add 'theme_dll' as a dependency of 'chrome_dll'.sgk@google.com2009-06-192-4/+2
| | | | | | | | | gyp DEPS roll so loadable_module targets ignore import libraries. BUG=none TEST=none Review URL: http://codereview.chromium.org/131109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18813 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the redness on the new Google Chrome continuous builder by notnsylvain@chromium.org2009-06-191-1/+3
| | | | | | | | running the mini_installer_tests that need to access the previous installers, since they are not accessible from this buildbot. Review URL: http://codereview.chromium.org/131070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18812 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline some Linux specific layout test differences from r18803.deanm@chromium.org2009-06-1912-6/+6
| | | | | | | | | | | | Skia's gradient drawing has changed a slight bit. None of the differences are noticable visually. These changes were specific to Linux and didn't happen on Windows since we use Skia gradients for drawing our form buttons on Linux. Inspected each difference manually, and they look ok. Review URL: http://codereview.chromium.org/131111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18811 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: add fake callframe for live object expansion in console.pfeldman@chromium.org2009-06-191-1/+7
| | | | | | Review URL: http://codereview.chromium.org/132068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18810 0039d316-1c4b-4281-b951-d872f2087c98
* Display an infobar alert when extension process crashes.phajdan.jr@chromium.org2009-06-199-32/+190
| | | | | | | | | | | | Also correctly handle crashes in task manager. The infobar allows user to restart the extension process. TEST=Install buildbot extension, see its content in the shelf. Open task manager, kill extension process. Click "restart" in the infobar that should appear. The extension content in the shelf should re-appear after the crash. http://crbug.com/14111 Review URL: http://codereview.chromium.org/126289 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18809 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline Linux layout tests for the Skia roll in r18803.deanm@chromium.org2009-06-1952-26/+26
| | | | | | | Review URL: http://codereview.chromium.org/131110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18808 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: remove dock/undock buttonpfeldman@chromium.org2009-06-191-1/+5
| | | | | | | BUG=25 Review URL: http://codereview.chromium.org/131108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18807 0039d316-1c4b-4281-b951-d872f2087c98
* Implement restoring closed tab menu item. Reworked cross-platform code to ↵pinkerton@chromium.org2009-06-1910-80/+181
| | | | | | | | | | handle the case of restoring when there are no browsers open by making window restore re-use a given browser if it has no tabs. Removed unit test that assumes it can pass a NULL Browser. Wrote a new UI test to cover the same area, but it's disabled until another bug is fixed, and I didn't want to hold up landing this feature. Added key shortcut for "open window in incognito mode". BUG=13758 TEST=restoring closed tabs with visible windows and with no windows remaining open. Review URL: http://codereview.chromium.org/125257 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18806 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: fix crash when inspect element invoked on the root element.pfeldman@chromium.org2009-06-191-4/+4
| | | | | | Review URL: http://codereview.chromium.org/131106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18805 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unnecessary devtool_sanity_unittest.cc entries from 'unit_tests'.sgk@chromium.org2009-06-191-4/+0
| | | | | | | | BUG=14639 TEST=none Review URL: http://codereview.chromium.org/132067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18804 0039d316-1c4b-4281-b951-d872f2087c98
* Roll Skia up to r224, for a few bug fixes.deanm@chromium.org2009-06-1983-42/+42
| | | | | | | | | | | | | | | Most importantly this fixes a spline drawing error and a possible Linux crash when failing to load a font. The rebaselines are mostly due to minor gradient changes (Skia changes r212 and r213). There was one layout test that was hitting the spline drawing bug, and the results now look correct (svg-as-background-5.html). BUG=13007,14536 Review URL: http://codereview.chromium.org/131105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18803 0039d316-1c4b-4281-b951-d872f2087c98
* Don't grant unnecessary handle privileges in OpenProcessHandle.phajdan.jr@chromium.org2009-06-194-9/+8
| | | | | | | | | This patch makes it harder for process handles with more privileges to leak to untrusted places. Review URL: http://codereview.chromium.org/125260 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18802 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a valgrind error related to Zygote's CommandLine usage.craig.schlenter@chromium.org2009-06-193-5/+12
| | | | | | | | Also touch up some include guards and a comment. Review URL: http://codereview.chromium.org/131054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18801 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: add devtools.css to webkit.gyp. It should have been added as part ↵yurys@google.com2009-06-193-3/+4
| | | | | | | | of http://codereview.chromium.org/125116 Review URL: http://codereview.chromium.org/131103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18800 0039d316-1c4b-4281-b951-d872f2087c98