summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* FBTF: Monster ctor patch after changing heuristics in clang plugin.erg@google.com2010-10-1885-182/+498
| | | | | | | | | | | (Only 916k this time off Debug Linux .a files) BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3814013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62967 0039d316-1c4b-4281-b951-d872f2087c98
* Update the list of plugin tests suppressed for Mac valgrindstuartmorgan@chromium.org2010-10-181-0/+3
| | | | | | | | | BUG=30661 TEST=Greener valgrind bot Review URL: http://codereview.chromium.org/3829006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62966 0039d316-1c4b-4281-b951-d872f2087c98
* Move chromotocol.proto to remoting/protocolhclam@chromium.org2010-10-1826-188/+238
| | | | | | | | | | | Move the proto file and split it into multiple smaller proto files. BUG=None TEST=None Review URL: http://codereview.chromium.org/3808002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62965 0039d316-1c4b-4281-b951-d872f2087c98
* Reserve right-most column of apps grid for web store icon.aa@chromium.org2010-10-183-8/+58
| | | | | | | | | | | | | | | | | | | | When there is less than one complete row of apps, position the web store icon naturally in the grid, to the right of the other apps. Once there is at least one complete row, position the web store icon at the top of the right-most column. BUG=58857 TEST=Install a few apps. Web store icon should be in top row directly to the right of the other apps. Install more apps. Once you have more than one row, web store icon should stay in top right corner by itself. No other apps should go below it. Review URL: http://codereview.chromium.org/3747007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62962 0039d316-1c4b-4281-b951-d872f2087c98
* Use TabContents for Constrained HTML dialogs.estade@chromium.org2010-10-184-31/+175
| | | | | | | | | | | This makes constrained html windows match HtmlDialogUI more closely. The main reason for wanting to do this is that TabContents{View} has a lot of functionality that we need, but miss out on if we use RenderViewHost directly. This isn't hooked up to anything yet, but can be tested using sync setup. BUG=58022 TEST=manual Review URL: http://codereview.chromium.org/3846002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62961 0039d316-1c4b-4281-b951-d872f2087c98
* Delete unreferenced chrome switches.estade@chromium.org2010-10-182-40/+0
| | | | | | | | | BUG=none TEST=compile Review URL: http://codereview.chromium.org/3744011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62960 0039d316-1c4b-4281-b951-d872f2087c98
* Convert LOG(INFO) to VLOG(1) - base/.pkasting@chromium.org2010-10-1814-51/+45
| | | | | | | | | | Also removes an "else" after "return" and aligns "<<" per style guide. BUG=none TEST=none Review URL: http://codereview.chromium.org/3845002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62959 0039d316-1c4b-4281-b951-d872f2087c98
* Pass test server port to javascript part of extensions API tests.skerner@chromium.org2010-10-1814-607/+787
| | | | | | | | | BUG=56715 TEST=ExtensionApiTests.(I18N|History|Clipboard,TabConnect) Review URL: http://codereview.chromium.org/3728004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62958 0039d316-1c4b-4281-b951-d872f2087c98
* Move the rest of the Extension data into either StaticData or RuntimeDatampcomplete@chromium.org2010-10-1814-302/+380
| | | | | | | | | | | | | | subclasses. The ultimate goal is to move StaticData back up to the top level, so that Extension itself will be a thread-safe immutable object. I plan on making Extension refcounted, and const everywhere that it doesn't need to be initialized. RuntimeData will be the only thing mutable, and then only on the UI thread. BUG=56550 TEST=extensions still work Review URL: http://codereview.chromium.org/3757001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62957 0039d316-1c4b-4281-b951-d872f2087c98
* Try to green the memory bots. This is just a band-aid, since my previous ↵jam@chromium.org2010-10-181-1/+0
| | | | | | | | | | change exposed the problem with tcmalloc being initialized twice by the test plugin. The effect of this band-aid is that the settings won't be saved right away, which is what's loading the plugin. BUG=59317 TBR=cpu Review URL: http://codereview.chromium.org/3775013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62956 0039d316-1c4b-4281-b951-d872f2087c98
* Update Dr. Memory suppressions to match anonymous namespaces i ToolSanityTeststimurrrr@chromium.org2010-10-181-16/+16
| | | | | | | TBR=glider Review URL: http://codereview.chromium.org/3837006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62955 0039d316-1c4b-4281-b951-d872f2087c98
* add wave out extensible support for 5.1 surround soundfbarchard@chromium.org2010-10-182-18/+36
| | | | | | | | | BUG=25315 TEST=play 5.1 audio and it should come out all 6 speakers, not downmixed to stereo. Review URL: http://codereview.chromium.org/3772009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62954 0039d316-1c4b-4281-b951-d872f2087c98
* Fix typo SetUseSSL2CheckboxStatechecked => SetUseSSL2CheckboxStatewtc@chromium.org2010-10-182-8/+20
| | | | | | | | | | | | | | | | | and similar typos for SSL3 and TLS1 checkboxes. Disable the SSL settings checkboxes if net::SSLConfigServiceWin::GetSSLConfigNow fails. R=mattm BUG=59125 TEST=On Windows, run chrome.exe --enable-tabbed-options. Open the wrench menu > Settings > Under the Hood. The "Use SSL 2.0", "Use SSL 3.0", and "Use TLS 1.0" checkboxes should reflect the actual settings rather than being all unchecked. Review URL: http://codereview.chromium.org/3772014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62953 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Always use the grippy cursor while dragging the ↵rsesek@chromium.org2010-10-181-2/+5
| | | | | | | | | | | BrowserActionsContainerView. BUG=36697 TEST=Install a few extensions with browser actions. Resise the container and move the mouse over the web contents and the Omnibox. Cursor remains the grippy, rather than the pointer. Review URL: http://codereview.chromium.org/3839003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62952 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure to use scoped_refptr for refcounted params in audio/video/remotingwillchan@chromium.org2010-10-188-22/+41
| | | | | | | | | BUG=28083 TEST=existing Review URL: http://codereview.chromium.org/3821005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62949 0039d316-1c4b-4281-b951-d872f2087c98
* Pull latest PPAPIbrettw@chromium.org2010-10-181-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62947 0039d316-1c4b-4281-b951-d872f2087c98
* Increased timeout for select() call.avayvod@chromium.org2010-10-182-5/+9
| | | | | | | | | | | Removed handling of capture failure to avoid image flickering. BUG=chromiumos:7612 TEST=Login with new user, verify that camera image doesn't flicker changing from actual image to broken camera image and back in any circumstances. Review URL: http://codereview.chromium.org/3799008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62946 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize data members in constructor.kmadhusu@chromium.org2010-10-187-4/+12
| | | | | | | | | | CID=1634, 11587, 5007, 13234, 13398, 9295, 8294, 8285 BUG=none TEST=none Review URL: http://codereview.chromium.org/3817007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62945 0039d316-1c4b-4281-b951-d872f2087c98
* Makes it so we show the instant confirm dialog until the user clickssky@chromium.org2010-10-183-3/+6
| | | | | | | | | | | ok. BUG=59148 TEST=none Review URL: http://codereview.chromium.org/3803007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62944 0039d316-1c4b-4281-b951-d872f2087c98
* Don't rely on "access_time < Time::Now()" to indicate "all cookies".rdsmith@google.com2010-10-183-11/+6
| | | | | | | | | | | | | | | | The interface to CookieMonster::GarbageCollectDeleteList() was signalling "delete all cookies in list" by specifying "delete all cookies in list with last access time before Now()". This was failing to work properly when the system clock wasn't updated frequently enough (== flaky test) and is also vulnerable to changes in systems clocks. That semantic is now explicitly signalled by a null time. BUG=58197 TEST=net_unittests CookieMonsterTest.* on Win/Linux and CookieMonsterTest.TestHostGarbageCollection (flaky test) repeatedly on Windows. Review URL: http://codereview.chromium.org/3780004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62943 0039d316-1c4b-4281-b951-d872f2087c98
* Fix poorly performancing implementation of MockSimplePersistentCookieStorerdsmith@google.com2010-10-182-28/+18
| | | | | | | | | BUG=57686 TEST=net_unittests CookieMonsterTest.* on Linux, running original valgrind test and confirming that it completed. Review URL: http://codereview.chromium.org/3752004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62942 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for r62662 (Wrong -logdir path for Dr.Memory)timurrrr@chromium.org2010-10-181-1/+1
| | | | | | | | TBR=glider,mrossetti TEST=Dr. Memory FYI bot should go up again Review URL: http://codereview.chromium.org/3809007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62941 0039d316-1c4b-4281-b951-d872f2087c98
* Call SceenConfigurationChanged from CapturerFake constructor.sergeyu@chromium.org2010-10-181-0/+1
| | | | | | | | | | | CapturerFake doesn't work without this change because screen parameters are never initialized. BUG=None TEST=None Review URL: http://codereview.chromium.org/3801010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62938 0039d316-1c4b-4281-b951-d872f2087c98
* Makes NativeFrameView implement GetPreferredSize. Without this wesky@chromium.org2010-10-187-14/+47
| | | | | | | | | | | | | | | | | | | don't correctly return a preferred/minimum size and the options dialog can end up getting clipped (because the cached size is too small). Also, makes the options window always use the minimum size when showing. This way if we happen to remove an option such that the dialog is smaller the dialog won't end up too big. BUG=59122 TEST=With aero enabled bring up the options dialog on M6/M7. Then bring up the options dialog with this fix enabled and make sure you don't get any clipping. Review URL: http://codereview.chromium.org/3825006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62937 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some problems with the ENTER_PASSPHRASE state in sync setup.johnnyg@chromium.org2010-10-1812-21/+75
| | | | | | | | | BUG=48706 TEST=none Review URL: http://codereview.chromium.org/3792007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62935 0039d316-1c4b-4281-b951-d872f2087c98
* Fix clang warning about local types being used as template parameters.thakis@chromium.org2010-10-181-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | clang would complain /Users/thakis/src/chrome-git/src/net/base/host_resolver_impl.cc:557:5: error: template argument uses local type 'net::HostResolverImpl::Job::Category' [-Wlocal-type-template-args] DCHECK_LT(category, RESOLVE_MAX); // Be sure it was set. ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from /Users/thakis/src/chrome-git/src/net/base/host_resolver_impl.cc:5: In file included from ../net/base/host_resolver_impl.h:18: In file included from ../net/base/network_change_notifier.h:10: In file included from ../base/observer_list_threadsafe.h:14: ../base/logging.h:662:31: note: instantiated from: #define DCHECK_LT(val1, val2) DCHECK_OP(LT, < , val1, val2) ^ ../base/logging.h:635:9: note: instantiated from: logging::Check##name##Impl((val1), (val2), \ ^~~~~~~ This seems to be a new warning. Since it only affects this file, we might as well fix the problem instead of disabling the warning. BUG=None TEST=clang/mac waterfall stays green after clobber build. Review URL: http://codereview.chromium.org/3816009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62934 0039d316-1c4b-4281-b951-d872f2087c98
* Show the current logged-in username on the NTP.johnnyg@chromium.org2010-10-188-0/+163
| | | | | | | | | BUG=58024 TEST=included, for manual test sign into sync then go to NTP Review URL: http://codereview.chromium.org/3784004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62933 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Remove the PageInfoWindow now that the Bubble is finished.rsesek@chromium.org2010-10-188-600/+4
| | | | | | | | | BUG=59030 TEST=compile Review URL: http://codereview.chromium.org/3837004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62932 0039d316-1c4b-4281-b951-d872f2087c98
* Fix one-time version check for Mac plugin IMEstuartmorgan@chromium.org2010-10-181-0/+1
| | | | | | | | | | | One-time checks work better when you remember that you've done them. BUG=None TEST=None Review URL: http://codereview.chromium.org/3779011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62930 0039d316-1c4b-4281-b951-d872f2087c98
* Remove port constants from src/chrome/browser/extensions/ .skerner@chromium.org2010-10-184-21/+52
| | | | | | | | | | | | Fixing the javascript side of extensions tests will be done in another CL. R=phajdan.jr@chromium.org BUG=56715 TEST=ExtensionApiTest.PopupBlockingHostedApp,AppApiTest.AppProcess,ExtensionBrowserTest.Incognito* Review URL: http://codereview.chromium.org/3440035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62928 0039d316-1c4b-4281-b951-d872f2087c98
* Virtual destructor cleanup: RRResolverHandle::Run does not need to be virtual.cbentzel@chromium.org2010-10-181-2/+2
| | | | | | | | BUG=45135 TEST=Build works. Review URL: http://codereview.chromium.org/3747008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62927 0039d316-1c4b-4281-b951-d872f2087c98
* non-virtual-dtor cleanup: Make DNSSecProvider destructor private.cbentzel@chromium.org2010-10-181-0/+3
| | | | | | | | | | Interface classes are an example where the -Wnon-virtual-dtor warning can be a bit annoying, but this still seems reasonable and makes it clear that users should not delete through the interface. BUG=45135 TEST=Builds Review URL: http://codereview.chromium.org/3781010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62926 0039d316-1c4b-4281-b951-d872f2087c98
* Caches DER data in X509 certificate for OpenSSL.bulach@chromium.org2010-10-181-26/+94
| | | | | | | | | BUG=none TEST=net_unittests --gtest_filter=*X509* Review URL: http://codereview.chromium.org/3785001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62925 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 2 speech input display issues seen in the M8 dev channel build.satish@chromium.org2010-10-182-13/+13
| | | | | | | | | | | | - The animation code was splitting the sprite into multiple bitmaps by drawing them onto a smaller canvas. In the mac build this was generating corrupted frames due to what appears like a Skia issue. I'm reporting this to the Skia team and in the mean time working around it by calling .extractSubset and copying it into a new bitmap. The copying-to-new-bitmap is required because without that it renders incorrectly squished vertically in Linux (!). - The speech bubble was positioned at the wrong X coordinate on Mac. Earlier we had to manually adjust the X coordinate to get the arrow point at the position we want, but now the base info bubble code already takes care of it so our adjustment is no longer needed. BUG=none TEST=manual, try speech input and verify that the animation looks right on all platforms and the bubble is positioned pointing at the text. Review URL: http://codereview.chromium.org/3859001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62924 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 62918 - net: clean up SSLHostInfo construction.agl@chromium.org2010-10-1850-244/+98
| | | | | | | | | | | | | | | | Create an SSLHostInfoFactory interface and plumb it from the HttpCache to the SSLConnectJob. Also, move the SSLHostInfo reference from the ssl_config to being passed to the SSLClientSocket. BUG=none TEST=net_unittests Review URL: http://codereview.chromium.org/3747003 TBR=agl@chromium.org Review URL: http://codereview.chromium.org/3846005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62922 0039d316-1c4b-4281-b951-d872f2087c98
* Update codereview.settings GITCL_* urls for new viewvc server url format.maruel@chromium.org2010-10-181-2/+2
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/3822009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62919 0039d316-1c4b-4281-b951-d872f2087c98
* net: clean up SSLHostInfo construction.agl@chromium.org2010-10-1850-98/+244
| | | | | | | | | | | | | Create an SSLHostInfoFactory interface and plumb it from the HttpCache to the SSLConnectJob. Also, move the SSLHostInfo reference from the ssl_config to being passed to the SSLClientSocket. BUG=none TEST=net_unittests Review URL: http://codereview.chromium.org/3747003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62918 0039d316-1c4b-4281-b951-d872f2087c98
* Adjust expectations for vistadual/morejs.chase@chromium.org2010-10-181-1/+1
| | | | | | | | | | BUG=none TEST=vistadual/morejs is green TBR=nsylvain@chromium.org Review URL: http://codereview.chromium.org/3750016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62917 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress crash in WebCore::UniscribeHelperTextRun::UniscribeHelperTextRun ↵tyoshino@chromium.org2010-10-181-0/+3
| | | | | | | | | | | | found by reliability bot. R=yutak BUG=31936 TEST=none Review URL: http://codereview.chromium.org/3844003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62914 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 62910 - WebKit merge 60808:69821hayato@chromium.org2010-10-181-1/+1
| | | | | | | | | | | | | | | | See http://code.google.com/p/chromium/issues/detail?id=59533. Try to roll up r69821 and see what happens. BUG=none TEST=none TBR=jamesr Review URL: http://codereview.chromium.org/3821006 TBR=hayato@chromium.org Review URL: http://codereview.chromium.org/3781015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62913 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 62911 - WebKit merge 60821:69822hayato@chromium.org2010-10-181-1/+1
| | | | | | | | | | | | | | | | See http://code.google.com/p/chromium/issues/detail?id=59533. Try to roll up r69822 and see what happens. BUG=none TEST=none TBR=jamesr Review URL: http://codereview.chromium.org/3836007 TBR=hayato@chromium.org Review URL: http://codereview.chromium.org/3814012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62912 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit merge 60821:69822hayato@chromium.org2010-10-181-1/+1
| | | | | | | | | | | | | See http://code.google.com/p/chromium/issues/detail?id=59533. Try to roll up r69822 and see what happens. BUG=none TEST=none TBR=jamesr Review URL: http://codereview.chromium.org/3836007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62911 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit merge 60808:69821hayato@chromium.org2010-10-181-1/+1
| | | | | | | | | | | | | See http://code.google.com/p/chromium/issues/detail?id=59533. Try to roll up r69821 and see what happens. BUG=none TEST=none TBR=jamesr Review URL: http://codereview.chromium.org/3821006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62910 0039d316-1c4b-4281-b951-d872f2087c98
* Marking GeneralMixMemoryTest.FiveTabTest flaky on Win bottyoshino@chromium.org2010-10-181-1/+7
| | | | | | | | | | R=yutak BUG=59335 TEST=none Review URL: http://codereview.chromium.org/3781013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62909 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 62802 - WebKit merge 69860:69873hayato@chromium.org2010-10-181-1/+1
| | | | | | | | | | | | | | | r62802 might cause http://code.google.com/p/chromium/issues/detail?id=59533. BUG=none TEST=green TBR=hayato Review URL: http://codereview.chromium.org/3839001 TBR=japhet@chromium.org Review URL: http://codereview.chromium.org/3803009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62908 0039d316-1c4b-4281-b951-d872f2087c98
* Extend reliability bot failure suppression for do_free_with_callbacktyoshino@chromium.org2010-10-181-0/+1
| | | | | | | | | | R=hayato BUG=57041 TEST=none Review URL: http://codereview.chromium.org/3822008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62907 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress reliability bot failure in WindowDragResponseTask::Runtyoshino@chromium.org2010-10-181-0/+3
| | | | | | | | | | R=hayato BUG=59345 TEST=none Review URL: http://codereview.chromium.org/3762010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62906 0039d316-1c4b-4281-b951-d872f2087c98
* Move scoped_nsdisable_screen_update from base to app/macbrettw@chromium.org2010-10-1851-137/+151
| | | | | | | | | | | Move scoped_aedesc from base to base/mac Use namespace and proper Google-style class naming. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3828009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62904 0039d316-1c4b-4281-b951-d872f2087c98
* Move chrome/browser/cocoa/download_* to chrome/browser/cocoa/download/.viettrungluu@chromium.org2010-10-1828-79/+77
| | | | | | | | | BUG=none TEST=builds Review URL: http://codereview.chromium.org/3813008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62903 0039d316-1c4b-4281-b951-d872f2087c98
* Move BaseDropTarget and BaseDragSource from base to app/win. Remove the ↵brettw@chromium.org2010-10-1719-205/+203
| | | | | | | | | | "Base" class name prefix and put in the app::win namespace. TEST=none BUG=none Review URL: http://codereview.chromium.org/3822007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62900 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-15 04:42:47 +0000