| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
R=levin
BUG=3319
TEST=no test regressions
Review URL: http://codereview.chromium.org/113372
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16546 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=http://codereview.chromium.org/112044
Note pieces of chrome.gyp come from a different CL
(keystone_glue work associated with this).
Review URL: http://codereview.chromium.org/113614
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16545 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Test expectation has updates for new failures along with
bugs that list the change that caused the failures.
BUG=0
TEST=none
Review URL: http://codereview.chromium.org/115594
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16544 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
r496 | sgk@chromium.org | 2009-05-20 11:11:15 -0700 (Wed, 20 May 2009) | 3 lines
Make copied files part of target_files, not prerequisites, so they get
installed even if the target has no other output files.
Review URL: http://codereview.chromium.org/113647
Review URL: http://codereview.chromium.org/113666
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16543 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115591
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16542 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Uploaded the following images:
muted: webkit\glue\resources\media_sound_none.png
not muted: webkit\glue\resources\media_sound_full.png
play: webkit\glue\resources\media_play.png
pause: webkit\glue\resources\media_pause.png
Review URL: http://codereview.chromium.org/113668
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=http://codereview.chromium.org/112044
chrome.gyp caught in a different CL but here is the relevant part of
the diff:
--- chrome.gyp (revision 16158)
+++ chrome.gyp (working copy)
@@ -2679,6 +2682,11 @@
],
'sources': [
'app/breakpad_mac_stubs.mm',
+ # *NO* files in chrome/app have unit tests (except keystone_glue)!!!
+ # It seems a waste to have an app_unittests target, so for now
+ # I add keystone_glue.m explicitly to this target.
+ 'app/keystone_glue.m',
+ 'app/keystone_glue_unittest.mm',
# All unittests in browser, common, and renderer.
'browser/autocomplete/autocomplete_unittest.cc',
'browser/autocomplete/autocomplete_popup_view_mac_unittest.mm',
Review URL: http://codereview.chromium.org/113613
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16540 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/11942
Review URL: http://codereview.chromium.org/115589
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16539 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This reverts commit 5b2fc12fbca26b20ed4176ac740c58fe49360c4a.
Review URL: http://codereview.chromium.org/113664
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16538 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=levin
Review URL: http://codereview.chromium.org/113663
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16537 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115586
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16535 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- slight refactor
TEST= there are no tests
BUG= http://b/issue?id=1860803
Review URL: http://codereview.chromium.org/113605
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16534 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Note that this is temporary in that, in the long run, we should be using mime type filters rather than shell-style globs.
TEST=right click/save as on a link. There should be no "*." filter.
Review URL: http://codereview.chromium.org/113660
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16533 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. Makes closing widget work.
. Makes clicking button send action.
. Fixes ownership of native controls.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/113657
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16532 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
at some point.
Review URL: http://codereview.chromium.org/115590
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16531 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
They should not be modified here (and especially should not be undone
in TearDown since it breaks things for following unit tests).
Review URL: http://codereview.chromium.org/115554
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16530 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also removed all external dependencies from ExtensionsService.
It now only sends out notifications, which other services
consume. This should allow us to unit test the
ExtensionsService frontend, but I haven't added that yet.
Review URL: http://codereview.chromium.org/113493
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16529 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
open multiple chrome processes, the first one just opens a new window.
This is based on http://codereview.chromium.org/88067 by Nikita
Ofitserov (himikof).
BUG=8073
Review URL: http://codereview.chromium.org/115572
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16528 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
convert the remaining ones, but this is enough for a first pass.
I also added a new disabled test, which will soon be enabled.
BUG=None
TEST=This whole changelist is about tests. :)
Review URL: http://codereview.chromium.org/113646
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16527 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
I filed http://crbug.com/12334 to fix the ifdefed-out block in ui_test.cc.
Review URL: http://codereview.chromium.org/113655
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16526 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the decoder.
Turns out packets filled out by av_read_frame() were being modifying on subsequent calls to av_read_frame(). Might be a case of setting the data pointer to internal memory as opposed to allocated memory.
Review URL: http://codereview.chromium.org/115561
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16525 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
I got rid of the border padding in an attempt to more closely match windows, where the bookmark bar is very compact.
BUG=http://crbug.com/12216
Review URL: http://codereview.chromium.org/115551
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113654
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16523 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The heart of this is that I wrapped up the request to the feed in a timeout and a bunch more error handling and abstracted all that into one function so I could be sure all the errors were getting handled the same way.
Also general cleaning while I was in there.
BUG=11969
TEST=Install Gmail Checker, go offline, go back online. It should start showing message counts again when you go back online.
Review URL: http://codereview.chromium.org/115584
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16522 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=sky
Review URL: http://codereview.chromium.org/113658
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16521 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
bitmap to a GdkPixbuf and caches the image so ThemeProvider users don't need to release them ala ResourceBundle::GetPixbufNamed.
Review URL: http://codereview.chromium.org/113626
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16520 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/12304
Review URL: http://codereview.chromium.org/115581
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16519 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://www.crbug.com/11847.
TEST=Navigate to an interstitial page. Click on Proceed. It should not crash.
Review URL: http://codereview.chromium.org/115549
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16518 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add failures for recurring layout tests failures.
This reverts part of r16498 which removed one of these test but the test
is failing consistently now.
BUG=http://crbug.com/12002, http://crbug.com/12340, http://crbug.com/12341
TEST=none needed. Just test expectations update.
Review URL: http://codereview.chromium.org/115585
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16517 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16516 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
build.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16515 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
(second attempt).
Previously we were using integer math to convert to microseconds, but depending on the frame rate and packet size we could introduce enough error that could accumulate and introduce audio/video synchronization drift. av_rescale_q() is a simple function but is designed to minimize error as much as possible.
Second attempt since I forgot to manually resolve av_rescale_q() for unittests.
Review URL: http://codereview.chromium.org/113619
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16514 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/11387
Review URL: http://codereview.chromium.org/113612
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Added a default in common.gypi to remove headers from all mac applications that are bundles.
Added a var to control the inclusion of keystone to chrome.gyp defaulted on branding and then honor it for the shipping work.
Review URL: http://codereview.chromium.org/113652
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16510 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16509 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16508 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=9007
Review URL: http://codereview.chromium.org/113487
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16506 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115579
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16505 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
A subsequent change will modify these files.
(Retrying previous change.)
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16504 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16503 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
A subsequent change will modify these files.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16502 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
FontDisplayView::SetFontType is overloaded and has two function signatures, but one of them became obsolete (its implementation is not synchronized with the other) and is no longer used.
TEST=none
Review URL: http://codereview.chromium.org/113610
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16501 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113638
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16500 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=dglazkov
Review URL: http://codereview.chromium.org/113651
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16498 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
sending them. This makes it so that types sendable via IPC no longer need
copy constructors.
BUG=12296
Review URL: http://codereview.chromium.org/112042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16497 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115576
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16496 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
render at (0,0) to match windows metrics. This helps eliminate differences between the two tab rendering implementations.
TEST=Open multiple tabs. Make sure the tabs are rendered correctly (close button, elided title text, favicon, sad tab crash animation).
Review URL: http://codereview.chromium.org/113623
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113648
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16494 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://build.chromium.org/buildbot/waterfall.fyi/waterfall?builder=Webkit%20%28webkit.org%29
This is the same code that was there upstream before these methods
became pure virtual.
TBR=dglazkov
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16492 0039d316-1c4b-4281-b951-d872f2087c98
|