summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fixes an invalid read bug in ClientSocketPoolBaseHelper and cancels ↵willchan@chromium.org2010-06-032-0/+38
| | | | | | | | | | | | | ConnectJobs on network changes. The bug seems to be running callbacks that delete the ClientSocketPoolBaseHelper object. We need to hold onto a self-reference in the stack frame. The new test does not crash, but will trigger invalid reads in valgrind without the fix. The fixes are overly conservative. At every entry point that can lead to releasing the last reference, we hold onto a self-reference. Not all of them can currently lead to crashes since the last operation is running the callback. But this conservative measure will help future-proof the code in case anyone adds code without thinking about it. The references are cheap anyway. BUG=44724 Review URL: http://codereview.chromium.org/2250001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48895 0039d316-1c4b-4281-b951-d872f2087c98
* Add a temporary test exception until the next WK roll.johnnyg@chromium.org2010-06-031-1/+5
| | | | | | | | | | TBR=pkasting BUG=none TEST=none Review URL: http://codereview.chromium.org/2625001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48894 0039d316-1c4b-4281-b951-d872f2087c98
* Change the test notification presenter to fire the display event ↵johnnyg@chromium.org2010-06-031-1/+11
| | | | | | | | | | | asynchronously, as this is what the spec calls for and enables more correct layout tests. BUG=none TEST=none Review URL: http://codereview.chromium.org/2608001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48893 0039d316-1c4b-4281-b951-d872f2087c98
* Fix submenu support for extensions context menu API.asargent@chromium.org2010-06-035-194/+162
| | | | | | | | | | | | | | | | This fixes submenus which broke on all platforms during a recent refactor of the RenderViewContextMenu class, and adds support for more than one level of child menus. BUG=39504 TEST=Create a test extension using the chrome.experimental.contextMenu API and add multiple levels of child menu items. Review URL: http://codereview.chromium.org/2443002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48892 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug in NPDrawingModelInvalidatingCoreAnimation, and make it more efficientstuartmorgan@chromium.org2010-06-032-5/+7
| | | | | | | | | | | | | Fixes a conditional mistake introduced with the new drawing model. Skips unnecessary work when a NPDrawingModelInvalidatingCoreAnimation plugin calls invalidate. Removes some obsolete comments (the renaming in question already happened) BUG=None TEST=Core Animation plugins still work Review URL: http://codereview.chromium.org/2578004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48891 0039d316-1c4b-4281-b951-d872f2087c98
* Navigating to a page in ChromeFrame in IE would display the sad tab page ↵ananta@chromium.org2010-06-036-11/+25
| | | | | | | | | | | | | | | briefly until the navigation was initiated from IE. We have code in the ChromeFrame external tab container to initiate the navigation during initialization if we have a valid url passed in while creating the external tab. The URL would not get passed down even though it was available from ChromeFrame. This fixes bug http://code.google.com/p/chromium/issues/detail?id=43482 Bug=43482 Review URL: http://codereview.chromium.org/2600002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48890 0039d316-1c4b-4281-b951-d872f2087c98
* Disabled InstallApps while I fix the text on Linux.mpcomplete@chromium.org2010-06-031-1/+3
| | | | | | | | BUG=41280 Review URL: http://codereview.chromium.org/2618002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48889 0039d316-1c4b-4281-b951-d872f2087c98
* Generated omnibox doc.kathyw@chromium.org2010-06-032-0/+603
| | | | | | | | | | TBR=mpcomplete BUG=none TEST=none Review URL: http://codereview.chromium.org/2555003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48887 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent installation of an app if its web extent overlaps another installed app.mpcomplete@chromium.org2010-06-038-11/+70
| | | | | | | | BUG=41280 Review URL: http://codereview.chromium.org/2469004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48886 0039d316-1c4b-4281-b951-d872f2087c98
* Remove BOM from js and css files in content script.cira@chromium.org2010-06-032-21/+51
| | | | | | | | | BUG=38152 TEST=Inject css file with BOM using an extension. It should be injected without BOM. Review URL: http://codereview.chromium.org/2453005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48885 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Repaint the toolbar after the bookmark bar has finished.erg@google.com2010-06-033-1/+20
| | | | | | | | | | | | This issue has been here for forever (or at least as long as far back as the bisect script will let me check). BUG=44502 TEST=See bug. Review URL: http://codereview.chromium.org/2616001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48884 0039d316-1c4b-4281-b951-d872f2087c98
* Wrap Sqlite utils functions into a sqlite_utils namespace.tfarina@chromium.org2010-06-039-44/+43
| | | | | | | | | | | Note: this was a TODO. BUG=None TEST=compiles Review URL: http://codereview.chromium.org/2410002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48883 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 48842 - Remove obsolete suppressionerg@google.com2010-06-031-0/+12
| | | | | | | | | | | | | | This suppression is still needed for the chromeos bots. BUG=16583 TEST=Valgrind doesn't cry. Review URL: http://codereview.chromium.org/2371002 TBR=erg@chromium.org Review URL: http://codereview.chromium.org/2568004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48882 0039d316-1c4b-4281-b951-d872f2087c98
* Address a TODO about renaming RequestInfo --> SourceInfo.eroman@chromium.org2010-06-033-172/+171
| | | | | | Review URL: http://codereview.chromium.org/2548003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48881 0039d316-1c4b-4281-b951-d872f2087c98
* TTF: Fix and enable AppModalDialogTest on Mac.dmuir@chromium.org2010-06-032-10/+16
| | | | | | | | | | | Also remove FLAKY annotation from test for other platforms -- annotation is likely stale. BUG=25039,5314 TEST=AutomationProxyTest.AppModalDialogTest Review URL: http://codereview.chromium.org/2576002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48880 0039d316-1c4b-4281-b951-d872f2087c98
* Force web_origin to be present only on extension gallery installs. Formpcomplete@chromium.org2010-06-035-17/+39
| | | | | | | | | | non-gallery installs, use the download URL as origin. BUG=40848 Review URL: http://codereview.chromium.org/2517001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48878 0039d316-1c4b-4281-b951-d872f2087c98
* Implement support for NPDrawingModelInvalidatingCoreAnimation in Mac pluginsstuartmorgan@chromium.org2010-06-035-11/+31
| | | | | | | | | BUG=38982 TEST=None (no plugins use it yet) Review URL: http://codereview.chromium.org/2561005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48877 0039d316-1c4b-4281-b951-d872f2087c98
* Fix "under the hood" options page truncation.xiyuan@chromium.org2010-06-031-0/+6
| | | | | | | | | BUG=chromium-os:3761 TEST=Verify fix for chromium-os:3761 Review URL: http://codereview.chromium.org/2600001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48876 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some test file complitation exceptions from chrome_tests.gypistuartmorgan@chromium.org2010-06-035-18/+15
| | | | | | | | | | | Adds bug annotation to the tests that still needs porting work. BUG=45766,45753,45770,45771 TEST=Compling ui_tests still works Review URL: http://codereview.chromium.org/2605001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48875 0039d316-1c4b-4281-b951-d872f2087c98
* Record out-of-proc-tests' FAILS/FLAKY failures in the XML output.kinuko@chromium.org2010-06-033-9/+29
| | | | | | | | | BUG=40473 TEST=Run browser_tests and see if failed FAILS_ or FLAKY_ tests are recorded in its XML output. Also make sure that failures of FAILS/FLAKY tests don't make the browser_tests exit with non-zero return value. Review URL: http://codereview.chromium.org/2431003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48873 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a regression where tabs.create() would focus the tab's window even ifmpcomplete@chromium.org2010-06-031-1/+0
| | | | | | | | | | selected is false. BUG=42531 Review URL: http://codereview.chromium.org/2483003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48872 0039d316-1c4b-4281-b951-d872f2087c98
* Win SxS: Creating a new shortcut with enable-udd-profiles uses wrong icon.mattm@chromium.org2010-06-0310-23/+19
| | | | | | | | | BUG=44847 TEST=see bug Review URL: http://codereview.chromium.org/2557001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48871 0039d316-1c4b-4281-b951-d872f2087c98
* Convert some DCHECKs() for redirect into CHECKs() to make sure they aren't ↵eroman@chromium.org2010-06-031-2/+2
| | | | | | | | | | getting hit. BUG=20470 Review URL: http://codereview.chromium.org/2508001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48870 0039d316-1c4b-4281-b951-d872f2087c98
* Adding WebGL-ized rotatemodel.html demo.luchen@google.com2010-06-031-0/+250
| | | | | | Review URL: http://codereview.chromium.org/2483002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48869 0039d316-1c4b-4281-b951-d872f2087c98
* Porting the Phong Shader demo to WebGL.luchen@google.com2010-06-031-0/+345
| | | | | | Review URL: http://codereview.chromium.org/2503001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48868 0039d316-1c4b-4281-b951-d872f2087c98
* Make HostResolver NonThreadSafe and not thread safe refcounted.willchan@chromium.org2010-06-0313-206/+334
| | | | | | | | | | Required making SyncHostResolverBridge not use RefCountedThreadSafe. I refactored the innards to have a thread safe refcounted Core implementation. BUG=45298 Review URL: http://codereview.chromium.org/2122015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48867 0039d316-1c4b-4281-b951-d872f2087c98
* Manual Review: Adding a bunch of ignores for deps pulls and some project filesthomasvl@chromium.org2010-06-030-0/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48866 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Revert "Enable zombies for all on devchannel."shess@chromium.org2010-06-031-3/+1
| | | | | | | | | | | | Is causing Perf(2) redness. TBR=pink,avi BUG=none TEST=none Review URL: http://codereview.chromium.org/2588002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48862 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bunch of lint/style issuesjar@chromium.org2010-06-032-21/+21
| | | | | | | r=willchan Review URL: http://codereview.chromium.org/2113017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48861 0039d316-1c4b-4281-b951-d872f2087c98
* Move MouseLeave ui test to interactive ui tests target.estade@chromium.org2010-06-033-8/+1
| | | | | | | | | BUG=45581,26349,45581 TEST=it runs, succeeds on bots Review URL: http://codereview.chromium.org/2520002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48860 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill: Make PersonalDataManager RefCountedThreadSafe.jhawkins@chromium.org2010-06-0310-40/+58
| | | | | | | | | BUG=40617 TEST=none Review URL: http://codereview.chromium.org/2521001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48858 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Tighten up objc zombie dealloc implementation.shess@chromium.org2010-06-031-3/+8
| | | | | | | | | | | | | | Enabling the zombie code in release causes Perf(2) to regress. Reviewing |ZombieDealloc()|, I notice that object_setClass() is implemented with a memory barrier. The objc runtime doesn't use it in deallocation, so move to direct access. BUG=none TEST=none Review URL: http://codereview.chromium.org/2605004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48857 0039d316-1c4b-4281-b951-d872f2087c98
* Disable DefaultPluginUITest.DefaultPluginLoadTest under valgrind.estade@chromium.org2010-06-031-0/+2
| | | | | | | | | | BUG=45792 TEST=tree goes green TBR=thakis Review URL: http://codereview.chromium.org/2612001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48856 0039d316-1c4b-4281-b951-d872f2087c98
* On Chrome OS browse without sign in mode open only incognito windows.nkostylev@google.com2010-06-033-0/+10
| | | | | | | | | | | As current implementation BWSI mode = "Incognito session" so only incognito windows should be open. BUG= http://crosbug.com/3473 TEST=Open BWSI mode from "New user" screen. Ctrl+N/Shift+Ctrl+N should open only Incognito windows. Review URL: http://codereview.chromium.org/2580001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48855 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: for Flash, disable right clicks in windowless mode.viettrungluu@chromium.org2010-06-032-2/+15
| | | | | | | | | | | This is a temporary hack to avoid hangs until Flash (10.1) is fixed. See bug. BUG=40157 TEST=On windowless Flash content, with Flash 10.1, right clicks shouldn't causes hangs. For windowed content, right clicks should work as before and bring up the Flash context menu. Other plugins shouldn't be affected (unless they're accepting Flash content). Review URL: http://codereview.chromium.org/2601001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48854 0039d316-1c4b-4281-b951-d872f2087c98
* Update WebKit to r60630.pkasting@chromium.org2010-06-031-1/+1
| | | | | | | | | BUG=none TEST=none TBR=tkent Review URL: http://codereview.chromium.org/2568002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48853 0039d316-1c4b-4281-b951-d872f2087c98
* Reusing the RegKey used to get the CurrentVersion to also get the Install ↵mirandac@google.com2010-06-031-3/+3
| | | | | | | | | | | Directory was causing an InvalidHandle exception, and causing FF import to fail. BUG=45730 TEST= FF import should work. Review URL: http://codereview.chromium.org/2581002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48852 0039d316-1c4b-4281-b951-d872f2087c98
* New autofill UI. Still not done:georgey@chromium.org2010-06-036-854/+826
| | | | | | | | | | 1. Countries ComboBox - need countries list. 2. Correct icons size. TEST=in the mocks. BUG=37816,39238,41232,41793,36601 Review URL: http://codereview.chromium.org/2500002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48849 0039d316-1c4b-4281-b951-d872f2087c98
* GPU plugin size is updated before GPU command buffer is initialized.apatrick@chromium.org2010-06-031-2/+4
| | | | | | | | | | Now it happens before the command buffer is initialized, which fixes an occasional race condition in Pepper 3D plugins that are not animated. TEST=try BUG=none Review URL: http://codereview.chromium.org/2461003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48848 0039d316-1c4b-4281-b951-d872f2087c98
* Added scroll view to internet settings page.chocobo@chromium.org2010-06-032-22/+131
| | | | | | | | | Refreshing of networks will keep the scroll location. BUG=chromium-os:3086 TEST=manually test to make sure scroll appears when the network list is long. and network changes keeps the same scroll location. Review URL: http://codereview.chromium.org/2578002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48845 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Make the History menu behave more like the NTP in its display of ↵rsesek@chromium.org2010-06-0310-267/+519
| | | | | | | | | | | | | | | | | | | | | recently closed items. Now, the menu will show Window entries that have a submenu of all the tabs. Currently, only the complete window can be restored, not submenu items (representing individual tabs) as this requires changing the TabRestoreService. That will come in a future CL. This CL also significantly refactors the internals of the history menu. XIB changes: Re-assign tag values in the History menu to those used in HistoryMenuBridge::Tags enum. BUG=43787 TEST=Open a window and navigate two tabs. Close window. In the History menu, there should be a "2 Tabs" item in the Recently Closed section. Select that to restore. TEST=Open a window and navigate two tabs. Close one tab. In the History menu, there should be that individual tab entry. Select to restore. Review URL: http://codereview.chromium.org/2481001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48844 0039d316-1c4b-4281-b951-d872f2087c98
* Change 'const' to 'var' in event_bindings.js for ECMAScript compatibility ↵ericdingle@chromium.org2010-06-031-5/+5
| | | | | | | | | | | reasons. BUG=None TEST=None Review URL: http://codereview.chromium.org/2444005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48843 0039d316-1c4b-4281-b951-d872f2087c98
* Remove obsolete suppressionerg@chromium.org2010-06-031-12/+0
| | | | | | | | | BUG=16583 TEST=Valgrind doesn't cry. Review URL: http://codereview.chromium.org/2371002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48842 0039d316-1c4b-4281-b951-d872f2087c98
* A very basic fix that prevents experimental popups from living longer than ↵twiz@google.com2010-06-0311-22/+158
| | | | | | | | | | | | | the ExtensionFunctionDispatcher/RenderViewHost that launched the popup. This is a problem, for example, when Chrome is closed while a popup is still displayed. I also removed the code that delayed sending the onClosed popup notification. I modified the ExtensionPopup::Obeserver interface to add methods for about-to-close, and fully-closed notifications. BUG=None TEST=ExtensionApiTest.Popup Review URL: http://codereview.chromium.org/2092020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48841 0039d316-1c4b-4281-b951-d872f2087c98
* Changes to allow focusing the syncronization dialog, useful for the case ↵csilv@chromium.org2010-06-039-2/+48
| | | | | | | | | | | | | where the user chooses to sync, but the window is already open and obscured by another window. For now this only works on Mac due to how browser dialogs are handled on different platforms. BUG=30649 TEST=Choose to 'Sync' when the sync window is already open behind a browser window. Review URL: http://codereview.chromium.org/2121017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48840 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Enable zombies for all on devchannel.shess@chromium.org2010-06-031-1/+3
| | | | | | | | | | | Attempt to flush out more use-after-free cases in the wild. Right now messages to freed ObjC objects are binned by the object's address, with this change they should aggregate into a bigger bin. Additionally, the treadmill should slightly increase the number of cases caught. BUG=35590,24987,45676 TEST=none Review URL: http://codereview.chromium.org/2478004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48838 0039d316-1c4b-4281-b951-d872f2087c98
* Fix leaky spdy sessions and remove suppression.vandebo@chromium.org2010-06-034-32/+10
| | | | | | | | | BUG=44738 TEST=heap checker no longer complains and tests still pass Review URL: http://codereview.chromium.org/2477004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48837 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor CommandBufferHelper to use Jump to loopgman@chromium.org2010-06-034-40/+75
| | | | | | | | | | | | | instead of Noop. This makes it actually work if you tell the command buffer helper to use less than the entire command buffer. TEST=modified unit tests and ran GLES2 conformance tests. BUG=NONE Review URL: http://codereview.chromium.org/2509001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48835 0039d316-1c4b-4281-b951-d872f2087c98
* Save/restore position for the preferences window based on prefs,tfarina@chromium.org2010-06-036-3/+18
| | | | | | | | | | | BUG=34644 TEST=Try moving the preferences window and confirm it works. Patch from Mingmin Xie <melvinxie@gmail.com> Review URL: http://codereview.chromium.org/2592001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48834 0039d316-1c4b-4281-b951-d872f2087c98
* Fix cloud print job title.scottbyer@chromium.org2010-06-033-17/+28
| | | | | | | | | | | Use the page title as the print job title for cloud printing. BUG=none TEST=none Review URL: http://codereview.chromium.org/2438004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48833 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-08 00:25:30 +0000