| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'm working on a Mac specific change where we'll need an IPC message to load a font and pass the font data back to the renderer process.
To prevent confusion this CL preemptively renames a Windows message which actually causes a font to be cached by the browser.
The distinction between these two operations is subtle but I thought it best to try to prevent future confusion by making sure the IPC messages don't have similar names.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/1805002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45931 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
for this cleanup yet.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/1813001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/1804004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45924 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=42704
TEST=Valgrind Mac will go green, eventually...
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crosbug.com/2743
TEST=none
Review URL: http://codereview.chromium.org/1711017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We're releasing panel controller but never deleted.
Handle edge case where a renderer requests resize after the panel is closed.
BUG=none
TEST=added new test case TestCloseOpen to verify it.
Review URL: http://codereview.chromium.org/1687011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45919 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implement the server side of chromium sync inside of testserver.py. The implementation supports at most one account (and ignores authentication credentials), but is otherwise reasonably full featured.
Make the sync_integration_tests run by default against the test server. An externallyprovided syncurl will give the old behavior.
Protocol buffers stuff: The test sync server requires Python generated code for .proto files. I've put generated code, as well as the python protocol buffers runtime library, in the output directory + "/python" (e.g, on windows, src/chrome/Debug/python/google/protobuf). This might be a bad place, or a bad name open to suggestions. The main thing is that there will be runtime dependencies on it, so it didn't seem right to put it in obj/.
Flakiness fix: In the InProcessBrowserTest framework, improve the mechanism for tests that want to manually set up a user data directory. The new way ensures that the user data directory is always wiped; tests can't accidentally forget to do this anymore.
Flakiness fix: Make testserver try to /kill any old instance that might be hogging the port. Very useful if a test failure leaves a server running. Tested this against all combos of protocols, and it seems to work.
Flakiness fix: Port sync_integration_tests to the outofprocess test runner.
Flakiness fix: For IN_PROC_BROWSER_TESTS, don't run the test body if the setup triggered a fatal (ASSERT_) failure.
BUG=20905,40980
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=44708
Review URL: http://codereview.chromium.org/1622012
TBR=nick@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45918 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(Continuing aftermath of native bookmark manager removal....)
BUG=38908
TEST=everything continues to work
Review URL: http://codereview.chromium.org/1747020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45917 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implement the server side of chromium sync inside of testserver.py. The implementation supports at most one account (and ignores authentication credentials), but is otherwise reasonably full featured.
Make the sync_integration_tests run by default against the test server. An externally-provided --sync-url will give the old behavior.
Protocol buffers stuff: The test sync server requires Python generated code for .proto files. I've put generated code, as well as the python protocol buffers runtime library, in the output directory + "/python" (e.g, on windows, src/chrome/Debug/python/google/protobuf). This might be a bad place, or a bad name -- open to suggestions. The main thing is that there will be run-time dependencies on it, so it didn't seem right to put it in obj/.
Flakiness fix: In the InProcessBrowserTest framework, improve the mechanism for tests that want to manually set up a user data directory. The new way ensures that the user data directory is always wiped; tests can't accidentally forget to do this anymore.
Flakiness fix: Make testserver try to /kill any old instance that might be hogging the port. Very useful if a test failure leaves a server running. Tested this against all combos of protocols, and it seems to work.
Flakiness fix: Port sync_integration_tests to the out-of-process test runner.
Flakiness fix: For IN_PROC_BROWSER_TESTS, don't run the test body if the setup triggered a fatal (ASSERT_) failure.
BUG=20905,40980
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=44708
Review URL: http://codereview.chromium.org/1622012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45916 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tabs. I've
added the following additions:
. made the layout work for opaque_browser_frame.
. Only show the menu if the user supplied enableverticaltabs.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1708014
TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/1795010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=erikkay@chromium.org
Review URL: http://codereview.chromium.org/1705012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45914 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It still fails intermittently, there should be another issue.
TBR=atwilson
BUG=42783
TEST=none
Review URL: http://codereview.chromium.org/1765011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45913 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The next step would be to expose the service side
once to the client but this step just adds the
strings.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/1699022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45909 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change all 3 implementations of the report broken page dialog to just use one
web form.
BUG=none
TEST=Make sure you can report bad pages on each platform
Review URL: http://codereview.chromium.org/1737016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
interface to the Post* methods
of a message loop. This class can outlive the target message loop. Changed ChromeThread to vend an implementation of this proxy.
BUG=None
TEST=ChromeThread unit-tests modified.
Review URL: http://codereview.chromium.org/1800008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45907 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
added the following additions:
. made the layout work for opaque_browser_frame.
. Only show the menu if the user supplied --enable-vertical-tabs.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1708014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
glGetActiveUniform.
BUG=none
TEST=ran o3d-webgl tests
Review URL: http://codereview.chromium.org/1748014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
appears to be broken in the Windows build, however.
BUG=none
TEST=built on Mac, attempted build on Windows
TBR=gman
Review URL: http://codereview.chromium.org/1699024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45903 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1736022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove the search button, use input[type=search] and set a placeholder text.
BUG=42214
TEST=Open bookmarks manager and do some searching
Review URL: http://codereview.chromium.org/1737020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45901 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
don't use an OwnedWidgetGtk for GtkWindows, which are no longer floating by the time the constructor returns.
BUG=42807
TEST=launch a debug build in a compositing window manager
Review URL: http://codereview.chromium.org/1795009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45900 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
that app URLs tend to open in the window associated with them, and nonapp URLs tend to not open in app windows.
After playing with this first attempt, I find it is unsatisfying because spreadsheets.google.com doesn't open in the docs app (different origin) and logging out of gmail directs you back to the browser.
So I'm going to fix that by adding a browse extent, separately.
But I still think this is a worthwhile stepping stone to check in.
Review URL: http://codereview.chromium.org/1732015
TBR=aa@chromium.org
Review URL: http://codereview.chromium.org/1759013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Manually copy webgl.js to output directory because we are not prepared
to run the documentation generation on this file yet. All o3d-webgl
samples now run out of the build directory.
BUG=none
TEST=ran o3d-webgl samples out of build directory
TBR=gman
Review URL: http://codereview.chromium.org/1796004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45897 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, we had a limit of 6 connections per proxy server, which was horrifically low.
Connections to all endpoint hosts remains at 6.
Basically, we have a map of socket pools, keyed by the proxy server.
Each of these proxy socket pools has a socket limit of 15 and a connection limit per host of 6.
The main TCP socket pool (non-proxied) has the standard 256 socket limit, and connection limit per host of 6.
There are two maps currently, one for HTTP proxies and one for SOCKS proxies.
Note that SSL tunnels over HTTP CONNECTs are still located within the standard http proxy socket pools.
We depend on the fact that our code never returns a non-SSL connected socket to the pool for a |connection_group|
that is to a HTTPS endpoint. A newly connected socket from the pool will only have the TCP connection done. An
idle socket will have both the TCP and the HTTP CONNECT and the SSL handshake done for it.
TODO(willchan): Remove the extra constructor overload for the old deprecated parameters. Switch to using HostPortPair everywhere.
TODO(willchan): Finish SSL socket pools.
TODO(willchan): Rip out the DoInitConnection() code so it can be shared by other caller (TCP pre-warming!).
TODO(willchan): Flush out the socket pool maps when the proxy configuration changes.
TODO(willchan): Fix up global socket limits. They're slightly broken in this case, since each pool instance has its own "global" limit, so obviously different pools don't share the same "global" limit. This is such a minor deal since the global limits are so small for proxy servers compared to the system global limits (256 vs 15), that it doesn't have a big effect.
TODO(willchan): Drink moar b33r.
BUG=12066
Review URL: http://codereview.chromium.org/1808001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since all the cr.js resources were moved to the shared folder, chrome.release
needs to be updated to copy it to the installer
BUG=none
TEST=Test that the bookmark manager works from the installer
Review URL: http://codereview.chromium.org/1796003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45895 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tend to open in the window associated with them, and non-app URLs tend to not open in app windows.
After playing with this first attempt, I find it is unsatisfying because spreadsheets.google.com doesn't open in the docs app (different origin) and logging out of gmail directs you back to the browser.
So I'm going to fix that by adding a browse extent, separately.
But I still think this is a worthwhile stepping stone to check in.
Review URL: http://codereview.chromium.org/1732015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45894 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1759012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45893 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1706018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
building the samples.
BUG=none
TEST=ran build on Mac, verified files were copied
TBR=gman
Review URL: http://codereview.chromium.org/1742016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
variable scoping problems making debugging more difficult.
BUG=none
TEST=none
TBR=petersont
Review URL: http://codereview.chromium.org/1758015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
add enable_eglimage
Review URL: http://codereview.chromium.org/1747019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Proxy servers can show up a page for invalid URLs. This does go in history,
and so that test fails. Use file:// urls only.
Review URL: http://codereview.chromium.org/1745020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We ensure that non-DOM-UI URLs are not sent to DOM UI renderers.
This patch makes an exception for about:blank, which can happen
if the user gets the renderer to go to any about: URL (e.g.,
using the web inspector).
BUG=42547
TEST=Type location='about:cache' into NTP's web inspector, then Reload.
Review URL: http://codereview.chromium.org/1790005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Even though we set this environment variable, GTK clears it after initializing
itself from it, with the intent of isolating the variable's value to just
this process.
If nspluginwrapper is involved, though, we want to propagate the variable to
its child as well. So we must set the variable both before initialization
(to initialize it for the current process) as well as after (to initialize
it for the child process, if any).
Review URL: http://codereview.chromium.org/1789008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45886 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implement shared resources and use them in bookmark manager
I had an issue with git when moving files so i had to create a new patch to
delete/readd them here. See code review 1564034. This is just for
trybots/checkins.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1694019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=PasswordManagerTest::FormSubmitFailedLogin + valgrind
Review URL: http://codereview.chromium.org/1795008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
related error.
BUG=42704
TEST=none
Review URL: http://codereview.chromium.org/1812003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45879 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
if it was truncated.
BUG=41563
TEST=unittest
Review URL: http://codereview.chromium.org/1719024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45878 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
experimental window.open feature strings to be captured and passed to the client.
It should wait for: https://bugs.webkit.org/show_bug.cgi?id=38013 to land. This is required because this patch needs to use the WebWindowFeature binding struct in WebKit.
Once this is landed, a webkit patch to change the call signature for WebViewClient::createView to include the WebWindowFeatures will be submitted (and after that another chromium patch to remove the old call signature).
This patch implements old and new WebViewClient::createView signatures, and additionally passes the vector all the way to RenderViewHostDelegateHelper who will eventually use it to observe the 'background' feature.
BUG=41275
TEST=all tests should pass
Review URL: http://codereview.chromium.org/1758004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45877 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
would just not forget about angleproject.
Review URL: http://codereview.chromium.org/1763016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45876 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also enable that test. Crash caused by using stl::map[unexisting_key] which inserts a dummy element. Added a check.
BUG=42783
TEST=WorkerTest.WorkerContextMultiPort
Review URL: http://codereview.chromium.org/1737019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
implemented for the glass frame yet.
Review URL: http://codereview.chromium.org/1727009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45874 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
PasswordStoreMac so that the sync backend can register as an observer.
BUG=35038
TEST=none
Review URL: http://codereview.chromium.org/1803006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45873 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
The patch contributed by chaitanya@chromium.org
Original review URL: http://codereview.chromium.org/1775006
Review URL: http://codereview.chromium.org/1774013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GTK grabs work on a per window group basis, so when a modal dialog comes up
(which performs a grab) and the user then clicks on something in the main
browser window that spawns an InfoBubble, the InfoBubble's code that handles
hiding the currently grabbed widget will hide the modal dialog and it is lost
until restart.
Since we need to remove the centering in ContentSettingsWindowGtk for this to
work, also change the centering behaviour for FontsLanguagesWindowGtk, which
has bothered me for a while.
BUG=41815
TEST=none
Review URL: http://codereview.chromium.org/1727012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45871 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=ran valgrind on chromeos version of chrome.
BUG=none
Review URL: http://codereview.chromium.org/1807006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45867 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
setup of the containing div is identical to that in the plugin version
of O3D. Fixed createClients to only call the initialization callback
once the client's initial size has been set. Fixed bug in texture wrap
mode setup which was breaking the bump map in helloworld.html.
BUG=none
TEST=ran all o3d-webgl samples
TBR=petersont
Review URL: http://codereview.chromium.org/1687019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45866 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
TBR=aa
Review URL: http://codereview.chromium.org/1705011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45863 0039d316-1c4b-4281-b951-d872f2087c98
|