summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Ensure bookmark title truncation always produces a valid UTF-8 string.craig.schlenter@chromium.org2009-07-011-6/+11
| | | | | | | | | | | | | | We also add ellipses to the bookmark title. TEST = A bookmark with a title that has a UTF-8 character that spans the 15 character truncation point should not cause "Gtk: Invalid input string" errors. See http://dev.chromium.org/developers/coding-style for an example of the problem. The title in that case is as follows: "Coding Style \u200E(Chromium Developer Documentation)\u200E" Review URL: http://codereview.chromium.org/147207 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19706 0039d316-1c4b-4281-b951-d872f2087c98
* Bookmark manager polish:estade@chromium.org2009-07-012-19/+111
| | | | | | | | | | | | | | - set a better default size - ellipsize columns - allow users to change column widths - remember user-modified column widths BUG=http://crbug.com/14742 TEST=none Review URL: http://codereview.chromium.org/151134 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19704 0039d316-1c4b-4281-b951-d872f2087c98
* Don't try to optimize out browser window reshapes.estade@chromium.org2009-07-012-12/+0
| | | | | | | | | | | The optimization failed to account for the possiblity of consecutive reshapes with different sizes. Instead of making the optimization smarter, just get rid of it, as it isn't clear it helps anything. BUG=none TEST=resize browser with custom frame on. Review URL: http://codereview.chromium.org/151132 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19703 0039d316-1c4b-4281-b951-d872f2087c98
* linux: mark a test as timing outevan@chromium.org2009-07-011-1/+3
| | | | | | | agl will revisit this as he continues to polish complex text, but for now we can acknowledge it so the builder stays green. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19702 0039d316-1c4b-4281-b951-d872f2087c98
* Enable some skia unittests on linux and mac.tc@google.com2009-07-012-8/+6
| | | | | | | | | | This enables the ImageOperations.* and SkiaUtils.* test_shell_tests on linux and mac. Review URL: http://codereview.chromium.org/151097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19701 0039d316-1c4b-4281-b951-d872f2087c98
* -Fix a wrong commentcpu@google.com2009-07-012-1/+4
| | | | | | | | | | | | | -Put a comment to clarify a behavior See coverity CID 1703 BUG=none TEST=none Review URL: http://codereview.chromium.org/150128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19700 0039d316-1c4b-4281-b951-d872f2087c98
* linux: more plugin layout test fixingevan@chromium.org2009-07-014-8/+43
| | | | | | | | | Intentionally no code change. For each plugin test, either fix baseline, mark as passing, or annotate with why we're failing. Review URL: http://codereview.chromium.org/151129 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19699 0039d316-1c4b-4281-b951-d872f2087c98
* linux: make layout test plugin build and run in test_shellevan@chromium.org2009-07-014-38/+85
| | | | | | | | | | | | | | | I used the upstream implementation as a guide for the changes I made, so style faults are theirs. Also includes updates to test_expectations for the new tests we pass, and one new baseline for a test that had an output image that we match Windows on aside from antialiasing. BUG=11516 Review URL: http://codereview.chromium.org/150144 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19698 0039d316-1c4b-4281-b951-d872f2087c98
* Back out the addition of native client into chromium.sehr@google.com2009-07-011-4/+0
| | | | | | Review URL: http://codereview.chromium.org/150149 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19697 0039d316-1c4b-4281-b951-d872f2087c98
* Implement shortcut for finalizing a trial with all remaining probabilityjar@chromium.org2009-07-013-7/+33
| | | | | | | | | | | It is helpful when defining experiments to put all remaining probability on the final (often the "control" group), without having to keep a careful tally of assignments of probabilities. This CL implements that functionality. r=rvargas Review URL: http://codereview.chromium.org/150141 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19696 0039d316-1c4b-4281-b951-d872f2087c98
* Put some hard limits on the low level audio apicpu@google.com2009-07-013-0/+50
| | | | | | | | | | | | | | - Max number of channels (2) - Bits per sample (64) - Sampling rate (256kHz) - Queue audio buffer (64MB x 2) BUG=none TEST= WinAudioTest.SanityOnMakeParams Review URL: http://codereview.chromium.org/151093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19695 0039d316-1c4b-4281-b951-d872f2087c98
* make FilePath:IsParent use case-insensitive compare for drive letters on windowsrafaelw@chromium.org2009-07-013-7/+124
| | | | | | | | | R=erikkay BUG=15659 Review URL: http://codereview.chromium.org/150109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19694 0039d316-1c4b-4281-b951-d872f2087c98
* Regression: task manager icon for chrome is blankcpu@google.com2009-07-012-5/+7
| | | | | | | | | | | | | - During first run (confusing the newbie) - In other special situations when we show UI before the main chrome window is created BUG=14192 TEST=see bug Review URL: http://codereview.chromium.org/151061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19692 0039d316-1c4b-4281-b951-d872f2087c98
* Enable opening downloads from the Mac download shelf.paul@chromium.org2009-07-013-11/+12
| | | | | | | | | | | Also added a stub for an unused method on Canvas in order to link. TEST=Selecting "Open" from the shelf menu will open a download BUG=15661 Review URL: http://codereview.chromium.org/150079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19691 0039d316-1c4b-4281-b951-d872f2087c98
* Disables unit test as starting failing due to close to end of month.sky@chromium.org2009-07-012-2/+3
| | | | | | | | | BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/150147 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19690 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 19687.dkegel@google.com2009-07-014-29/+30
| | | | | | Review URL: http://codereview.chromium.org/150145 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19689 0039d316-1c4b-4281-b951-d872f2087c98
* Minor changes to ARAB and ARAD necessary for OLAkylep@chromium.org2009-07-014-30/+29
| | | | | | Review URL: http://codereview.chromium.org/150140 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19687 0039d316-1c4b-4281-b951-d872f2087c98
* Send port disconnect events when a frame is unloaded.mpcomplete@chromium.org2009-07-019-42/+79
| | | | | | | | | | | | This is the other half of CL http://codereview.chromium.org/125280, which I split into http://codereview.chromium.org/147033 and this CL. BUG=12686 TEST=no Review URL: http://codereview.chromium.org/150125 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19686 0039d316-1c4b-4281-b951-d872f2087c98
* Wire up a LoginDatabase for PasswordStoreMac, and start using it for lookup.stuartmorgan@chromium.org2009-06-305-42/+91
| | | | | | | | | | (Although it will always be empty at this point, since storage isn't implemented yet.) BUG=11745 TEST=none (no user-visible effect yet) Review URL: http://codereview.chromium.org/147044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19685 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash in ~WidgetGtk. This was caused by your change to no longersky@chromium.org2009-06-302-6/+6
| | | | | | | | | | | set RootView::widget_ = NULL in RootView::OnWidgetDestroyed. BUG=none TEST=none Review URL: http://codereview.chromium.org/150137 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19684 0039d316-1c4b-4281-b951-d872f2087c98
* Don't screw up /usr/bin/ld if you can't write to current dir as root.dkegel@google.com2009-06-301-11/+23
| | | | | | | | | BUG=http://crbug.com/15700 TEST=make sure ld is not gold, make sure root can't write to your nfs home directory, copy this script there, run it, let it install gold, verify it aborts early without torching /usr/bin/ld Review URL: http://codereview.chromium.org/151113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19683 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit Update 45381:54503dglazkov@google.com2009-06-302-2/+9
| | | | | | | | | | R=jorlow BUG=15710 TEST=no layout test regressions. Review URL: http://codereview.chromium.org/150138 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19682 0039d316-1c4b-4281-b951-d872f2087c98
* A recent refactoring of the DOM UI had caused the download page to be blank.jcampan@chromium.org2009-06-301-0/+1
| | | | | | | | | | A call to Init had been removed. BUG=http://crbug.com/15680 TEST=Download a file. Open the download page (CTRL-J) it should show the download. Review URL: http://codereview.chromium.org/151110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19681 0039d316-1c4b-4281-b951-d872f2087c98
* Fix missing include.brettw@chromium.org2009-06-301-0/+1
| | | | | | Review URL: http://codereview.chromium.org/151123 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19680 0039d316-1c4b-4281-b951-d872f2087c98
* Fix typo for buildbrettw@chromium.org2009-06-301-1/+1
| | | | | | Review URL: http://codereview.chromium.org/151121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19679 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Mac installer build. We were not inserting the version number into the ↵maf@google.com2009-06-301-2/+4
| | | | | | | | Keystone registration script, which gave it a bogus registered version that caused a silent update once a day. Review URL: http://codereview.chromium.org/151106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19678 0039d316-1c4b-4281-b951-d872f2087c98
* FixIt: initalize values.kuchhal@chromium.org2009-06-301-4/+6
| | | | | | | | BUG=15338 Review URL: http://codereview.chromium.org/151085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19677 0039d316-1c4b-4281-b951-d872f2087c98
* Add Mac-specific sizing rule with unit test.jrg@chromium.org2009-06-303-27/+103
| | | | | | | | Port rest of window_sizer_unittest.cc to non-Windows. Review URL: http://codereview.chromium.org/149035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19676 0039d316-1c4b-4281-b951-d872f2087c98
* Move GetTabContentsID out of tab util because it has nothing to do with tabs orbrettw@chromium.org2009-06-308-50/+62
| | | | | | | | | | | | TabContents. I put a more accurately named static function in ResourceDispatcherHost which is what really controls this request data. I also moved a couple of static functions from the header to the cc in resource_dispatcher. Review URL: http://codereview.chromium.org/150124 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19675 0039d316-1c4b-4281-b951-d872f2087c98
* FixIt: Remove first run dead code.kuchhal@chromium.org2009-06-301-12/+2
| | | | | | Review URL: http://codereview.chromium.org/151089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19674 0039d316-1c4b-4281-b951-d872f2087c98
* Implement setXSSAuditorEnabled for test_shelldglazkov@google.com2009-06-304-30/+16
| | | | | | | | | | | | | BUG=15649 BUG=15132 BUG=14889 BUG=14773 TEST=no layout test regressions R=abarth Review URL: http://codereview.chromium.org/151092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19672 0039d316-1c4b-4281-b951-d872f2087c98
* linux: retry on plugin fix.evan@chromium.org2009-06-301-0/+9
| | | | | | | Copy the Windows branch of the build file. This is super-screwed. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19671 0039d316-1c4b-4281-b951-d872f2087c98
* Fixit: Initialize variable.kuchhal@chromium.org2009-06-301-1/+1
| | | | | | | | BUG=15338 Review URL: http://codereview.chromium.org/150117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19670 0039d316-1c4b-4281-b951-d872f2087c98
* Modify printing methods on WebFrame to be more inline with the versiondarin@chromium.org2009-06-306-81/+45
| | | | | | | | | | | | | | specified in webkit/api/public/WebFrame.h. Removes an unused method on WebFrame related to printing. BUG=10034 TEST=none R=brettw Review URL: http://codereview.chromium.org/150027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19669 0039d316-1c4b-4281-b951-d872f2087c98
* Fixit: Remove bunch of coverity warnings from chrome/installer/*.kuchhal@chromium.org2009-06-3023-147/+198
| | | | | | | | BUg=12849 Review URL: http://codereview.chromium.org/151101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19668 0039d316-1c4b-4281-b951-d872f2087c98
* Add a function to the History{Service,Backend} to query for a list of ↵meelapshah@chromium.org2009-06-307-1/+115
| | | | | | | | | | | | | redirects ending at a specified URL. Add the list of redirects leading to the URL to URLVisitedDetails which is broadcasted on HISTORY_URL_VISITED. BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/151055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19667 0039d316-1c4b-4281-b951-d872f2087c98
* Fix forjrg@chromium.org2009-06-302-1/+21
| | | | | | | | http://build.chromium.org/buildbot/waterfall/builders/Modules%20Mac%20(valgrind)/builds/1303/steps/valgrind%20test:%20unit/logs/stdio Review URL: http://codereview.chromium.org/151107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19666 0039d316-1c4b-4281-b951-d872f2087c98
* Review URL: http://codereview.chromium.org/151103apatrick@google.com2009-06-305-20/+18
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19663 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling beachdemo selenium test in Chrome.apatrick@google.com2009-06-301-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19662 0039d316-1c4b-4281-b951-d872f2087c98
* Forgot these 2 files in the last checkingman@google.com2009-06-302-8/+8
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19661 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline 4 tests again.jianli@chromium.org2009-06-3010-25/+171
| | | | | | | | | TBR=levin BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19660 0039d316-1c4b-4281-b951-d872f2087c98
* This CL contains the the changes needed to buildgman@google.com2009-06-309-125/+2343
| | | | | | | | | | an externs file for the JSCompiler as well as the code to build a compiled verison of the o3djs sample libs. Review URL: http://codereview.chromium.org/147079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19659 0039d316-1c4b-4281-b951-d872f2087c98
* Some minor JS fixesgman@google.com2009-06-301-7/+19
| | | | | | Review URL: http://codereview.chromium.org/150131 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19658 0039d316-1c4b-4281-b951-d872f2087c98
* Makes WidgetGtk specify a size before realizing the window. Withoutsky@chromium.org2009-06-302-3/+11
| | | | | | | | | | | this we might not end up with the correct size. BUG=none TEST=none Review URL: http://codereview.chromium.org/149111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19657 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes compile bugs for views on gtk.sky@chromium.org2009-06-302-5/+4
| | | | | | | | | | TBR=jcampan BUG=none TEST=none Review URL: http://codereview.chromium.org/151099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19656 0039d316-1c4b-4281-b951-d872f2087c98
* Disabled a couple of selenium tests that don't work in Chrome (see comment). ↵apatrick@google.com2009-06-302-3/+8
| | | | | | | | Set some members to NULL when Client::TearDown. Review URL: http://codereview.chromium.org/147185 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19655 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/126036 for Thiago.sky@chromium.org2009-06-305-11/+45
| | | | | | | | | | | | | | | | | From Thiago: This patch is to solve the problem in import/export bookmarks. They aren't exported correctly and also not imported correctly. Now when the bookmarks are exported the character " are escaped to " and when they are imported, they are unescaped. BUG=7505 TEST=Try importing/exporting bookmarks, make sure nothing is broken. Review URL: http://codereview.chromium.org/126222 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19654 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline 6 layout tests due to WebKit merge 45270:45287.jianli@chromium.org2009-06-3027-36/+48
| | | | | | | | | BUG=15490 TEST=none Review URL: http://codereview.chromium.org/150067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19653 0039d316-1c4b-4281-b951-d872f2087c98
* Remove hack for zoom button now that it's no longer neededpinkerton@chromium.org2009-06-301-10/+0
| | | | | | | | BUG=12498 TEST=zoom button should always be enabled. Review URL: http://codereview.chromium.org/150134 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19652 0039d316-1c4b-4281-b951-d872f2087c98
* Reland arv's NNTP enablery after it was reverted in 19603glen@chromium.org2009-06-304-39/+41
| | | | | | | | TBR=arv Review URL: http://codereview.chromium.org/151108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19651 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-21 01:36:05 +0000