| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1089002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that we have more and more proper grd dependencies in place,
this script may just do more harm than good by causing spurious rebuilds.
Additionally, it horked the build today.
TEST=none
BUG=17706
Review URL: http://codereview.chromium.org/1019007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41947 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1111001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41944 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
With this changes, users can add and remove preferred languages using the
table on the left, that used to be just saying "Not yet implemented".
TEST=manually
BUG=crosbug.com/1688
Review URL: http://codereview.chromium.org/1104001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41943 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
third_party/tcmalloc/chromium/src.
Review URL: http://codereview.chromium.org/576001
TBR=glider@chromium.org
Review URL: http://codereview.chromium.org/1076002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1110001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41941 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
than duplicate its logic
This is a follow up to http://codereview.chromium.org/668075 which made the corresponding changes in win & linux
BUG=none
TEST=chrome/browser/cocoa/content_blocked_bubble_controller_unittest.mm
Review URL: http://codereview.chromium.org/1018003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Valgrind UI tests go green.
TBR=jhawkins
Review URL: http://codereview.chromium.org/1112001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41939 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
third_party/tcmalloc/chromium/src.
Review URL: http://codereview.chromium.org/576001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41938 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/838008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41934 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
as URLRequest::set_context() does.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1000006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41933 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=dglazkov
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1099001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41932 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=markus
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1107001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41931 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original change http://codereview.chromium.org/982008 by luoyx.
Change the first letter of two const strings to lowercase, to make them
consistent with message from WebKit. Otherwise, debugger output messages
won't be pushed out to remote clients.
Contributed by Yuxiang Luo (luoyx@google.com)
BUG=38387
TEST=Attach a remote debugger client to chrome, then open a testing page that has exception. Make sure exception information can be received.
Review URL: http://codereview.chromium.org/1103001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41928 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=jhawkins
BUG=38481
TEST=make the "Chromius OS (valgrind)(1)" bot green.
Review URL: http://codereview.chromium.org/1098001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41925 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Added AddProgress method to the progress bar control.
BUG=35249
TEST=Run out/Debug/chrome --login-manager --login-screen=update. Update screen should remain visible for at least 3 seconds. As there is no network available in this mode yet, login wizard should return back to the network selection screen.
Review URL: http://codereview.chromium.org/1061004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
sandbox.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1076001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41917 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=dglazkov
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1075002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41914 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=zork
BUG=38490
TEST=make valgrind bots green.
Review URL: http://codereview.chromium.org/1086001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41913 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
errors, i.e. CHECK(false). Also enable tests to make sure we assert/crash as expected.
BUG=none
TEST=Chrome in release mode generates crash dumps when CHECK() fails. See UI tests: AssertionTest.*:CheckFalseTest.*:RendererCrashTest.*
Review URL: http://codereview.chromium.org/830003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41912 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=darin
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41911 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=zork
BUG=38487
TEST=make valgrind bots greener.
Review URL: http://codereview.chromium.org/1085001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41910 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=jhawkins
BUG=38481
TEST=make valgrind bots greener.
Review URL: http://codereview.chromium.org/1077002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41909 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ffmpeg
BUG=38477
TEST=build linux arm debug mode
Review URL: http://codereview.chromium.org/1073001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This adds a warning to extension docs that appears if docs are being viewed in chrome via the file: scheme that view live changes to underlying docs files requires adding a switch to chrome to allow file xhr access
Review URL: http://codereview.chromium.org/997010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
is going to be skewed slightly, as calling gettimeofday() by itself also
takes a little bit of time. But it should be good enough to allow us to see
where we have performance bottlenecks.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/997009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=AutoFillQueryXmlParserTest
Review URL: http://codereview.chromium.org/1014008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
they go away while the menu is open.
BUG=34522
TEST=\
1) Confirm bookmark context menus continue to work (e.g. rename, delete).
2) Repeat the "sync and delete while context menu" is open test from the
bug; make sure the op is ignored (and we don't crash).
Review URL: http://codereview.chromium.org/1041003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41903 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/896001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41901 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=eroman
BUG=31497
TEST=none
Review URL: http://codereview.chromium.org/1069001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41900 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reloading a page for the second time dismisses the warning before showing it again.
CLs for other platforms forthcoming.
BUG=26271
TEST=RepostFormWarningTest.TestDoubleReload
Manual test: Go to http://www.cs.unc.edu/~jbs/resources/perl/perl-cgi/programs/form1-POST.html, hit Submit, then reload. The warning sheet should be tab-modal, not window-modal. Hit reload again. The warning sheet should close and immediately reopen.
Review URL: http://codereview.chromium.org/969003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=abarth
BUG=36957
TEST=none
Review URL: http://codereview.chromium.org/1047005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41897 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
used in the test files.
2. Allow for window-style paths when searching for individual tests.
Review URL: http://codereview.chromium.org/1039009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41895 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Find correct screen (based on current position of mouse pointer) and monitor.
BUG=27800
Review URL: http://codereview.chromium.org/399101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41894 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=35850
TEST=FFMPEG should still build/run
Review URL: http://codereview.chromium.org/862005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41893 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR:thestig
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
directory creation race has been fixed.)
BUG=none
TEST=On Linux, "chrome --enable-logging --user-data-dir=/tmp/foobar" writes renderer logs to chrome_debug.log in /tmp/foobar rather than in $XDG_CONFIG_HOME.
TBR=evan
Original review: http://codereview.chromium.org/885003
Review URL: http://codereview.chromium.org/1060002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
about:memory page
BUG=37732
TEST=none
Review URL: http://codereview.chromium.org/807005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=26463
TEST=Reload/shoot down the extension process hosting the extension/infobar and
make sure the browser doesn't crash.
Review URL: http://codereview.chromium.org/1001004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This fires the OnPopupClosed event in a later event via PostTask. This gives the popup time to complete closing before the OnPopupClosed is received by the extension
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/1041004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
profiles can be manipulated in the AutoFill dialog, and the data from those profiles can be used to fill forms in an incognito window.
BUG=38009
TEST=none
Review URL: http://codereview.chromium.org/1064002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- show the same options menu regardless of infobar's states
- changes are made for win, linux and mac
- modified mac unittest so that it passes:
- provide testing api to create options menu items
- modify testing of menu items
BUG=38109
TEST=verify per bug report.
Review URL: http://codereview.chromium.org/976009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41886 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
name
checkdeps.py failed
BUG=36732
TEST=Verify Chrome's main window has a name in AccExplorer or run the new test.
Review URL: http://codereview.chromium.org/661054
TBR=ctguil@chromium.org
Review URL: http://codereview.chromium.org/1063004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
CacheType::APP_CACHE value.
BUG=38273
TEST=existing layout tests and unit tests apply
Review URL: http://codereview.chromium.org/886003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A few things to note:
- I ended the plubming (it's-a me, mario!) at the SyncBackendHost (the PSS does not know about pausing). The SyncBackendHost now has RequestPause/RequestResume methods. The notifications that are sent when pause and resume is complete are dispatched to the notification service by the SyncBackendHost.
- Calls to SHB::Request(Pause|Resume) go directly to the similar named methods on the SyncerThread. This is unlike other methods on the SHB which are usually dispatched to the "core" thread before calling deeper into the onion. I did this to avoid having to deal with callbacks to carry the result value of pause/resume (since the methods can fail and return false). If this is a problem I can change the way it works.
- There is a little trickery regarding the integration unit tests since we typically use a specially initialized SBH for these tests, and the syncer thread does not really run for these tests. Since the thread is not running, pause and resume won't work properly. To get around this, the DataTypeManagerImpl in these tests is constructed with a mock SBH that will respond properly to pause and resume requests.
BUG=37154,37553
Review URL: http://codereview.chromium.org/1063002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41883 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=36732
TEST=Verify Chrome's main window has a name in AccExplorer or run the new test.
Review URL: http://codereview.chromium.org/661054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
processes tries to create the same file system tree simultaneously.
BUG=38112
TEST=none
Review URL: http://codereview.chromium.org/990002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41881 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
safer operation and consistancy. Added more tests.
TEST=even more unit tests
BUG=none
Review URL: http://codereview.chromium.org/1003005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41880 0039d316-1c4b-4281-b951-d872f2087c98
|