summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Remove trailing comma to allow compilation with Native Client's higher ↵sehr@google.com2010-02-011-1/+1
| | | | | | | | warning level. Review URL: http://codereview.chromium.org/552266 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37749 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for a focus bug when loading a plugin in an extension background page.mpcomplete@chromium.org2010-02-011-1/+4
| | | | | | | | BUG=32658 Review URL: http://codereview.chromium.org/557009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37748 0039d316-1c4b-4281-b951-d872f2087c98
* Add the DnD work around to bookmark manager as well.arv@chromium.org2010-02-011-1/+14
| | | | | | | | | BUG=None TEST=Add the extension and try dragging items around. Review URL: http://codereview.chromium.org/553178 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37747 0039d316-1c4b-4281-b951-d872f2087c98
* The "after infobar" could be sticky in some cases.jcampan@chromium.org2010-02-011-0/+11
| | | | | | | | | | | Make sure we always remove it before showing a new "before translate" infobar. BUG=34076 TEST=See bug. Review URL: http://codereview.chromium.org/552258 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37746 0039d316-1c4b-4281-b951-d872f2087c98
* Bookmark manager: Make sure we position the context menu inside the window viewarv@chromium.org2010-02-011-1/+33
| | | | | | | | | BUG=None TEST=In the new bookmark manager. Right click near the lower right corner. The context menu should be shown above and to the left of the mouse. Review URL: http://codereview.chromium.org/554139 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37745 0039d316-1c4b-4281-b951-d872f2087c98
* Add per-observer instrumenting code to NotificationRegistrar.huanr@chromium.org2010-02-012-26/+23
| | | | | | | | | TEST=All current tests pass BUG=31078 Review URL: http://codereview.chromium.org/554130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37744 0039d316-1c4b-4281-b951-d872f2087c98
* Add tab switch notification to the Mac plugin plumbing.stuartmorgan@chromium.org2010-02-0112-64/+147
| | | | | | | | | | | | | | | | | | | Using the new notification: - Update plugin clip rect when it's not in a visible tab. - Update plugin idle event rate when it's not in a visible tab. - Switch the unfocus-on-tab-switch event to be based on the this new notification, instead of a browser-level broadcast. Related changes: - Stop sending redundant focus events to plugins. - Send window activation to Carbon event plugins too, not just Cocoa. - Now that plugins are getting window and tab de-focus events directly, remove the older hack to force all plugins to lose focus any window or tab loses focus. BUG=29371, 32229, 30838 TEST=Flash should still only register keystrokes when it is in the active window+tab. Plugins in background tabs should use less CPU. Review URL: http://codereview.chromium.org/548224 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37743 0039d316-1c4b-4281-b951-d872f2087c98
* Remove wrong license file.maruel@chromium.org2010-02-011-27/+0
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/552228 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37740 0039d316-1c4b-4281-b951-d872f2087c98
* linux: add an option to disable FBO support for platforms that don't have it.piman@google.com2010-02-014-3/+25
| | | | | | Review URL: http://codereview.chromium.org/551218 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37737 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Mac browser crash in BookmarkMenuBridge::UpdateMenu.snej@chromium.org2010-02-011-2/+6
| | | | | | | | | BUG=33890 TEST=none (see steps to repro in bug report) Review URL: http://codereview.chromium.org/557085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37736 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Remove focus ring from table in task manager.thakis@chromium.org2010-02-011-3/+3
| | | | | | | | | | | | | xib change: Change "Focus Ring" from "Default" to "None" on both scroll view and contained table view. This does not address the ring around the first column when tabbing through. BUG=33699 TEST=Click row in table in task manager. The table should not have a focus ring. Review URL: http://codereview.chromium.org/559004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37735 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily allow writing to the default malloc zone structure while ↵avi@chromium.org2010-02-011-0/+24
| | | | | | | | | | | modifying it. BUG=none TEST=no crash when launching Chromium next year Review URL: http://codereview.chromium.org/557084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37733 0039d316-1c4b-4281-b951-d872f2087c98
* Moved Autofill view to appropriate browser/views folder.georgey@chromium.org2010-02-014-20/+15
| | | | | | | | BUG=33026 TEST=none Review URL: http://codereview.chromium.org/558051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37732 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Enable some left-behind unit tests.shess@chromium.org2010-02-013-12/+14
| | | | | | | | | | | NavicationControllerTest, TaskManagerTest and BackFwdMenuModelTest. BUG=none TEST=none Review URL: http://codereview.chromium.org/557063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37731 0039d316-1c4b-4281-b951-d872f2087c98
* TEST=new tests added.stoyan@chromium.org2010-02-0122-1016/+1496
| | | | | | Review URL: http://codereview.chromium.org/545093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37728 0039d316-1c4b-4281-b951-d872f2087c98
* task manager gtk:estade@chromium.org2010-02-011-20/+49
| | | | | | | | | | | | | When sorting by a column that is shared by resources in a group (e.g. process id or CPU, but not network), make sure those rows are grouped. Also get rid of the confusing grid lines. I think we want separators between groups, but getting them to draw properly without introducing huge complexity to the code is hard. BUG=none TEST=manual Review URL: http://codereview.chromium.org/555177 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37727 0039d316-1c4b-4281-b951-d872f2087c98
* Task manager model: Make a find quicker.estade@chromium.org2010-02-011-6/+6
| | | | | | | | | | | | | | | | | Given a list such as 00000222223333 and an index i into that list, find the first occurrence of the value of list[i]. The current code just does a plain search. The new code does a reverse search starting at i. The reason I am bothering to optimize this is because it is used in TaskManagerGtk::CompareImpl, pending my other cl. BUG=none TEST=none Review URL: http://codereview.chromium.org/553155 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37726 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Make page and app menus shortcut control flow match windows more closely.estade@chromium.org2010-02-014-34/+15
| | | | | | | | | BUG=33471 TEST=alt+f, alt+e Review URL: http://codereview.chromium.org/551214 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37725 0039d316-1c4b-4281-b951-d872f2087c98
* Make pressing <esc> while dragging in the omnibox correctly cancel dragging. ↵pkasting@chromium.org2010-02-016-4/+31
| | | | | | | | | Original patch by Philippe Beaudoin (see http://codereview.chromium.org/554143 ), r=me, tweaked. BUG=33460 TEST=Write goog in the omnibox, drag around, while pressing the left mouse button hit ESC. The selection should return to the first entry and not move as you continue to drag. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37724 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 37721.avi@chromium.org2010-02-011-24/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37723 0039d316-1c4b-4281-b951-d872f2087c98
* Don't store IDR ids in ThemePack files as they change whenever the grd is ↵erg@google.com2010-02-013-78/+257
| | | | | | | | | | | | | | | | | modified. Instead, add an association table at the top of browser_theme_pack.cc that maps the JSON string name and IDR# to a stable constant that won't change between releases. The ThemePack version number has been bumped to two, forcing a rebuild. BUG=33416 TEST=none Review URL: http://codereview.chromium.org/548207 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37722 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily allow writing to the default malloc zone structure while ↵avi@chromium.org2010-02-011-0/+24
| | | | | | | | | | | modifying it. BUG=none TEST=no crash when launching Chromium next year Review URL: http://codereview.chromium.org/551229 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37721 0039d316-1c4b-4281-b951-d872f2087c98
* Implement the broker process that launches NaCl loader processes on 64-bit ↵gregoryd@google.com2010-02-0136-77/+665
| | | | | | | | | | | | Windows systems. BUG=28176 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=37578 Review URL: http://codereview.chromium.org/542030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37720 0039d316-1c4b-4281-b951-d872f2087c98
* Make acrobat work with --safe-plugins by giving it write accessnsylvain@chromium.org2010-02-013-25/+62
| | | | | | | | | | | | | | | to HKCU\Software\Adobe. Since we already have write access to HKCU\Software\Macromedia, I don't believe this is making it less secure than it actually is. We also give it write access to AppData\Adobe. Finally, we also need to let it do a directory listing in c:\users\<user> and c:\users\<user>\AppData, otherwise it crashes. Review URL: http://codereview.chromium.org/554095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37719 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of check that caused redirects to fail extension updates.asargent@chromium.org2010-02-011-5/+1
| | | | | | | | | | | | | | | | | When the extension autoupdater downloads .crx files, we rely on the UrlFetcher class to do it for us. Inside OnCrxFetchComplete I had put a sanity check that the url we finished with was the same one we started with, but of course this breaks the case of redirects and wasn't needed because the API of UrlFetcher is that there's one UrlFetcher per outstanding fetch. BUG=26177 TEST=Extension Autoupdate should keep working normally, and work with redirects such as the example mentioned in the bug. Review URL: http://codereview.chromium.org/549215 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37718 0039d316-1c4b-4281-b951-d872f2087c98
* Allow FileBrowse to change title of open/save dialogxiyuan@chromium.org2010-02-011-0/+54
| | | | | | | | | | | | Add a DOMMessageHandler to FileBrowse based SelectFileDialog that supports a "setDialogTitle" call from javascript. BUG=none TEST=none Review URL: http://codereview.chromium.org/554136 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37717 0039d316-1c4b-4281-b951-d872f2087c98
* Fix type of file_type_index_ from size_t to int to get rid of printf format ↵xiyuan@chromium.org2010-02-011-1/+1
| | | | | | | | | | | warning. BUG=none TEST=none Review URL: http://codereview.chromium.org/552253 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37716 0039d316-1c4b-4281-b951-d872f2087c98
* BSD port: chrome/app and chrome/browser ifdef cleaningpvalchev@google.com2010-02-018-29/+27
| | | | | | Review URL: http://codereview.chromium.org/548203 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37714 0039d316-1c4b-4281-b951-d872f2087c98
* make chrome.tabs.executeScript/insertCss details arg required.rafaelw@chromium.org2010-02-011-4/+2
| | | | | | | | | | they were marked as optional and if either functions were called no arguments, the extension process was terminated because it thought was expecting an argument list. BUG=33628 Review URL: http://codereview.chromium.org/558049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37713 0039d316-1c4b-4281-b951-d872f2087c98
* Add a DCHECK to make sure that SpawnTarget is not callednsylvain@chromium.org2010-02-011-0/+7
| | | | | | | | | | | | from multiple threads. In chrome all child processes are started from the PROCESS_LAUNCHER thread. BUG=28798 Review URL: http://codereview.chromium.org/548192 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37712 0039d316-1c4b-4281-b951-d872f2087c98
* Fix submenu leak in menu2.oshima@chromium.org2010-02-013-19/+34
| | | | | | | | | | | | Added "destroy" signal handler to delete menu2 only when the native gtk widget gets destroyed first. BUG=33475 TEST=chromeos valgrind tests passes without suppression. Review URL: http://codereview.chromium.org/557058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37708 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Fix IB warning about progressView_.thakis@chromium.org2010-02-011-732/+55
| | | | | | | | All I did was re-save in IB, no changes. Review URL: http://codereview.chromium.org/557081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37706 0039d316-1c4b-4281-b951-d872f2087c98
* A better way to fix the compilation issues on Windows x64wtc@chromium.org2010-02-012-54/+2
| | | | | | | | | | | | | | | | | | | | with NSPR headers. Test the Visual C++ predefined macros _M_X64 and _M_AMD64, so that we don't need to include <windows.h> for the definition of _AMD64_. Remove obsolete code for Windows NT Alpha. Based on upstream NSPR patch at https://bugzilla.mozilla.org/show_bug.cgi?id=541690 R=maruel BUG=none TEST=No compilation errors on Windows. Review URL: http://codereview.chromium.org/552182 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37705 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: add missing -D to dpkg-buildpackage command line to enable build ↵tschmelcher@chromium.org2010-02-011-0/+1
| | | | | | | | | | dependency checks. TEST=removed cdbs, built, and verified a build-dep error is reported; trybot Review URL: http://codereview.chromium.org/552244 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37704 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Valgrind error in ExtensionInstalledBubble unit test.mirandac@chromium.org2010-02-011-10/+11
| | | | | | | | BUG= 34052 TEST= no valgrind error. Review URL: http://codereview.chromium.org/555199 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37703 0039d316-1c4b-4281-b951-d872f2087c98
* Implementation of the DatabaseModelWorker, take 2.albertb@google.com2010-02-0111-24/+185
| | | | | | | | | BUG=none TEST=unit tests Review URL: http://codereview.chromium.org/557043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37702 0039d316-1c4b-4281-b951-d872f2087c98
* Show download item menu on mouse down instead of mouse up.thakis@chromium.org2010-02-015-23/+47
| | | | | | | | | | | | | BUG=20812 TEST= * Click right part of download item. Menu should appear on mouse down. * After menu is closed, mousing over the menu should not show the depressed state. * Click left part of download item. File should be opened on mouse up. * http://crbug.com/28215 should not have regressed. Review URL: http://codereview.chromium.org/380002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37701 0039d316-1c4b-4281-b951-d872f2087c98
* Speculative fix for thread sanitizer failures in ProfileSyncServiceTest.tim@chromium.org2010-02-011-1/+1
| | | | | | | | | | | We should not raise an "auth needed" event if we're not supposed to attempt auth in the first place. TBR=albertb Review URL: http://codereview.chromium.org/549222 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37700 0039d316-1c4b-4281-b951-d872f2087c98
* Add temporary download progress overlay to the dock icon for the Mac (real ↵avi@chromium.org2010-02-018-0/+322
| | | | | | | | | | | UI coming soon), and provide the hooks for the Win7 implementation. BUG=http://crbug.com/8039 TEST=download; see progress in the dock icon Review URL: http://codereview.chromium.org/545157 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37698 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Reduce jank in the cookie manager by lazily creating child nodes for ↵rsesek@chromium.org2010-02-014-12/+23
| | | | | | | | | | | | | the UI. Also selects the first cookie node whene expanding an origin node. BUG=33248 TEST=With a lot of cookies in your profile: Chromium-->Preferences-->Under the Hood-->Show cookies... Filter by a domain, expand the domain and the first cookie should be selected. Clear the filter and list should reappear speadily. Review URL: http://codereview.chromium.org/554151 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37695 0039d316-1c4b-4281-b951-d872f2087c98
* Propagate window focus changes to plugins on the Macstuartmorgan@chromium.org2010-02-018-3/+70
| | | | | | | | | | | This gives plugins mostly correct window activation information; there are still a few loose ends like initial focus state and changes that happen while plugins are in background tabs, but those will be handled in follow-up bugs. BUG=31847 TEST=Plugins that are in background windows should act accordingly (e.g., Silverlight hover effects shouldn't trigger) Review URL: http://codereview.chromium.org/549194 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37694 0039d316-1c4b-4281-b951-d872f2087c98
* Keep packages from being selected in a Cocoa open single file dialog.avi@chromium.org2010-02-011-0/+24
| | | | | | | | | | | | Patch from Vernon Tang. BUG=33483 TEST=Check that user can't select an .app using an html file input element. Check that the "load unpacked extension" and "pack extension" browse dialogs in chrome://extensions/ continue to work as expected. Review URL: http://codereview.chromium.org/548199 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37693 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit roll 54103:54127.pfeldman@chromium.org2010-02-012-1/+6
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37691 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 312.0 to 313.0chrome-release@google.com2010-02-011-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37690 0039d316-1c4b-4281-b951-d872f2087c98
* OS X: Import settings dialog cleanup.jeremy@chromium.org2010-02-017-71/+61
| | | | | | | | | | | | | * Make Import settings dialog app modal. * No longer allow display of multiple dialogs at once. * For some reason, unit test was present but missing from .gyp file - re-added and freshened up. BUG=33011 TEST=selecting Chrome->Import Bookmarks and settings multiple times should only open bookmarks once. Review URL: http://codereview.chromium.org/556097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37689 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding the hooking of the translate feature UI.jcampan@chromium.org2010-02-0121-60/+340
| | | | | | | | See http://codereview.chromium.org/549217 Review URL: http://codereview.chromium.org/558065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37688 0039d316-1c4b-4281-b951-d872f2087c98
* Always percent-escape the copied URL when all the text in the address bar is ↵kinuko@chromium.org2010-02-011-0/+38
| | | | | | | | | | | | | | | | | | | | selected. BUG=29397 TEST=Visit http://www.google.com/search?ie=UTF-8&q=上地 and select entire text in Omnibox, then copy the text. Paste the copied text into other applications such as gedit and check if the pasted text contains %E4%B8%8A%E5%9C%B0, not 上地. Paste the copied text into Firefox's URL bar and type return. Check if you are navigated to the same website. Paste the copied text into textareas in Chrome and check if the pasted text contains %E4%B8%8A%E5%9C%B0. TEST=Visit http://www.google.com/search?ie=UTF-8&q=上地 again and select "q=上地" in Omnibox, then copy the text. Paste it into somewhere and check if you see "q=上地". TEST=Copy "上地" from somewhere and paste it into Omnibox. Copy from Omnibox and paste it into other apps such as gedit. Then check if the pasted text is NOT encoded. TEST=Paste the copied text into Gmail's rich text editing mode and check if the pasted text contains 上地. Right click the link you pasted in Gmail and check if you see "Go to: http://www.google.com/...%E4%B8%8A%E5%9C%B0". TEST=Steps described in http://codereview.chromium.org/173098. Review URL: http://codereview.chromium.org/465053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37686 0039d316-1c4b-4281-b951-d872f2087c98
* Add a utility function to run a process as an arbitrary usercpu@chromium.org2010-02-015-15/+78
| | | | | | | | | | | | | - Only for windows - Needed in certain upgrade scenarios, useful for all BUG=32474 TEST= unit tests included Review URL: http://codereview.chromium.org/555192 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37682 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug where we were only checking the screen size oftony@chromium.org2010-02-011-1/+1
| | | | | | | | | | | | | the default monitor, not the current monitor when disabling the full screen hack in metacity/compiz. This is just a guess, I don't have a multimonitor setup here. BUG=32347 Review URL: http://codereview.chromium.org/557056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37680 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Theme status text of download items.thakis@chromium.org2010-01-311-30/+67
| | | | | | | | | | | Slightly complicated because the default theme's "clicked" gradient is not transparent. BUG=21176 TEST=Start long download (e.g. ubuntu disk image), then go through a lot of themes and make sure the status text stays readable, both in normal and clicked states. Also check with default theme. Review URL: http://codereview.chromium.org/551224 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37676 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-10 06:47:45 +0000