summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Landing again the CL that adds security info to canceled requests (last time ↵jcampan@chromium.org2009-03-0834-72/+196
| | | | | | | | | it was causing sync XMLHttpRequests to hang, breaking many layout tests). TBR=darin Review URL: http://codereview.chromium.org/39321 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11221 0039d316-1c4b-4281-b951-d872f2087c98
* The MetricsService are not initialized unless the user have opted injar@chromium.org2009-03-081-9/+13
| | | | | | | | | See contributed CL 28315 by Xharze BUG=2278 Review URL: http://codereview.chromium.org/40274 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11219 0039d316-1c4b-4281-b951-d872f2087c98
* Update tests fixable.ericroman@google.com2009-03-081-1/+1
| | | | | | | | TRB=nsylvain Review URL: http://codereview.chromium.org/40281 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11218 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a duplicate expectation. Somehow linting didnt catch this.ericroman@google.com2009-03-081-1/+0
| | | | | | | TBR=nsylvain Review URL: http://codereview.chromium.org/39318 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11217 0039d316-1c4b-4281-b951-d872f2087c98
* Update test lists following merge. There are some failures on MAC and LINUX ↵ericroman@google.com2009-03-081-0/+10
| | | | | | | | | | which need to be explored. TBR=nsylvain Review URL: http://codereview.chromium.org/40280 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11216 0039d316-1c4b-4281-b951-d872f2087c98
* Roll deps to pick up a hackified chromiumbridge.cpp.ericroman@google.com2009-03-081-1/+1
| | | | | | | | TBR=darin Review URL: http://codereview.chromium.org/39317 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11215 0039d316-1c4b-4281-b951-d872f2087c98
* Don't call ChromiumBridge::initV8CounterFunction() since it asserts not reached.ericroman@google.com2009-03-081-1/+2
| | | | | | | | | | | This will need to be looked at for a real fix. Maybe we should put this back in chromium_bridge_impl.cc ? TBR=darin Review URL: http://codereview.chromium.org/40279 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11213 0039d316-1c4b-4281-b951-d872f2087c98
* Fix tests list -- some expected fails are no longer valid on MAC because ↵ericroman@google.com2009-03-081-3/+2
| | | | | | | | | | those tests have been moved. TRB=nsylvain@chromium.org Review URL: http://codereview.chromium.org/40278 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11212 0039d316-1c4b-4281-b951-d872f2087c98
* Fill out some of the new abstract methods of WebKitClient.ericroman@google.com2009-03-086-35/+53
| | | | | | | | | | | | | | | | This is a quickie to get things compiling -- after I updated DEPS to land webkit merge, I picked up your r11178 which changed these interfaces. Note, it looks like there is a reachability problem with ChromiumBridge::initV8CounterFunction() -- I had to remove the implementation from chromium_bridge_impl.cc to avoid multiple definitions (already in ChromiumBridge.cpp)... however that version does: ASSERT_NOT_REACHED(); This is a problem, since v8_proxy.cpp still calls it... this might crash in debug mode, but hopefully makes tree a bit happier... TBR=darin Review URL: http://codereview.chromium.org/40277 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11211 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit merge 41447:41498ericroman@google.com2009-03-0749-13/+536
| | | | | | Review URL: http://codereview.chromium.org/39297 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11210 0039d316-1c4b-4281-b951-d872f2087c98
* Revert change 11197 because it created 138 new layout testsnsylvain@chromium.org2009-03-0734-194/+71
| | | | | | | | failures. Review URL: http://codereview.chromium.org/39311 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11201 0039d316-1c4b-4281-b951-d872f2087c98
* Revert change 11199 because it breaks the page cyclersnsylvain@chromium.org2009-03-075-72/+55
| | | | | | | | | | on windows. My theory is that the GURL in RunPageCycler is not correct. (Missing a "/" maybe.) Review URL: http://codereview.chromium.org/40268 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11200 0039d316-1c4b-4281-b951-d872f2087c98
* Make page_cycler_tests build on Linux (doesn't run successfully yet).phajdan.jr@chromium.org2009-03-075-55/+72
| | | | | | Review URL: http://codereview.chromium.org/40182 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11199 0039d316-1c4b-4281-b951-d872f2087c98
* Allow clicks to windows disabled by modal dialogs to bring the entire modal ↵ben@chromium.org2009-03-071-0/+13
| | | | | | | | | | stack to the front. Apparently you need to let DefWindowProc handle WM_SETCURSOR unless you want clicks to background disabled windows to get lost. http://crbug.com/8437 Review URL: http://codereview.chromium.org/39308 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11198 0039d316-1c4b-4281-b951-d872f2087c98
* Landing again the CL that adds security info to canceled requests (it was ↵jcampan@chromium.org2009-03-0734-71/+194
| | | | | | | | | | | breaking NPAPI tests on Vista due to an erroneuous commented line). TBR=darin Review URL: http://codereview.chromium.org/39309 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11197 0039d316-1c4b-4281-b951-d872f2087c98
* Fix memory leak of "screen size bitmap" (e.g. 1.5M if 750x548) jrg@chromium.org2009-03-071-5/+4
| | | | | | | | | | | | | | | | | that happened on *every page view* on OSX. VSIZE/RSIZE now hovers around 500M/30M instead of growing to 1.3G/260M within a few minutes. Surprisingly, Chromium.app seems quite a bit snappier! The essence of the change is that SkBitmap::setPixels() does NOT take ownership of the pointer, whereas SkBitmap::allocPixels() both allocates and owns. Review URL: http://codereview.chromium.org/39307 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11196 0039d316-1c4b-4281-b951-d872f2087c98
* Fix about box truncation (and truncation of probably every other box on ↵ben@chromium.org2009-03-071-1/+2
| | | | | | | | | | | | glass frames). Our windows don't have WS_CAPTION. It's remarkable to me that we've made it this far without noticing this glaring oversight. I guess I fixed a bug with my frame changes earlier in the week that resulted in AdjustWindowRectEx getting called correctly for the first time, and it was not providing correct offsets because of the absence of this flag. http://crbug.com/8445 Review URL: http://codereview.chromium.org/39300 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11195 0039d316-1c4b-4281-b951-d872f2087c98
* Remove redundent expected layout test results. These are the same as the ↵thestig@chromium.org2009-03-074-190/+0
| | | | | | | | ones under chromium-win. Review URL: http://codereview.chromium.org/40262 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11194 0039d316-1c4b-4281-b951-d872f2087c98
* Pulling in operator=() to ScopedComPtr.tommi@chromium.org2009-03-072-0/+8
| | | | | | Review URL: http://codereview.chromium.org/40256 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11193 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline text/text-text-0[5-7]-t tests on Linux. The images only differ in ↵thestig@chromium.org2009-03-079-704/+3
| | | | | | | | the highlight color from before, and the text files now match the other platforms. Review URL: http://codereview.chromium.org/40261 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11192 0039d316-1c4b-4281-b951-d872f2087c98
* DCHECK affects performance in release build.fbarchard@chromium.org2009-03-071-0/+7
| | | | | | | | | OFFICIAL_BUILD is okay, but this ifdef makes DCHECK only work in debug. On 720p DCHECK version is 8.14 ms and without, its 2.68 ms Review URL: http://codereview.chromium.org/40245 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11191 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 11179.jcampan@chromium.org2009-03-0734-195/+72
| | | | | | | Reverting CL as plugin UI tests fail on Vista Review URL: http://codereview.chromium.org/40260 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11187 0039d316-1c4b-4281-b951-d872f2087c98
* oopsestade@chromium.org2009-03-071-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11186 0039d316-1c4b-4281-b951-d872f2087c98
* fix windows build break.estade@chromium.org2009-03-071-1/+2
| | | | | | | | tbr=tony Review URL: http://codereview.chromium.org/40259 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11184 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor render view context menu in preparation for porting.estade@chromium.org2009-03-0714-731/+774
| | | | | | | | | | * RenderViewContextMenu is now cross platform. Each platform needs to implement an inheritor that fills in the virtual methods. * RenderViewContextMenuController was deleted. Platform agnostic elements from it were added to RenderViewContextMenu, while the Menu::Delegate implemenation was moved to RenderViewContextMenuWin. * Some more (minor) refactoring may need to be performed as the rest of the menu actions are ported. * include clipboard_service.h on all platforms (not sure why it wasn't included before) Review URL: http://codereview.chromium.org/40249 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11183 0039d316-1c4b-4281-b951-d872f2087c98
* Rename _posix to _mac since it doesn't build on Linux.mmoss@chromium.org2009-03-072-1/+1
| | | | | | | | | | Fixes a gyp Linux build error because gyp expects all _posix files to actually build on all posix platforms. Review URL: http://codereview.chromium.org/39290 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11182 0039d316-1c4b-4281-b951-d872f2087c98
* Exclude more IPC tests from purify buildbot. Looks like one of the tests ↵jam@chromium.org2009-03-071-2/+2
| | | | | | | | | using TimeoutServer has a leak because the threads don't get to run for enough time. BUG=8469 Review URL: http://codereview.chromium.org/39294 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11181 0039d316-1c4b-4281-b951-d872f2087c98
* Make both Hebrew Visual (ISO-8859-8) and Hebrew Logical (ISO-8859-8-I)jungshik@google.com2009-03-075-6/+12
| | | | | | | | | | | | available in the encoding menu. Make windows-1255 come before ISO-8859-8* both in the full encoding list and in Hebew Chrome's static list. BUG=2927 Review URL: http://codereview.chromium.org/39248 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11180 0039d316-1c4b-4281-b951-d872f2087c98
* This CL adds a way to specify the security info when canceling a URLRequest.jcampan@chromium.org2009-03-0734-72/+195
| | | | | | | | | | | This allows to tag a request on the renderer side with its security info. It is useful for the "frame info" dialog. When showing that dialog for blocked frames, the security info can be retrieved and users can see the cert details for the blocked frame. TEST=Open a page containing a frame served over bad HTTPS. The frame is blocked (replaced with a warning message). Right-click, select "Frame info". The dialog should have a "show cert" button which when pressed should show the frame's bad cert. BUG=2853 Review URL: http://codereview.chromium.org/7276 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11179 0039d316-1c4b-4281-b951-d872f2087c98
* Enable interstitial pages for SSL certificate errors on Linux.markus@chromium.org2009-03-072-15/+18
| | | | | | | | | | | There are still problems with this patch, as acknowledging the interstitial page often fails to load a new page. Instead, it just displays a blank gray page. This appears to be somewhat timing related. Nonetheless, this changelist is strictly an improvement over what we have right now. So, I would still like to commit it. Ideally, I'd like to remove the special-case Windows code. But I don't have a Windows machine to check whether the new code is actually a full superset of the old Windows code. Review URL: http://codereview.chromium.org/40095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11177 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline two tests that, according to Finnur, were erroneously ↵pkasting@chromium.org2009-03-067-40/+38
| | | | | | | | re-baselined by brettw. Review URL: http://codereview.chromium.org/39289 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11175 0039d316-1c4b-4281-b951-d872f2087c98
* Enable the character encoding menu, zoom menu, and the help menu item.tc@google.com2009-03-064-15/+18
| | | | | | | | | | The character encoding menu is still broken in that it doesn't load the encoding names (sub-menu items), but auto detect might work. Review URL: http://codereview.chromium.org/39286 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11174 0039d316-1c4b-4281-b951-d872f2087c98
* Snapshoting improvements for building with gyp under windows.bradnelson@google.com2009-03-064-219/+720
| | | | | | | | Added google_update and install utils. Review URL: http://codereview.chromium.org/39204 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11173 0039d316-1c4b-4281-b951-d872f2087c98
* Start the crash_service on windows when running ui tests, if it's not ↵jam@chromium.org2009-03-063-45/+107
| | | | | | | | running already. Otherwise there's no point in running ui_tests! Review URL: http://codereview.chromium.org/39282 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11172 0039d316-1c4b-4281-b951-d872f2087c98
* Defer a test which also fails upstream, and has never passed locally (or, I ↵pkasting@chromium.org2009-03-061-1/+2
| | | | | | | | think, upstream with Windows font metrics). Review URL: http://codereview.chromium.org/40253 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11171 0039d316-1c4b-4281-b951-d872f2087c98
* Enable some code that compiles fine on linux now. This code talkstc@google.com2009-03-061-8/+0
| | | | | | | | | about the next merge and was written in September. Review URL: http://codereview.chromium.org/39281 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11170 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build break.mpcomplete@google.com2009-03-061-1/+2
| | | | | | | TBR=aa Review URL: http://codereview.chromium.org/39283 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11169 0039d316-1c4b-4281-b951-d872f2087c98
* The output from these layout tests now resembles the senorblanco@chromium.org2009-03-065-4/+4
| | | | | | | | | mac output (they have alpha), so they've been rebaselined. Review URL: http://codereview.chromium.org/39274 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11168 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Purify UMR and MLK due to ExtensionViewTest:mpcomplete@google.com2009-03-062-1/+5
| | | | | | | | | | | | - UMR was caused by stubbing out GetHistoryListCount, which RenderViewHost expected to initialize its out params. - MLK was (I think) caused by the IPC reply message to the javascript alert never getting freed. BUG=8364 Review URL: http://codereview.chromium.org/39157 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11167 0039d316-1c4b-4281-b951-d872f2087c98
* Implement accelerators in the gtk port (try 2).erg@google.com2009-03-069-52/+142
| | | | | | | | | | | - Adds accelerators to all the menu items that had them on windows. - Adds accelerators to back (Alt+left), forward (Alt+right), reload (Ctr+R) and focus the URL box (Ctr+L). Review URL: http://codereview.chromium.org/39278 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11166 0039d316-1c4b-4281-b951-d872f2087c98
* fix linux/mac: remove on linux/mac tootc@google.com2009-03-061-1/+0
| | | | | | | | | TBR=ananta Review URL: http://codereview.chromium.org/40252 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11165 0039d316-1c4b-4281-b951-d872f2087c98
* Removing the destroy-stream-twice.html test from pending as we now match the ↵ananta@chromium.org2009-03-062-78/+0
| | | | | | | | upstream layout test plugin. Review URL: http://codereview.chromium.org/39279 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11164 0039d316-1c4b-4281-b951-d872f2087c98
* Rebase cg-fallback-bolding test on Linux. We have anti-aliasing turned on.thestig@chromium.org2009-03-063-4/+1
| | | | | | Review URL: http://codereview.chromium.org/40247 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11163 0039d316-1c4b-4281-b951-d872f2087c98
* New switch --gdb allows TestShell.app to be debugged by gdb even whenjrg@chromium.org2009-03-063-3/+11
| | | | | | | | | using --layout-tests, where we otherwise try hard to not talk to CrashReporter (and also breaks gdb). Review URL: http://codereview.chromium.org/39270 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11162 0039d316-1c4b-4281-b951-d872f2087c98
* Generate data packs for all languages and allow us to loadtc@google.com2009-03-069-264/+279
| | | | | | | | | | | | | | any lang (currently using --lang=ar or whatever). Also remove app/resources/SConscript since it's filled with windows specific code. BUG=8125 Review URL: http://codereview.chromium.org/40246 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11161 0039d316-1c4b-4281-b951-d872f2087c98
* Build test_shell and test_shell_tests on Linux from gyp-generated scons files:sgk@google.com2009-03-064-14/+118
| | | | | | | | | | | | | | | | | | | | | | * Catch up to recent changes: * Rename RenderThemeChromiumGtk.cpp to RenderThemeChromiumLinux.cpp. * Fix spelling of V*NPObject.{cpp,h} * Explicitly include varions WebCore *Gtk.cpp and *Linux.cpp files that are excluded by the general regular expression. * Add webinput_event_util.cc. * Exclude glue/plugins/plugin_stubs.cc. * Add a Linux test_shell_resources target to build test_shell_resources.{h,pak}. * Add an explicit test_shell action to repack resources into test_shell.pak. * Use -Wno-multichar when building libtest_shell_common.a. * Use -DWTF_USE_PTHREADS when building libwtf.a, and when dependent targets compile against it. * Use tools/test_shell/test_shell_main{,_GYP}.scons as the main entry point for GYP-based builds of webkit. * Add base/gfx/gtk_util.cc to the base build. Review URL: http://codereview.chromium.org/39219 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11160 0039d316-1c4b-4281-b951-d872f2087c98
* Add url to AutomationMsg_DidNavigate amit@chromium.org2009-03-062-2/+3
| | | | | | | | | | Automation clients can now find out the url navigated to instead of just index in the history. Review URL: http://codereview.chromium.org/39205 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11159 0039d316-1c4b-4281-b951-d872f2087c98
* Moved mock media filter constructors from private to public.scherkus@chromium.org2009-03-062-48/+32
| | | | | | Review URL: http://codereview.chromium.org/40243 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11158 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes the following layout tests.ananta@chromium.org2009-03-063-25/+17
| | | | | | | | | | | | | | 1. LayoutTests\plugins\netscape-plugin-setwindow-size.html 2. LayoutTests\plugins\destroy-stream-twice.html. The fix for the first test was to get our NPP_SetWindow implementation in the layout test plugin on par with webkit's implementation. I also added a fflush(stdout) to make sure that the printf shows up. If we don't do this the test fails often. The fix for the second test is to get our NPP_DestroyStream implementation in the layout test plugin on par with webkit's implementation. With the latest webkit update, there is a destroyNullStream test which has been added in this layout test. The layout test plugin had to be updated with this new method on the same lines as its counterpart in webkit. Review URL: http://codereview.chromium.org/39242 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11157 0039d316-1c4b-4281-b951-d872f2087c98
* Change JSONFileValueSerializer to use FilePath by default.erikkay@google.com2009-03-061-2/+7
| | | | | | Review URL: http://codereview.chromium.org/39271 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11156 0039d316-1c4b-4281-b951-d872f2087c98