summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Remove base/gfx/.estade@chromium.org2010-04-018-347/+15
| | | | | | | | | BUG=none TEST=trybots Review URL: http://codereview.chromium.org/1570005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43362 0039d316-1c4b-4281-b951-d872f2087c98
* Show an infobar when the user is using an unsupported flag.viettrungluu@chromium.org2010-04-018-11/+62
| | | | | | | | | | | | Patch stolen from Evan and a translatable string added: <http://codereview.chromium.org/490019>. BUG=40113 TEST=Run Chromium with --no-sandbox; should get an infobar warning that you're going to die young. Review URL: http://codereview.chromium.org/1599010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43361 0039d316-1c4b-4281-b951-d872f2087c98
* Add final remainging strings for geolocation, for the exceptions dialog.joth@chromium.org2010-04-011-5/+14
| | | | | | | | | BUG=39817 TEST=none Review URL: http://codereview.chromium.org/1524006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43358 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Line up omnibox popup under field.shess@chromium.org2010-04-014-28/+26
| | | | | | | | | | | | Also line up the icons. Spacing can be adjusted later. BUG=37865 TEST=Popup edges line up under field edges. TEST=Popup icons and text should line up under field icon and text. Review URL: http://codereview.chromium.org/1608001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43357 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bookmarks on subfolder. Introduced with ↵jrg@chromium.org2010-04-011-3/+2
| | | | | | | | | | | | | http://codereview.chromium.org/1547010 Thx to rsesek for noticing quick BUG=40110 Review URL: http://codereview.chromium.org/1585010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43356 0039d316-1c4b-4281-b951-d872f2087c98
* Officially close PDF files when done writing them. No difference now, but if ↵avi@chromium.org2010-04-011-0/+1
| | | | | | | | | | | we ever move to GC, this will prevent problems. BUG=http://crbug.com/33239 TEST=none (does not fix bug) Review URL: http://codereview.chromium.org/1508015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43355 0039d316-1c4b-4281-b951-d872f2087c98
* Ignore invalid-looking extension ids when loading extensions.aa@chromium.org2010-04-011-0/+7
| | | | | | | | | | We should also consider whether to revert the original change so this doesn't get onto trunk. TBR=asargent@chromium.org BUG=40017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43354 0039d316-1c4b-4281-b951-d872f2087c98
* Make chrome://plugins treat MIME type descriptions as HTML.viettrungluu@chromium.org2010-04-011-1/+1
| | | | | | | | | BUG=40036 TEST=MIME type descriptions should mostly show up as before. On Linux (especially?), the descriptions for the MIME type of the Java plug-in should have proper "TM" characters instead of "&#153". Review URL: http://codereview.chromium.org/1591008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43353 0039d316-1c4b-4281-b951-d872f2087c98
* Add new strings for the search engine experimental dialog. Also remove a ↵mirandac@chromium.org2010-04-011-4/+31
| | | | | | | | | | | superfluous NTP promo string. BUG= 37564 TEST= none Review URL: http://codereview.chromium.org/1587007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43352 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 43331 - Implement closing handshake described in ↵jar@chromium.org2010-04-012-128/+4
| | | | | | | | | | | | | | | | | | drafthixiethewebsocketprotocol76. [Arm build was seemingly broken by this change.] exchange closing frame (0xFF 0x00) to close the WebSocket connection cleanly. BUG=none TEST=none Review URL: http://codereview.chromium.org/1374004 TBR=ukai@chromium.org Review URL: http://codereview.chromium.org/1549010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43351 0039d316-1c4b-4281-b951-d872f2087c98
* Break the test of chrome.tab.captureVisibleTab() out of ExtensionApiTest.Tabs.skerner@chromium.org2010-04-019-50/+154
| | | | | | | | | | | | Tests of chrome.tab.captureVisibleTab() fail on mac 10.6, and disabling all tab tests because of this is unfortunate. Breaking the test this way makes the 10.6 failure easier to debug. BUG=37387 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43101 Review URL: http://codereview.chromium.org/1520005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43349 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit roll 56868:56904.vitalyr@chromium.org2010-04-011-1/+1
| | | | | | | | | | BUG=none TEST=none TBR=darin Review URL: http://codereview.chromium.org/1517011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43348 0039d316-1c4b-4281-b951-d872f2087c98
* Make "Reset to Defaults" reset geolocation permissions toojoth@chromium.org2010-04-011-0/+2
| | | | | | | | | BUG=38626 TEST=Allow or block a site using geolocation, select Reset To Defaults, reload page. It should re-prompt. Review URL: http://codereview.chromium.org/1530014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43347 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Fixes bug where disabling the last browser action would cause the ↵andybons@chromium.org2010-04-011-1/+3
| | | | | | | | | | location bar and go button to overlap with the page and wrench menus (if they were visible). TEST=none BUG=40003 Review URL: http://codereview.chromium.org/1555004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43346 0039d316-1c4b-4281-b951-d872f2087c98
* Makes tab contents look for extension whose extent contains thesky@chromium.org2010-04-014-18/+158
| | | | | | | | | | | current url and fetches the smallish icon if the extension is found. BUG=none TEST=none Review URL: http://codereview.chromium.org/1576006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43345 0039d316-1c4b-4281-b951-d872f2087c98
* Workaround for 40099 - disable failing testjoth@chromium.org2010-04-011-1/+2
| | | | | | | | | BUG=40099 TEST=none Review URL: http://codereview.chromium.org/1549009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43343 0039d316-1c4b-4281-b951-d872f2087c98
* Defer sending wifi data via the network provider until permission has been ↵joth@chromium.org2010-04-0114-108/+280
| | | | | | | | | | | | | | granted to use geolocaiton. Also fixes a long standing todos/bugs that the host sent in the network request was not set correctly, and location results were not always tagged against the correct source data in the cache. BUG=39171 TEST=run with --geolocation-enabled and --log-level=0, check from logs that no location request sent until authorized. Review URL: http://codereview.chromium.org/1541008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43339 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] add additional fields to cookie prompt for web databasesdanno@chromium.org2010-04-016-12/+217
| | | | | | | | | | | | | xib changes: added two new lines to the web database cookie prompt subview of the cookie details NSView, one for database description and one for expected database size. Wired bindings to the appropriate methods in the cookie details object in the same style as the existing fields. Web database cookie prompt now looks like this: http://img208.imageshack.us/img208/9703/picture6j.png BUG=36435 TEST=augmented unit tests and manual tests Review URL: http://codereview.chromium.org/1582003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43338 0039d316-1c4b-4281-b951-d872f2087c98
* Flip the flag to enable geolocation by default.joth@chromium.org2010-04-016-15/+9
| | | | | | | | | BUG=39808 TEST=run browser with & withou --disable-geolocaiton. Review URL: http://codereview.chromium.org/1534008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43337 0039d316-1c4b-4281-b951-d872f2087c98
* Follow up on http://codereview.chromium.org/1552002bulach@chromium.org2010-04-011-1/+0
| | | | | | | | Removes obsolete #include. Review URL: http://codereview.chromium.org/1589006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43336 0039d316-1c4b-4281-b951-d872f2087c98
* Landing http://codereview.chromium.org/1084017:glider@chromium.org2010-04-011-1/+3
| | | | | | | | | | | | | | | nacl sources should be included conditionally TEST=build with and without disable_nacl=1 BUG=39034 This CL was initially prepared by appamatto@gmail.com TBR=sehr Review URL: http://codereview.chromium.org/1562007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43335 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 367.0 to 368.0chrome-release@google.com2010-04-011-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43333 0039d316-1c4b-4281-b951-d872f2087c98
* Implement closing handshake described in draft-hixie-thewebsocketprotocol-76.ukai@chromium.org2010-04-012-4/+128
| | | | | | | | | | | exchange closing frame (0xFF 0x00) to close the WebSocket connection cleanly. BUG=none TEST=none Review URL: http://codereview.chromium.org/1374004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43331 0039d316-1c4b-4281-b951-d872f2087c98
* Added the link to heapchecker howto.glider@chromium.org2010-04-011-0/+3
| | | | | | | | TBR=timurrrr Review URL: http://codereview.chromium.org/1527006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43330 0039d316-1c4b-4281-b951-d872f2087c98
* Update V8 to version 2.2.0.3.kmillikin@chromium.org2010-04-011-1/+1
| | | | | | | | | | | This fixes an ASSERT failure. BUG=39766 TEST=none Review URL: http://codereview.chromium.org/1604003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43329 0039d316-1c4b-4281-b951-d872f2087c98
* Fix leak in WebSocketThrottleTest::Throttleukai@chromium.org2010-04-013-18/+10
| | | | | | | | | | | | chromium r43192 add check of next_state_ to call DoLoop in SocketStream::Close(), so if next_state_ is STATE_NONE, we don't need socket->AddRef() to balance Release() in SocketStream::Finish(). BUG=39979 TEST=valgrind passes WebSocketThrottleTest Review URL: http://codereview.chromium.org/1517010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43328 0039d316-1c4b-4281-b951-d872f2087c98
* Annotate benign race in SyncherThread::IsSyncingCurrentlySilenced()timurrrr@chromium.org2010-04-011-1/+7
| | | | | | | | | | | | | | | | | | | | | | | Example of TSan report is: WARNING: Possible data race during write of size 8 at 0xEBC2AF0: {{{ T24 (SyncEngine_SyncerThread) (locks held: {L780}): #0 base::TimeTicks::operator=(base::TimeTicks) base/time.h:442 #1 browser_sync::SyncerThread::SyncMain(browser_sync::Syncer*) chrome/browser/sync/engine/syncer_thread.cc:418 #2 browser_sync::SyncerThread::ThreadMainLoop() chrome/browser/sync/engine/syncer_thread.cc:288 #3 browser_sync::SyncerThread::ThreadMain() chrome/browser/sync/engine/syncer_thread.cc:408 #4 void DispatchToMethod<browser_sync::SyncerThread, void (browser_sync::SyncerThread::*)()>(browser_sync::SyncerThread*, void (browser_sync::SyncerThread::*)(), Tuple0 const&) base/tuple.h:412 ... Concurrent read(s) happened at (OR AFTER) these points: T0 (locks held: {}): #0 base::TimeTicks::operator-(base::TimeTicks) const base/time.h:447 #1 browser_sync::SyncerThread::IsSyncingCurrentlySilenced() chrome/browser/sync/engine/syncer_thread.cc:202 #2 browser_sync::SyncerThreadWithSyncerTest::WaitForThrottle() chrome/browser/sync/engine/syncer_thread_unittest.cc:81 #3 browser_sync::SyncerThreadWithSyncerTest_Throttling_Test::TestBody() chrome/browser/sync/engine/syncer_thread_unittest.cc:666 #4 testing::Test::Run() testing/gtest/src/gtest.cc:2095 }}} Review URL: http://codereview.chromium.org/1575007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43327 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug where we were showing "t" in language config dialog.satorux@chromium.org2010-04-015-14/+72
| | | | | | | | | | Instead, we'll be showing "Others" BUG=crosbug.com/2167 Review URL: http://codereview.chromium.org/1608002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43325 0039d316-1c4b-4281-b951-d872f2087c98
* Enable disabled WebSocket tests (ExtensionApiTest.WebSocket and ↵ukai@chromium.org2010-04-012-6/+2
| | | | | | | | | | | | | | | WorkerWebSocketLayoutTests). These tests were not worked well, because of some bugs in websocket server implementation for tests, in Windows XP. This was fixed in webkit r56614 and r56774. BUG=38225,33247,36630 TEST=pass ExtensionApiTest.WebSocket and WorkerWebSocketLayoutTests Review URL: http://codereview.chromium.org/1575003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43324 0039d316-1c4b-4281-b951-d872f2087c98
* Strings for pattern support in content settings.jochen@chromium.org2010-04-011-0/+9
| | | | | | | | | BUG=37394 TEST=none Review URL: http://codereview.chromium.org/1599008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43323 0039d316-1c4b-4281-b951-d872f2087c98
* Revert update to WebKit 56880 since it broke worker tests.darin@chromium.org2010-04-011-1/+1
| | | | | | | | TBR=hclam Review URL: http://codereview.chromium.org/1539012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43322 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug that caused the add language dialog to have a huge combobox button.satorux@chromium.org2010-04-011-3/+28
| | | | | | | | | | | | | With this change, the add language dialog will look just like the hangul configuration dialog. There should be a better UI design, but this is at least much nicer than having the huge combobox. BUG=crosbug.com/2166 TEST=manually on netbook Review URL: http://codereview.chromium.org/1572010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43321 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build errors that occur on Ubuntu 9.10satorux@chromium.org2010-04-012-6/+10
| | | | | | | | | | | | | | | With g++ 4.4.1, ignoring return values from write() results in compilation errors: error: ignoring return value of ‘ssize_t write(int, const void*, size_t)’, declared with attribute warn_unused_result BUG=none TEST=built and ran the tests out/Release/unit_tests --gtest_filter='PipeReaderTest*' out/Release/unit_tests --gtest_filter='ExternalMetricsTest*' Review URL: http://codereview.chromium.org/1564005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43320 0039d316-1c4b-4281-b951-d872f2087c98
* Make the browser survive massive data: URIs, via various techniques:cevans@chromium.org2010-04-014-4/+23
| | | | | | | | | | | | | | | | | | | | | | | 1) Drop the URL limit from 10MB to 2MB. The browser survives without this, but that final tweaks makes the whole data: URI attack fairly smooth (on my admittedly powerful machine). 2) Elide the title string at kMaxTitleChars. We already have a hard title limit but there was a path whereby the title is implied by the URL (e.g. file: and data: etc). 3) For massive URLs, limit the length shown in URL bar. We need to support them, because someone might redirect to a data: URI with e.g. an image in it. However, attempting to show them would kill the browser. We can't elide them because eliding URLs is a security risk (and would lead to correctness issues with an edit/press enter cycle). So we show at least the origin (minus path) or just the scheme for data: URIs BUG=33952 TEST=NONE Review URL: http://codereview.chromium.org/1569011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43319 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes client side of readpixels so it doesn't writegman@chromium.org2010-04-011-5/+21
| | | | | | | | | | | | | | | pad bytes. Am working on framework for unit tests for the client side but it still needs work so tested this in the debugger by hand for now. TEST=none BUG=none Review URL: http://codereview.chromium.org/1578006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43317 0039d316-1c4b-4281-b951-d872f2087c98
* Roll WebKit 56868:56880hclam@chromium.org2010-04-011-1/+1
| | | | | | | | | | TBR=fishd@chromium.org TEST=tree is green Roll WebKit to 56880. Review URL: http://codereview.chromium.org/1547011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43315 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor WebSocket Live experiment code.ukai@chromium.org2010-04-013-150/+202
| | | | | | | | | | | | | Move saving result in WebSocketExperimentTask. Add net::WebSocket::ProtocolVersion in WebSocketExperimentTask::Config. Change Histgram managements. BUG=none TEST=none Review URL: http://codereview.chromium.org/1539007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43314 0039d316-1c4b-4281-b951-d872f2087c98
* Add CUSTOMIZE_SYNC_DIALOG_WIDTH_CHARS and _HEIGHT_LINES to xtb filesdantasse@chromium.org2010-04-0151-0/+102
| | | | | | | | | BUG=34209 TEST=none Review URL: http://codereview.chromium.org/1521008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43313 0039d316-1c4b-4281-b951-d872f2087c98
* Add themes to new sync UI.dantasse@chromium.org2010-04-015-1/+33
| | | | | | | | | BUG=34209,32414 TEST=none Review URL: http://codereview.chromium.org/1582006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43312 0039d316-1c4b-4281-b951-d872f2087c98
* In order for CF to support FF3.6, the code that checks for privilege mode ↵rogerta@chromium.org2010-04-018-883/+87
| | | | | | | | | | | | | | | | | | | | | | | needs to be updated since it currently depends on APIs that have been deprecated. The new method for determining if CF is running in privilege mode is to verify that the URL of the page that instantiates CF is a "chrome:" URL. An advantage to this change is the code should now work in all version of Firefox. Previously, the code was different for each of versions 3.0, 3.5, and now 3.6. Note that the API change to npapi::GetStringIdentifiers() was necessary to get around a problem where xpcom defines the same typedefs as chrome base, but with different types. If there is a better solution, please let me know. TEST=see existing unit tests BUG=none Review URL: http://codereview.chromium.org/1535002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43311 0039d316-1c4b-4281-b951-d872f2087c98
* Quick fix for a problem introduced by 41865 which causes sync notificationsakalin@chromium.org2010-04-011-3/+4
| | | | | | | | | | | to break for non-gmail.com accounts. BUG=40054 TEST=manual testing Review URL: http://codereview.chromium.org/1523007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43310 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ChromeOS build (function was renamed)finnur@chromium.org2010-04-011-2/+2
| | | | | | | | | | TEST=None BUG=None TBR=oshima Review URL: http://codereview.chromium.org/1534011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43309 0039d316-1c4b-4281-b951-d872f2087c98
* Wire up Ctrl+Enter for Find on ToolkitViews to match GTK.finnur@chromium.org2010-04-014-21/+48
| | | | | | | | | BUG=38366 TEST=Find a link, press Ctrl+Enter. Find box should close chrome should navigate the link. Review URL: http://codereview.chromium.org/1562006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43308 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: On unsupported DE, show local help page about configuring proxies.mattm@chromium.org2010-04-013-2/+45
| | | | | | | | | BUG=30657 TEST=unset GNOME_DESKTOP_SESSION_ID; run chrome and try to launch proxy config. Review URL: http://codereview.chromium.org/1541007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43307 0039d316-1c4b-4281-b951-d872f2087c98
* Add encoding override support for Chrome frame. With this change, users can ↵jnd@chromium.org2010-04-014-4/+164
| | | | | | | | | | | | | | | override current page encoding in Chrome Frame via clicking IE's encoding menu. Unfortunately this change does not work on IE8 since the encoding menu is off on IE8. This change was from http://codereview.chromium.org/460036/show, which was on a temporary machine which I can not access from China now. I will re-create the patch, make some modifications according to previous reviewers' comments. now I send to you for review. BUG=24040 TEST=none Review URL: http://codereview.chromium.org/1530012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43306 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the build: swap the parameters for GetForms.jhawkins@chromium.org2010-04-011-14/+14
| | | | | | | | | | TBR=dhollowa BUG=none TEST=none Review URL: http://codereview.chromium.org/1596002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43305 0039d316-1c4b-4281-b951-d872f2087c98
* FormManager cleanups:jhawkins@chromium.org2010-04-012-55/+80
| | | | | | | | | | | | | * Factor out WebFormControlElementToFormField. * Misc. readability cleanups. * Make FormElementToFormData static. BUG=none TEST=none Review URL: http://codereview.chromium.org/1595006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43304 0039d316-1c4b-4281-b951-d872f2087c98
* Set bookmark bar menu windows to the correct level.jrg@chromium.org2010-04-013-12/+21
| | | | | | | | | | | | | | | Fixes some menu awkwardness (e.g. is below the menubar and dock). Fixes some scroll awkwardness related dock overlap. Does NOT cause awkwardness if you Expose' which is smart enough to hide popup menus when exposeeing. BUG=http://crbug.com/36225 Review URL: http://codereview.chromium.org/1547010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43303 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill: Store the form method on the FormData object. This is another ↵jhawkins@chromium.org2010-04-013-0/+5
| | | | | | | | | | | step in consolidating FormData and FormFieldValues. BUG=33032 TEST=none Review URL: http://codereview.chromium.org/1558012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43298 0039d316-1c4b-4281-b951-d872f2087c98
* Solaris: various edits towards compiling Chromium on Solaris. Changed ↵evan@chromium.org2010-04-017-9/+30
| | | | | | | | | | | | __Solaris__ to __sun. Defined NAME_MAX as MAXNAMLEN for systems where it is undefined. BUG=30101 TEST=compiles Patch by James Choi <jchoi42 at pha.jhu.edu> Review URL: http://codereview.chromium.org/652166 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43297 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-30 15:05:33 +0000