summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Revert 82385 - this might be breaking the interactive_ui_tests on windows ↵nsylvain@chromium.org2011-04-214-51/+25
| | | | | | | | | | | and browser_tests on windows. The blamelist is big, so this is a guess. Original description: Add SubmenuView::magic_token_ and checks.Add MenuHostRootView::destroyed_flag_ and check.May help identify the cause of crbug.com/78792.Minor refactoring / code consolidation.BUG=78792TEST=noneReview URL: http://codereview.chromium.org/6879059 TBR=msw@chromium.org Review URL: http://codereview.chromium.org/6882117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82466 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 743.0 to 744.0chrome-release@google.com2011-04-211-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82463 0039d316-1c4b-4281-b951-d872f2087c98
* Revert the occasional batch add of suppression types to the suppression namesglider@chromium.org2011-04-211-408/+408
| | | | | | | TBR=timurrrr Review URL: http://codereview.chromium.org/6879107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82461 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce the ANNOTATE_LEAKING_OBJECT_PTR annotation that can be used to markglider@chromium.org2011-04-218-424/+434
| | | | | | | | | | | | heap allocated objects as intentionally leaked ones. Annotate the histograms produced by {Histogram,BooleanHistogram,LinearHistogram,CustomHistogram}::FactoryGet(), as leaked. Rename StatsHistogram::StatsHistogramFactoryGet to StatsHistogram::FactoryGet, annotate the result as leaky, update the suppressions. BUG=79322 Review URL: http://codereview.chromium.org/6869009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82460 0039d316-1c4b-4281-b951-d872f2087c98
* safebrowsing: Change "This file appears to be malicious" to "This file is ↵panayiotis@google.com2011-04-211-2/+2
| | | | | | | | malicious" in the warning message for malicious downloads. Review URL: http://codereview.chromium.org/6879097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82459 0039d316-1c4b-4281-b951-d872f2087c98
* Let everyone change the gtest filters for Valgrind tools.glider@chromium.org2011-04-212-1/+1
| | | | | | | | | Remove the paranoid "set noparent" from tools/valgrind/OWNERS TBR=timurrrr Review URL: http://codereview.chromium.org/6882113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82455 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 82448 - nsylvain@chromium.org2011-04-213-114/+3
| | | | | | | | | | | This is breaking FormStructureBrowserTest.DataDrivenHeuristics Original description: Refine inferring label algorithm to Autofill correctly.1. Exclude <script> and <option> tags from the "Infer" traversals. 2. Exclude <!-- comment --> elements from the "Infer" traversals. 3. Change IDS_AUTOFILL_ZIP_CODE_RE to be ... |^cap$ ... to strengthen the match.BUG=64818TEST=1. Go to gmail.com and click on the "Create an account" button. 2. Double click first name field and try to trigger Autofill. 3. Choose an item from the Autofill window. 4. Make sure the fields are correctly filled.Review URL: http://codereview.chromium.org/6873030 TBR=Takano.Naoki@gmail.com Review URL: http://codereview.chromium.org/6879106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82452 0039d316-1c4b-4281-b951-d872f2087c98
* Webkit roll to r84471, and upstreaming expectation overrides.dpranke@google.com2011-04-212-13/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82450 0039d316-1c4b-4281-b951-d872f2087c98
* Modify ForceFontPointSize to not access widget->style, as it can be ↵falken@chromium.org2011-04-211-2/+2
| | | | | | | | | | | | | incorrect if the widget is not realized yet. This fixes an issue in Chrome OS where the omnibox is not set to the base UI font when it is overridden by a locale-specific gtkrc. BUG=chromium-os:14133 TEST=verified the font is correct in Japanese UI and English UI on Chrome OS netbook, and verified font in omnibox and downloaded item widget (which also uses ForceFontPointSize) is the same on Chrome on Linux with and without GTK+ theme before and after this change Review URL: http://codereview.chromium.org/6883004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82449 0039d316-1c4b-4281-b951-d872f2087c98
* Refine inferring label algorithm to Autofill correctly.Takano.Naoki@gmail.com2011-04-213-3/+114
| | | | | | | | | | | | 1. Exclude <script> and <option> tags from the "Infer" traversals. 2. Exclude <!-- comment --> elements from the "Infer" traversals. 3. Change IDS_AUTOFILL_ZIP_CODE_RE to be ... |^cap$ ... to strengthen the match. BUG=64818 TEST=1. Go to gmail.com and click on the "Create an account" button. 2. Double click first name field and try to trigger Autofill. 3. Choose an item from the Autofill window. 4. Make sure the fields are correctly filled. Review URL: http://codereview.chromium.org/6873030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82448 0039d316-1c4b-4281-b951-d872f2087c98
* Make the SBH wait until syncer is put in config mode before it triggers DTM ↵lipalani@chromium.org2011-04-214-11/+23
| | | | | | | | | | | to do model association. BUG=80124 TEST= Review URL: http://codereview.chromium.org/6879099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82447 0039d316-1c4b-4281-b951-d872f2087c98
* Modify error code of move/copy preparation.tzik@google.com2011-04-212-6/+6
| | | | | | | | | | | | ref: https://bugs.webkit.org/show_bug.cgi?id=58864 BUG=None TEST=None Review URL: http://codereview.chromium.org/6881078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82446 0039d316-1c4b-4281-b951-d872f2087c98
* Add virtual in QuitaFileUtil to fix the compilation error in r82441.yutak@chromium.org2011-04-211-2/+2
| | | | | | | | | | TBR=dmikurube,kinuko BUG=none TEST=none Review URL: http://codereview.chromium.org/6882112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82445 0039d316-1c4b-4281-b951-d872f2087c98
* Reflect the preference of remapping modifier keys on the keyboard overlay.mazda@chromium.org2011-04-212-6/+110
| | | | | | | | | | BUG=chromium-os:8681 TEST=manually on the chrome notebook Review URL: http://codereview.chromium.org/6881082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82442 0039d316-1c4b-4281-b951-d872f2087c98
* Add "allowed growth" for writing operations, such as copy, move, write and ↵dmikurube@chromium.org2011-04-2113-37/+789
| | | | | | | | | | | | | truncate. A writing operation which increases the file size more than "allowed growth" results in PLATFORM_FILE_ERROR_NO_SPACE. BUG=74841 TEST=FileWriterDelegateTest.*,QuotaFileUtilTest.*,FileSystemOperationTest.* Review URL: http://codereview.chromium.org/6725021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82441 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress failures for transforms/2d/hindi-rotated,dpranke@google.com2011-04-211-0/+8
| | | | | | | inspector/debugger/live-edit, and inspector/console/console-object-constructor-name git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82434 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress plugins/embed-attributes-style.html failure on WIN/LINUX.dpranke@google.com2011-04-211-0/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82432 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure the PpapiBrokerImpl is deleted when it has no more clients.ddorwin@chromium.org2011-04-212-20/+71
| | | | | | | | | | | | | This handles a corner case where all broker resources are deleted before the channel created IPC response is handled or if it never occurs. This doesn't solve all potential problems, but it helps with the ones we can influence. An example scenario that this does not fix is if another broker resource is created by the plugin in the same renderer but the broker process is hung or thinks it has a channel to this renderer (channel names are based on the renderer). Even though a new PpapiBrokerImpl will be created as expected, the broker will not establish the channel. BUG=none TEST=none Review URL: http://codereview.chromium.org/6883101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82431 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome crashes on importing bookmark files from Bookmark Manager.toyoshim@chromium.org2011-04-212-10/+49
| | | | | | | | | | | In the case of bookmarks which don't have any subfolder, importer failed to insert prefix to bookmark item pathes and called erase() on empty vector. BUG=79978 TEST=unit_tests --gtest_filter=FirefoxImporterTest.\* Review URL: http://codereview.chromium.org/6877080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82429 0039d316-1c4b-4281-b951-d872f2087c98
* Cleaning up print_preview.js event listeners.dpapad@chromium.org2011-04-212-43/+24
| | | | | | | | | | | | | | 1) All event listeners are now added in js code (not in html). 2) Some unnecessary listeners have been removed. 3) Per HTML element: There is only one listener for the same event. BUG=NONE TEST=Print preview tab should behave as before. Review URL: http://codereview.chromium.org/6880090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82428 0039d316-1c4b-4281-b951-d872f2087c98
* Mark some interactive_ui_tests DISABLED on Linux.cmp@chromium.org2011-04-212-0/+100
| | | | | | | | | | | These tests are hanging/failing on Lucid. BUG=none TEST=interactive_ui_tests passes Review URL: http://codereview.chromium.org/6882109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82427 0039d316-1c4b-4281-b951-d872f2087c98
* Webkit roll to r84438. Also clear out the downstream overrides.dpranke@google.com2011-04-212-104/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82426 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 82405 - Support more than 9 arguments for ↵nsylvain@chromium.org2011-04-212-40/+8
| | | | | | | | | ReplaceStringPlaceholders()- support more than 9 arguments ($1, $2, $3, ..., $9 and $10, $11, $12, ...) for ReplaceStringPlaceholders()- add the unittest named ReplaceStringPlaceholdersMoreThan9Replacements for testing more than 9 arguments for ReplaceStringPlaceholders()BUG=16963TEST=string_util_unittest:StringUtilTest.ReplaceStringPlaceholdersMoreThan9ReplacementsPatch by haraken@google.com.Review URL: http://codereview.chromium.org/6877008 TBR=tony@chromium.org Review URL: http://codereview.chromium.org/6882108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82423 0039d316-1c4b-4281-b951-d872f2087c98
* More flaky tests and debug assertionsdpranke@google.com2011-04-211-0/+7
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82420 0039d316-1c4b-4281-b951-d872f2087c98
* Mac Bookmark bar menus: ensure that the innermost visible submenu always has ↵maf@chromium.org2011-04-211-0/+3
| | | | | | | | | | "key" status. Fixes bug where they keystrokes started going to the browser window if you opened and closed a submenu from the keyboard. R=mrossetti@chromium.org BUG=80003 Review URL: http://codereview.chromium.org/6881089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82419 0039d316-1c4b-4281-b951-d872f2087c98
* Make bookmark menu windows not beep whenever they get a keystroke.maf@chromium.org2011-04-211-0/+4
| | | | | | | | R=mrossetti@chromium.org BUG=80065 Review URL: http://codereview.chromium.org/6879089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82418 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed JS payload for drive notification event.zelidrag@chromium.org2011-04-211-1/+1
| | | | | | | | BUG=chromium-os:14330 TEST=make sure file browser pops up when USB is inserted Review URL: http://codereview.chromium.org/6881098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82415 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of chrome://filebrowseachuith@chromium.org2011-04-212-2/+0
| | | | | | | | BUG=chromium-os:14328 TEST=NONE Review URL: http://codereview.chromium.org/6880091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82412 0039d316-1c4b-4281-b951-d872f2087c98
* The passive worker was being added to the session once per datatype. Fix it ↵lipalani@chromium.org2011-04-211-7/+19
| | | | | | | | | | | so it gets added only once so we dont do extra processing. BUG=80049 TEST= Review URL: http://codereview.chromium.org/6880082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82411 0039d316-1c4b-4281-b951-d872f2087c98
* Add command-line control of the HSTS preload list.cevans@chromium.org2011-04-217-46/+130
| | | | | | Review URL: http://codereview.chromium.org/6869043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82409 0039d316-1c4b-4281-b951-d872f2087c98
* Support more than 9 arguments for ReplaceStringPlaceholders()tony@chromium.org2011-04-202-8/+40
| | | | | | | | | | | | | | - support more than 9 arguments ($1, $2, $3, ..., $9 and $10, $11, $12, ...) for ReplaceStringPlaceholders() - add the unittest named ReplaceStringPlaceholdersMoreThan9Replacements for testing more than 9 arguments for ReplaceStringPlaceholders() BUG=16963 TEST=string_util_unittest:StringUtilTest.ReplaceStringPlaceholdersMoreThan9Replacements Patch by haraken@google.com. Review URL: http://codereview.chromium.org/6877008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82405 0039d316-1c4b-4281-b951-d872f2087c98
* OnWindowPosChanged override wasn't calling through to WidgetWin impl, ↵ben@chromium.org2011-04-201-0/+1
| | | | | | | | | | resulting in the RootView never getting sized. http://crbug.com/79432 TEST=see bug Review URL: http://codereview.chromium.org/6877104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82403 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] Don't show theme install butterbar if theme was installed by syncakalin@chromium.org2011-04-202-24/+2
| | | | | | | | | | | | Make ExtensionInstallUI::ShowThemeInfoBar() private. BUG=80062 TEST=Sync a theme to a computer. Make sure the install butterbar doesn't show. Review URL: http://codereview.chromium.org/6881093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82402 0039d316-1c4b-4281-b951-d872f2087c98
* Plumb direction of document title through IPC layer.evan@chromium.org2011-04-2015-32/+62
| | | | | | | | | | | | | It's ignored at the other end of the IPC, but I have tagged all the places it needs to be obeyed with a link to the bug. While I'm at it, switch UpdateTitle to using string16. BUG=27094 Review URL: http://codereview.chromium.org/6880073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82400 0039d316-1c4b-4281-b951-d872f2087c98
* Added additional tests to Autofill.dyu@chromium.org2011-04-2011-12/+254
| | | | | | | | | | | | | | | - testAbleToFillFormAfterFormReset - testDinstinguishMiddleInitialWithinName (M13 feature) - testMultipleEmailAddressFilledByOneUserGesture - testProfilesNotAggregatedWhenEmailFoundInNonEmailField (M13 feature) Changed form id name for each html file for better consistency. TEST=none BUG=none Review URL: http://codereview.chromium.org/6882071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82399 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Fix "Statusbar does not move up when we get the download shelf"asvitkine@chromium.org2011-04-201-1/+2
| | | | | | | | | | | BUG=28736 TEST=In a maximized window without the download shelf showing, click on a download link. The status bubble should be moved above the download shelf that appears instead of overlapping with it. Review URL: http://codereview.chromium.org/6882040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82398 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Reset isHandlingSendEvent flag in case of exceptional condition.shess@chromium.org2011-04-203-0/+17
| | | | | | | | | | | | | | | NSExceptions can cause the flag to get latched to YES, which messes with window closing. A number of suspected exceptions shouldn't cause too much other damage, so this patches over the problem for the short term. TBR=jam@chromium.org BUG=45928 TEST=see bug Review URL: http://codereview.chromium.org/6873081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82397 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Fix another instance of "Import bookmarks now..." overlap with "Other ↵asvitkine@chromium.org2011-04-201-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | Bookmarks" Call [self reconfigureBookmarkBar] from |nodeRemoved:| instead of from |removeButton:|. When it was called from |removeButton:|, the |noItemContainer| was still hidden, so |adjustNoItemContainerWidthsForMaxX:| did nothing. Calling it from |nodeRemoved:| fixes this. Also, it is no longer necessary to call |configureOffTheSideButtonContentsAndVisibility:| from |nodeRemoved:|, since that is done by |reconfigureBookmarkBar| already. BUG=44711 TEST=Add a bunch of items to the bookmarks bar. Resize the window to be narrow. Open the bookmark manager and shift-select all items in the bookmark bar. Delete the items through the context menu. The bookmark bar should now contain the "Import bookmarks now..." text that does not overlap with "Other bookmarks" Review URL: http://codereview.chromium.org/6879010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82396 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent extra destroy on several GTK dialogsestade@chromium.org2011-04-204-1/+11
| | | | | | | | | | | | | | | Counter-intuitively, in gtk_dialog_init(), they use g_signal_connect() to attach a delete-event handler which calls gtk_dialog_respond with DELETE_EVENT, but then they return FALSE to fall through to the default handler, which calls destroy. The widget_hide_on_delete handler that we're using here is inserted after the dialog delete-event handler, but before the default handler, thus overriding the destroy. BUG=79764 TEST=manual Review URL: http://codereview.chromium.org/6880078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82395 0039d316-1c4b-4281-b951-d872f2087c98
* more flakiness.dpranke@google.com2011-04-201-0/+5
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82394 0039d316-1c4b-4281-b951-d872f2087c98
* Fix corrupt line-endings on port_monitor.cc. (Step 1, remove line-endings ↵csilv@chromium.org2011-04-202-11/+9
| | | | | | | | | | property) BUG=none TBR=vandebo@chromium.org Review URL: http://codereview.chromium.org/6880080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82393 0039d316-1c4b-4281-b951-d872f2087c98
* Mark more things as WIN/LINUX instead of just LINUX, add more flakydpranke@google.com2011-04-201-4/+13
| | | | | | tests. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82392 0039d316-1c4b-4281-b951-d872f2087c98
* Adds widget_delegate.cc to appease the clang bot.sky@chromium.org2011-04-203-5/+35
| | | | | | | | | | | R=ben@chromium.org TBR=ben@chromium.org BUG=none TEST=none Review URL: http://codereview.chromium.org/6878085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82391 0039d316-1c4b-4281-b951-d872f2087c98
* When the v8 proxy resolver is used, add the v8 heap size to the JavaScript ↵evan@chromium.org2011-04-202-0/+28
| | | | | | | | | | | | | | | | | | | | memory column in task manager. This memory is significant enough that we should be looking at it when analyzing memory of the browser process. BUG=None TEST= 1. Open up Task Manager, 2. Right-click and "enable" Javascript Memory 3. Observe that the "Browser" row reports the v8 heap Note, like the v8-based proxy resolver this is DISABLED for single-process chrome because v8 is not thread safe. Patch by Greg Simon <gregsimon@chromium.org>. Review URL: http://codereview.chromium.org/6760003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82390 0039d316-1c4b-4281-b951-d872f2087c98
* I can't count.mark@chromium.org2011-04-201-1/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6873135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82387 0039d316-1c4b-4281-b951-d872f2087c98
* 10.5 SDK compatibility for ObjCPropertyReleaserTest.mark@chromium.org2011-04-201-23/+8
| | | | | | | | BUG=none TEST=green trees Review URL: http://codereview.chromium.org/6880088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82386 0039d316-1c4b-4281-b951-d872f2087c98
* Add SubmenuView::magic_token_ and checks.msw@chromium.org2011-04-204-25/+51
| | | | | | | | | | | | | Add MenuHostRootView::destroyed_flag_ and check. May help identify the cause of crbug.com/78792. Minor refactoring / code consolidation. BUG=78792 TEST=none Review URL: http://codereview.chromium.org/6879059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82385 0039d316-1c4b-4281-b951-d872f2087c98
* Refactors login window widget creation methods into platform specific methods.sky@chromium.org2011-04-2016-179/+229
| | | | | | | | | | BUG=none TEST=none R=ben@chromium.org Review URL: http://codereview.chromium.org/6877064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82384 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce ObjCPropertyReleaser for automatic releasing of Objective-Cmark@chromium.org2011-04-205-0/+474
| | | | | | | | | | properties marked "retain" or "copy" backed by synthesized instance variables. BUG=none TEST=base_unittests ObjCPropertyReleaserTest.SesameStreet Review URL: http://codereview.chromium.org/6881091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82383 0039d316-1c4b-4281-b951-d872f2087c98
* one more mac change.dpranke@google.com2011-04-201-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82377 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-28 23:50:51 +0000