summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Pass the NetworkChangeNotifier to HostResolver.willchan@chromium.org2010-02-0436-108/+165
| | | | | | | | | | | | | | | This requires the following refactors: (1) NetworkChangeNotifier moves out of HttpNetworkSession into IOThread. (2) HostResolver gets initialized with NetworkChangeNotifier. (3) NetworkChangeNotifier needs to get passed into HttpCache and HttpNetworkSession (required updating a lot of files). (4) NetworkChangeNotifier is no longer reference counted. It is owned by IOThread. (5) IOThread gains a new struct: Globals. It can only be used on the io thread. (6) ChromeURLRequestContextFactory uses IOThread::Globals to initialize ChromeURLRequest objects with the host resolver and network change notifier. BUG=26159 Review URL: http://codereview.chromium.org/552117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38052 0039d316-1c4b-4281-b951-d872f2087c98
* linux: Use SimpleMenuModel::Delegate in TaskManager instead of ↵estade@chromium.org2010-02-041-10/+20
| | | | | | | | | | | | | MenuGtk::Delegate. BUG=31365 TEST=manually patch by tfarina <thiago.farina [at] gmail> original review ==> http://codereview.chromium.org/557072/show Review URL: http://codereview.chromium.org/562040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38051 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure locally stored site data is deleted after DB and WebKit threads ↵jochen@chromium.org2010-02-041-6/+12
| | | | | | | | | | | are gone. BUG=32719 TEST=none Review URL: http://codereview.chromium.org/564050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38048 0039d316-1c4b-4281-b951-d872f2087c98
* Mark URLRequestTestFTP.FTPGetTestAnonymous as flaky.chase@chromium.org2010-02-041-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | It failed here: http://codf2.jail:8010/builders/Modules%20XP/builds/22848/steps/net_unittests/logs/stdio [ RUN ] URLRequestTestFTP.FTPGetTestAnonymous .\url_request\url_request_unittest.cc(2094): error: Value of: static_cast<int>(file_size) Actual: 1563 Expected: d.bytes_received() Which is: 0 [ FAILED ] URLRequestTestFTP.FTPGetTestAnonymous (15 ms) It passed in the next (forced) build here: http://codf2.jail:8010/builders/Modules%20XP/builds/22849/steps/net_unittests/logs/stdio [ RUN ] URLRequestTestFTP.FTPGetTestAnonymous [ OK ] URLRequestTestFTP.FTPGetTestAnonymous (16 ms) BUG=25045 TEST=test is greener than before TBR=phajdan.jr@chromium.org Review URL: http://codereview.chromium.org/561062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38047 0039d316-1c4b-4281-b951-d872f2087c98
* Add candidate_window to chromiumos-chromium.zipsatorux@chromium.org2010-02-041-0/+1
| | | | | | | | | | | | candidate_window is used for entering text in CJK languages on Chrome OS. See http://www.chromium.org/chromium-os/chromiumos-design-docs/text-input for details. TEST=none BUG=none Review URL: http://codereview.chromium.org/561059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38045 0039d316-1c4b-4281-b951-d872f2087c98
* Bump chromium DEPS to pick up my skia Linux crash fix.tschmelcher@chromium.org2010-02-031-1/+11
| | | | | | | | | TEST=built and ran on Linux and loaded a font that was not installed BUG=none Review URL: http://codereview.chromium.org/565013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38044 0039d316-1c4b-4281-b951-d872f2087c98
* Check the LSID before starting up a ProfileSyncService. This will stop ↵dantasse@chromium.org2010-02-031-0/+4
| | | | | | | | | | | memory leaks in tests. It will also stop us from starting Sync in Chromium OS UI tests. BUG=32085,32084 TEST=none Review URL: http://codereview.chromium.org/560033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38042 0039d316-1c4b-4281-b951-d872f2087c98
* OpenBSD has sys/exec_elf.h for the ELF defines, not elf.hpvalchev@google.com2010-02-033-4/+10
| | | | | | | | rename 'linux' files to 'posix' (and exclude them on mac) Review URL: http://codereview.chromium.org/562023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38041 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 316.0 to 317.0chrome-release@google.com2010-02-031-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38040 0039d316-1c4b-4281-b951-d872f2087c98
* Added support for lost context recovery on the client side. None of our ↵apatrick@chromium.org2010-02-0315-108/+232
| | | | | | | | | | | | | | | | | | | service side GL implementations actually report lost contexts (yet). Added pglGetError to PGL library. pglSwapBuffers returns false on a lost context or other non-recoverable error and pglGetError reports PGL_CONTEXT_LOST. Updated demo plugins to reset their PGL contexts on context lost. Standalone plugins cannot currently recover from lost context because they don't use PGL. Added error code to NPDeviceContext3D for lost context. TEST=none BUG=none Review URL: http://codereview.chromium.org/566021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38039 0039d316-1c4b-4281-b951-d872f2087c98
* seccomp: allow dup/dup2evan@chromium.org2010-02-031-0/+2
| | | | | | | | | | This is needed for opening the renderer<->plugin channel. TEST=flash works in seccomp mode Review URL: http://codereview.chromium.org/563024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38037 0039d316-1c4b-4281-b951-d872f2087c98
* Clip compact location bar's window when animating.oshima@chromium.org2010-02-035-144/+170
| | | | | | | | | | | | | | | | - Moved window clipping code to DropdownBarHost so that CompactLocationBar can use it. - Changed CompactLocationBar to do clipping when animating. - Adjust the location of compact location bar when bookmark bar is visible. CompactLocationBar's shape will be different from one for find bar. I'll change the UpdateWindowEdge so that i can handle different shapes later. BUG=31766 TEST=none Review URL: http://codereview.chromium.org/560036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38035 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the "On top" display mode of the extension shelf, it is no longer ↵ben@chromium.org2010-02-039-76/+9
| | | | | | | | | | | used or supported. BUG=none TEST=none Review URL: http://codereview.chromium.org/566035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38034 0039d316-1c4b-4281-b951-d872f2087c98
* Add autofill proto buffer for sync.zork@google.com2010-02-032-0/+25
| | | | | | | | | BUG=34203 TEST=none Review URL: http://codereview.chromium.org/562027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38033 0039d316-1c4b-4281-b951-d872f2087c98
* Fix wrong locking scope.stoyan@chromium.org2010-02-031-11/+13
| | | | | | Review URL: http://codereview.chromium.org/565039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38032 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: fix Esc-killing-Omnibox-focus problem (after find bar shown).viettrungluu@chromium.org2010-02-031-0/+9
| | | | | | | | | BUG=33094 TEST=Open a new browser window; Cmd-F to show the find bar; Esc to hide the find bar; focus the Omnibox; press Esc a few times (with or without editing its contents); focus should remain in the Omnibox. Make sure showing/hiding/using the find bar works normally. Review URL: http://codereview.chromium.org/561055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38030 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the three tests broken by gcf: change.amit@chromium.org2010-02-032-13/+19
| | | | | | | | | BUG=34461 TEST=Fixed and enabled tests CFProtocol, Persistent cookie and NavigateOut Review URL: http://codereview.chromium.org/561057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38029 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 38001 and 38002.darin@chromium.org2010-02-0323-463/+1079
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Modify CookiePolicy to work asynchronously This change will enable us to prompt the user before setting a cookie. While we only need to prompt before setting, we actually need to make both CanSetCookie and CanGetCookies asynchronous. This is necessary in order to preserve FIFO ordering since the value returned by GetCookies depends on the changes made to the cookie DB by SetCookie. This change also includes some simplification of CookieStore. Instead of N virtual functions, I distilled it down to only 4. The remaining functions are instead expressed in terms of those. While studying all the places where we currently use CookiePolicy, I found that some of them were not appropriate. After discussing with Amit, I decided to remove the policy checks in URLRequestAutomationJob. See the comments in the code regarding this. I changed the signature of CookieMonster::GetRawCookies to GetAllCookiesForURL to better match GetAllCookies. Related to this change webkit/glue/webcookie.h grows a constructor that takes a CanonicalCookie to help clean up some code. On the Chrome side, ChromeURLRequestContext now has a ChromeCookiePolicy object. That object is threadsafe ref counted because it is passed between the UI and IO threads. It is responsible for implementing the queuing logic described above. It will also in the future trigger the Chrome UI code to actually show the setcookie prompt. Please review the state machinery changes in URLRequestHttpJob carefully. R=eroman BUG=34331 TEST=no tests yet for prompting. Review URL: http://codereview.chromium.org/564045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38028 0039d316-1c4b-4281-b951-d872f2087c98
* The ExternalTabContainer enters a modal loop while waiting for the unload ↵ananta@chromium.org2010-02-032-2/+30
| | | | | | | | | | | | | | | | | | events on the tab to complete. If multiple ChromeFrame tabs were closed together then we end up in a nested loop hierarchy. In this case the innermost message loop ends up dispatching the TabContents::Close method which then calls its delegate which is the ExternalTabContainer for the other ExternalTabs as well. As a result the outer loops never exit, which causes IE tabs to hang. Fix is to use a local global stack of ExternalTabContainers. If we receive a CloseContents call for any other container but the innermost one, we post it back to the loop. Bug=31853 Review URL: http://codereview.chromium.org/560034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38022 0039d316-1c4b-4281-b951-d872f2087c98
* Fix race conditions.stoyan@chromium.org2010-02-032-34/+32
| | | | | | | | BUG=34389 Review URL: http://codereview.chromium.org/564041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38021 0039d316-1c4b-4281-b951-d872f2087c98
* Fix startup regression caused by (r38006).erg@google.com2010-02-031-0/+0
| | | | | | | | TBR=mirandac Review URL: http://codereview.chromium.org/561052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38018 0039d316-1c4b-4281-b951-d872f2087c98
* GTK bookmark bar button throbbing tweaksestade@chromium.org2010-02-031-12/+15
| | | | | | | | | | | | a) initialize throbbing_widget_ (fixes crasher http://crbug.com/34313) b) throb "Other Bookmarks" button when appropriate BUG=34313 TEST=manual Review URL: http://codereview.chromium.org/561051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38017 0039d316-1c4b-4281-b951-d872f2087c98
* Dropping unconnected obsolete vsprops files.bradnelson@google.com2010-02-0319-294/+0
| | | | | | | | | BUG=8042 TEST=None Review URL: http://codereview.chromium.org/567033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38016 0039d316-1c4b-4281-b951-d872f2087c98
* Implement chrome.browserAction.setPopup().skerner@chromium.org2010-02-0319-16/+427
| | | | | | | | | BUG=27526 TEST=Unit tests BrowserActionApiTest.BrowserAction*Popup . Review URL: http://codereview.chromium.org/552263 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38015 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] use subprocess.Popen instead of os.popen2 to avoid warnings on 10.6 ↵thomasvl@chromium.org2010-02-031-1/+2
| | | | | | | | | | bots due to newer python version BUG=27879 TEST=none Review URL: http://codereview.chromium.org/570004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38013 0039d316-1c4b-4281-b951-d872f2087c98
* OTS DEPS roll to r26 to support "kern" OpenType table.yusukes@chromium.org2010-02-031-1/+1
| | | | | | | | BUG=27132 TEST=none Review URL: http://codereview.chromium.org/567019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38012 0039d316-1c4b-4281-b951-d872f2087c98
* Don't show a translate infobar when the page is in a languagejcampan@chromium.org2010-02-033-1/+25
| | | | | | | | | | | | not supported by the translation server. BUG=34365 TEST=Visit http://www.breizh.net/brezhoneg/, no translation infobar should be shown. Review URL: http://codereview.chromium.org/568028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38010 0039d316-1c4b-4281-b951-d872f2087c98
* Themes: HasCustomImage() must only return true for images that were providederg@google.com2010-02-033-20/+81
| | | | | | | | | | | | | by the extension and not for images that were autogenerated. Since this adds data to the theme pack file, bump the version number. BUG=34078 TEST=BrowserThemePackTest.TestHasCustomImage Review URL: http://codereview.chromium.org/562025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38006 0039d316-1c4b-4281-b951-d872f2087c98
* BSD port: another chunk of chrome/browser ifdef cleaningpvalchev@google.com2010-02-0310-29/+30
| | | | | | Review URL: http://codereview.chromium.org/553153 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38004 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: middle click on a bookmark bar folder should open all in tabs.estade@chromium.org2010-02-032-1/+13
| | | | | | | | | BUG=34416 TEST=try it Review URL: http://codereview.chromium.org/569031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38003 0039d316-1c4b-4281-b951-d872f2087c98
* Back out trunk r37998.mark@chromium.org2010-02-0322-1077/+430
| | | | | | | | | | | | | | | | | | | | | | | | | | Modify CookiePolicy to work asynchronously This change will enable us to prompt the user before setting a cookie. While we only need to prompt before setting, we actually need to make both CanSetCookie and CanGetCookies asynchronous. This is necessary in order to preserve FIFO ordering since the value returned by GetCookies depends on the changes made to the cookie DB by SetCookie. This change also includes some simplification of CookieStore. Instead of N virtual functions, I distilled it down to only 4. The remaining functions are instead expressed in terms of those. While studying all the places where we currently use CookiePolicy, I found that some of them were not appropriate. After discussing with Amit, I decided to remove the policy checks in URLRequestAutomationJob. See the comments in the code regarding this. I changed the signature of CookieMonster::GetRawCookies to GetAllCookiesForURL to better match GetAllCookies. I also filed a bug about making it even closer in functionality. Related to this change webkit/glue/webcookie.h grows a constructor that takes a CanonicalCookie to help clean up some code. On the Chrome side, ChromeURLRequestContext now has a ChromeCookiePolicy object. That object is threadsafe ref counted because it is passed between the UI and IO threads. It is responsible for implementing the queuing logic described above. It will also in the future trigger the Chrome UI code to actually show the setcookie prompt. Please review the state machinery changes in URLRequestHttpJob carefully. R=eroman BUG=34331 TEST=no tests yet for prompting. Review URL: http://codereview.chromium.org/567015 TBR=darin@chromium.org Review URL: http://codereview.chromium.org/562037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38002 0039d316-1c4b-4281-b951-d872f2087c98
* Back out trunk r38000.mark@chromium.org2010-02-031-2/+33
| | | | | | | | | | | | | Fix ChromiumOS build. TBR=eroman Review URL: http://codereview.chromium.org/569030 TBR=darin@chromium.org Review URL: http://codereview.chromium.org/565036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38001 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ChromiumOS build.darin@chromium.org2010-02-031-33/+2
| | | | | | | | TBR=eroman Review URL: http://codereview.chromium.org/569030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38000 0039d316-1c4b-4281-b951-d872f2087c98
* Added status area to login wizard view.avayvod@chromium.org2010-02-032-5/+42
| | | | | | | | | | Separated objects construction and initialization. BUG=34374 TEST=Chrome based login now should have status area buttons in the right-top corner. Review URL: http://codereview.chromium.org/564027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37999 0039d316-1c4b-4281-b951-d872f2087c98
* Modify CookiePolicy to work asynchronouslydarin@chromium.org2010-02-0322-430/+1077
| | | | | | | | | | | | | | | | | | | | | This change will enable us to prompt the user before setting a cookie. While we only need to prompt before setting, we actually need to make both CanSetCookie and CanGetCookies asynchronous. This is necessary in order to preserve FIFO ordering since the value returned by GetCookies depends on the changes made to the cookie DB by SetCookie. This change also includes some simplification of CookieStore. Instead of N virtual functions, I distilled it down to only 4. The remaining functions are instead expressed in terms of those. While studying all the places where we currently use CookiePolicy, I found that some of them were not appropriate. After discussing with Amit, I decided to remove the policy checks in URLRequestAutomationJob. See the comments in the code regarding this. I changed the signature of CookieMonster::GetRawCookies to GetAllCookiesForURL to better match GetAllCookies. I also filed a bug about making it even closer in functionality. Related to this change webkit/glue/webcookie.h grows a constructor that takes a CanonicalCookie to help clean up some code. On the Chrome side, ChromeURLRequestContext now has a ChromeCookiePolicy object. That object is thread-safe ref counted because it is passed between the UI and IO threads. It is responsible for implementing the queuing logic described above. It will also in the future trigger the Chrome UI code to actually show the set-cookie prompt. Please review the state machinery changes in URLRequestHttpJob carefully. R=eroman BUG=34331 TEST=no tests yet for prompting. Review URL: http://codereview.chromium.org/567015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37998 0039d316-1c4b-4281-b951-d872f2087c98
* Add "File Bug" link to flakiness dashboard to ease filing new layout test ↵dglazkov@chromium.org2010-02-031-1/+18
| | | | | | | | | | | | regression bugs. R=arv TEST=none BUG=none Review URL: http://codereview.chromium.org/563020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37997 0039d316-1c4b-4281-b951-d872f2087c98
* Adding catches to states of the UI to only allow button pushes in certain ↵dhg@chromium.org2010-02-032-6/+31
| | | | | | | | | | | states. Basically adding error catching. BUG=none TEST=none Review URL: http://codereview.chromium.org/562005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37996 0039d316-1c4b-4281-b951-d872f2087c98
* Make Chrome CLD uses the most recent generated tables.jcampan@chromium.org2010-02-034-225/+74905
| | | | | | | | | TEST=None BUG=None Review URL: http://codereview.chromium.org/565020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37995 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: fix menu IDs (Save Page As... and Text Encoding menu items).viettrungluu@chromium.org2010-02-031-151/+924
| | | | | | | | | | | | Fix breakage caused by <http://src.chromium.org/viewvc/chrome?view=rev&revision=37819>. Changed tags for File->{Save Page As..., Email Page Location, Print...} and View->Text Encoding. BUG=34463 TEST=Check that File->Save Page As... (and Cmd-S), File->Email Page Location, and View->Text Encoding work properly. Review URL: http://codereview.chromium.org/566033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37994 0039d316-1c4b-4281-b951-d872f2087c98
* Enabled in-process NaCl plugin on Linux. Turns out it's remarkably similar ↵cbiffle@google.com2010-02-031-2/+2
| | | | | | | | | | to OS X support, so this CL simply tweaks the #ifdefs. BUG=32602 TEST=none Review URL: http://codereview.chromium.org/569018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37993 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 37989 - unit test failed on Mac builder despite passing on try serverjoth@chromium.org2010-02-0310-404/+13
| | | | | | | | | | | | | | | | Original change: Add tests for the geolocation network provider. Also some small tidy up a few other files. BUG=http://crbug.com/11246 TEST=unit_tests.exe gtest_filter=NetworkLocationProvider* gtest_break_on_failure Review URL: http://codereview.chromium.org/556106 TBR=joth@chromium.org Review URL: http://codereview.chromium.org/570006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37992 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling NavigateOut test since that also depends on theamit@chromium.org2010-02-031-1/+3
| | | | | | | | | | gcf: protocol that's now disabled. TBR=ananta Review URL: http://codereview.chromium.org/560035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37990 0039d316-1c4b-4281-b951-d872f2087c98
* Add tests for the geolocation network provider.joth@chromium.org2010-02-0310-13/+404
| | | | | | | | | | | Also some small tidy up a few other files. BUG=http://crbug.com/11246 TEST=unit_tests.exe --gtest_filter=NetworkLocationProvider* --gtest_break_on_failure Review URL: http://codereview.chromium.org/556106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37989 0039d316-1c4b-4281-b951-d872f2087c98
* Disable failing tests and change GMock'ism foramit@chromium.org2010-02-031-21/+25
| | | | | | | | | | | | testing::AnyNumber() to be followed by WillRepeatedly(...) instead of WillOnce TBR=ananta Review URL: http://codereview.chromium.org/563019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37988 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: follow up fix for raw cookies access. Restore auto-locking and do ↵pfeldman@chromium.org2010-02-031-0/+8
| | | | | | | | | | GC upon raw cookies request. TBR=yurys Review URL: http://codereview.chromium.org/564039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37985 0039d316-1c4b-4281-b951-d872f2087c98
* Socket late binding bugfix.willchan@chromium.org2010-02-032-0/+72
| | | | | | | | | I added code in r36144 so that we wouldn't create extra ConnectJobs if we were still releasing sockets. This code did not handle the case where we had multiple disconnected releasing sockets. I've added a test and code to cover this case now. BUG=34123 Review URL: http://codereview.chromium.org/557089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37984 0039d316-1c4b-4281-b951-d872f2087c98
* Disable DCHECK'ing that all NetworkChangeNotifiers are removed.willchan@chromium.org2010-02-031-1/+4
| | | | | | | | BUG=34391 Review URL: http://codereview.chromium.org/560026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37982 0039d316-1c4b-4281-b951-d872f2087c98
* Remove cf: protocolamit@chromium.org2010-02-0314-59/+249
| | | | | | | | | | | | | | | | | | | | Well, almost. cf: is now changed to gcf: protocol. gcf: protocol now is supported only for the following cases: 1. gcf:attach_external_tabXXX urls. These are URLs used internally by Chrome Frame to implement window.open 2. gcf:about:xxx 3. gcf:view-source:xxx 4 For any other URLs ONLY if it is enabled by setting a registry value 'EnableGCFProtocol' to 1 in HKCU\Software\Google\ChromeFrame BUG=22721,23006,23175,29350 TEST=changed existing cf: tests to new gcf: tests, added a new test for cf:view-source Review URL: http://codereview.chromium.org/562008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37981 0039d316-1c4b-4281-b951-d872f2087c98
* Move bookmark managerarv@chromium.org2010-02-0335-0/+0
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/560023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37980 0039d316-1c4b-4281-b951-d872f2087c98
* a little code cleanup for translate infobarskuan@chromium.org2010-02-033-7/+17
| | | | | | | | | | | - use index of selected language menu item (which corresponds to index in array of languages) to check if selection has changed; was retrieving, converting and comparing text, which is more expensive and slower - only call backend to translate when source and target languages are different BUG=31297 TEST=verify that selection of languages in translate infobars still work as expected. Review URL: http://codereview.chromium.org/563018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37979 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-20 17:04:36 +0000