| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
The bug was that the handle was getting reused, so the ConnectingSocket doesn't know that it got canceled. It just keeps chugging away.
I added a map to keep track of the ConnectingSockets so they can be canceled if we detect a reuse.
TBR=wtc
Review URL: http://codereview.chromium.org/118219
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17606 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also implement DNS congestion avoidance in the pre-fetch system.
BUG=13276
r=mbelshe
Review URL: http://codereview.chromium.org/118149
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17605 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=willchan
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/119147
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17603 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=ukai
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17602 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=no compile or layout test failures.
There is a change (http://trac.webkit.org/changeset/44401) here which will likely break quite a few Linux layout tests. The plan is to run the build, then add all the tests with REBASELINE keyword into test_expectations.txt for automated rebaselining.
Review URL: http://codereview.chromium.org/118215
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17601 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change pulls in the new googleurl, which contains the ability to parse
partial IPv6 literals.
Add a test for chromium's SegmentURL, to verify that it's working.
BUG=none
TEST=Ran "unit_tests" in Debug and Release mode.
Patch by pmarks@google.com
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17598 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/119145
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17597 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
and downsample.
Review URL: http://codereview.chromium.org/118207
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17596 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the shelf.
BUG=9025
TEST=Download file in one tab, open new tab, and check that download shelf is
still open. Also try the shelf's close button and the "show all downloads"
link. When saving a file, the download animation should not show up.
Review URL: http://codereview.chromium.org/115740
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17595 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
browser/browser_theme_provider_unittest.cc
Review URL: http://codereview.chromium.org/119144
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17593 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
See http://codereview.chromium.org/115910
BUG=12768
TEST=none
Review URL: http://codereview.chromium.org/115911
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17592 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This reverts commit d3d93c94d040db33599b798723ac1fef560b653a.
It broke document-location-click-timeout.html again =/
Review URL: http://codereview.chromium.org/119143
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17591 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
was, however).
BUG=12891
Review URL: http://codereview.chromium.org/118106
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17590 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fixed a bug where we were double compensating for active_socket_count in CancelRequest and OnIOComplete.
Added ClientSocketPoolTest_TwoRequestsCancelOne to catch this. Triggered a DCHECK in debug mode before I removed the extra code in OnIOComplete.
BUG=http://www.crbug.com/13289
Review URL: http://codereview.chromium.org/118172
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17588 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Theme our bookmark bar buttons.
BUG=12467
TEST=Apply a theme and verify that bookmark bar text colors changes.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17587 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=12762
TEST=Verify that buttons can be themed.
Review URL: http://codereview.chromium.org/119025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17586 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/112093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17583 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
failure (fails with the same diff on my PC)
* Added comment about the valid values for the min, mag and mip filters in sampler.idl
* Cleaned up some typos in texture.idl
* Changed the texture-set-test to use POINT filter for min and mag to avoid issues with h/w that doesn't support linear filtering of floating point textures
* Bumped up rev for o3d_assets to include new reference image for texture-set-test
Review URL: http://codereview.chromium.org/118212
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17582 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
This reverts commit r17573, on beng's request.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Committers will use custom_deps.
Review URL: http://codereview.chromium.org/118213
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17580 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
o3d.code.google.com repositories.
Review URL: http://codereview.chromium.org/118210
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17579 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17577 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
A change which needs some WebKit patches that haven't been merged yet
slipped into my last patch.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17576 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://code.google.com/p/chromium/wiki/LinuxSandboxIPC
Without filesystem access from the renderers, we need another way of
dealing with fontconfig and font loading.
This add support for:
* An "SBX_D" environment variable in the renderers which is used to
signal the end of dynamic linking so that the chroot can be
enforced.
* A sandbox_host process, running outside the sandbox, to deal with
fontconfig requests from the renderers. See the wiki page for
the reasoning behind making it a separate process.
* A new, custom SkFontHost for Skia. Because this is Chrome
specific, it will live outside the upstream Skia tree. This
FontHost can be configured either to drive fontconfig directly
(for the browser process and for any unsandboxed renderers) or to
use an IPC system. Since the same SkFontHost has to be linked into
both the browser and renderer (they are the same binary), this
switch has to be made at run time.
Sandbox IPC calls are rare (a couple of dozen at page load time) and
add about 50us of overhead for each call.
http://codereview.chromium.org/112074
BUG=8081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17575 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/118202
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17574 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
actually creating the window it lives in. Make sure the table is only allocated and initialized when it's inserted into a view hierarchy to avoid leaking the columns.
BUG=none
TEST=purify unit test bot
Review URL: http://codereview.chromium.org/118199
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
statement for when response is non-200.
The cache is disabled to avoid problems when switching networks (wouldn't want to re-use cached response from old network after switching to new network).
This is only a partial piece for 12293 (still needs to re-trigger auto-detect on network change).
BUG=12293
Review URL: http://codereview.chromium.org/118032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17572 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/114061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17571 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the handler set up by a potentially new tab.
BUG=none
TEST=Open a new browser window with two tabs. Open a second browser window. Drag a tag in and out of the tabstrip in the second browser window.
Review URL: http://codereview.chromium.org/119124
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17567 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Slower, but better.
1.0.154.59 to 1.0.154.65
Old: 1m19s, 354,997 bytes
New: 4m01s, 279,798 bytes
Timings on Lenovo T61 (T7700 cpu)
BUG=none
TEST=none (existing tests)
Review URL: http://codereview.chromium.org/118031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17566 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/13273
TEST=open page info window for secure sites, see separators are correctly 2px tall.
Review URL: http://codereview.chromium.org/118197
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A change in Breakpad upstream caused the custom key/value pairs we specified to no longer be sent to crash server (e.g. process type).
This change pulls in an upstream fix and causes our code to use new APIs to specify this information.
BUG=13131
TEST=Crash breakpad, look at crash dump on crash server, make sure pytpe field is present.
Review URL: http://codereview.chromium.org/119121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17563 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
were no longer available.I introduced this regression when moving |result_| to the AutocompleteController; the specific problem was the "result_.CopyFrom(latest_result_);" line I added when handling the synchronous messages being available. This was done so the popup could get at the new results to update the edit with them.Instead, go back to the old method (of not updating the results until the first coalesced update came in), and pass the appropriate result set as a Details<> in the notification, so the popup can get at it without having to know how the controller works under-the-hood.BUG=11742
Review URL: http://codereview.chromium.org/119116
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17562 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
of FileStream.
BUG=8942
Review URL: http://codereview.chromium.org/112090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
getting the mechanics of the shelf handle and the dragging correct. Part 2 will actually allow the order to be changed.TEST=hover over an extension toolstrip, grab the handle and drag. release.
Review URL: http://codereview.chromium.org/119103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17559 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
KDE. Don't let Gnome use default KDE icons themes and vice versa.
BUG=13001
TEST=Download some files, make sure file icons in the download manager match / closely resemble those in Nautalus / Konqueror.
Review URL: http://codereview.chromium.org/119113
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17558 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=11745
TEST=Passwords from Keychain should be filled once the username field is filled and blurred.
Review URL: http://codereview.chromium.org/119118
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17557 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/119119
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17556 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
deleted/cancelled, the delegate should never be called again.
(The text added to URLRequest::Cancel() was copied from URLRequest::~URLRequest()).
The comment change in resource_dispatcher_host.cc is an unrelated name fix.
TEST=0
BUG=0
Review URL: http://codereview.chromium.org/118151
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17555 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/119050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17553 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
additional height to accommodate the buttons (in XP classic mode). Some (like .te) needed additional width to accommodate the combobox.
BUG=11487
TEST=Open Clear Browsing Data dialog in all languages and make sure no control is being truncated/squished against another control.
Review URL: http://codereview.chromium.org/118191
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17551 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/118185
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17550 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
AutomationProxy.
Move out TabProxyDelegate filter.
Review URL: http://codereview.chromium.org/119098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17549 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
TBR=ben
Review URL: http://codereview.chromium.org/118184
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17548 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Fixed the leak.
Review URL: http://codereview.chromium.org/118190
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17547 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
script context is empty.
R=mbelshe
BUG=13266
TEST=gmail shouldn't crash anymore.
Review URL: http://codereview.chromium.org/119109
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17546 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
only.
Enables the PasswordStore refactoring yet again (third time's the charm?).
BUG=12479
TEST=Password save/autofill should continue to work on Windows.
Review URL: http://codereview.chromium.org/118131
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17545 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
regressions (pressing ESC would close the dialog instead of closing an opened combo-box, pressing enter on a dialog with a focused link would not open the link).Looking at fixing these I realized the method View::OvverideAccelerator was not needed anymore as View::SkipDefaultKeyEventProcessing supersedes it.So I removed View::OvverideAccelerator. As a result I also ended up moving some Windows specific code from LocationbarView to AutocompleteEditViewWin.BUG=6900TEST=Open the option dialog, click on a combo-box to open the drop-down list. Press ESC, the drop-down list should be closed. Move the focus to a link (by pressing Tab). Press Enter, the link should be opened and the option dialog should not be closed. Make sure that accelerators (ESC, tab, key up/down...) still work ok in the omnibox)
Review URL: http://codereview.chromium.org/119016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17544 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Open a browser window with two tabs. Drag one of those tabs in and out of the window's tabstrip many times. Open a new window and drag a tab into that window's tabstrip.
Review URL: http://codereview.chromium.org/118142
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17542 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
linux, <sys/types.h> happened to be define before this anyway, but on other POSIX systems this is not the case.
Review URL: http://codereview.chromium.org/119110
Patch from Peter Valchev <pvalchev@google.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17541 0039d316-1c4b-4281-b951-d872f2087c98
|