| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/73016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13665 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Add these resources to theme_resources.grd.
Review URL: http://codereview.chromium.org/73030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
bugs and not marked as WONTFIX.
The bugs have already been created, this just updates the expectations file.
R=ojan
Review URL: http://codereview.chromium.org/73026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13663 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/62151
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13662 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Create a separate controller for the bar. Hide bar when it's not supposed to be
visible instead of just allowing it to be covered by content (it's not always
covered, which leads to drawing errors).
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13661 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes Vista ui_test debug failures.
Patch by Paul Godavari
Review: http://codereview.chromium.org/67120
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13660 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/73033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
change is to get the V8 latest builder compiling again so we can
keep track of any regressions (new files were introduced - need
to update the v8.gyp file).
Review URL: http://codereview.chromium.org/73032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 4f47758f5238f2e5b05d9de18f390bfe2aeb6980.
Revert "TBR: Fix unit tests, line endings."
This reverts commit 257fa01e20c46c68dce1c5992b75c64686cb1a66.
Review URL: http://codereview.chromium.org/67122
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/67121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13651 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Increases performance by about 10% with minimal quality loss.
Review URL: http://codereview.chromium.org/63107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Arv: can you take json_schema.js and json_schema_test.js.
Matt: you take the rest.
Review URL: http://codereview.chromium.org/66006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=yurys@chromium.org
Review URL: http://codereview.chromium.org/67118
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13648 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=yurys@chromium.org
Review URL: http://codereview.chromium.org/73027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13647 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SafeBrowsing check has completed. The problem occurs since the
SafeBrowsingResourceHandler is not deleted when its associated
URLRequest is cleaned up *and* a SafeBrowsing check is in progress.
When the check completes, the next resource handler in the chain
(the AsyncResourceHandler which caches a pointer the now deleted
ResourceMessageFilter) will crash.
This CL adds a notification for objects to know when the
ResourceMessageFilter is destroyed.
BUG=8544 (http://crbug.com)
Review URL: http://codereview.chromium.org/63036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13644 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/73003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13643 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/67092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13642 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This supports a restricted memory model, that does not require the
current section (window) of expanded data (from an SDCH decompression) to
remain memory resident (for future reference). Also added the
change to tell vcdiff that Chrome only supports the more memory
effecient mode.
r=openvcdiff
Review URL: http://codereview.chromium.org/66070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I recently updated these tests to reduce flakiness, but there
was a typo in one line of the update.
Since tasks were run serially, the total time to run N-1 tasks should
be greater than or EQUAL to the task durtaion, times N-1.
r=mark
Review URL: http://codereview.chromium.org/74003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This undoes changes from:
http://codereview.chromium.org/66045
Review URL: http://codereview.chromium.org/67114
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Prints these for the time spent in test_shell and the time
spent doing each diff comparison.
Also removes the check to compute statistics only in debug mode.
That was an overoptimization (computing the statistics takes ~100ms).
Review URL: http://codereview.chromium.org/73017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
This also does a minor fix for forward-declares of RenderViewHostFactory.
Review URL: http://codereview.chromium.org/66046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13637 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, the title of a JavaScript dialog box contains "Alert"
regardless of how it's made: whether by alert(), prompt(), or confirm().
"Alert" should be there only when the dialog box is created by alert().
Tested by: unittest, ui_tests, manually
BUG=2359
Original patch by yuzo@google.com at http://codereview.chromium.org/67099
Review URL: http://codereview.chromium.org/70002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Use this as part of the DNS testing trials.
r=wtc
Review URL: http://codereview.chromium.org/67083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13634 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none (various)
TEST=covered by layout tests
Review URL: http://codereview.chromium.org/67110
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13633 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/73008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13632 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/67086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
9798 and 9797 bugs alphanumerically.
Review URL: http://codereview.chromium.org/67090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13630 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
instead create a new one for crashing.
The old way of using notifications was incorrect since a RenderProcessHost might have sent only one notification even though a new renderer might have been created after a crash.
BUG=9379
Review URL: http://codereview.chromium.org/66069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13629 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
we need to convert between that representations.
Review URL: http://codereview.chromium.org/67104
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13627 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
/usr/local/google/chromium3/src/net/base/nss_memio.c:142: warning: 'memio_buffer_empty' defined but not used
/usr/local/google/chromium3/src/net/base/nss_memio.c:148: warning: 'memio_buffer_full' defined but not used
Review URL: http://codereview.chromium.org/67098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Put LayoutTests/compositing/overflow/overflow-positioning.html back in for
Linux, removed accidentally.
File a new bug for non-shadow-related merge 43264:42403 regressions and move
those three tests into it.
BUG=none (various)
TEST=covered by layout tests
Review URL: http://codereview.chromium.org/67103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/73014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
parent_window argument
to the Reposition function in tab_proxy
Review URL: http://codereview.chromium.org/73019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13623 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The problem is sometimes the functions to remove event listeners get called
outside of a ContextScope (even though we still have a valid context).
BUG=9775
Review URL: http://codereview.chromium.org/66045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13622 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
that now pass after http://codereview.chromium.org/59006 .
This CL should be the last change needed to fix http://code.google.com/p/chromium/issues/detail?id=9581
Review URL: http://codereview.chromium.org/73011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13621 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
We compiled before, but we'd crash with missing symbols when test_shell tried to load it. I also ported some bits of code, and added comments to the other bits that need porting.
Review URL: http://codereview.chromium.org/73015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13620 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/67093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=9381
Review URL: http://codereview.chromium.org/67064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13618 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/66015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13617 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There was an error in InitXMLReader where it tries to delete the bufffer_
member,
setting it to null will make it work as mulhern stated.
\src\chrome\Debug>automated_ui_tests.exe
Started crash_service.exe so you know if a test crashes!
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from AutomatedUITest
[ RUN ] AutomatedUITest.TheOneAndOnlyTest
.\automated_ui_tests.cc(167): error: Value of: InitXMLReader()
Actual: false
Expected: true
Error initializing XMLReader
Then it crashes.
TEST=Ran the test again, doesn't crash.
BUG=9625 http://crbug.com/9625
Patch by Mohamed Mansour <m0.interactive@gmail.com> in
http://codereview.chromium.org/63001
Review URL: http://codereview.chromium.org/67094
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13616 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the code path to do static value initializations for worker process.
Review URL: http://codereview.chromium.org/66063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13615 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none (various)
TEST=covered by layout tests
Review URL: http://codereview.chromium.org/69002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13614 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the same thing in another tab. Therefore, if you haven't searched for anything within that tab then Chrome should prepopulate the Find box with the last string you searched for (in any tab).
BUG=876
TEST=Open google.com, Ctrl+F, search for 'e'. Open a new tab/new window/open a link in a new window. In all of those new tabs the Find box should be prepopulated with 'e' that is selected (for easy overwriting).
Review URL: http://codereview.chromium.org/67066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13613 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
passing stuff to use json.
Also made sure to lowercase extension IDs when looking them up in
ExtensionMessageService.
Review URL: http://codereview.chromium.org/67054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13612 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The URL of removed thumbnails is added to a blacklist, which is a user pref.
I had to modify the VisitSegmentDatabase::QuerySegmentUsage not to return a
fixed number of items, as now we may filter the ones we get back.
Note: this adds between 20 and 30ms to the first NTP load on my machine (a
3 to 5% increase).
BUG=685
TEST=Open the NTP. Click the 'Edit thumbnails' link. Remove some thumbnails.
Press Done. Edit again, use the "Restore removed" link.
Review URL: http://codereview.chromium.org/67037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
r13555
Log:
Remove the Activex shim registration for generic Activex controls. The Activex shim only handles windows media
player in the wild and will continue to do so for the forseeable future.
This fixes http://code.google.com/p/chromium/issues/detail?id=8584, which is basically related to our NPAPI plugin
installer not getting instantiated on pages which instantiated flash using an object tag, which would result in
webkit attempting to instantiate the activex shim. The shim only loads the windows media player classid, thus causing
this issue.
Added a test shell test which tests whether the default plugin loaded correctly. This is done by attempting to instantiate
a special mime type application/chromium-test-default-plugin, which serves as an indicator to the default plugin to
call a function in the page indicating that the test succeeded. I also made a change to ensure that the default plugin
is loaded in test_shell_tests.
Removed the activexshim dll project from chrome.sln
Bug=8584
New Revision: 13558
Log:
Removing the Activex shim plugin from the list of default plugins caused some activex shim tests to fail. This basically
fails for pages which instantiate the media player like an activex only. To handle this case we attempt to map the clsid
to a NPAPI mime type if possible in the shim. If we succeed then the shim is instantiated as an NPAPI plugin as before.
It internally loads the media player activex.
The other changes are to ensure that the default plugin is only enabled in test_shell for windows for now.
Bug=8584
Review URL: http://codereview.chromium.org/72004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13610 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
caused menus (such as the book-mark menu) to be closed on mouse-wheel scroll.
I had put the rerouting of the mouse-wheel messages in the RenderWidgetViewWin::OnWheelEvent after the workaround for the Thinkpad mousewheel driver, which closes the popups.
In the original code, the rerouting was done in the FocusManager by way of sub-classing and was therefore happening before RenderWidgetViewWin::OnWheelEvent.
This CL reverts to the original order which fixes the bug.
BUG=9752
TEST=Have a profile with lots of bookmarks in a folder on the bookmark toolbar, click on the folder to bring up the scrollable menu. The menu should scroll when you use the mouse-wheel.
Review URL: http://codereview.chromium.org/67063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13609 0039d316-1c4b-4281-b951-d872f2087c98
|