summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fix a bug where a download isn't canceled when the user requests it.paul@chromium.org2009-08-052-7/+21
| | | | | | | | | | | | | | | This particular bug only occurs when the user is prompted via save file dialog and then chooses cancel. In this case, the file selection code path for canceling was not the same as regular cancel case, so the network requests continued. BUG=18160 TEST=When prompted to save a download, choose cancel and notice that there is no further network traffic due to that download. Review URL: http://codereview.chromium.org/160627 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22557 0039d316-1c4b-4281-b951-d872f2087c98
* Safari Bookmark/Favicon import.jeremy@chromium.org2009-08-059-89/+367
| | | | | | Review URL: http://codereview.chromium.org/159750 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22556 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: make gfx::Canvas honor GTK font settings.derat@chromium.org2009-08-051-0/+76
| | | | | | | | | BUG=18038 TESTED=restarted chrome a bunch while mucking around with gnome-appearance-settings Review URL: http://codereview.chromium.org/164017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22555 0039d316-1c4b-4281-b951-d872f2087c98
* So tired of trying to keep up with these test expectationspkasting@chromium.org2009-08-051-6/+6
| | | | | | | | | TBR=jar BUG=9798,10380,10382,10410,18027,18584 TEST=none Review URL: http://codereview.chromium.org/164026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22554 0039d316-1c4b-4281-b951-d872f2087c98
* Yet Another Flaky Mac Crashpkasting@chromium.org2009-08-051-1/+2
| | | | | | | | | TBR=jar BUG=11795 TEST=none Review URL: http://codereview.chromium.org/165020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22552 0039d316-1c4b-4281-b951-d872f2087c98
* More updates. One crash no longer seems to occur on the Mac; a Windows test ↵pkasting@chromium.org2009-08-051-2/+1
| | | | | | | | | | | is flaky in release mode too. TBR=jar BUG=17942,18027 TEST=none Review URL: http://codereview.chromium.org/164022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22551 0039d316-1c4b-4281-b951-d872f2087c98
* A couple tests seem to be flakily crashing :(pkasting@chromium.org2009-08-051-2/+2
| | | | | | | | | TBR=jar BUG=9798,10463 TEST=none Review URL: http://codereview.chromium.org/164019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22550 0039d316-1c4b-4281-b951-d872f2087c98
* This is a quick fix for include file path issue in livesynctest related file.tejasshah@google.com2009-08-051-1/+1
| | | | | | Review URL: http://codereview.chromium.org/165015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22549 0039d316-1c4b-4281-b951-d872f2087c98
* FAIL -> CRASHpkasting@chromium.org2009-08-051-1/+1
| | | | | | | | | TBR=tc BUG=18569 TEST=none Review URL: http://codereview.chromium.org/164018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22548 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some tests that seem to be passing.pkasting@chromium.org2009-08-051-7/+0
| | | | | | | | | TBR=dglazkov BUG=10475,16639,16410,16675 TEST=none Review URL: http://codereview.chromium.org/164015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22547 0039d316-1c4b-4281-b951-d872f2087c98
* Fix include path for header file to fix sync build.tim@chromium.org2009-08-051-1/+1
| | | | | | | I'll hold off committing until Idan lets me know I didn't butcher anything else, too :) Review URL: http://codereview.chromium.org/165004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22546 0039d316-1c4b-4281-b951-d872f2087c98
* Updated O3D to work with most recent Chrome base.apatrick@google.com2009-08-056-12/+41
| | | | | | | Added build.scons for Chrome IPC. Review URL: http://codereview.chromium.org/160616 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22545 0039d316-1c4b-4281-b951-d872f2087c98
* Mark overflow-scroll-delete.html as flaky on mac debug. It's been flipping ↵tc@google.com2009-08-051-0/+2
| | | | | | | | | | | back and forth for a long time. TBR=pkasting Review URL: http://codereview.chromium.org/165009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22544 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Fancy html5 draggy stuff.estade@chromium.org2009-08-053-60/+159
| | | | | | | | | | | | | | | | | | | | | Also, don't crash in release mode when the tab contents is deleted during a drag. 1) Source side: when the tab contents is going down, abort the current drag (if any). Initiate drags on a GtkInvisible (matching firefox, among other programs I assume). This lets us give up ownership of the drag widget and let the drag unwind. 2) Destination side: make a seemingly harmless GTK assert point to a crbug bug. This warrants further investigation. BUG=16249 TEST=drag around ntp thumbnails BUG=18557 In release mode, you should be able to do all the following without crashing or getting any asserts besides the two mentioned in 18557 TEST=drag something from gedit over a tab that closes TEST=drag something from the render view over a tab that closes TEST=drag something from the render view off of the browser from within a tab that closes TEST=repeat all the above with a tab that is being swapped out according to the repro steps in bug 16073 Review URL: http://codereview.chromium.org/159889 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22542 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 22517.rohitrao@chromium.org2009-08-0524-493/+438
| | | | | | Review URL: http://codereview.chromium.org/165001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22541 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that we never call into WebCore::Page static methods when Page ↵dglazkov@chromium.org2009-08-058-1/+22
| | | | | | | | | | | | | | | | constructor hasn't been called. This is a top crash for Mac right now. The crash occurs because the static table of all pages in the renderer is initialized in WebCore:: Page constructor, and if we attempt to access this table before the Page was created (i.e. before WebView::Create is called), we get into a crashy situation. I am really not sure how to reproduce this, but I can defend against the situation. BUG=17555 R=darin TEST=unable to repro, speculative fix. Review URL: http://codereview.chromium.org/159887 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22540 0039d316-1c4b-4281-b951-d872f2087c98
* Draw the theme overlay. I hadn't implemented this previously becausetc@google.com2009-08-051-7/+7
| | | | | | | | | | | | I didn't have an example theme that does this. TEST=Install the Folders theme from the theme gallery and you should see a paperclip and some paper in the theme. Review URL: http://codereview.chromium.org/165002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22539 0039d316-1c4b-4281-b951-d872f2087c98
* Add the anti-clockwise waiting throbber to app mode/popup windows.tc@google.com2009-08-055-24/+50
| | | | | | | | | BUG=18181 Review URL: http://codereview.chromium.org/160653 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22537 0039d316-1c4b-4281-b951-d872f2087c98
* Add unit tests for unpacking and patching methods.kuchhal@chromium.org2009-08-0518-189/+338
| | | | | | | | | BUG=12849 TEST=none Review URL: http://codereview.chromium.org/160623 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22535 0039d316-1c4b-4281-b951-d872f2087c98
* Fishing expedition in mac ui tests. dank@chromium.org2009-08-053-13/+124
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adds suppressions for lots of bugs. The only problems left I know of result in valgrind internal error messages. Widen suppression for 16128 to match on Mac. Remove suppression for 16210, which is a dup of 16128, and was out of date. The reference builds don't have symbols on the mac, so suppressions don't work. And they have old known valgrind issues. Disable SunSpiderReferenceTest.Perf and V8BenchmarkReferenceTest.Perf under valgrind until those problems are addressed (and possibly longer -- reference builds tend to have old valgrind errors since fixed and no longer of interest). Also, disable DownloadTest.UnknownSize under valgrind, it is known to send garbage. None of these errors are showing up on the bots for some reason; they only show up when you do a local run of shard_all_tests.sh, which does one test at a time instead of the normal batches of 30. It seems valgrind on the mac isn't stable enough to do large batches of ui tests in a single run. BUG=6522,16128,16210,17113,17451,18189,18223,18236,18252,18253,18268,18540 TEST=run tools/valgrind/shard_all_tests.sh for ui_tests on mac, verify it finds no normal valgrind warnings Review URL: http://codereview.chromium.org/159770 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22533 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing svn:ignore on several files.bradnelson@google.com2009-08-050-0/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22532 0039d316-1c4b-4281-b951-d872f2087c98
* Implement TabContentsViewMac::SizeContents(), so that the TabContentsViewjaphet@chromium.org2009-08-051-2/+5
| | | | | | | | | | | | gets sized properly on creation. BUG=619 BUG=15960 TEST=none Review URL: http://codereview.chromium.org/162016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22531 0039d316-1c4b-4281-b951-d872f2087c98
* Fix layout test controller simulation script to make it work for worker UI test.jianli@chromium.org2009-08-051-3/+15
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/160670 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22527 0039d316-1c4b-4281-b951-d872f2087c98
* Use a font size of 9pt in the tab titles. This is a bittc@google.com2009-08-051-5/+7
| | | | | | | | | | | bigger than before. This matches the font size used in Windows (the heights are the same), but on Linux, the text render a bit wider. BUG=17866 Review URL: http://codereview.chromium.org/160663 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22525 0039d316-1c4b-4281-b951-d872f2087c98
* extensions: clean up some code I saw while tracking down a bugevan@chromium.org2009-08-051-4/+3
| | | | | | | | The bug was already fixed, but this change shouldn't hurt too. Review URL: http://codereview.chromium.org/162020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22524 0039d316-1c4b-4281-b951-d872f2087c98
* linux: always show bookmarks bar on NTPevan@chromium.org2009-08-051-1/+1
| | | | | | | | BUG=16825 Review URL: http://codereview.chromium.org/159897 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22523 0039d316-1c4b-4281-b951-d872f2087c98
* Original change by Min-Yu Huang <minyu.huang@gmail.com> intc@google.com2009-08-0517-614/+900
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | http://codereview.chromium.org/160347 This is the very preliminary implementation to support printing on Linux and it has not been finished yet. For each page to be printed, we convert rendering actions on canvas into cairo APIs and generate a PS/PDF file. chrome/chrome.gyp: Include our newly added and renamed files. chrome/browser/browser.h: chrome/browser/browser.cc: Allow the user print the web page by hitting ctrl-p. chrome/browser/gtk/standard_menus.cc: Show "Print" in the menu. chrome/renderer/print_web_view_helper.cc: chrome/renderer/print_web_view_helper.h: chrome/renderer/print_web_view_helper_mac.cc chrome/renderer/print_web_view_helper_win.cc Move the class PrepareFrameAndViewForPrint to the header file and move platform dependent parts to their corresponding files. chrome/renderer/print_web_view_helper_linux.cc: Hard-coded parameters for printing. Only print the first page now. skia/ext/vector_canvas.cc: skia/ext/vector_canvas.h: skia/ext/vector_canvas_linux.cc: skia/ext/vector_canvas_win.cc: Move platform dependent parts to their corresponding files. skia/ext/vector_platform_device.h: skia/ext/vector_platform_device_linux.cc: skia/ext/vector_platform_device_linux.h We translate skia APIs into Cairo APIs here. A PDF file is also created and saved to the disk at this moment for testing purpose (you have to run chrome without the sandbox to save the file). There are still lots of bugs. skia/skia.gyp: Include our newly added files when compiling skia package on Linux. BUG=9847 Review URL: http://codereview.chromium.org/160673 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22522 0039d316-1c4b-4281-b951-d872f2087c98
* Add the sync files to chrome.gyp. They still don't result in anything ↵tim@chromium.org2009-08-0512-3/+2158
| | | | | | | | | | | | building because the files are wrapped in #ifdef CHROME_PERSONALIZATION which is not defined anywhere at the moment. Add live_sync to chrome\test and corresponding target to chrome.gyp Review URL: http://codereview.chromium.org/159902 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22521 0039d316-1c4b-4281-b951-d872f2087c98
* Update to WebKit r46807.pkasting@chromium.org2009-08-054-20/+9
| | | | | | | | BUG=none TEST=Covered by existing unittests Review URL: http://codereview.chromium.org/162018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22518 0039d316-1c4b-4281-b951-d872f2087c98
* Rewrites the Mac view resizing logic to have the BrowserWindowControllerrohitrao@chromium.org2009-08-0524-438/+493
| | | | | | | | | | | | | | | | | | | directly resize and relayout its children views. Now when a view needs to be resized, it asks its resize delegate (typically its controller's parent) to perform the resize. BUG=http://crbug.com/17619 TEST=Make sure that views are laid out correctly, even when they change size. Open and close the bookmark bar. Trigger an infobar and then close it. Trigger the download shelf and then close it. Trigger a download shelf with the infobar open, or with the bookmark bar open. Switch to and from fullscreen with various bars open. Resize the browser window with various bars open. Start the browser with and without the bookmark bar open. Try all of the above in a popup window. Review URL: http://codereview.chromium.org/159776 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22517 0039d316-1c4b-4281-b951-d872f2087c98
* Add some spacing to titlebar buttons.estade@chromium.org2009-08-053-18/+52
| | | | | | Review URL: http://codereview.chromium.org/160593 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22515 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a unit test for coverage of bug 15786.sky@chromium.org2009-08-051-1/+6
| | | | | | | | | BUG=15786 TEST=this is just a test change. Review URL: http://codereview.chromium.org/160651 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22514 0039d316-1c4b-4281-b951-d872f2087c98
* linux: rearrange widget layout in importer dialogevan@chromium.org2009-08-056-58/+66
| | | | | | | | | I'm not especially happy with how it looks now, though I think it's better than before. Review URL: http://codereview.chromium.org/160661 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22512 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up SavePage UI test, remove dead code.phajdan.jr@chromium.org2009-08-051-21/+2
| | | | | | | | | | | As most of the tests moved to the browser test, this is now unneeded. TEST=none BUG=none Review URL: http://codereview.chromium.org/160666 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22511 0039d316-1c4b-4281-b951-d872f2087c98
* Move the entire application into a dylib (framework)mark@chromium.org2009-08-056-231/+357
| | | | | | Review URL: http://codereview.chromium.org/160538 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22506 0039d316-1c4b-4281-b951-d872f2087c98
* First stab at a layout tests flakiness/speed dashboard.ojan@chromium.org2009-08-054-10/+886
| | | | | | | | | | | | | | | | | | | | | | | | This isn't functional yet, but I want to get this reviewed and in the tree so I can do the rest incrementally. This works by having the bots generate JSON that is then red into a static HTML file that generates the dashboard from the JSON. I've tried to make this generic, so we should be able to use the same HTML file for our other test types (e.g. UI tests) as well once this is functional by just having the bots that run those tests generate the JSON files and copy them to the right place. All the work that needs doing to get this 100% functional is listed as a TODO at the top of flakiness_dashboard.html. Most of what's left is buildbot integration (i.e. copy files to the right place on the bot). Review URL: http://codereview.chromium.org/149656 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22505 0039d316-1c4b-4281-b951-d872f2087c98
* Don't mutate |config_| after failing proxy-autodetect.eroman@chromium.org2009-08-053-5/+113
| | | | | | | | | | | | Otherwise when polling for configuration changes, we think the current configuration is different than the fetched one. This was a recent regression from r22485. BUG=http://crbug.com/18526 TEST=ProxyServiceTest.UpdateConfigAfterFailedAutodetect Review URL: http://codereview.chromium.org/160654 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22504 0039d316-1c4b-4281-b951-d872f2087c98
* Reapply r22418 for Linux lanpacks, with fix for Mac langpacks.mmoss@chromium.org2009-08-052-142/+223
| | | | | | | | | | | Update Mac output path to match the gyp 'outputs' list, and restrict Mac to the four previously built locales. A future change will add all the locales for Mac, probably after gyp adds looping capability (which isn't to say it couldn't be added now, but that feature is coming soon, so avoiding multiple refactors). Review URL: http://codereview.chromium.org/159886 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22502 0039d316-1c4b-4281-b951-d872f2087c98
* Removes notification observers at the end of each CustomHomePagesModel unittest.rohitrao@chromium.org2009-08-051-0/+5
| | | | | | | | | | This gets rid of some scary warnings and may also fix a flaky test. BUG=http://crbug.com/17452 TEST=None Review URL: http://codereview.chromium.org/160643 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22501 0039d316-1c4b-4281-b951-d872f2087c98
* Correctly handle multiple control responses for RETR command.phajdan.jr@chromium.org2009-08-054-25/+54
| | | | | | | | | | | | Re-enable tests which were intermittently failing before this fix and remove debugging code used to track down the issue. TEST=Covered by net_unittests. http://crbug.com/18036 Review URL: http://codereview.chromium.org/160537 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22500 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 22478.avi@chromium.org2009-08-0513-554/+14
| | | | | | | TBR=jar Review URL: http://codereview.chromium.org/160660 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22499 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit Update 46794:46804.dglazkov@google.com2009-08-051-1/+1
| | | | | | | | | | TBR=senorblanco TEST=no layout test regressions BUG=none Review URL: http://codereview.chromium.org/160655 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22498 0039d316-1c4b-4281-b951-d872f2087c98
* Copy files to preserve version history. Will be edited when Itc@google.com2009-08-052-0/+532
| | | | | | | | | land Min-Yu's changes in http://codereview.chromium.org/160347 . TBR=evan git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22494 0039d316-1c4b-4281-b951-d872f2087c98
* Add some unit tests for master preferences parsing code.kuchhal@chromium.org2009-08-058-165/+359
| | | | | | | | | BUG=12849 TEST=none Review URL: http://codereview.chromium.org/160560 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22493 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: preload ffmpeg in the zygote.agl@chromium.org2009-08-053-1/+11
| | | | | | | | | | | | | | | | | | When using the sandbox, the renderer cannot load the ffmpeg shared objects from disk. So we load them in the zygote before the sandbox is started. (Note that this doesn't get media working, but it's a start.) BUG=18329 http://codereview.chromium.org/159841 (Note: relanding. Original landing in r22392, reverted in r22405 due to check-deps failure.) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22492 0039d316-1c4b-4281-b951-d872f2087c98
* manual review: ignore for the directory tests are checked out intothomasvl@chromium.org2009-08-050-0/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22491 0039d316-1c4b-4281-b951-d872f2087c98
* On bookmark edit, the OK button is now disabled if the entered URL isjrg@chromium.org2009-08-054-16/+82
| | | | | | | | | | | | | | | | | | invalid (e.g. is the empty string). The Cancel button is never disabled. BUG=http://crbug.com/17006 TEST=Right click on a bookmark button to edit it. Make sure OK is enabled. Set URL to "" (the empty string). Make sure OK is DISabled. Set URL to "x". Make sure OK is enabled. Review URL: http://codereview.chromium.org/160628 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22490 0039d316-1c4b-4281-b951-d872f2087c98
* Allow the lastchange target to get a hard-coded default last changesgk@google.com2009-08-052-5/+16
| | | | | | | | | from build/LASTCHANGE.in if there's no actual svn or git change found. BUG=none TEST=none Review URL: http://codereview.chromium.org/159876 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22489 0039d316-1c4b-4281-b951-d872f2087c98
* Quick 'low-risk-for-the-next-release' fix to increase theme install/load ↵glen@chromium.org2009-08-051-1/+1
| | | | | | | | | | | perf (should be a 2-4x speedup). Bug should remain open until a better approach (background threads, perhaps) is used. BUG=17696 TEST=none Review URL: http://codereview.chromium.org/159903 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22487 0039d316-1c4b-4281-b951-d872f2087c98
* Add the WS_CLIPCHILDREN style to the external tab container window to ↵robertshield@chromium.org2009-08-051-1/+1
| | | | | | | | prevent massive visual flickering during resize. Review URL: http://codereview.chromium.org/160646 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22486 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-06-08 05:38:25 +0000