summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fixes leak of UserDataManager on shutdown.sky@google.com2009-01-233-4/+6
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/18714 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8581 0039d316-1c4b-4281-b951-d872f2087c98
* Adds switch to ui tests that enable dialogs in slave process. I'msky@google.com2009-01-231-3/+9
| | | | | | | | | | | adding this to make it easier to attach to a failing ui test. BUG=none TEST=none Review URL: http://codereview.chromium.org/18725 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8580 0039d316-1c4b-4281-b951-d872f2087c98
* fix bustage by disabling testsben@chromium.org2009-01-231-12/+12
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8579 0039d316-1c4b-4281-b951-d872f2087c98
* This CL makes the safe browsing interstitial page support multiple unsafe ↵jcampan@chromium.org2009-01-2313-192/+662
| | | | | | | | | | | | | | | | | | | | | | | resources in one page. We had a bug when an interstitial was showing and another unsafe resource was detected. We would show another interstitial on top of the original one, causing the DontProceed method to be invoked several times. That would cause us to remove more than once an entry from the navigation controller and cause crashers. With this new CL, if an interstitial shows and a new resource is flagged as bad, the SafeBrowsingBlockingPage will queue that notification. If the user decides to proceed through the interstitial, we'll create another interstitial warning about all the unsafe resources we have received so far. This CL also contains a fix for a crasher that would happen when closing a tab with a safe browsing interstitial. BUG=5916,6207,6306 TEST=Test all actions in the interstitial you get when opening pages with the followin scenarios: - Main page is malware - Main page is fishing - Main page is OK contains resources (images,iframes...) which are malware - Main page is OK contains resources (images,iframes...) which are phishing - Main page is OK contains resources (images,iframes...) some of them phishing, some of then malware. Note that when there are more than one bad resource, it is normal to see a 1st interstitial, then another one listing all the other bad resources. (ex of malware site http://ianfette.org, phishing site http://cvisit.tripod.com) Review URL: http://codereview.chromium.org/18346 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8578 0039d316-1c4b-4281-b951-d872f2087c98
* Prep for generated .vcproj files:sgk@google.com2009-01-2314-59/+73
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix minor stylistic inconsistencies in some .vcproj files: * /> tag termination: net\net_resources.vcproj * Add empty <ToolFiles>, <References> and <Globals> sections: net\net_resources.vcproj third_party\zlib\zlib.vcproj third_party\libpng\libpng.vcproj chrome\tools\test\image_diff\image_diff.vcproj * Remove .\ on file names where its use is inconsistent with the rest of the file names in the .vcproj: net\build\net.vcproj net\build\net_unittests.vcproj chrome\installer\util\util.vcproj * Add explicit RootNamespace attribute: chrome\test\automation\automation.vcproj testing\gtest.vcproj * Fix file order in four locales that don't match other locale .vcproj files: chrome\app\locales\da.vcproj chrome\app\locales\he.vcproj chrome\app\locales\zh-TW.vcproj chrome\app\locales\en-US.vcproj * Remove duplicate files from the list: chrome\browser\views\browser_views.vcproj (event_utils.[ch]) Review URL: http://codereview.chromium.org/18555 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8577 0039d316-1c4b-4281-b951-d872f2087c98
* Try again to commit r8486, which updates the manifestaa@chromium.org2009-01-2314-227/+449
| | | | | | | | | | | | | | | | | | | | | | | parsing in the Extension class to also parse out user script details. The problem was that extension_protocols.cc appears to link OK if you don't refer to anything in it, but as soon as you try to use something defined in it, a bunch of other symbols it refers to turn up undefined. To avoid this problem in the future, I stopped compiling extensions_protocol.cc so that we would realize if we tried to use it. Also in this change, I absolutified paths in ExtensionsService before creating Extension instances. On Linux, the path that PathService was giving us was not absolute. Review URL: http://codereview.chromium.org/18704 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8576 0039d316-1c4b-4281-b951-d872f2087c98
* Update test list to remove tests that are passing now and rebaseline one test.kuchhal@chromium.org2009-01-234-46/+47
| | | | | | | | | BUG=945322 Review URL: http://codereview.chromium.org/18721 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8575 0039d316-1c4b-4281-b951-d872f2087c98
* Keystone auto-update support for TestShellmark@chromium.org2009-01-235-5/+201
| | | | | | Review URL: http://codereview.chromium.org/18521 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8574 0039d316-1c4b-4281-b951-d872f2087c98
* Importing pkg-dmg for all of your dmg packaging needs.mark@chromium.org2009-01-232-0/+1525
| | | | | | | Review URL: http://codereview.chromium.org/18521 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8573 0039d316-1c4b-4281-b951-d872f2087c98
* Don't expose the go and star button views directly through the BrowserWindow ↵ben@chromium.org2009-01-2313-114/+102
| | | | | | | | interface (for porting). Review URL: http://codereview.chromium.org/18540 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8572 0039d316-1c4b-4281-b951-d872f2087c98
* ui refresh from cole. make it look chromey and get the basic framework for ↵pinkerton@google.com2009-01-2321-446/+8067
| | | | | | | | the views we'll need. Review URL: http://codereview.chromium.org/18720 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8571 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r8560 due to broken interactive_ui_testsmark@chromium.org2009-01-2311-70/+56
| | | | | | Review URL: http://codereview.chromium.org/18722 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8570 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug when saving web pages that have a period in their title.paulg@google.com2009-01-234-5/+19
| | | | | | | | | | | | | | | | | | | | | | The save dialog code attempts to generate a file extension based on the suggested name provided to it, which in the case of saving a web page is the title. If that title contains a '.' character, it treats anything that follows as the file extension and appends it to the name the user selects. For example, saving a page with the title "Google Inc. - A search engine" and the user choosing the save name as "Google" will result in the saved file being named "Google. - A search engine.htm" when it should be "Google.htm". In the case of saving a web page, we can ignore trying to figure out the file extension since we already know it will be ".htm". BUG=6105 (http://crbug.com/6105) Review URL: http://codereview.chromium.org/18699 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8569 0039d316-1c4b-4281-b951-d872f2087c98
* Project changes (automatic reordering by UUID).avi@chromium.org2009-01-231-4/+4
| | | | | | Review URL: http://codereview.chromium.org/18629 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8568 0039d316-1c4b-4281-b951-d872f2087c98
* Set the svn eol-style to LF for merge scripts.tc@google.com2009-01-231-109/+109
| | | | | | | TBR=pamg Review URL: http://codereview.chromium.org/18557 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8567 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 8565.brettw@chromium.org2009-01-232-59/+32
| | | | | | Review URL: http://codereview.chromium.org/18718 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8566 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of unnecessary region code from spellcheck language/locale codessidchat@google.com2009-01-232-32/+59
| | | | | | | Issue=6329 Review URL: http://codereview.chromium.org/18694 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8565 0039d316-1c4b-4281-b951-d872f2087c98
* Move security style into the tab_contents directory. This is the last part ofbrettw@chromium.org2009-01-236-18/+11
| | | | | | | the "Tab Contents (old)" group! Review URL: http://codereview.chromium.org/18686 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8564 0039d316-1c4b-4281-b951-d872f2087c98
* Adds missing include in scoped_ole_initializer. Without this includesky@google.com2009-01-231-0/+2
| | | | | | | | | | | someone can't just include scoped_ole_initializer and have it work. BUG=none TEST=none Review URL: http://codereview.chromium.org/18536 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8563 0039d316-1c4b-4281-b951-d872f2087c98
* Adds call to unload plugins on shutdown.sky@google.com2009-01-231-1/+7
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/18715 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8562 0039d316-1c4b-4281-b951-d872f2087c98
* Add a PNGEncoder helper function that takes an SkBitmap,nick@chromium.org2009-01-237-29/+28
| | | | | | | | | | | | which is how PNGEncode is used almost everywhere. This should be strictly no functional change, except for the ImageFilterPeer::DataReady case, where we now take an SkAutoLockPixels where previously we did not. Review URL: http://codereview.chromium.org/18347 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8561 0039d316-1c4b-4281-b951-d872f2087c98
* Porting in chrome/phajdan.jr@chromium.org2009-01-2311-56/+70
| | | | | | Review URL: http://codereview.chromium.org/18446 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8560 0039d316-1c4b-4281-b951-d872f2087c98
* When the server says "nosniff" but then doesn't give us a Content-Type we ↵abarth@chromium.org2009-01-231-1/+10
| | | | | | | | | | now treat the response as "text/plain". Before, we treated the response as a download. This behavior is (a) safer and (b) matches what we expect in IE8. R=darin Review URL: http://codereview.chromium.org/18549 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8559 0039d316-1c4b-4281-b951-d872f2087c98
* Ignore googlemac.maruel@chromium.org2009-01-230-0/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8558 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes leak of shutdown event in BrowserProcess.sky@google.com2009-01-232-4/+6
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/18534 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8555 0039d316-1c4b-4281-b951-d872f2087c98
* Decrements FieldTrialList::constructor_count_ in the destructor. I'msky@google.com2009-01-233-10/+1
| | | | | | | | | | | | | going to run ui tests in process and call BrowserMain multiple times. That means FieldTrialList's constructor is run multiple times. Without this decrement, the constructor isn't happy. BUG=none TEST=none Review URL: http://codereview.chromium.org/18535 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8554 0039d316-1c4b-4281-b951-d872f2087c98
* More Mac test updatesthomasvl@chromium.org2009-01-231-15/+12
| | | | | | | | - mark a few flaky tests. - update for more things passing (webkit fixes) Review URL: http://codereview.chromium.org/18713 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8553 0039d316-1c4b-4281-b951-d872f2087c98
* Set svn:eol-style native on media_player.vcproj,sgk@google.com2009-01-230-0/+0
| | | | | | | so it matches the other *.vcproj files. Review URL: http://codereview.chromium.org/18553 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8552 0039d316-1c4b-4281-b951-d872f2087c98
* Support domain=IPADDR if it matches the url ip address exactly.deanm@chromium.org2009-01-232-2/+12
| | | | | | | | | | | This doesn't do anything special to handle ipv6, dotless ip address, etc. BUG=3699 Review URL: http://codereview.chromium.org/18657 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8551 0039d316-1c4b-4281-b951-d872f2087c98
* A quick fix for "Issue 6252: Regression: IME candidate window showing far ↵hbono@chromium.org2009-01-231-5/+2
| | | | | | | | | | | | away from the input box". This issue is caused by a recent WebKit merge that changes the behavior of the ScrollView::contentsToWindow() function. To fix this issue, this change uses the SelectionController::absoluteCaretBounds() function instead of calling the ScrollView::contentsToWindow() function. BUG=6252 Review URL: http://codereview.chromium.org/17638 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8550 0039d316-1c4b-4281-b951-d872f2087c98
* Update test list again as these tests sometimes fails and sometimes timeout.kuchhal@chromium.org2009-01-231-7/+9
| | | | | | Review URL: http://codereview.chromium.org/18547 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8549 0039d316-1c4b-4281-b951-d872f2087c98
* Backs out 8523 in hopes of a greener tree.sky@google.com2009-01-238-300/+26
| | | | | | | | | | BUG=none TEST=none TBR=brg Review URL: http://codereview.chromium.org/18548 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8548 0039d316-1c4b-4281-b951-d872f2087c98
* Relands 8521, it isn't the culprit. Sorry John.sky@google.com2009-01-233-14/+1
| | | | | | | | | BUG=none TEST=none TBR=jam Review URL: http://codereview.chromium.org/18706 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8547 0039d316-1c4b-4281-b951-d872f2087c98
* Backs out r8521 in hopes of greener trees.sky@google.com2009-01-233-1/+14
| | | | | | | | | BUG=none TEST=none TBR=jam Review URL: http://codereview.chromium.org/18545 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8546 0039d316-1c4b-4281-b951-d872f2087c98
* 159.0mal@chromium.org2009-01-231-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8545 0039d316-1c4b-4281-b951-d872f2087c98
* BUG=1007hclam@chromium.org2009-01-237-6/+381
| | | | | | | | | Added a dialog for removing exceptions of password manager Added the PasswordManagerExceptionsView class for removing exception of password manager added by "Never for this site" button. Also added a button in "Minor Tweaks" tab for openning the dialog. Review URL: http://codereview.chromium.org/18494 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8544 0039d316-1c4b-4281-b951-d872f2087c98
* Change histogram for eviction to get details of long tailjar@google.com2009-01-231-1/+1
| | | | | | | r=petersont Review URL: http://codereview.chromium.org/18705 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8543 0039d316-1c4b-4281-b951-d872f2087c98
* Update test list.kuchhal@chromium.org2009-01-231-13/+26
| | | | | | Review URL: http://codereview.chromium.org/18703 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8542 0039d316-1c4b-4281-b951-d872f2087c98
* POSIX: get bits of renderer_glue compilingagl@chromium.org2009-01-233-22/+36
| | | | | | | Review URL: http://codereview.chromium.org/16817 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8541 0039d316-1c4b-4281-b951-d872f2087c98
* Roll deps to pick up regression fix.tc@google.com2009-01-232-4/+1
| | | | | | | TBR=ojan Review URL: http://codereview.chromium.org/18543 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8540 0039d316-1c4b-4281-b951-d872f2087c98
* Update the diff3 wrapper to use the checked intc@google.com2009-01-232-3/+3
| | | | | | | | | python and use windows paths rather than cygwin paths because the checked in python doesn't know about cygwin paths. Review URL: http://codereview.chromium.org/18680 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8539 0039d316-1c4b-4281-b951-d872f2087c98
* fix list- these lines were lost in r8532:tc@google.com2009-01-231-0/+6
| | | | | | | | | | | http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/test_lists/tests_fixable.txt?r1=8532&r2=8531&pathrev=8532 TBR=kuchhal Review URL: http://codereview.chromium.org/18542 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8537 0039d316-1c4b-4281-b951-d872f2087c98
* Fix strings in url_fixer_upper.estade@chromium.org2009-01-238-229/+305
| | | | | | | | | | * change URLs from wstring to string * change filenames from wstring to FilePath * url_fixer_upper{_unittest}.cc building on posix Review URL: http://codereview.chromium.org/18525 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8536 0039d316-1c4b-4281-b951-d872f2087c98
* Linux plugin loader loads and unloads .so files.evan@chromium.org2009-01-231-5/+45
| | | | | | | Review URL: http://codereview.chromium.org/18539 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8535 0039d316-1c4b-4281-b951-d872f2087c98
* fix test list.kuchhal@chromium.org2009-01-231-1/+0
| | | | | | Review URL: http://codereview.chromium.org/18698 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8534 0039d316-1c4b-4281-b951-d872f2087c98
* fix test list.kuchhal@chromium.org2009-01-231-9/+2
| | | | | | Review URL: http://codereview.chromium.org/18697 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8533 0039d316-1c4b-4281-b951-d872f2087c98
* Dump text/image on notifyDone.kuchhal@chromium.org2009-01-2317-233/+224
| | | | | | Review URL: http://codereview.chromium.org/18440 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8532 0039d316-1c4b-4281-b951-d872f2087c98
* Handle race between deleting a low use referrer acruing valuejar@chromium.org2009-01-232-14/+21
| | | | | | | | | | | | | | | | | | Prevent a DCHECK from firing. As we adaptively learn about referrers to enhance DNS pre-resolution, we are forced to evict some entries to prevent accidentally getting really large lists (when we make mistakes). Sometimes we evict a referred item from a list *while* that item is being resolved (because it was in teh list). In that case, we have to be careful when we try to acrue credit (latency savings). r=paulg Review URL: http://codereview.chromium.org/18527 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8531 0039d316-1c4b-4281-b951-d872f2087c98
* Do the SCons hackery necessary to get the test plugin in the right directory.evan@chromium.org2009-01-233-8/+21
| | | | | | | Review URL: http://codereview.chromium.org/18696 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8530 0039d316-1c4b-4281-b951-d872f2087c98
* update tests_fixable with regression from the mergetc@google.com2009-01-231-0/+3
| | | | | | | Review URL: http://codereview.chromium.org/18532 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8528 0039d316-1c4b-4281-b951-d872f2087c98