| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
Nor do we have support for alternate file formats; nor do we have a default icon.
BUG=http://crbug.com/8631
Review URL: http://codereview.chromium.org/113571
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=Scripting in the browser. This should be pretty well covered by other testing.
BUG=http://crbug.com/12063
Review URL: http://codereview.chromium.org/115542
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/11387
Review URL: http://codereview.chromium.org/112038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16442 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moved detection from -controlTextDidEndEditing: to
-control:textShouldEditEditing: in case any of the code depends on
still having focus when this happens.
http://crbug.com/12252
TEST=Type "word" in omnibox. Click on page. Popup should dissappear.
Review URL: http://codereview.chromium.org/116006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16441 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16440 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=mirandac
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16439 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/115265
Original text:
"""
This addresses 3 of the 4 issues described in Issue 9223:
1) Creates a new streamlined bubble with less text.
2) Incorporates a close [x].
3) Driven by configuration option in master_preferences file; this alternate
bubble will be used only if "oem_bubble": true is set.
Requested longer linger time feature will involve mucking with the focus
manager; this change will be uploaded separately.
BUG=9223
TEST=Add "oem_bubble": true to master_preferences file. Run chrome with
--first-run option. Alternate, smaller OEM bubble should appear over the Chrome
browser in the place of the standard first-run bubble.
"""
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16438 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
rendering of the close button to TabRendererGtk (where it belongs).
Review URL: http://codereview.chromium.org/115543
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Go eventually calls LocationBarViewMac::AcceptInputWithDisposition(),
which was NOTIMPLEMENTED(). Implement.
http://crbug.com/12253
TEST=Type some text into omnibox. Click the Go button rather than hitting enter.
Review URL: http://codereview.chromium.org/113595
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16436 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
r=wtc
Review URL: http://codereview.chromium.org/113535
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115544
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The TabContentsContainerGtk now uses a GtkFixed to store its
children, and the status bubble is now a child of that GtkFixed
so that it can be absolutely positioned on top of the rendered
data. Since it is no longer a GTK_WINDOW_POPUP, all the weird
stuff related to different window managers goes away.
http://crbug.com/11635
Review URL: http://codereview.chromium.org/113590
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/112040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16432 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
and GetWidget to match windows.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/113603
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16431 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/12059
Review URL: http://codereview.chromium.org/113601
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16430 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/113600
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=11696
TEST=Verify that the grey line between toolbar and content exists in restored and maximized mode and *not* on the new tab page, and when an infobar (e.g. default browser infobar) is present.
Review URL: http://codereview.chromium.org/113556
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) Take advantage of new String::createUninitialized() call in webkit.
This allows us to have one malloc node per string, without an
extra copy of the characters
2) Take advantage of new V8 behavior, to return NULL from
GetExternalStringResource() if it hasn't been externalized,
speeding up our usage by not requiring us to call isExternal
3) Check if string type is an integer. If it is, don't call into V8 to
get string...instead do it in C++, caching previous integer strings less
than 100.
Also removed unnecessary test for IsEmpty() as the called function also
tests for it.
Review URL: http://codereview.chromium.org/115517
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
it needs) compile on GTK.
Review URL: http://codereview.chromium.org/113589
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16426 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=12060
TEST=Enable this extension, browse to a page with a Feed and an RSS icon should show up in the Omnibox. Clicking it brings you to a subscribe page. No feed preview is displayed.
Review URL: http://codereview.chromium.org/115536
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=12262
Review URL: http://codereview.chromium.org/113599
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16424 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115541
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16423 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Landing a patch written by myself, which is originally reviewed at <http://codereview.chromium.org/113489>.
BUG=7633
Review URL: http://codereview.chromium.org/115524
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16422 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Split into three categories. The third category is for real bugs.
(This makes periodic sweeps to find unused bug suppressions a bit easier.)
Review URL: http://codereview.chromium.org/113596
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16421 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=11507
Review URL: http://codereview.chromium.org/115522
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16420 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16419 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16418 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16417 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113597
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16416 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
memory leak every time a renderer process goes away.
Review URL: http://codereview.chromium.org/115492
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16415 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the plugin. This ensures that the plugin will always be instantiated with the correct mime type at all times.
Added plugin tests to cover this case where in the embed tag is specified with a URL but without a mime type.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=8973
Bug=8973
Test :- Added a plugin test for this case.
Review URL: http://codereview.chromium.org/113326
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ProxyService::CreateWithoutV8Resolver() methods.
Instead of using a NULL ProxyResolver dependency in cases where PAC is not supported, it uses a ProxyResolverNull (always fail) implementation.
This is to avoid needing to check in other cases (when v8 is unsupported) if there is a non-null ProxyResolver.
Review URL: http://codereview.chromium.org/115532
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16413 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
recover.
Review URL: http://codereview.chromium.org/115538
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16412 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
http://codereview.chromium.org/113245 ), r=me.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16411 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Made the tab cell use a generic NSView for showing the icon instead of relying on the NSButtonCell to draw it, so a NSImageView is in place by default. Remove un-needed outlets, bindings, and views from the nib. BUG=11916. TEST=loading pages, opening and closing tabs.
Review URL: http://codereview.chromium.org/115527
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16410 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
M binaries/gears.pdb
M binaries/gears.dll
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/115528
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16407 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/12254
TBR=dglazkov
Review URL: http://codereview.chromium.org/113593
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16406 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
(Corrected the header file upstream for ScriptController.h)
TEST=none needed, build fix.
TBR=dglazkov
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115518
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=11513 (http://crbug.com/11513).
Review URL: http://codereview.chromium.org/113570
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16398 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Neither the nss or Windows GetSSLInfo methods check this
condition, which can be called in error situations.
Review URL: http://codereview.chromium.org/113559
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
ports through the automation postMessage interface.
See original review at: http://codereview.chromium.org/113461
Patch by Siggi Asgeirsson <sigurdur.asgeirsson@gmail.com>
Review URL: http://codereview.chromium.org/113538
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16396 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
app.gyp.
http://crbug.com/11387
Review URL: http://codereview.chromium.org/113588
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16395 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=11017,12056
Review URL: http://codereview.chromium.org/113587
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
omnibox text.
I used a static for the black text tag, but we need a separate instance
per omnibox (one per browser window).
BUG=11450
Review URL: http://codereview.chromium.org/115521
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16393 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
As a bonus, debugging of extensions now works. Go OOP inspector team!
Inspection code was calling RVHD::GetProfile(), which was not implemented by ExtensionHost. Looking into this, it seems better to just remove the method from the interface since Profile is already accessible by way of RVH.
The only caller to RVHD::GetProfile() besides the inspector was HWNDHtmlView which is itself dead code, so I removed it too.
Review URL: http://codereview.chromium.org/115501
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Initially just the two failed to delay-load bind exceptions
- Shows the same error dialog as the OS shows so no localization required
TEST= hard to test, but I'll give some pointers on the bug
BUG = 11919
Review URL: http://codereview.chromium.org/113492
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Leaving this on produces warnings with newer gccs.
In https://bugs.webkit.org/show_bug.cgi?id=25864, Darin Adler says, regarding
leaving strict aliasing rules on: "I would expect many, many problems in
WebCore. Not just warnings, but actual code generation problems."
BUG=9104
Review URL: http://codereview.chromium.org/115520
Patch from Craig Schlenter <craig.schlenter@gmail.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit r16383.
Session restore fails with this change.
TBR=willchan
Review URL: http://codereview.chromium.org/115519
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16387 0039d316-1c4b-4281-b951-d872f2087c98
|