summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Refactor: Address some style comments from a review (which missed the ↵eroman@chromium.org2009-10-239-24/+40
| | | | | | | | original check-in). Review URL: http://codereview.chromium.org/322009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29874 0039d316-1c4b-4281-b951-d872f2087c98
* Disable system suspend while downloading files on win32.mark@chromium.org2009-10-238-1/+146
| | | | | | | | | | | | | | | | | | | | If the system goes into power-save sleep mode while downloading files, the download fails. So, prevent sleep mode until the download finishes. This patch introduces a new RAII class to request that the system's power-save mode be disabled - PowerSaveBlocker. This is only implemented for win32; other platforms are stubbed out. This only partially implements bug 25420 it only attempts to handle the downloading case. Patch by Bryan Donlan <bdonlan@gmail.com> BUG=25420 TEST=Download a large file with the system sleep timeout set to a short interval. Review URL: http://codereview.chromium.org/287017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29873 0039d316-1c4b-4281-b951-d872f2087c98
* Remove passing attribute-listener tests from expectations.johnnyg@chromium.org2009-10-231-5/+0
| | | | | | | | | | TBR=dglazkov BUG=23740 TEST=these Review URL: http://codereview.chromium.org/326006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29872 0039d316-1c4b-4281-b951-d872f2087c98
* This test is flaky, it has failed multiple times on the Linuxfinnur@chromium.org2009-10-231-1/+1
| | | | | | | | | | | | interactive dbg bot tonight. TBR=erg BUG=25614 TEST=none Review URL: http://codereview.chromium.org/332004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29871 0039d316-1c4b-4281-b951-d872f2087c98
* Webkit roll 49957-49961. Lots of rebaselines for new -webkit-shadow ↵johnnyg@chromium.org2009-10-2341-4/+40
| | | | | | | | | | | | attribute in svg. TBR=tc BUG=none TEST=none Review URL: http://codereview.chromium.org/329003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29869 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Remove flicker when typing in the findbar.rohitrao@chromium.org2009-10-232-0/+7
| | | | | | | | BUG=http://crbug.com/25590 TEST=No flicker when typing in findbar. Review URL: http://codereview.chromium.org/333007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29868 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 29861 since this fail on the interactivefinnur@chromium.org2009-10-238-91/+18
| | | | | | | | | | | | | | | | | | | | | | | | linux dbg bot, for some weird reason... Page actions that don't specify an icon (ie. have a spelling error in the manifest, such as icon instead of icons/default_icon) caused a crash when they try to display their icon. We now check when the extension tries to enable the page action whether there are any icons to display. If not, we don't proceed and log an error to the console. TBR=nsylvain BUG=25562 TEST=Covered by browser test. Review URL: http://codereview.chromium.org/316018 TBR=finnur@chromium.org Review URL: http://codereview.chromium.org/327007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29867 0039d316-1c4b-4281-b951-d872f2087c98
* Implements tests for testing browser's overall key events handling behavior.suzhe@chromium.org2009-10-2312-147/+958
| | | | | | | | | | | | This CL implements some basic tests for testing browser's overall key events handling behavior. This CL depends on http://codereview.chromium.org/235039 and http://codereview.chromium.org/195062. Currently, only Linux and Windows are supported. The tests assume US keyboard layout is used and no IME is activated. We still need to investigate how to write tests that involving different keyboard layout and input methods. BUG=none TEST=none Review URL: http://codereview.chromium.org/268035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29866 0039d316-1c4b-4281-b951-d872f2087c98
* ValidityState-patternMismatch-001.html has become flaxy. Adding to ↵johnnyg@chromium.org2009-10-231-0/+4
| | | | | | | | | | | | test_expectations. BUG=none TEST=none TBR=tc Review URL: http://codereview.chromium.org/326005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29865 0039d316-1c4b-4281-b951-d872f2087c98
* Add unittest for WebSocket::ProcessFrameData.ukai@chromium.org2009-10-233-65/+189
| | | | | | | | | | | | | | It catches a bug fixed in r29760. Also find another bug and fixed in this change. (same bug found in WebKit code. reported as http://bugs.webkit.org/show_bug.cgi?id=30668) BUG=none TEST=net_unittests passes Review URL: http://codereview.chromium.org/307036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29864 0039d316-1c4b-4281-b951-d872f2087c98
* Make SSLClientSocketMac full-duplexukai@chromium.org2009-10-232-136/+159
| | | | | | | | | BUG=13289,12497 TEST=visit https site and works as before Review URL: http://codereview.chromium.org/266078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29863 0039d316-1c4b-4281-b951-d872f2087c98
* linux: tweak combining characters slightlyevan@chromium.org2009-10-231-1/+4
| | | | | | | | | | | | This fixes Arabic and a Cyrillic test. Behdad has promised to rewrite all of this for WebKit, but for now, this new behavior is less broken than before. BUG=22872,22367 Review URL: http://codereview.chromium.org/327006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29862 0039d316-1c4b-4281-b951-d872f2087c98
* Page actions that don't specify an icon (ie.finnur@chromium.org2009-10-238-18/+91
| | | | | | | | | | | | | | | | | have a spelling error in the manifest, such as icon instead of icons/default_icon) caused a crash when they try to display their icon. We now check when the extension tries to enable the page action whether there are any icons to display. If not, we don't proceed and log an error to the console. BUG=25562 TEST=Covered by browser test. Review URL: http://codereview.chromium.org/316018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29861 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: fix crash in PopulateCookieDetails called by OnSelectionChanged callbackmattm@chromium.org2009-10-235-0/+50
| | | | | | | | | | | which can be called while the view and model are in inconsistent states. BUG=25535 TEST=open cookies manager, select all, remove all Review URL: http://codereview.chromium.org/334001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29860 0039d316-1c4b-4281-b951-d872f2087c98
* linux: cut down on EPIPE error spewevan@chromium.org2009-10-231-1/+5
| | | | | | Review URL: http://codereview.chromium.org/315019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29859 0039d316-1c4b-4281-b951-d872f2087c98
* Webkit roll 49947-49957johnnyg@chromium.org2009-10-231-1/+1
| | | | | | | | | | TBR=tc BUG=none TEST=none Review URL: http://codereview.chromium.org/332001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29858 0039d316-1c4b-4281-b951-d872f2087c98
* Fix conflicts between accelerator keys and HTML DOM accesskeys.suzhe@chromium.org2009-10-2322-74/+553
| | | | | | | | | | | | | This CL fixes conflicts between accelerator keys and HTML DOM accesskeys by suppressing Char events if corresponding RawKeyDown event was handled by the browser after returning from the renderer unhandled. This CL not only fixes this conflict issue, but also makes the behavior of handling accelerator keys similar than IE, which also suppresses a key press event if the key down event was handled as an accelerator key. BUG=21624 accesskey attributes conflict with browser shortcuts (like tab-switching) TEST=Open http://djmitche.github.com/buildbot/docs/0.7.11/ in one of opened multiple tabs, switch to another tab by pressing an alt-# key binding, then switch back to the original page to see if it's just as you left it before switching tabs. Review URL: http://codereview.chromium.org/235039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29857 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed valgrind breakage by r29848hclam@chromium.org2009-10-231-9/+3
| | | | | | | | | | TBR=scherkus References shouldn't have been released. Review URL: http://codereview.chromium.org/333004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29856 0039d316-1c4b-4281-b951-d872f2087c98
* Trying to fix the build. gman taking over.apatrick@google.com2009-10-234-11/+12
| | | | | | Review URL: http://codereview.chromium.org/329002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29855 0039d316-1c4b-4281-b951-d872f2087c98
* The TableViewObserver::OnKeyDown method signature was changed recently andjcampan@chromium.org2009-10-236-23/+27
| | | | | | | | | | | | | | | | | the bookmark manager view had not been properly updated and was not called anymore, breaking the keyboard shortcuts. This was broken in the TaskManager as well. Also changed the TreeView to use the base::KeyboardCode. BUG=25533 TEST=Test that the different shortcuts (CTRL-X,CTRL-V, CTRL-C, DELETE, ENTER...) work in the bookmark manager. Test that in the TaskManager, pressing ENTER activates the selected tab. Review URL: http://codereview.chromium.org/322006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29854 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 29844 - Disable the Web drop target unittests because theynsylvain@chromium.org2009-10-231-5/+5
| | | | | | | | | | | | | keep crashing. BUg=25586 Review URL: http://codereview.chromium.org/330001 TBR=nsylvain@chromium.org Review URL: http://codereview.chromium.org/327004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29853 0039d316-1c4b-4281-b951-d872f2087c98
* Disable the FileUtilICU tests because they hang purifynsylvain@chromium.org2009-10-231-2/+2
| | | | | | | BUG: 25598 Review URL: http://codereview.chromium.org/334003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29852 0039d316-1c4b-4281-b951-d872f2087c98
* Use a saved copy of the time when pausing media elements.scherkus@chromium.org2009-10-232-0/+11
| | | | | | | | | | | | | | Since our internal pause is asynchronous and we don't want to hang the render thread, it's possible to have our clock creep ahead. This produces unexpected behaviour when pausing media elements, such as seeing currentTime attribute nudge a little ahead after calling pause(). This so happens to also address layout test flakiness. BUG=13907 TEST=layout tests, especially video-pause-immediately.html -- a new layout test I wrote and am upstreaming Review URL: http://codereview.chromium.org/334002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29851 0039d316-1c4b-4281-b951-d872f2087c98
* [GTK] Use gtk_window_present_with_time since the doc's says it is better to usemattm@chromium.org2009-10-231-2/+2
| | | | | | | | | | | | it when it is a response to a user action. BUG=None TEST=compiled and tested. Review URL: http://codereview.chromium.org/299001 Patch from Thiago Farina <thiago.farina@gmail.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29850 0039d316-1c4b-4281-b951-d872f2087c98
* Adding documentation for extensions options pages.asargent@chromium.org2009-10-2334-2/+599
| | | | | | | | | BUG=23801 TEST=none Review URL: http://codereview.chromium.org/314012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29849 0039d316-1c4b-4281-b951-d872f2087c98
* Allow <video> to read from a data URI. Data URI is now handledhclam@chromium.org2009-10-239-74/+159
| | | | | | | | | | | | | | by SimpleDataSource. Selection of data source is done by the existing factory method by calling to IsMediaFormatSupported. And each data source would determine if they support the mentioned scheme. BUG=24357 TEST=open a video with data:/ scheme. Review URL: http://codereview.chromium.org/284007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29848 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 29827 - Refactor securityicon code to a more general form, also more ↵nsylvain@chromium.org2009-10-2311-319/+132
| | | | | | | | | | | | | | | | consistent with the Windows implementation, in preparation for implementing page actions. BUG=14899, 22922, 12281 TEST=unit tests included Review URL: http://codereview.chromium.org/264037 TBR=pamg@google.com Review URL: http://codereview.chromium.org/333002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29847 0039d316-1c4b-4281-b951-d872f2087c98
* Disable DromaeoReferenceTest.Perf on Mac valgrind botsstuartmorgan@chromium.org2009-10-231-0/+2
| | | | | | | | | BUG=25589 TEST=Mac UI valgrind bot 2 should be happier Review URL: http://codereview.chromium.org/332002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29846 0039d316-1c4b-4281-b951-d872f2087c98
* Fix coverage on the Mac.jrg@chromium.org2009-10-233-12/+38
| | | | | | | | Add extra unit test bundles (all platforms). Review URL: http://codereview.chromium.org/307032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29845 0039d316-1c4b-4281-b951-d872f2087c98
* Disable the Web drop target unittests because theynsylvain@chromium.org2009-10-231-5/+5
| | | | | | | | | | keep crashing. BUg=25586 Review URL: http://codereview.chromium.org/330001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29844 0039d316-1c4b-4281-b951-d872f2087c98
* Use scoped_array (not scoped_ptr) with new[].kuchhal@chromium.org2009-10-2310-11/+11
| | | | | | | | | BUG=24266 TEST=No functional change so make sure nothing changes. Review URL: http://codereview.chromium.org/307045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29843 0039d316-1c4b-4281-b951-d872f2087c98
* Potential fix for the PluginChannel::CleanUp crash. This will go out on ↵jam@chromium.org2009-10-221-2/+6
| | | | | | | | | | | tomorrow's dev channel build and we can see if the crashes go away while I try to write a repro. The only scenario that I can think of is that an NPObject in the plugin process has a deallocate function which releases an npobject from the renderer. That would cause the corresponding NPObjectProxy to go away, but since PluginChannel has in_remove_route_ set, the list won't get updated and in the future iteration of the loop we'll call the method on a deleted object. BUG=25439 Review URL: http://codereview.chromium.org/327003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29839 0039d316-1c4b-4281-b951-d872f2087c98
* fixed include order issues for osx I introducedgman@google.com2009-10-222-5/+8
| | | | | | | | with last change. Review URL: http://codereview.chromium.org/327002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29838 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: in gtk theme mode, when a chrome button is showing a menu, make it look ↵estade@chromium.org2009-10-221-0/+3
| | | | | | | | | | | depressed. BUG=21053 TEST=app menu Review URL: http://codereview.chromium.org/328001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29837 0039d316-1c4b-4281-b951-d872f2087c98
* * Moved panel controller to chromeos directoryoshima@chromium.org2009-10-2217-104/+132
| | | | | | | | | | | | | | | | | * Include BrowserExtender to regular build to remove CHROMEOS ifdefs in BrowserView * moved browser_extender.h to chrome/browser/views/frame, and BrowserExtender methods to chrome/browser/views/frame/browser_extender.cc. * Added StandardExtender (standard_extender.cc), which is empty now. I'm going to add MainMenu support to win, which will be added vua StandardExtender with a command line flag. * factory method "Create" is now defined in standard_extender.cc and chromeos/chromeos_browser_extenders.cc. toolkit_views=1 uses chromeos_browser_extenders.cc and other build uses standard_extender BUG=None TEST=None Review URL: http://codereview.chromium.org/317001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29836 0039d316-1c4b-4281-b951-d872f2087c98
* Remove failing test; copying images was implemented in r29812, making this ↵avi@chromium.org2009-10-221-1/+0
| | | | | | | | | | | test start passing. BUG=http://crbug.com/10435, http://crbug.com/13099 TEST=none; tree should stay green Review URL: http://codereview.chromium.org/319007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29835 0039d316-1c4b-4281-b951-d872f2087c98
* Moved castToHTMLXXXElement and getNameForInputElement to DOMUtilitiesPrivate.yaar@chromium.org2009-10-229-92/+84
| | | | | | Review URL: http://codereview.chromium.org/304013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29834 0039d316-1c4b-4281-b951-d872f2087c98
* Set the svn:eol-style property to LF.wtc@chromium.org2009-10-220-0/+0
| | | | | | | | | R=rafaelw BUG=none TEST=none Review URL: http://codereview.chromium.org/314017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29833 0039d316-1c4b-4281-b951-d872f2087c98
* Do some cleanup of file path name handling.brettw@chromium.org2009-10-2217-151/+223
| | | | | | | | | | | | | | | | | | | | | | | | | | | This started trying to cleanup DownloadManager::GenerateFilename which asserts if your system locale isn't UTF-8 (I ran into this when mine got messed up). The solution is to have GetSuggestedFilename return a FilePath rather than calling FromWStringHack. The rest of the patch is a result of trying to write GetSuggestedFilename in a reasonable way. I changed ReplaceIllegalCharacters to work on a FilePath::StringType. Some places in the code calling these functions got cleaner, some got messier. I think overall the ones that got messier are the ones doing sketchy things with paths and the ones that got cleaner are the ones doing things more properly. The only code here that gets called a nontrivial number of times is the weburlloader, and I think the new code does about the same number of string conversions overall (though on certain platforms the number will be higher or lower). BUG=none TEST=none Review URL: http://codereview.chromium.org/271056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29832 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes to get renderer=cb cb_service=gl to compilegman@google.com2009-10-2248-881/+1168
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | again. I was working on spliting some of the command buffer code in preparation for GL command buffers so those changes are in there as well. I didn't realize the gl command buffers were broken. I'm planning on sharing some of the command buffer code and commands so I thought about making the command buffers into 2 parts. The first N (256?) commands are common commands. Noop, SetToken, Jump Gosub. Those will be handled by common code. After that come the O3D or GL command buffer commands. I'm not sure that's a good idea but there is a significant amount of code in managing tokens and parsing etc and it seems like it would be nice to share it until/if we delete the O3D command buffers. Note: You'll see that SetToken is hardcoded to 1. I plan to fix that in the next CL when I split the command into shared vs specific. Review URL: http://codereview.chromium.org/307043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29831 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for issue 18228.xiyuan@chromium.org2009-10-224-1/+11
| | | | | | | | | | | Don't record browser history for navigations for tabs in app frame. BUG=18228 TEST=Open chrome in app frame (via "-app", application shortcut or convert a page to app), navigations in app frame should not appear in history. Review URL: http://codereview.chromium.org/306052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29830 0039d316-1c4b-4281-b951-d872f2087c98
* GCC's optimizer is getting more aggressive. It is no longer goodmarkus@chromium.org2009-10-223-7/+14
| | | | | | | | | | | | | | | | | | | | enough to just pass the address of a structure as an input parameter to assembly code. The assembly code must also mark "memory" as getting clobbered, even if it only wants to read from the structure. This seems to be a result of strict aliasing and the lack of an ability for the assembly code to clearly say which pointers it dereferences. Furthermore, if the assembly code touches the stack (e.g. uses "push"), it must now mark the stack pointer as getting clobbered. Otherwise, GCC assumes that the red zone won't be clobbered, and that it is possible to use the stack pointer as an input register. BUG=none TEST=none Review URL: http://codereview.chromium.org/320008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29829 0039d316-1c4b-4281-b951-d872f2087c98
* Webkit roll 49946:49947, also wtc's change ↵johnnyg@chromium.org2009-10-222-1/+10
| | | | | | | | | | | | (http://codereview.chromium.org/315017) BUG=none TEST=none TBR=wtc Review URL: http://codereview.chromium.org/314013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29828 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor security-icon code to a more general form, also more consistent withpamg@google.com2009-10-2211-132/+319
| | | | | | | | | | | the Windows implementation, in preparation for implementing page actions. BUG=14899, 22922, 12281 TEST=unit tests included Review URL: http://codereview.chromium.org/264037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29827 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor: Don't send the quit command before killing test server for ↵eroman@chromium.org2009-10-221-2/+1
| | | | | | | | | ProxyScriptFetcherTest.NoCache. Instead we just murder the process directly. Calling HttpTestServer::SendQuit() adds unnecessary latency since we need to wait for the sever to respond. But more importantly it is adding noise to my valgrind race investigation, since SendQuit() spins up its own IO thread to issue requests on (making the test have multiple threads that handle requests). Review URL: http://codereview.chromium.org/320003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29826 0039d316-1c4b-4281-b951-d872f2087c98
* Optimize memory usage in MultipartResponseDelegate by not usingtony@chromium.org2009-10-221-3/+3
| | | | | | | | | | std::string::substr so much. TEST=Covered by existing tests. Review URL: http://codereview.chromium.org/322007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29825 0039d316-1c4b-4281-b951-d872f2087c98
* Support for chrome.browserAction.setIcon(imageData) on linux.rafaelw@chromium.org2009-10-221-18/+30
| | | | | | | | This updates BrowserActionButton so it picks up the icon from the extension->browser_action_state(). Review URL: http://codereview.chromium.org/300027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29824 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enabling worker fast tests (doing a more surgical disabling of just a ↵atwilson@chromium.org2009-10-221-7/+9
| | | | | | | | | | single test). BUG=22780 Review URL: http://codereview.chromium.org/315018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29821 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure OK is only enabled when there is text in the text field for folders ↵pinkerton@chromium.org2009-10-224-5/+73
| | | | | | | | | | and items (whitespace is ok). BUG=19558 TEST=per bug, test existing folders and new folders alike. Review URL: http://codereview.chromium.org/292046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29820 0039d316-1c4b-4281-b951-d872f2087c98
* Fix profile_sync_service_unittest.cc to build on Mac and Linuxzork@chromium.org2009-10-221-59/+60
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/307011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29819 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-12 14:20:08 +0000