| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24707 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=12316: Linux Omnibox, autocomplete on paste annoying.
BUG=13096: Support desired_tld in Linux omnibox
BUG=20166: Linux omnibox control key behavior is incorrect
TEST=Select all text in omnibox and paste something into omnibox by either ctrl-v, paste item in context menu or middle click, to see if inline autocomplete is not activated.
TEST=Input something in omnibox, eg. "goog", make sure the inline autocomplete is activated, then press ctrl key to see if the inline autocomplete is still there.
TEST=Input something in omnibox, eg. "cnn", press ctrl-Enter to see if www.cnn.com is opened.
Review URL: http://codereview.chromium.org/173462
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24705 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
dropdown (existing sort was effectively random). Patch by Pierre-Antoine LaFayette (see http://codereview.chromium.org/165455 ), r=sky,me, tweaked.
BUG=16230
TEST=In the omnibox dropdown, bookmarked URLs that have been typed more often should be ranked above those that have been typed less often.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24704 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Will it kill flakiness? I'm undisabling some tests on Linux to find out.
TEST=none
http://crbug.com/19361
Review URL: http://codereview.chromium.org/175006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24703 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also make sure they all use DISALLOW_COPY_AND_ASSIGN.
TEST=none
http://crbug.com/19874
Review URL: http://codereview.chromium.org/176004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24702 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Patch by Cole.
BUG=http://crbug.com/18573;http://crbug.com/18574;http://crbug.com/18360;http://crbug.com/18438
TEST=none
Review URL: http://codereview.chromium.org/165499
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24700 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
timeout on the mac.
TBR=wtc
BUG=20438
TEST=none
Review URL: http://codereview.chromium.org/173596
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24699 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/20027
Review URL: http://codereview.chromium.org/182004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24698 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/179010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24697 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was a silly oops. I had intended to call clearPluginContainer on each
WebPluginLoadObserver held in WebPluginContainerImpl's m_pluginLoadObservers
array when the WebPluginContainerImpl is destroyed, but I never hooked that up.
Here it is.
R=jam
BUG=10036
TEST=layout test: chrome/plugins/get-url-with-iframe-target-no-crash.html
Review URL: http://codereview.chromium.org/182003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24696 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/180012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We now scan more directories, sort file entries by mtime, use
realpath() before loading plugins (fixes a Java bug), and de-duplicate
multiple instances of the same plugin.
This matches the Mozilla plugin loading code more closely.
We also ignore xpcom-related errors while loading plugins, as that
breaks layout tests.
I encountered this while attempting to fix QuickTime (need to load
the Totem plugins) but the fix overlaps with the Java one. I believe
neither quite work yet, though.
BUG=16787,19712
TEST=about:plugins should show more plugins
Review URL: http://codereview.chromium.org/173550
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24691 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/177011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24687 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
doesn't make a hit for
a stand-alone dependent vowel sign of Indic scripts, which is OK according to a native Malayalam speaker.
Revise FindInPageControllerTest.FindCrash_Issue1341577 to run FindInPage (U+0D4C) without checking the return value because the test was devised to test the 'crash' issue.
BUG=8198
TEST=FindInPageControllerTest.FindCrash_Issue1341577 pass before and after ICU upgrade to 4.2
Review URL: http://codereview.chromium.org/174629
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24686 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also ellipsize long tooltips.
Also make the bookmark bar tooltips more like window (Title on one line, then url on the next line). I've made the title bold, although that isn't the case on windows.
Menus: Prefer popping downwards rather than upwards when there is more space down than up.
BUG=18617
BUG=20120
Review URL: http://codereview.chromium.org/175004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24685 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This was regressed by the subview layout refactoring.
BUG=14672
TEST=download several items, resize window, make sure that no download item ever overlaps the "Show all downloads" link on the right.
Review URL: http://codereview.chromium.org/173048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24683 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
other issues as well.
BUG=10398
TEST=green webkit builders
Review URL: http://codereview.chromium.org/179007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24682 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The tests used to be flaky and now looks like stable.
The current results show it is a rebaselining issue.
TBR=dglazkov
TEST=layouy test
BUG=877986
Review URL: http://codereview.chromium.org/178006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24680 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now, if a builder isn't found, it won't spew a stack trace.
Also, fixed a problem with mis-reporting PNG diff failures.
BUG=none
TEST=Run test_output_formatter.py with a bogus builder, verify error message.
Review URL: http://codereview.chromium.org/176008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24679 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=ojan
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/177010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24678 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=dglazkov
TEST=none
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24676 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This optimizes the common case of just needing to update
favicons. If the expose area consists of just favicons,
only paint the favicons (i.e., don't bother with the complex
tab edges that overlap).
This doesn't help when tabs are resizing or moving, but does
reduce CPU usage quite a bit.
BUG=15872
Review URL: http://codereview.chromium.org/179003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Solves some very nasty behavior when renderers crash in a certain situation.
BUG=20370
TEST=Follow repro steps for crash in 20366, browser process should show sad tabs rather than crash.
Review URL: http://codereview.chromium.org/173593
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24674 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
is not reproducible.
BUG=19519,20430
TEST=none
Review URL: http://codereview.chromium.org/182002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24673 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
LayoutTests/fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html. It never crashed on Windows or Mac, so this should have been limited to Linux anyway. Looking through flakyness dashboard for Linux release, it hasn't crashed in the last 100 runs. I also looked at the past 10 runs of Linux dbg. Pretty sure the crash was fixed by http://src.chromium.org/viewvc/chrome?view=rev&revision=23944.
TEST=none
BUG=18686
Review URL: http://codereview.chromium.org/176007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24672 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I just added this test, so the failure is probably not a regression.
TBR=wtc
BUG=20438
TEST=none
Review URL: http://codereview.chromium.org/177009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24670 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
2. Fix bug in detecting whether expectations applied to a test.
foo/bar = PASS FAIL
MAC : foo/bar/baz.html = TIMEOUT
On WIN/LINUX, we would incorrectly think that there were
no expectations for foo/bar/baz.html because we'd see the
results for the mac and assume there were no others.
Review URL: http://codereview.chromium.org/178004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG= none
TEST= none
Review URL: http://codereview.chromium.org/178005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24668 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This has been bugging me.
Review URL: http://codereview.chromium.org/174620
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of chrome.
This was preventing the installer from baking it in.
BUG=None
TEST=None
TBR=gspencer
Review URL: http://codereview.chromium.org/173591
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24666 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This was adding all Mac debug builds to the default build group, so we were trying to build the
work-in-progress command buffer version and failing.
Review URL: http://codereview.chromium.org/174628
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24665 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
these tests.
TBR=levin
BUG=8630
TEST=none
Review URL: http://codereview.chromium.org/173590
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=15712
TEST=Download a few things, close shelf, download something else, note initial few things are no longer on the shelf.
Special cases:
* Dangerous downloads still awaiting affirmation should never be removed, no matter if they are completed or not.
* Cancelled downloads should be removed.
* In-progress downloads should not be removed.
Review URL: http://codereview.chromium.org/173186
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24663 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ROLE_SYSTEM_LISTITEM.
BUG=19982
TEST=Assign @role option on a child element to either menu or listbox. It will be exposed as either menuitem or listitem, respectively.
Review URL: http://codereview.chromium.org/173488
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24662 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/176002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24661 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
in the file (with other lighthttpd issues). Old bug was just the webkit merge bug, updated to more specific bug.
TEST=none, no functional change
BUG=8941,9916
Review URL: http://codereview.chromium.org/177006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24660 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
on Upload
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24659 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=ojan
BUG=20430
TEST=none
Review URL: http://codereview.chromium.org/175003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24658 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=darin
TEST=none
BUG=16237
Review URL: http://codereview.chromium.org/173587
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL eliminates direct calls to WebPluginDelegate::DidFinishLoadWithReason
from WebFrameLoaderClient.
This CL also moves WebDataSourceImpl into webkit/api/src. That change was
needed so that WebPluginContainerImpl can add a WebPluginLoadObserver to it,
which WebFrameLoaderClient uses to communicate back to the WebPlugin upon
completion of the frame load.
WebViewDelegate::DidFinishLoadWithReason is modified to include url and
notify_data parameters, eliminating the URLRequestRouted method. This is done
so that we can support overlapping NPN_GetURLNotify targetting different
frames.
WebPluginContainer grows an executeScriptURL method to deal with javascript:
URLs.
NOTE: I'm working on some UI tests to better cover the case of overlapping
NPN_GetURLNotify calls.
R=jam
BUG=10036
TEST=none yet
Review URL: http://codereview.chromium.org/174514
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24655 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
reference
We now strip away the reference when comparing the url's (for the purpose of clearing the page action icons).
BUG=20398
TEST=None
Review URL: http://codereview.chromium.org/174613
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=yurys
Review URL: http://codereview.chromium.org/178003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=aa,rafaelw
Review URL: http://codereview.chromium.org/173586
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
infrastructure.
Also send events for the modifier keys. This matches Windows more closely. I needed this for an test I was writing which I decided to throw away as it was using the wrong approach.
Review URL: http://codereview.chromium.org/178002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=ojan
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/177004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/173570
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24648 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/174612
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24647 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Browser tests use the header files generated from the chrome_strings grd files,
thus they need a direct dependency on chrome_strings.
BUG=19866
TEST=None
Review URL: http://codereview.chromium.org/173583
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=ojan
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/177003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24645 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
And it is not the final set. The main goal of this patch
is to prevent further regressions.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/173547
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24644 0039d316-1c4b-4281-b951-d872f2087c98
|