| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
dependencies on ATL.
BUG=5027
TEST=none
Review URL: http://codereview.chromium.org/200045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25879 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
required changes.
This way future merging would be much easier.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/201034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25878 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
correctly when using the zygote.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/196009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25877 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
section of the xml file is missing/empty
Review URL: http://codereview.chromium.org/203018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25876 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=19361
Review URL: http://codereview.chromium.org/199076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/194069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25874 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=21383
TEST=covered by current unit tests.
Review URL: http://codereview.chromium.org/201065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25873 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The difference between repaint areas is due to the difference in repaint logic.
Safari/Mac port uses NSView's native
rectangle collection/unification, and we just unify all into one damage rect.
R=jparent
BUG=8630
TEST=none
Review URL: http://codereview.chromium.org/193070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
mini_installer. Does not cause them to be registered.
Review URL: http://codereview.chromium.org/202044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25871 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
prevent it from trying to create Chrome desktop shortcuts.
Review URL: http://codereview.chromium.org/196068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
We run diff-index to see if there are any changes we need to pull in,
but we don't need it to print all of those changes.
Review URL: http://codereview.chromium.org/202045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25869 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=20653
TEST=Mac Valgrind UI bots
Review URL: http://codereview.chromium.org/199062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25868 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
from a secure to non-secure URL.
Also calling OnSSLCertificateError in case of certificate errors.
TEST=Run automation tests.
BUG=none
Review URL: http://codereview.chromium.org/195054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25867 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This fix the build.
TBR=phajdan
Review URL: http://codereview.chromium.org/201081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25866 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/202033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25864 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
interactive UI tests, so the interactive UI tests can be run isolated.
BUG=None
TEST=Run the the interactive ui tests with the new launcher:
test_launcher --lib=interactive_ui_tests_dll
Review URL: http://codereview.chromium.org/197045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25863 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
as the default action. Buttons with destructive actions should never be
the default.
This removes the return key equivalent from the Clear Browsing Data button.
It also adds an escape key equivalent to the Cancel button, so that it will
blink appropriately in response to both escape and command-period.
BUG=21461
TEST=Look and try as above
Review URL: http://codereview.chromium.org/194068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25862 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= http://crbug.com/21290
TEST= Install a theme without an NTP image (greyscale). Look at NTP with bookmarkbar attached and detached. See no white box at bottom of NTP.
Review URL: http://codereview.chromium.org/194066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is an optimization, and also helps stability. Fixes an intermittent DCHECK
I was hitting while working on unrelated parts of code.
TEST=There are DCHECKs that make sure the new code is valid.
BUG=none
Review URL: http://codereview.chromium.org/200069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=15494
TEST=none
Review URL: http://codereview.chromium.org/203004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25859 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
bundles. One part has been there for 2+ weeks, the other 1+ week, at this point anyone that hasn't build/build can do a clobber.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/192066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Dynamically set the tooltip for the star button based on state.
- make bookmark
- edit bookmark
Build the go button tooltip when asked so it can react to state of the tab and of the url bar.
- stop state
- got to url state
- do search state
BUG=21089
TEST=All the buttons in the toolbar should have localized tooltips. The star's depends on it's state. To go button will be stop, goto site, or do search (link windows).
Review URL: http://codereview.chromium.org/198027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This version greatly reduces the initial memory usage of V8.
Review URL: http://codereview.chromium.org/200075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
of the last change.
TEST=checkdeps.py
BUG=none
Review URL: http://codereview.chromium.org/200076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25853 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL fixes issue 11480: Support GTK keyboard themes (emacs keybindings).
A new class GtkKeyBindingsHandler has been added, which matches a key event against key bindings defined in current Gtk keyboard theme.
A new render message ViewMsg_SetEditCommandsForNextKeyEvent has been added for sending edit commands associated to a key event to renderer. This message shall be sent just before sending the key event. RenderView will handle this event and cache the edit commands until the key event is processed.
When processing the key event, EditClientImpl::handleKeyboardEvent() will eventually be called to handle the key event, if it's not handled by DOM and the focus is inside an input box. Then a newly added method WebViewDelegate::ExecuteEditCommandsForCurrentKeyEvent(), which is implemented in RenderView, will be called by EditClientImpl::handleKeyboardEvent() to execute edit commands previously sent from browser by ViewMsg_SetEditCommandsForNextKeyEvent message. If WebViewDelegate::ExecuteEditCommandsForCurrentKeyEvent() returns false, which means the key event doesn't have edit command associated, EditClientImpl will handle the key event with built-in logic, which may trigger a built-in key binding.
With this approach, system defined key bindings always have higher priority than built-in key bindings defined in editor_client_impl.cc.
Known issue:
If a key event matches not only a system defined key binding but also an accesskey of a DOM element, then both corresponding edit commands and accesskey action will be executed. Because accesskey is handled in WebViewImpl::CharEvent(), while edit commands are bound to RawKeyDown or KeyUp events.
BUG=11480 "Support GTK keyboard themes (emacs keybindings)"
TEST=Switch to Emacs keyboard theme by changing the value of gconf key
"/desktop/gnome/interface/gtk_key_theme" to "Emacs", then starts chrome and
opens a webpage with a text input box. Input something into the text box, then
press any of the Emacs key bindings defined in
/usr/share/themes/Emacs/gtk-2.0-key/gtkrc, to see if it works as expected. For
example, ctrl-p should move the cursor up one line, and ctrl-k should delete to
the end of paragraph.
Review URL: http://codereview.chromium.org/165293
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25852 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and adding a DEPS rule to allow "talk/".
This code is not yet compiled,
but it is still subject to checkdeps.
TEST=ran checkdeps.py
BUG=none
Review URL: http://codereview.chromium.org/201077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The code is not built on any platform yet. That will arrive
as a subsequent checkin.
This is an implementation of the interface exposed earlier
through syncapi.h. It is the client side of a sync
protocol that lets users sync their browser data
(currently, just bookmarks) with their Google Account.
Table of contents:
browser/sync/
protocol - The protocol definition, and
other definitions necessary to connect to
the service.
syncable/ - defines a data model for syncable objects,
and provides a sqlite-based backing store
for this model.
engine/ - includes the core sync logic, including commiting
changes to the server, downloading changes from
the server, resolving conflicts, other parts of
the sync algorithm.
engine/net - parts of the sync engine focused on the
business of talking to the server. Some of
this is binds a generic "server connection"
interface to a concrete implementation
provided by Chromium.
notifier - the part of the syncer focused on the business
of sending and receiving xmpp notifications.
Notifications are used instead of polling to
achieve very low latency change propagation.
util - not necessarily sync specific utility code. Much
of this is scaffolding which should either be
replaced by, or merged with, the utility code
in base/.
BUG=none
TEST=this code includes its own suite of unit tests.
Review URL: http://codereview.chromium.org/194065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25850 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
For some reason these just started acting up now.
TBR=eroman
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/196075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25844 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=12497
TEST=googleurl_unittsts URLCanonTest.CanonicalizeStandardURL passes.
Review URL: http://codereview.chromium.org/202040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25843 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enable database logging on history thread.
Original review: http://codereview.chromium.org/198011
BUG=16591
TEST=History UI test
Review URL: http://codereview.chromium.org/194067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25842 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moved NavigationGesture out of webview_delegate.h into its own
header in chrome/common since it is only needed by Chrome.
Adds WebFrame::isProcessingUserGesture to facilitate the removal
of NavigationGesture.
Cleaned up some TestShell methods related to URL loading. The
method to load an URL now takes a GURL instead of a wchar_t*.
R=dglazkov
BUG=21332
TEST=none
Review URL: http://codereview.chromium.org/200054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25841 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=darin
BUG=21439,21442
Review URL: http://codereview.chromium.org/200073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25840 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The difference between repaint areas is due to the difference in repaint logic.
Safari/Mac port uses NSView's native
rectangle collection/unification, and we just unify all into one damage rect.
R=jparent
BUG=8630
TEST=none
Review URL: http://codereview.chromium.org/195047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25839 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=rafaelw,aa
Review URL: http://codereview.chromium.org/196074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25838 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
included this change to the signature of the SaveThemeBitmap method.
BUG= none
TEST= none
TBR: glen
Review URL: http://codereview.chromium.org/196073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25837 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=21443
Review URL: http://codereview.chromium.org/192060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25836 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= http://crbug.com/21394
TEST= Change chrome language. Close and reopen browser. Tips should appear in new language, or, if not available, they should not appear.
Review URL: http://codereview.chromium.org/199073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Move link construction logic to scoped_clipboard_writer.cc
- Make callers use EscapeForHTML on the anchor text
- Make WriteHyperlink just write html, and not a bookmark as well (only affects one caller, which I updated)
- implement WriteBookmark for gtk
BUG=18034,18035
Review URL: http://codereview.chromium.org/194052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25833 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/195046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25832 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Sets the container border and box padding values, so that each widget doesn't need an alignment to pad itself.
With this the horizontal padding is almost the same as windows (in a few cases we have 1 more pixel between elements.)
The vertical padding should be unchanged.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/195048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25831 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=21157
Review URL: http://codereview.chromium.org/203013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25830 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
themed. Also fix HasCustomImage so that it only returns true when the image is in the extension's original set, not just a generated theme for the cache.
BUG= http://crbug.com/21134
TEST= install a theme with a detailed frame background. Open many tabs. Make sure the inactive tab image lines up with the frame image.
Review URL: http://codereview.chromium.org/193030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25829 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
server and have better performance. In the presence of XRender, let cairo do
things smarter."
Valgrind problems.
This reverts commit 03871714c3e5b39ee0f8369ecc2313c02fe0ca08 (r25814).
Review URL: http://codereview.chromium.org/200071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25828 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit r25825, 12ccd8bcd7b19a818d47f983f617539232cfc20f.
TBR=dkegel
Review URL: http://codereview.chromium.org/202037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25827 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=21443
TBR=davemoore
Review URL: http://codereview.chromium.org/202036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25826 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/203009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25825 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
throws a 500 when there is an unsupported query parameter. Use hash parameters
for everything instead.
TBR since the dashboard is broken until this is checked in.
TBR=arv@chromium.org
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/193066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25824 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
libxml (as
thirdparty code) doesn't exclude _mac.cc files automatically.
BUG=none
TEST=build without warning
Review URL: http://codereview.chromium.org/194062
TBR=sgk@google.com
Review URL: http://codereview.chromium.org/201074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25823 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is meant to test to see if we can reduce SQL related crashes by
removing the pre-load optimization.
I also added a line of defensive code (initializing a pointer).
r=brettw
Review URL: http://codereview.chromium.org/203011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25822 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
show bookmark folder dropdowns even if there is no overflow
BUG=21430
Review URL: http://codereview.chromium.org/203010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25821 0039d316-1c4b-4281-b951-d872f2087c98
|