| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=29633
TEST=manual
Review URL: http://codereview.chromium.org/1513002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Uses sqlite's pragma integrity_check
- Tests the 5 main databases
BUG=27885
TEST=none
Review URL: http://codereview.chromium.org/1548005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=39745
TEST=Extension update in general, and blacklisting, should still work normally.
Review URL: http://codereview.chromium.org/1540003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=37275
TEST=None
Checked in for jaysoffian@gmail.com
Original review: http://codereview.chromium.org/661439
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Farina (see http://codereview.chromium.org/1580002 ), r=me.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1528009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43136 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
After some research it turns out we can exclude certain .exe/.dll files from /NXCOMPAT and /DYNAMICBASE due to various reasons (pure data DLLs, special purpose applications, non-shipping code, etc...)
BUG=25952
TEST=checkbins step on buildbot should stay green with no failing files
Review URL: http://codereview.chromium.org/1576003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43135 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
factory unless the --auth-server-whitelist command-line option
is specified.
R=ahendrickson,cbentzel
BUG=29596
TEST=HTTP NTLM or Negotiate authentication should work again.
Review URL: http://codereview.chromium.org/1569007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43134 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
I will resubmit with the proper patch attribution.
TBR=atwilson@google.com
Review URL: http://codereview.chromium.org/1558006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43133 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
refactors the various views for this dialog in hopes of simplifying a few things.
BUG=none
TEST=Open content settings dialog, observe Location tab. (Note: Exceptions button is not wired up.)
Review URL: http://codereview.chromium.org/1526004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
cert to send.
BUG=38905
TEST=None (don't have a way for me to reproduce this yet)
Review URL: http://codereview.chromium.org/1514004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds ability for ImageLoadingTracker to cache images.
BUG=none
TEST=none
TBR=aa@chromium.org
Review URL: http://codereview.chromium.org/1534006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1508005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
before.
Did some refactoring and fixed comments.
BUG=none
TEST=manually
Review URL: http://codereview.chromium.org/1543004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43128 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
have run.
This is consistent with the comment for Thread::CleanUp(), which says it runs after the message loop has "stopped".
Certain consumers depend on this ordering to avoid accessing variables which are deleted by Thread::CleanUp().
BUG=39723
TEST=ThreadTest.CleanUp
Review URL: http://codereview.chromium.org/1540002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43127 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
is closed.
TEST=none at all
BUG=none
Review URL: http://codereview.chromium.org/1560003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43126 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
container, update cursors properly and fix a bug where a newly added extension would be put in the overflow menu if all extensions were shown.
BUG=36697
TEST=none
Review URL: http://codereview.chromium.org/1581003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43125 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
variable in the failure case.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1534007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43124 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
it through to the pepper API. This pepper API just supports adding the filename
to the "upload files" whitelist and returning it to the plugin, but it does not
actually give any ability for a sandboxed plugin to read the file (this will
come in a separate changelist).
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/1094004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43123 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It seems the best way to keep the seccomp sandbox working is to have
everyone's development environment have it on by default. So we turn
on the seccomp sandbox, but only for non-official builds.
If the build-time flag is set: --disable-seccomp-sandbox turns it off.
If the build-time flag is *not* set: --enable-seccomp-sandbox turns it on.
BUG=36133
Review URL: http://codereview.chromium.org/1558003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43122 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds label scraping to AutoFill where labels reside in tables. Infers labels
from surrounding context of input fields in the WebKit DOM. Specific case added
is:
- Table cell element containing text preceding INPUT element contained in a table cell.
Eg. <TR><TD>First name:</TD><TD><INPUT type="text" id="firstname" value="John"/></TD></TR>
BUG=33031
TEST=FormManagerTest.LabelsFromInferredTableCell
Review URL: http://codereview.chromium.org/1517005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43121 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://code.google.com/p/chromium-os/issues/detail?id=2156
TEST=run ffmpeg_tests on an audio file and it should report success and performance
Review URL: http://codereview.chromium.org/1544002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43120 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=39364
TEST=Select the "Bookmarks bar" tree item. Right click and do new folder. The text "New folder" should not be clipped.
Review URL: http://codereview.chromium.org/1534004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43119 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- test server to serve account creation page
- deferred creation of login windows to tune account screen for testing
- refactored InProcessBrowserTest to shutdown test reliably.
BUG=39310
TEST=Run browser_tests with --gtest_filter=AccountScreenTest.*
Review URL: http://codereview.chromium.org/1452001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43118 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=gcl upload doesn't spit out a parsing error.
TBR=nkostylev@google.com
Review URL: http://codereview.chromium.org/1539005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
enablegeolocation switch
BUG=39806
TEST=run browser with and without the enablegeolocation flag, and open the content settings page. (restart browser when Location tab was selected as current tab)
Review URL: http://codereview.chromium.org/1575005
TBR=joth@chromium.org
Review URL: http://codereview.chromium.org/1540006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=thestig
Review URL: http://codereview.chromium.org/1542006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43115 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=38591
TEST=Drag bookmarks inside the bookmark manager. The move cursor should be shown.
Rearrange thumbnails on the new tab page using DnD. The move icon should be used.
Review URL: http://codereview.chromium.org/1563003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43114 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also, add a type ConstrainedDialogDelegate that is used for constrained windows that show a dialog. In a future CL, Mac and Gtk will be changed to use that type.
BUG=26271
TEST=Go to http://www.cs.unc.edu/~jbs/resources/perl/perl-cgi/programs/form1-POST.html, hit Submit, then refresh. The warning sheet should be tab-modal, not window-modal. Opening a login form (which is also tab-modal) while the warning is shown should not crash, neither should hitting the reload button again, or bringing up the warning while a login form is shown.
Review URL: http://codereview.chromium.org/1138009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43112 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
--enable-geolocation switch
BUG=39806
TEST=run browser with and without the --enable-geolocation flag, and open the content settings page. (restart browser when Location tab was selected as current tab)
Review URL: http://codereview.chromium.org/1575005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43111 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
when enabling an extension to run in incognito mode.
BUG=39355
Review URL: http://codereview.chromium.org/1569003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ExtensionApiTest.Tabs.
Tests of chrome.tab.captureVisibleTab() fail on mac 10.6, and disabling all tab tests because of this is unfortunate. Breaking the test this way makes the 10.6 failure easier to debug.
BUG=37387
Review URL: http://codereview.chromium.org/1520005
TBR=skerner@chromium.org
Review URL: http://codereview.chromium.org/1577002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43109 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
on __LP64__ (which is predefined in gcc on 64-bit systems)
(Necessary for BSD port)
Review URL: http://codereview.chromium.org/747003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43108 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
(c.f. http://people.redhat.com/drepper/selinux-mem.html)
Fix compilation warnings on Fedora.
BUG=none
TEST=when running Chrome on Fedora, verify that we don't get AVC warnings
Review URL: http://codereview.chromium.org/1535004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is a temporary fix until the underlying problem with coordinates in windowless plugins is fixed at the WebKit level, since it's a more serious problem on the Mac (due to all plugins being windowless). Using what we know about the plugin location on screen, we infer zoom levels from the coordinates and correct the coordinates (to within a pixel or two, which is the best we can do with the already-rounded values we are given).
BUG=26466
TEST=Zoom a page with plugins on the Mac; mouse interaction should work correctly.
Review URL: http://codereview.chromium.org/1594001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43106 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=38548
TEST=none yet.
Review URL: http://codereview.chromium.org/1407001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43105 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
on spaces, so delete the extra whitespace. Also, special case Chrome for one v8 test, in which Chrome expects no parenthesis around the exception.
Review URL: http://codereview.chromium.org/1566005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43104 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
invalid argument CRT reports are generated to allow sorting those dumps by stack signature.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1418001
TBR=siggi@chromium.org
Review URL: http://codereview.chromium.org/1556003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43103 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a continuation of zork's change http://codereview.chromium.org/1354001 that adds some preventitive DCHECKs througout the sync code to make sure stuff happens on the UI thread.
This also includes a leak fix in the ProfileSyncServiceTypedUrlTest.
The final change is changing the TestingProfile to return a ProfileSyncServiceMock rather than a real ProfileSyncService. This should help prevent random test failes due to other tests that need to use the PSS.
BUG=38490,38487
Review URL: http://codereview.chromium.org/1383002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Tests of chrome.tab.captureVisibleTab() fail on mac 10.6, and disabling all tab tests because of this is unfortunate. Breaking the test this way makes the 10.6 failure easier to debug.
BUG=37387
Review URL: http://codereview.chromium.org/1520005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43101 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=7713
TEST=SafeBrowsingUtilTest.CanonicalizeUrl
Review URL: http://codereview.chromium.org/1275002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43099 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
In cases where I've added an #include, it's generally due to Clang being
more picky about templates being available during expansions.
Review URL: http://codereview.chromium.org/1432003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43098 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- if "always translate" options is checked, both "never translate" options are disabled
- if either or both "never translate" options are checked, "always translate" option is disabled
BUG=39174
TEST=verify per bug report.
Review URL: http://codereview.chromium.org/1569004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43097 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the folder menu items, and no longer needed calls.
I found an easier, simpler change.
BUG=39428
TEST=Pop up a folder menu and insure that the background does not adopt any theme settings.
Review URL: http://codereview.chromium.org/1548003
TBR=mrossetti@chromium.org
Review URL: http://codereview.chromium.org/1596001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
bookmark bar (except the "import bookmarks" link itself).
Xib change: hooked the bookmark bar context menu up to the width tweaker that holds the "import bookmarks" link.
BUG= 39362
TEST= in a browser with no bookmarks, try to right-click to the right of the "import bookmarks" link. The menu for bookmark creation should pop up.
Review URL: http://codereview.chromium.org/1385001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Well, I didn't really port. I just uncommented out some methods marked
UNIMPLEMENTED(). They seem to work just fine.
TEST=ui_tests --gtest_filter=OmniboxTest.* --run_omnibox_test
Review URL: http://codereview.chromium.org/1513003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43094 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
sockets in the Mac
renderer sandbox to support running Native Client.
2. Put the Native Client sel_ldr (which contains the user's untrusted code
into a new Mac sandbox type.
3. Open /dev/random in SandboxWarmup().
4. Remove the "nosandbox" flag when running Mac tests.
BUG=http://code.google.com/p/nativeclient/issues/detail?id=327
TEST=nacl_ui_tests still pass while running in the sandbox.
Review URL: http://codereview.chromium.org/1234003
TBR=msneck@google.com
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
considering the alternatives, I've decided that it's not terrible. This code
does not make it into the Chrome build, it's only used for the symbol dumper.
BUG=none
TEST=Mac official build
Review URL: http://codereview.chromium.org/1535005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43092 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=10.6 SDK build
Review URL: http://codereview.chromium.org/1552004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43091 0039d316-1c4b-4281-b951-d872f2087c98
|